XSLTransformator::getTransformedOutputXML() - Code Metrics - Inspection of "Ap5 ap6 ap1 internal format" - kitodo/kitodo-publication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#195)

unknown

created 2021-02-18 16:06 UTC

XSLTransformator::getTransformedOutputXML() B

↳ Parent: XSLTransformator

Complexity

Conditions	6
Paths	10

Size

Total Lines	55
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	33
nc	10
nop	2
dl	0
loc	55
rs	8.7697
c	0
b	0
f	0

How to fix Long Method

<?php
namespace EWW\Dpf\Helper;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use EWW\Dpf\Configuration\ClientConfigurationManager;
use EWW\Dpf\Domain\Repository\DocumentTypeRepository;
use EWW\Dpf\Services\Transformer\DocumentTransformer;
use TYPO3\CMS\Extbase\Object\ObjectManager;
use \TYPO3\CMS\Core\Utility\GeneralUtility;
use \TYPO3\CMS\Core\Log\Logger;
use \TYPO3\CMS\Core\Log\LogLevel;
use \TYPO3\CMS\Core\Log\LogManager;

class XSLTransformator
{

    /**
     * clientConfigurationManager
     *
     * @var \EWW\Dpf\Configuration\ClientConfigurationManager
     * @inject
     */
    protected $clientConfigurationManager;

    /**
     * documentTypeRepository
     *
     * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
     * @inject
     */
    protected $documentTypeRepository;

    /**
     * @param $xml
     * @return string
     */
    public function transformInputXML($xml) {
        $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
        $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
        $this->documentTypeRepository = $objectManager->get(DocumentTypeRepository::class);

        $docTypeInput = $this->clientConfigurationManager->getTypeXpathInput();

        $domDocument = new \DOMDocument();
        $domDocument->loadXML($xml);

        $domXPath = \EWW\Dpf\Helper\XPath::create($domDocument);

        $documentTypeName = $domXPath->query('//' . $docTypeInput)->item(0)->nodeValue;

        $documentType = $this->documentTypeRepository->findOneByName($documentTypeName);

        $transformationFile = $documentType->getTransformationFileInput()->current();
        if (!$transformationFile) {
            $transformationFile = $this->clientConfigurationManager->getInputTransformation();
        }

        if ($transformationFile != NULL) {
            $filePath = $transformationFile->getFile()->getOriginalResource()->getIdentifier();
            $documentTransformer = new DocumentTransformer();

            $transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $xml);
        } else {
            // return generated xml if no transformation file is present
            $transformedXml = $xml;

            /** @var $logger Logger */
            $logger = GeneralUtility::makeInstance(
                LogManager::class)->getLogger(__CLASS__
            );

            $logger->log(
                LogLevel::WARNING,
                "Input XML: No transformation file is present. The given xml data was taken over as it is",
                array(
                    'documentTypeName' => $documentTypeName
                )
            );
        }

        return $transformedXml;
    }

    /**
     * @param \EWW\Dpf\Domain\Model\Document $document
     * @return string The transformed xml
     */
    public function getTransformedOutputXML($document, $xmlData = false)
    {
        $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
        $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);

        $ownerId = $this->clientConfigurationManager->getOwnerId();
        $documentType = $document->getDocumentType();

        $transformationFile = $documentType->getTransformationFileOutput()->toArray()[0];
        if (!$transformationFile) {
            $transformationFile = $this->clientConfigurationManager->getOutputTransformation();
        }

        if ($transformationFile != NULL) {
            $filePath = $transformationFile->getFile()->getOriginalResource()->getIdentifier();
            $documentTransformer = new DocumentTransformer();

            if ( !$document->getRemoteState() || $document->getRemoteState() == 'NONE' ) {
                $remoteState = 'ACTIVE';
            } else {
                $remoteState = $document->getRemoteState();
            }

            $transformParams = [
                'record_state' => $remoteState,
                'agent_name' => $ownerId,
                'document_type' => $document->getDocumentType()->getName(),
                'process_number' => $document->getProcessNumber()
            ];

            if ($xmlData) {
                $transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $xmlData, $transformParams);
            } else {
                $transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $document->getXmlData(), $transformParams);
            }

        } else {
            // return generated xml if no transformation file is present
            $transformedXml = $document->getXmlData();

            /** @var $logger Logger */
            $logger = GeneralUtility::makeInstance(
                LogManager::class)->getLogger(__CLASS__
            );

            $logger->log(
                LogLevel::WARNING,
                "Output XML: No transformation file is present. The generated xml data was taken over as it is",
                array(
                    'documentTypeName' => $documentTypeName

                )
            );
        }

        return $transformedXml;
    }

}


1			<?php
2			namespace EWW\Dpf\Helper;
3
4			/*
5			* This file is part of the TYPO3 CMS project.
6			*
7			* It is free software; you can redistribute it and/or modify it under
8			* the terms of the GNU General Public License, either version 2
9			* of the License, or any later version.
10			*
11			* For the full copyright and license information, please read the
12			* LICENSE.txt file that was distributed with this source code.
13			*
14			* The TYPO3 project - inspiring people to share!
15			*/
16
17			use EWW\Dpf\Configuration\ClientConfigurationManager;
18			use EWW\Dpf\Domain\Repository\DocumentTypeRepository;
19			use EWW\Dpf\Services\Transformer\DocumentTransformer;
20			use TYPO3\CMS\Extbase\Object\ObjectManager;
21			use \TYPO3\CMS\Core\Utility\GeneralUtility;
22			use \TYPO3\CMS\Core\Log\Logger;
23			use \TYPO3\CMS\Core\Log\LogLevel;
24			use \TYPO3\CMS\Core\Log\LogManager;
25
26			class XSLTransformator
27			{
28
29			/**
30			* clientConfigurationManager
31			*
32			* @var \EWW\Dpf\Configuration\ClientConfigurationManager
33			* @inject
34			*/
35			protected $clientConfigurationManager;
36
37			/**
38			* documentTypeRepository
39			*
40			* @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
41			* @inject
42			*/
43			protected $documentTypeRepository;
44
45			/**
46			* @param $xml
47			* @return string
48			*/
49			public function transformInputXML($xml) {
50			$objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
51			$this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
52			$this->documentTypeRepository = $objectManager->get(DocumentTypeRepository::class);
53
54			$docTypeInput = $this->clientConfigurationManager->getTypeXpathInput();
55
56			$domDocument = new \DOMDocument();
57			$domDocument->loadXML($xml);
58
59			$domXPath = \EWW\Dpf\Helper\XPath::create($domDocument);
60
61			$documentTypeName = $domXPath->query('//' . $docTypeInput)->item(0)->nodeValue;
62
63			$documentType = $this->documentTypeRepository->findOneByName($documentTypeName);
64
65			$transformationFile = $documentType->getTransformationFileInput()->current();
66			if (!$transformationFile) {
67			$transformationFile = $this->clientConfigurationManager->getInputTransformation();
68			}
69
70			if ($transformationFile != NULL) {
71			$filePath = $transformationFile->getFile()->getOriginalResource()->getIdentifier();
72			$documentTransformer = new DocumentTransformer();
73
74			$transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $xml);
75			} else {
76			// return generated xml if no transformation file is present
77			$transformedXml = $xml;
78
79			/** @var $logger Logger */
80			$logger = GeneralUtility::makeInstance(
81			LogManager::class)->getLogger(__CLASS__
82			);
83
84			$logger->log(
85			LogLevel::WARNING,
86			"Input XML: No transformation file is present. The given xml data was taken over as it is",
87			array(
88			'documentTypeName' => $documentTypeName
89			)
90			);
91			}
92
93			return $transformedXml;
94			}
95
96			/**
97			* @param \EWW\Dpf\Domain\Model\Document $document
98			* @return string The transformed xml
99			*/
100			public function getTransformedOutputXML($document, $xmlData = false)
101			{
102			$objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
103			$this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
104
105			$ownerId = $this->clientConfigurationManager->getOwnerId();
106			$documentType = $document->getDocumentType();
107
108			$transformationFile = $documentType->getTransformationFileOutput()->toArray()[0];
109			if (!$transformationFile) {
110			$transformationFile = $this->clientConfigurationManager->getOutputTransformation();
111			}
112
113			if ($transformationFile != NULL) {
114			$filePath = $transformationFile->getFile()->getOriginalResource()->getIdentifier();
115			$documentTransformer = new DocumentTransformer();
116
117			if ( !$document->getRemoteState() \|\| $document->getRemoteState() == 'NONE' ) {
118			$remoteState = 'ACTIVE';
119			} else {
120			$remoteState = $document->getRemoteState();
121			}
122
123			$transformParams = [
124			'record_state' => $remoteState,
125			'agent_name' => $ownerId,
126			'document_type' => $document->getDocumentType()->getName(),
127			'process_number' => $document->getProcessNumber()
128			];
129
130			if ($xmlData) {
131			$transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $xmlData, $transformParams);
132			} else {
133			$transformedXml = $documentTransformer->transform(PATH_site . 'fileadmin' . $filePath, $document->getXmlData(), $transformParams);
134			}
135
136			} else {
137			// return generated xml if no transformation file is present
138			$transformedXml = $document->getXmlData();
139
140			/** @var $logger Logger */
141			$logger = GeneralUtility::makeInstance(
142			LogManager::class)->getLogger(__CLASS__
143			);
144
145			$logger->log(
146			LogLevel::WARNING,
147			"Output XML: No transformation file is present. The generated xml data was taken over as it is",
148			array(
149			'documentTypeName' => $documentTypeName
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-02-17 15:12 UTC by Report Bug Copy Issue Report The variable `$documentTypeName` does not exist. Did you maybe mean `$document`? Loading history...
150			)
151			);
152			}
153
154			return $transformedXml;
155			}
156
157			}
158

kitodo / kitodo-publication

Pull Request — master (#195)

XSLTransformator::getTransformedOutputXML() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like