for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace EWW\Dpf\ViewHelpers;
/*
* This file is part of the TYPO3 CMS project.
*
* It is free software; you can redistribute it and/or modify it under
* the terms of the GNU General Public License, either version 2
* of the License, or any later version.
* For the full copyright and license information, please read the
* LICENSE.txt file that was distributed with this source code.
* The TYPO3 project - inspiring people to share!
*/
class ShowStateViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper
{
/**
* @param string $state
public function render($state)
$key = "";
switch ($state) {
case \EWW\Dpf\Domain\Model\Document::OBJECT_STATE_NEW:
$key = 'search.resultList.state.new';
break;
case \EWW\Dpf\Domain\Model\Document::OBJECT_STATE_ACTIVE:
case 'A':
$key = 'search.resultList.state.active';
case \EWW\Dpf\Domain\Model\Document::OBJECT_STATE_INACTIVE:
case 'I':
$key = 'search.resultList.state.inactive';
case \EWW\Dpf\Domain\Model\Document::OBJECT_STATE_DELETED:
case \EWW\Dpf\Domain\Model\Document::OBJECT_STATE_LOCALLY_DELETED:
case 'D':
$key = 'search.resultList.state.deleted';
default:
return "-";
break
The break statement is not necessary if it is preceded for example by a return statement:
return
switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. }
If you would like to keep this construct to be consistent with other case statements, you can safely mark this issue as a false-positive.
case
}
return \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate($key, 'dpf', $arguments = null);
kitodo /
kitodo-publication
The
breakstatement is not necessary if it is preceded for example by areturnstatement:If you would like to keep this construct to be consistent with other
casestatements, you can safely mark this issue as a false-positive.