EWW\Dpf\Controller\AjaxBackofficeController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	addWorkspaceFilterAction()	0	19	9
A	addWorkspaceSortAction()	0	4	1
A	removeBookmarkAction()	0	10	2
A	setWorkspaceItemsPerPageAction()	0	4	1
A	toggleWorkspaceExcludeDiscardedAction()	0	4	1
A	addBookmarkAction()	0	13	2
A	toggleWorkspaceBookmarksOnlyAction()	0	4	1

<?php
namespace EWW\Dpf\Controller;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * AjaxBackofficeController
 */
class AjaxBackofficeController extends \EWW\Dpf\Controller\AbstractController
{
    /**
     * bookmarkRepository
     *
     * @var \EWW\Dpf\Domain\Repository\BookmarkRepository
     * @inject
     */
    protected $bookmarkRepository = null;


    /**
     * Adds a the given document identifier to the bookmark list of the current fe user.
     *
     * @param string $identifier
     * @return bool
     */
    public function addBookmarkAction($identifier)
    {
        /** @var \EWW\Dpf\Domain\Model\Bookmark $bookmark */
        $bookmark = $this->bookmarkRepository->findBookmark($this->security->getUser()->getUid(), $identifier);
        if (!$bookmark) {

$bookmark is of type EWW\Dpf\Domain\Model\Bookmark, thus it always evaluated to true.

            $bookmark = $this->objectManager->get(\EWW\Dpf\Domain\Model\Bookmark::class);
            $bookmark->setDocumentIdentifier($identifier);
            $bookmark->setFeUserUid($this->security->getUser()->getUid());
            $this->bookmarkRepository->add($bookmark);
            return true;
        }

        return false;
    }

    /**
     * Removes the given document from the bookmark list of the current fe user.
     *
     * @param string $identifier
     * @return bool
     */
    public function removeBookmarkAction($identifier)
    {
        /** @var \EWW\Dpf\Domain\Model\Bookmark $bookmark */
        $bookmark = $this->bookmarkRepository->findBookmark($this->security->getUser()->getUid(), $identifier);
        if ($bookmark) {

$bookmark is of type EWW\Dpf\Domain\Model\Bookmark, thus it always evaluated to true.

            $this->bookmarkRepository->remove($bookmark);
            return true;
        }

        return false;
    }

    /**
     * Adds a workspace filter to the session.
     *
     * @param string $name
     * @param array $values
     */
    public function addWorkspaceFilterAction($name, $values = [])
    {
        if ($name && $values && is_array($values)) {

The expression $values of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $workspaceFilters = $this->getSessionData('workspaceFilters');
            if ($workspaceFilters && is_array($workspaceFilters)) {
                $workspaceFilters[$name] = $values;
                $this->setSessionData('workspaceFilters', $workspaceFilters);

$workspaceFilters of type array is incompatible with the type string expected by parameter $data of EWW\Dpf\Controller\AbstractController::setSessionData().

            } else {
                $this->setSessionData('workspaceFilters', [$name => $values]);

array($name => $values) of type array<string,array> is incompatible with the type string expected by parameter $data of EWW\Dpf\Controller\AbstractController::setSessionData().

            }
        } else {
            $workspaceFilters = $this->getSessionData('workspaceFilters');
            if ($name && is_array($workspaceFilters) && array_key_exists($name, $workspaceFilters)) {
                unset($workspaceFilters[$name]);
                $this->setSessionData('workspaceFilters', $workspaceFilters);

$workspaceFilters of type array is incompatible with the type string expected by parameter $data of EWW\Dpf\Controller\AbstractController::setSessionData().

            }
        }

        return;

    }

    /**
     * Adds a workspace sort to the session.
     *
     * @param string $field
     * @param string $order
     */
    public function addWorkspaceSortAction($field, $order)
    {
        $this->session->setWorkspaceSort($field, $order);
        return;
    }

    /**
     * Toggles the filter to exclude discarded documents.
     *
     */
    public function toggleWorkspaceExcludeDiscardedAction()
    {
        $this->session->toggleWorkspaceExcludeDiscardedFilter();
        return;
    }

    /**
     * Toggles the filter to hide bookmarked documents.
     *
     */
    public function toggleWorkspaceBookmarksOnlyAction()
    {
        $this->session->toggleWorkspaceBookmarksOnlyFilter();
        return;
    }

    /**
     * Sets the items per page for the workspace list.
     *
     * @param int $itemsPerPage
     */
    public function setWorkspaceItemsPerPageAction($itemsPerPage)
    {
        $this->session->setWorkspaceItemsPerPage($itemsPerPage);
        return;
    }


}