kitodo / kitodo-publication

Classes/Exceptions/ElasticSearchConnectionErrorException.php

Braces +2 added lines, -4 removed lines

@@ -14,10 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-class ElasticSearchConnectionErrorException extends \Exception implements DPFExceptionInterface
-{
-    public function messageLanguageKey()
-    {
+class ElasticSearchConnectionErrorException extends \Exception implements DPFExceptionInterface {
+    public function messageLanguageKey() {
         return 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_transfer.elasticsearch_connection_error';
     }
 }
\ No newline at end of file

Classes/Exceptions/RepositoryConnectionErrorException.php

Braces +2 added lines, -4 removed lines

@@ -14,10 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-class RepositoryConnectionErrorException extends \Exception implements DPFExceptionInterface
-{
-    public function messageLanguageKey()
-    {
+class RepositoryConnectionErrorException extends \Exception implements DPFExceptionInterface {
+    public function messageLanguageKey() {
         return 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_transfer.repository_connection_error';
     }
 }
\ No newline at end of file

Classes/Services/ElasticSearch.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
         // initialize elasticsearch lib
         $extensionPath = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('dpf');
 
-        $params['hosts'] = array(
+        $params['hosts'] = array (
             $this->server . ':' . $this->port,
         );
 
@@ -86,7 +86,7 @@ 
             $this->resultList = $results['hits'];
 
             return $this->resultList;
-        } catch ( \Elasticsearch\Common\Exceptions\Curl\CouldNotConnectToHost $exception) {
+        } catch (\Elasticsearch\Common\Exceptions\Curl\CouldNotConnectToHost $exception) {
             throw new \EWW\Dpf\Exceptions\ElasticSearchConnectionErrorException("Could not connect to repository server.");
         } catch (\Elasticsearch\Common\Exceptions\Curl\CouldNotResolveHostException $exception) {
             throw new \EWW\Dpf\Exceptions\ElasticSearchConnectionErrorException("Could not connect to repository server.");

Braces +4 added lines, -8 removed lines

@@ -24,8 +24,7 @@ 
  * @package EWW\Dpf\Services
  * @deprecated since version 4.0
  */
-class ElasticSearch
-{
+class ElasticSearch {
     protected $es;
 
     protected $server = ''; //127.0.0.1';
@@ -43,8 +42,7 @@ 
     /**
      * elasticsearch client constructor
      */
-    public function __construct()
-    {
+    public function __construct() {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 
@@ -68,8 +66,7 @@ 
      * @param  array $query search query
      * @return array        result list
      */
-    public function search($query, $type)
-    {
+    public function search($query, $type) {
         try {
             // define type and index
             if (empty($query['index'])) {
@@ -99,8 +96,7 @@ 
      * returns the result list
      * @return [type] [description]
      */
-    public function getResults()
-    {
+    public function getResults() {
         // return results from the last search request
         return $this->resultList;
     }

Classes/Exceptions/DocumentMaxSizeErrorException.php

Braces +2 added lines, -4 removed lines

@@ -14,10 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-class DocumentMaxSizeErrorException extends \Exception implements DPFExceptionInterface
-{
-    public function messageLanguageKey()
-    {
+class DocumentMaxSizeErrorException extends \Exception implements DPFExceptionInterface {
+    public function messageLanguageKey() {
         return 'LLL:EXT:dpf/Resources/Private/Language/locallang.xlf:document_save.max_size_error';
     }
 }
\ No newline at end of file

Classes/Plugins/MetaTags/MetaTags.php

Indentation -1 removed lines

@@ -107,7 +107,6 @@
 
     /**
      * Get PDF document list
-
      * @return array of attachments
      */
     protected function getAttachments()

Spacing +6 added lines, -6 removed lines

@@ -71,7 +71,7 @@ 
             }
         }
 
-        $metadata = array();
+        $metadata = array ();
         $metadata = $this->doc->getTitleData($this->conf['pages']);
 
         // Collect files from download file group
@@ -126,7 +126,7 @@ 
                 case 'title':
                     if (is_array($values)) {
                         $outArray['citation_title'][] = $values[0];
-                        $GLOBALS['TSFE']->page['title'] =  $values[0];
+                        $GLOBALS['TSFE']->page['title'] = $values[0];
                     }
                     break;
 
@@ -148,8 +148,8 @@ 
                     break;
 
                 case 'attachments':
-                    foreach($values as $attachment) {
-                        $conf = array(
+                    foreach ($values as $attachment) {
+                        $conf = array (
                             'useCacheHash'     => 0,
                             'parameter'        => $this->conf['apiPid'],
                             'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment&tx_dpf[attachment]=' . $attachment['ID'],
@@ -209,14 +209,14 @@ 
      */
     protected function getAttachments()
     {
-        $attachments = array();
+        $attachments = array ();
 
         $xPath = 'mets:fileSec/mets:fileGrp[@USE="' . $this->conf['fileGrpDownload'] . '"]/mets:file';
         $files = $this->doc->mets->xpath($xPath);
 
         if (is_array($files)) {
             foreach ($files as $key => $file) {
-                $singleFile = array();
+                $singleFile = array ();
                 foreach ($file->attributes('mext', 1) as $attribute => $value) {
                     $singleFile[$attribute] = $value;
                 }

Braces +5 added lines, -10 removed lines

@@ -25,8 +25,7 @@ 
  * @subpackage    tx_dpf
  * @access    public
  */
-class MetaTags extends \Kitodo\Dlf\Common\AbstractPlugin
-{
+class MetaTags extends \Kitodo\Dlf\Common\AbstractPlugin {
     public $scriptRelPath = 'Classes/Plugins/MetaTags.php';
 
     /**
@@ -45,8 +44,7 @@ 
      *
      * @return    string        The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
 
         $this->init($conf);
 
@@ -107,8 +105,7 @@ 
      *
      * @return    string        The metadata array ready for output
      */
-    protected function printMetaTags(array $metadata)
-    {
+    protected function printMetaTags(array $metadata) {
 
         $output = '';
         // Load all the metadata values into the content object's data array.
@@ -196,8 +193,7 @@ 
      *
      * @return Formatted date
      */
-    protected function safelyFormatDate($format, $date)
-    {
+    protected function safelyFormatDate($format, $date) {
         return (strlen($date) == 4) ? $date : date($format, strtotime($date));
     }
 
@@ -207,8 +203,7 @@ 
 
      * @return array of attachments
      */
-    protected function getAttachments()
-    {
+    protected function getAttachments() {
         $attachments = array();
 
         $xPath = 'mets:fileSec/mets:fileGrp[@USE="' . $this->conf['fileGrpDownload'] . '"]/mets:file';

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -54,14 +54,14 @@ 
         // Flexform wins over TS
         $dpfTSconfig = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_dpf.'];
         if (is_array($dpfTSconfig['settings.'])) {
-            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, true, false);
+            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, TRUE, FALSE);
             $this->conf = $dpfTSconfig['settings.'];
         }
         // Turn cache on.
-        $this->setCache(true);
+        $this->setCache(TRUE);
         // Load current document.
         $this->loadDocument();
-        if ($this->doc === null) {
+        if ($this->doc === NULL) {
             // Quit without doing anything if required variables are not set.
             return $content;
         } else {
@@ -153,7 +153,7 @@ 
                             'useCacheHash'     => 0,
                             'parameter'        => $this->conf['apiPid'],
                             'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment&tx_dpf[attachment]=' . $attachment['ID'],
-                            'forceAbsoluteUrl' => true,
+                            'forceAbsoluteUrl' => TRUE,
                         );
                         $outArray['citation_pdf_url'][] = $this->cObj->typoLink_URL($conf);
                     }

Classes/ViewHelpers/Link/DataCiteViewHelper.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         $dataCite = $this->uriBuilder
             ->reset()
             ->setTargetPageUid($apiPid)
-            ->setArguments(array( 'tx_dpf' => $row))
+            ->setArguments(array ('tx_dpf' => $row))
             ->setCreateAbsoluteUri(true)
             ->setUseCacheHash(FALSE)
             ->buildFrontendUri();

Braces +4 added lines, -8 removed lines

@@ -17,8 +17,7 @@ 
 use TYPO3\CMS\Core\Utility\MathUtility;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
 
-class DataCiteViewHelper extends AbstractViewHelper
-{
+class DataCiteViewHelper extends AbstractViewHelper {
     /**
      * @var \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder
      * @TYPO3\CMS\Extbase\Annotation\Inject
@@ -48,8 +47,7 @@ 
      * @param  string $class
      * @return string html output
      */
-    protected function getViewIcon($row, $pageUid, $apiPid, $insideText, $class)
-    {
+    protected function getViewIcon($row, $pageUid, $apiPid, $insideText, $class) {
         $dataCite = $this->uriBuilder
             ->reset()
             ->setTargetPageUid($apiPid)
@@ -64,8 +62,7 @@ 
         return $icon;
     }
 
-    public function initializeArguments()
-    {
+    public function initializeArguments() {
         parent::initializeArguments();
 
         $this->registerArgument('arguments', 'array', '', true);
@@ -80,8 +77,7 @@ 
      *
      * @return string the rendered record list
      */
-    public function render()
-    {
+    public function render() {
         $arguments = $this->arguments['arguments'];
         $pageUid = $this->arguments['pageUid'];
         $apiPid = $this->arguments['apiPid'];

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -38,7 +38,7 @@ 
      *
      * @var bool
      */
-    protected $escapeOutput = false;
+    protected $escapeOutput = FALSE;
 
     /**
      * Returns the View Icon with link
@@ -54,11 +54,11 @@ 
             ->reset()
             ->setTargetPageUid($apiPid)
             ->setArguments(array( 'tx_dpf' => $row))
-            ->setCreateAbsoluteUri(true)
+            ->setCreateAbsoluteUri(TRUE)
             ->setUseCacheHash(FALSE)
             ->buildFrontendUri();
 
-        $title = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('manager.tooltip.datacite', 'dpf', $arguments = null);
+        $title = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('manager.tooltip.datacite', 'dpf', $arguments = NULL);
         $icon  = '<a href="' . $dataCite . '" data-toggle="tooltip" class="' . $class . '" title="' . $title . '">' . $insideText . '</a>';
 
         return $icon;
@@ -68,10 +68,10 @@ 
     {
         parent::initializeArguments();
 
-        $this->registerArgument('arguments', 'array', '', true);
-        $this->registerArgument('pageUid', 'int', '', true);
-        $this->registerArgument('apiPid', 'int', '', true);
-        $this->registerArgument('class', 'string', '', true);
+        $this->registerArgument('arguments', 'array', '', TRUE);
+        $this->registerArgument('pageUid', 'int', '', TRUE);
+        $this->registerArgument('apiPid', 'int', '', TRUE);
+        $this->registerArgument('class', 'string', '', TRUE);
     }
 
     /**

Classes/ViewHelpers/Link/PreviewViewHelper.php

Indentation +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     protected function getViewIcon(array $row, $pageUid, $apiPid, $insideText, $class)
     {
 
-       $previewMets = $this->uriBuilder
+        $previewMets = $this->uriBuilder
             ->reset()
             ->setTargetPageUid($apiPid)
             ->setArguments(array( 'tx_dpf' => $row))

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
        $previewMets = $this->uriBuilder
             ->reset()
             ->setTargetPageUid($apiPid)
-            ->setArguments(array( 'tx_dpf' => $row))
+            ->setArguments(array ('tx_dpf' => $row))
             ->setCreateAbsoluteUri(true)
             ->setUseCacheHash(FALSE)
             //->setNoCache(TRUE)
@@ -96,7 +96,7 @@ 
             ->setUseCacheHash(TRUE)
             //->setNoCache(TRUE)
             ->setArguments(
-                array( 'tx_dlf' => array(
+                array ('tx_dlf' => array (
                         'id' => urldecode($previewMets),
                     )
                 )
@@ -105,7 +105,7 @@ 
             ->buildFrontendUri();
 
         $title = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('manager.tooltip.preview', 'dpf', $arguments = null);
-        $icon = '<a href="'. $additionalGetVars . '" data-toggle="tooltip" class="' . $class . '" title="' . $title . '">' . $insideText . '</a>';
+        $icon = '<a href="' . $additionalGetVars . '" data-toggle="tooltip" class="' . $class . '" title="' . $title . '">' . $insideText . '</a>';
 
         return $icon;
 

Braces +4 added lines, -8 removed lines

@@ -18,8 +18,7 @@ 
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface;
 
-class PreviewViewHelper extends AbstractViewHelper
-{
+class PreviewViewHelper extends AbstractViewHelper {
     /**
      * @var \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface
      * @TYPO3\CMS\Extbase\Annotation\Inject
@@ -78,8 +77,7 @@ 
      * @param  string $class
      * @return string html output
      */
-    protected function getViewIcon(array $row, $pageUid, $apiPid, $insideText, $class)
-    {
+    protected function getViewIcon(array $row, $pageUid, $apiPid, $insideText, $class) {
 
        $previewMets = $this->uriBuilder
             ->reset()
@@ -111,8 +109,7 @@ 
 
     }
 
-    public function initializeArguments()
-    {
+    public function initializeArguments() {
         parent::initializeArguments();
 
         $this->registerArgument('arguments', 'array', '', true);
@@ -127,8 +124,7 @@ 
      *
      * @return string the rendered record list
      */
-    public function render()
-    {
+    public function render() {
         $arguments = $this->arguments['arguments'];
         $pageUid = $this->arguments['pageUid'];
         $apiPid = $this->arguments['apiPid'];

Upper-Lower-Casing +8 added lines, -8 removed lines

@@ -52,7 +52,7 @@ 
      *
      * @var bool
      */
-    protected $escapeOutput = false;
+    protected $escapeOutput = FALSE;
 
 
     /**
@@ -85,7 +85,7 @@ 
             ->reset()
             ->setTargetPageUid($apiPid)
             ->setArguments(array( 'tx_dpf' => $row))
-            ->setCreateAbsoluteUri(true)
+            ->setCreateAbsoluteUri(TRUE)
             ->setUseCacheHash(FALSE)
             //->setNoCache(TRUE)
             ->buildFrontendUri();
@@ -101,10 +101,10 @@ 
                     )
                 )
             )
-            ->setCreateAbsoluteUri(true)
+            ->setCreateAbsoluteUri(TRUE)
             ->buildFrontendUri();
 
-        $title = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('manager.tooltip.preview', 'dpf', $arguments = null);
+        $title = \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('manager.tooltip.preview', 'dpf', $arguments = NULL);
         $icon = '<a href="'. $additionalGetVars . '" data-toggle="tooltip" class="' . $class . '" title="' . $title . '">' . $insideText . '</a>';
 
         return $icon;
@@ -115,10 +115,10 @@ 
     {
         parent::initializeArguments();
 
-        $this->registerArgument('arguments', 'array', '', true);
-        $this->registerArgument('pageUid', 'int', '', true);
-        $this->registerArgument('apiPid', 'int', '', true);
-        $this->registerArgument('class', 'string', '', true);
+        $this->registerArgument('arguments', 'array', '', TRUE);
+        $this->registerArgument('pageUid', 'int', '', TRUE);
+        $this->registerArgument('apiPid', 'int', '', TRUE);
+        $this->registerArgument('class', 'string', '', TRUE);
     }
 
     /**

Classes/Domain/Workflow/DocumentWorkflow.php

Indentation +1 added lines, -1 removed lines

@@ -218,7 +218,7 @@
                         );
                     } else {
                         $definitionBuilder->addTransition(
-                             new Transition($transitionName, $fromState, $transition["to"])
+                                new Transition($transitionName, $fromState, $transition["to"])
                         );
                     }
                 }

Spacing +12 added lines, -12 removed lines

@@ -34,30 +34,30 @@
     const REMOTE_STATE_INACTIVE     = "INACTIVE";
     const REMOTE_STATE_DELETED      = "DELETED";
 
-    const STATE_NONE_NONE            = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_NONE;
+    const STATE_NONE_NONE            = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_NONE;
 
     // New
-    const STATE_NEW_NONE             = self::LOCAL_STATE_NEW.':'.self::REMOTE_STATE_NONE;
+    const STATE_NEW_NONE             = self::LOCAL_STATE_NEW . ':' . self::REMOTE_STATE_NONE;
 
     // Registered
-    const STATE_REGISTERED_NONE      = self::LOCAL_STATE_REGISTERED.':'.self::REMOTE_STATE_NONE;
+    const STATE_REGISTERED_NONE      = self::LOCAL_STATE_REGISTERED . ':' . self::REMOTE_STATE_NONE;
 
     // In progress
-    const STATE_IN_PROGRESS_NONE     = self::LOCAL_STATE_IN_PROGRESS.':'.self::REMOTE_STATE_NONE;
-    const STATE_IN_PROGRESS_ACTIVE   = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_ACTIVE;
-    const STATE_IN_PROGRESS_INACTIVE = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_INACTIVE;
-    const STATE_IN_PROGRESS_DELETED  = self::LOCAL_STATE_IN_PROGRESS.":".self::REMOTE_STATE_DELETED;
+    const STATE_IN_PROGRESS_NONE     = self::LOCAL_STATE_IN_PROGRESS . ':' . self::REMOTE_STATE_NONE;
+    const STATE_IN_PROGRESS_ACTIVE   = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_ACTIVE;
+    const STATE_IN_PROGRESS_INACTIVE = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_INACTIVE;
+    const STATE_IN_PROGRESS_DELETED  = self::LOCAL_STATE_IN_PROGRESS . ":" . self::REMOTE_STATE_DELETED;
 
     // Active
-    const STATE_NONE_ACTIVE          = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_ACTIVE;
+    const STATE_NONE_ACTIVE          = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_ACTIVE;
 
     // Postponed
-    const STATE_POSTPONED_NONE       = self::LOCAL_STATE_POSTPONED.':'.self::REMOTE_STATE_NONE;
-    const STATE_NONE_INACTIVE        = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_INACTIVE;
+    const STATE_POSTPONED_NONE       = self::LOCAL_STATE_POSTPONED . ':' . self::REMOTE_STATE_NONE;
+    const STATE_NONE_INACTIVE        = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_INACTIVE;
 
     // Discarded
-    const STATE_DISCARDED_NONE       = self::LOCAL_STATE_DISCARDED.':'.self::REMOTE_STATE_NONE;
-    const STATE_NONE_DELETED         = self::LOCAL_STATE_NONE.':'.self::REMOTE_STATE_DELETED;
+    const STATE_DISCARDED_NONE       = self::LOCAL_STATE_DISCARDED . ':' . self::REMOTE_STATE_NONE;
+    const STATE_NONE_DELETED         = self::LOCAL_STATE_NONE . ':' . self::REMOTE_STATE_DELETED;
 
     const TRANSITION_CREATE              = "CREATE_TRANSITION";
     const TRANSITION_CREATE_REGISTER     = "CREATE_REGISTER_TRANSITION";

Braces +3 added lines, -6 removed lines

@@ -20,8 +20,7 @@ 
 use Symfony\Component\Workflow\Workflow;
 use Symfony\Component\Workflow\Registry;
 
-class DocumentWorkflow
-{
+class DocumentWorkflow {
     const LOCAL_STATE_NONE          = 'NONE';
     const LOCAL_STATE_NEW           = 'NEW';
     const LOCAL_STATE_REGISTERED    = 'REGISTERED';
@@ -264,8 +263,7 @@ 
         ]
     ];
     
-    public static function getWorkflow()
-    {
+    public static function getWorkflow() {
         $definitionBuilder = new DefinitionBuilder();
 
         $definitionBuilder->addPlaces(self::PLACES);
@@ -297,8 +295,7 @@ 
         return $localState . ':' . $remoteState;
     }
 
-    public static function getAliasStateByLocalOrRepositoryState($state)
-    {
+    public static function getAliasStateByLocalOrRepositoryState($state) {
         // FIXME: Information hiding. Future note: Fedora 3 implementation knowledge should be hidden in separate class module.
 
         // A,I and D are the states returned by a repository search.

Classes/Domain/Repository/MetadataPageRepository.php

Braces +1 added lines, -2 removed lines

@@ -17,7 +17,6 @@
 /**
  * The repository for MetadataPages
  */
-class MetadataPageRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository
-{
+class MetadataPageRepository extends \EWW\Dpf\Domain\Repository\AbstractRepository {
 
 }