View GitHub Repository kitodo-publication

Schedule Inspection
Subscribe
Passed
Push — master ( 3603b1...7670bb )
by Ralf
10:54
created
Status
Category
Toggle Patches
Classes/Plugins/DownloadTool/DownloadTool.php 1 patch
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -46,13 +46,13 @@  discard block
 
 block discarded – undo
46 46 
         // Flexform wins over TS
47 47 
         $dpfTSconfig = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_dpf.'];
48 48 
         if (is_array($dpfTSconfig['settings.'])) {
49 
-            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, true, false);
49 
+            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, TRUE, FALSE);
50 50 
             $this->conf = $dpfTSconfig['settings.'];
51 51 
         }
52 52
53 53 
         // Load current document.
54 54 
         $this->loadDocument();
55 
-        if ($this->doc === null || empty($this->conf['fileGrpDownload'])) {
55 
+        if ($this->doc === NULL || empty($this->conf['fileGrpDownload'])) {
56 56 
             // Quit without doing anything if required variables are not set.
57 57 
             return $content;
58 58 
         }
 
@@ -76,7 +76,7 @@  discard block
 
 block discarded – undo
76 76 
                     'useCacheHash'     => 0,
77 77 
                     'parameter'        => $this->conf['apiPid'] . ' - piwik_download',
78 78 
                     'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment' . '&tx_dpf[attachment]=' . $file['ID'],
79 
-                    'forceAbsoluteUrl' => true,
79 
+                    'forceAbsoluteUrl' => TRUE,
80 80 
                 );
81 81 
                 $title = $file['LABEL'] ? $file['LABEL'] : $file['ID'];
82 82 
                 $markerArray['###FILE###'] = $this->cObj->typoLink($title, $conf);
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
                 $content .= $this->cObj->substituteMarkerArray($subpartArray['downloads'], $markerArray);
90 90 
             }
91 91 
         }
92 
-        return $this->cObj->substituteSubpart($this->template, '###DOWNLOADS###', $content, true);
92 
+        return $this->cObj->substituteSubpart($this->template, '###DOWNLOADS###', $content, TRUE);
93 93 
     }
94 94
95 95 
     /**
Please login to merge, or discard this patch.
Classes/Plugins/RelatedListTool/RelatedListTool.php 1 patch
Upper-Lower-Casing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -46,13 +46,13 @@  discard block
 
 block discarded – undo
46 46 
         // Flexform wins over TS
47 47 
         $dpfTSconfig = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_dpf.'];
48 48 
         if (is_array($dpfTSconfig['settings.'])) {
49 
-            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, true, false);
49 
+            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, TRUE, FALSE);
50 50 
             $this->conf = $dpfTSconfig['settings.'];
51 51 
         }
52 52
53 53 
         // Load current document.
54 54 
         $this->loadDocument();
55 
-        if ($this->doc === null) {
55 
+        if ($this->doc === NULL) {
56 56 
             // Quit without doing anything if required variables are not set.
57 57 
             return $content;
58 58 
         }
 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
                         'useCacheHash'     => 0,
76 76 
                         'parameter'        => $this->conf['apiPid'],
77 77 
                         'additionalParams' => '&tx_dpf[qid]=' . $value['docId'] . '&tx_dpf[action]=mets',
78 
-                        'forceAbsoluteUrl' => true,
78 
+                        'forceAbsoluteUrl' => TRUE,
79 79 
                     );
80 80
81 81 
                     $metsApiUrl = urlencode($this->cObj->typoLink_URL($confApi));
 
@@ -83,19 +83,19 @@  discard block
 
 block discarded – undo
83 83 
                         'useCacheHash'     => 1,
84 84 
                         'parameter'        => $GLOBALS['TSFE']->page['uid'],
85 85 
                         'additionalParams' => '&tx_dlf[id]=' . $metsApiUrl,
86 
-                        'forceAbsoluteUrl' => true,
86 
+                        'forceAbsoluteUrl' => TRUE,
87 87 
                     );
88 88 
                 } elseif ($value['type'] == 'urn') {
89 89 
                     // use urn link
90 90 
                     $conf = array(
91 91 
                         'useCacheHash'     => 0,
92 92 
                         'parameter'        => 'https://nbn-resolving.de/' . $value['docId'],
93 
-                        'forceAbsoluteUrl' => true,
93 
+                        'forceAbsoluteUrl' => TRUE,
94 94 
                     );
95 95 
                 } else {
96 96 
                     $conf = array(
97 97 
                         'useCacheHash'     => 0,
98 
-                        'forceAbsoluteUrl' => true,
98 
+                        'forceAbsoluteUrl' => TRUE,
99 99 
                     );
100 100 
                 }
101 101 
                 $title = $value['title'] ? $value['title'] : $value['docId'];
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
                 $content .= $this->cObj->substituteMarkerArray($subpartArray['items'], $markerArray);
105 105 
             }
106 106 
         }
107 
-        return $this->cObj->substituteSubpart($this->template, '###ITEMS###', $content, true);
107 
+        return $this->cObj->substituteSubpart($this->template, '###ITEMS###', $content, TRUE);
108 108 
     }
109 109
110 110 
     private function compareByOrderVolumeTitle($a, $b)
 
@@ -134,8 +134,8 @@  discard block
 
 block discarded – undo
134 134 
             $element['type'] = $type;
135 135 
             $element['title'] = $title;
136 136 
             $element['docId'] = $docId;
137 
-            $element['order'] = (!empty($order)) ? $order : null;
138 
-            $element['volume'] = (!empty($volume)) ? $volume : null;
137 
+            $element['order'] = (!empty($order)) ? $order : NULL;
138 
+            $element['volume'] = (!empty($volume)) ? $volume : NULL;
139 139
140 140 
             $relatedItems[$index] = $element;
141 141 
         }
Please login to merge, or discard this patch.
Classes/Plugins/MetaTags/MetaTags.php 1 patch
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -54,14 +54,14 @@  discard block
 
 block discarded – undo
54 54 
         // Flexform wins over TS
55 55 
         $dpfTSconfig = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_dpf.'];
56 56 
         if (is_array($dpfTSconfig['settings.'])) {
57 
-            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, true, false);
57 
+            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, TRUE, FALSE);
58 58 
             $this->conf = $dpfTSconfig['settings.'];
59 59 
         }
60 60 
         // Turn cache on.
61 
-        $this->setCache(true);
61 
+        $this->setCache(TRUE);
62 62 
         // Load current document.
63 63 
         $this->loadDocument();
64 
-        if ($this->doc === null) {
64 
+        if ($this->doc === NULL) {
65 65 
             // Quit without doing anything if required variables are not set.
66 66 
             return $content;
67 67 
         } else {
 
@@ -153,7 +153,7 @@  discard block
 
 block discarded – undo
153 153 
                             'useCacheHash'     => 0,
154 154 
                             'parameter'        => $this->conf['apiPid'],
155 155 
                             'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment&tx_dpf[attachment]=' . $attachment['ID'],
156 
-                            'forceAbsoluteUrl' => true,
156 
+                            'forceAbsoluteUrl' => TRUE,
157 157 
                         );
158 158 
                         $outArray['citation_pdf_url'][] = $this->cObj->typoLink_URL($conf);
159 159 
                     }
Please login to merge, or discard this patch.