ExternalMetadataImportController::uploadImportFileAction()

Complexity

Conditions	12
Paths	348

Size

Total Lines	66
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function uploadImportFileAction($fileType, $uploadFile = [])
    {
        $this->externalMetadataRepository->clearExternalMetadataByFeUserUid($this->security->getUser()->getUid());

        $uploadFileUrl = new \EWW\Dpf\Helper\UploadFileUrl;
        $uploadFilePath = Environment::getPublicPath() . "/" . $uploadFileUrl->getDirectory() .
            "/importFile.".md5($this->security->getUser()->getUid());

        if ($uploadFile['error'] === UPLOAD_ERR_OK) {
            \TYPO3\CMS\Core\Utility\GeneralUtility::upload_copy_move($uploadFile['tmp_name'], $uploadFilePath);
            //$finfo       = finfo_open(FILEINFO_MIME_TYPE);
            //$contentType = finfo_file($finfo, $uploadFilePath);
            //finfo_close($finfo);
        } elseif ($uploadFile['error'] == UPLOAD_ERR_NO_FILE) {
            $this->redirect('uploadStart');
        } else {
            $this->redirect('uploadStart', null, null, ['error' => 'UPLOAD_ERROR']);
        }

        try {

            if ($fileType == 'bibtex') {
                /** @var FileImporter $fileImporter */
                $fileImporter = $this->objectManager->get(BibTexFileImporter::class);
                $results = $fileImporter->loadFile($uploadFilePath, $this->settings['bibTexMandatoryFields']);
            } elseif ($fileType == 'riswos') {
                /** @var FileImporter $fileImporter */
                $fileImporter = $this->objectManager->get(RisWosFileImporter::class);
                $results = $fileImporter->loadFile($uploadFilePath, $this->settings['riswosMandatoryFields']);
            } else {
                $results = [];
            }

            foreach ($results as $externalMetadata) {
                $this->externalMetadataRepository->add($externalMetadata);
            }

            if ($mandatoryErrors = $fileImporter->getMandatoryErrors()) {

The variable $fileImporter does not seem to be defined for all execution paths leading up to this point.

                foreach (
                    $mandatoryErrors as $mandatoryError
                ) {
                    $message = LocalizationUtility::translate(
                        "manager.uploadImport.incompleteData",
                        [

array($mandatoryError['index'], $mandatoryError['title'] ? ' (' . $mandatoryError['title'] . ')' : '', implode(',', $mandatoryError['fields'])) of type array<integer,mixed|string> is incompatible with the type null|string expected by parameter $extensionName of TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate().

                            $mandatoryError['index'],
                            ($mandatoryError['title'] ? ' (' . $mandatoryError['title'] . ')' : ''),
                            implode(',', $mandatoryError['fields'])
                        ]
                    );
                    $this->addFlashMessage($message, '', AbstractMessage::ERROR);
                }
            } elseif ($results) {
                    $this->redirect(
                        'importUploadedData',
                        null,
                        null,
                        ['uploadFilePath' => $uploadFilePath]
                    );
            } else {
                $this->redirect('uploadStart', null, null, ['error' => 'INVALID_FORMAT']);
            }
        } catch (\TYPO3\CMS\Extbase\Mvc\Exception\StopActionException $exception) {
            // A redirect always throws this exception, but in this case, however,
            // redirection is desired and should not lead to an exception handling
        } catch (\RenanBr\BibTexParser\Exception\ParserException $exception) {
            $this->redirect('uploadStart', null, null, ['error' => 'INVALID_FORMAT']);
        }