We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -152,7 +152,7 @@ |
||
| 152 | 152 | // field for which highlighting is going to be performed, |
| 153 | 153 | // is required if you want to have OCR highlighting |
| 154 | 154 | $solrRequest->addParam('hl.ocr.fl', $this->fields['fulltext']); |
| 155 | - // return the coordinates of highlighted search as absolute coordinates |
|
| 155 | + // return the coordinates of highlighted search as absolute coordinates |
|
| 156 | 156 | $solrRequest->addParam('hl.ocr.absoluteHighlights', 'on'); |
| 157 | 157 | // max amount of snippets for a single page |
| 158 | 158 | $solrRequest->addParam('hl.snippets', '40'); |
@@ -34,7 +34,7 @@ |
||
| 34 | 34 | |
| 35 | 35 | $view->assign( |
| 36 | 36 | 'configObject', |
| 37 | - [ 'wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article> |
|
| 37 | + ['wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article> |
|
| 38 | 38 | key.wrap = <label>|</label> |
| 39 | 39 | value.required = 1 |
| 40 | 40 | value.wrap = <li>|</li>' |
@@ -50,7 +50,7 @@ |
||
| 50 | 50 | <root> |
| 51 | 51 | <single /> |
| 52 | 52 | </root> |
| 53 | -XML; |
|
| 53 | +xml; |
|
| 54 | 54 | $node = Helper::getXmlFileAsString($xml); |
| 55 | 55 | self::assertIsObject($node); |
| 56 | 56 | self::assertEquals('root', $node->getName()); |
@@ -331,7 +331,7 @@ discard block |
||
| 331 | 331 | $pages = []; |
| 332 | 332 | $pagesSect = []; |
| 333 | 333 | $aRange = []; |
| 334 | - $nRange = 5; // ToDo: should be made configurable |
|
| 334 | + $nRange = 5; // ToDo: should be made configurable |
|
| 335 | 335 | |
| 336 | 336 | // lower limit of the range |
| 337 | 337 | $nBottom = $currentPageNumber - $nRange; |
@@ -346,7 +346,7 @@ discard block |
||
| 346 | 346 | |
| 347 | 347 | // check whether the first screen page is > 1, if yes then points must be added |
| 348 | 348 | if ($aRange[0] > 1) { |
| 349 | - array_push($pagesSect, ['label' => '...','startRecordNumber' => '...']); |
|
| 349 | + array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']); |
|
| 350 | 350 | }; |
| 351 | 351 | $lastStartRecordNumberGrid = 0; // due to validity outside the loop |
| 352 | 352 | foreach (range($firstPage, $lastPage) as $i) { |
@@ -389,7 +389,7 @@ discard block |
||
| 389 | 389 | |
| 390 | 390 | // Check if screen page is in range |
| 391 | 391 | if (in_array($i, $aRange)) { |
| 392 | - array_push($pagesSect, ['label' => $i,'startRecordNumber' => $startRecordNumber]); |
|
| 392 | + array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $startRecordNumber]); |
|
| 393 | 393 | }; |
| 394 | 394 | }; |
| 395 | 395 | }; |
@@ -351,7 +351,8 @@ discard block |
||
| 351 | 351 | $lastStartRecordNumberGrid = 0; // due to validity outside the loop |
| 352 | 352 | foreach (range($firstPage, $lastPage) as $i) { |
| 353 | 353 | // detect which pagination is active: ListView or GridView |
| 354 | - if (get_class($pagination) == 'TYPO3\CMS\Core\Pagination\SimplePagination') { // ListView |
|
| 354 | + if (get_class($pagination) == 'TYPO3\CMS\Core\Pagination\SimplePagination') { |
|
| 355 | +// ListView |
|
| 355 | 356 | $lastStartRecordNumberGrid = $i; // save last $startRecordNumber for LastPage button |
| 356 | 357 | |
| 357 | 358 | $pages[$i] = [ |
@@ -364,7 +365,8 @@ discard block |
||
| 364 | 365 | if (in_array($i, $aRange)) { |
| 365 | 366 | array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $i]); |
| 366 | 367 | }; |
| 367 | - } else { // GridView |
|
| 368 | + } else { |
|
| 369 | +// GridView |
|
| 368 | 370 | // to calculate the values for generation the links for the pagination pages |
| 369 | 371 | /** @var \Kitodo\Dlf\Pagination\PageGridPaginator $paginator */ |
| 370 | 372 | $itemsPerPage = $paginator->getPublicItemsPerPage(); |
@@ -334,7 +334,7 @@ |
||
| 334 | 334 | * |
| 335 | 335 | * @return void |
| 336 | 336 | */ |
| 337 | - private function addCollections(Document &$document, array $collections): void |
|
| 337 | + private function addCollections(Document & $document, array $collections): void |
|
| 338 | 338 | { |
| 339 | 339 | foreach ($collections as $collection) { |
| 340 | 340 | $documentCollection = $this->collectionRepository->findOneByIndexName($collection); |
@@ -29,10 +29,10 @@ |
||
| 29 | 29 | */ |
| 30 | 30 | class DocumentValidator |
| 31 | 31 | { |
| 32 | - /** |
|
| 33 | - * @access protected |
|
| 34 | - * @var Logger This holds the logger |
|
| 35 | - */ |
|
| 32 | + /** |
|
| 33 | + * @access protected |
|
| 34 | + * @var Logger This holds the logger |
|
| 35 | + */ |
|
| 36 | 36 | protected Logger $logger; |
| 37 | 37 | |
| 38 | 38 | /** |
@@ -347,7 +347,7 @@ discard block |
||
| 347 | 347 | } |
| 348 | 348 | } |
| 349 | 349 | } |
| 350 | - return $label ?: $orderLabel; |
|
| 350 | + return $label ? : $orderLabel; |
|
| 351 | 351 | } |
| 352 | 352 | |
| 353 | 353 | /** |
@@ -382,7 +382,7 @@ discard block |
||
| 382 | 382 | { |
| 383 | 383 | usort( |
| 384 | 384 | $menu[0]['_SUB_MENU'], |
| 385 | - function ($firstElement, $secondElement) { |
|
| 385 | + function($firstElement, $secondElement) { |
|
| 386 | 386 | if (!empty($firstElement['orderlabel'])) { |
| 387 | 387 | return $firstElement['orderlabel'] <=> $secondElement['orderlabel']; |
| 388 | 388 | } |
@@ -382,7 +382,8 @@ |
||
| 382 | 382 | { |
| 383 | 383 | usort( |
| 384 | 384 | $menu[0]['_SUB_MENU'], |
| 385 | - function ($firstElement, $secondElement) { |
|
| 385 | + function ($firstElement, $secondElement) |
|
| 386 | + { |
|
| 386 | 387 | if (!empty($firstElement['orderlabel'])) { |
| 387 | 388 | return $firstElement['orderlabel'] <=> $secondElement['orderlabel']; |
| 388 | 389 | } |
@@ -122,7 +122,7 @@ discard block |
||
| 122 | 122 | } |
| 123 | 123 | |
| 124 | 124 | if (isset($listRequestData['searchParameter']) && is_array($listRequestData['searchParameter'])) { |
| 125 | - $this->searchParams = array_merge($this->searchParams ?: [], $listRequestData['searchParameter']); |
|
| 125 | + $this->searchParams = array_merge($this->searchParams ? : [], $listRequestData['searchParameter']); |
|
| 126 | 126 | $listViewSearch = true; |
| 127 | 127 | $GLOBALS['TSFE']->fe_user->setKey('ses', 'search', $this->searchParams); |
| 128 | 128 | } |
@@ -190,7 +190,7 @@ discard block |
||
| 190 | 190 | $simplePagination = new SimplePagination($solrPaginator); |
| 191 | 191 | |
| 192 | 192 | $pagination = $this->buildSimplePagination($simplePagination, $solrPaginator); |
| 193 | - $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $solrPaginator ]); |
|
| 193 | + $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $solrPaginator]); |
|
| 194 | 194 | } |
| 195 | 195 | |
| 196 | 196 | $this->view->assign('documents', !empty($solrResults) ? $solrResults : []); |
@@ -354,7 +354,7 @@ |
||
| 354 | 354 | $solrDoc->setField('title', $metadata['title'][0]); |
| 355 | 355 | $solrDoc->setField('volume', $metadata['volume'][0]); |
| 356 | 356 | // verify date formatting |
| 357 | - if(strtotime($metadata['date'][0])) { |
|
| 357 | + if (strtotime($metadata['date'][0])) { |
|
| 358 | 358 | $solrDoc->setField('date', self::getFormattedDate($metadata['date'][0])); |
| 359 | 359 | } |
| 360 | 360 | $solrDoc->setField('record_id', $metadata['record_id'][0]); |