Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#836)
by Beatrycze
04:08
created
Build/Documentation/dbdocs/RstSection.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function($entry) {
50 50
             return !empty($entry);
51 51
         }));
52 52
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function ($entry)
50
+        {
50 51
             return !empty($entry);
51 52
         }));
52 53
 
Please login to merge, or discard this patch.
Classes/Common/Indexer.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -531,7 +531,8 @@  discard block
 block discarded – undo
531 531
      *
532 532
      * @return \Solarium\Core\Query\DocumentInterface
533 533
      */
534
-    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') {
534
+    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '')
535
+    {
535 536
         $solrDoc = $updateQuery->createDocument();
536 537
         // Create unique identifier from document's UID and unit's XML ID.
537 538
         $solrDoc->setField('id', $document->getUid() . $unit['id']);
@@ -555,7 +556,8 @@  discard block
 block discarded – undo
555 556
      *
556 557
      * @return array|string
557 558
      */
558
-    private static function removeAppendsFromAuthor($authors) {
559
+    private static function removeAppendsFromAuthor($authors)
560
+    {
559 561
         if (is_array($authors)) {
560 562
             foreach ($authors as $i => $author) {
561 563
                 $splitName = explode(chr(31), $author);
Please login to merge, or discard this patch.
Classes/Common/MetsDocument.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -670,7 +670,7 @@
 block discarded – undo
670 670
             }
671 671
         }
672 672
 
673
-        return array_filter($allMdIds, function ($element) {
673
+        return array_filter($allMdIds, function($element) {
674 674
             return !empty($element);
675 675
         });
676 676
     }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -412,7 +412,8 @@  discard block
 block discarded – undo
412 412
         return $details;
413 413
     }
414 414
 
415
-    private function getLogicalStructureFor3D($details) {
415
+    private function getLogicalStructureFor3D($details)
416
+    {
416 417
         // add description and identifier for 3D objects
417 418
         if ($details['type'] == 'collection' || $details['type'] == 'object') {
418 419
             $metadata = $this->getMetadata($details['id']);
@@ -710,7 +711,8 @@  discard block
 block discarded – undo
710 711
             }
711 712
         }
712 713
 
713
-        return array_filter($allMdIds, function ($element) {
714
+        return array_filter($allMdIds, function ($element)
715
+        {
714 716
             return !empty($element);
715 717
         });
716 718
     }
Please login to merge, or discard this patch.
Build/Documentation/dbdocs/Generator.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function($lhs, $rhs) {
208 208
             return $lhs->name <=> $rhs->name;
209 209
         });
210 210
 
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
                 'description' => 'Description',
232 232
             ]];
233 233
 
234
-            $rows = array_map(function ($column) use ($page) {
234
+            $rows = array_map(function($column) use ($page) {
235 235
                 return [
236 236
                     'field' => (
237 237
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,8 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function ($lhs, $rhs)
208
+        {
208 209
             return $lhs->name <=> $rhs->name;
209 210
         });
210 211
 
@@ -231,7 +232,8 @@  discard block
 block discarded – undo
231 232
                 'description' => 'Description',
232 233
             ]];
233 234
 
234
-            $rows = array_map(function ($column) use ($page) {
235
+            $rows = array_map(function ($column) use ($page)
236
+            {
235 237
                 return [
236 238
                     'field' => (
237 239
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Classes/Controller/Backend/NewTenantController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@
 block discarded – undo
277 277
 
278 278
         if ($this->solrCoreRepository->findOneByPid($this->pid) === null) {
279 279
             $newRecord = GeneralUtility::makeInstance(SolrCore::class);
280
-            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')');
280
+            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')');
281 281
             $indexName = Solr::createCore('');
282 282
             $newRecord->setIndexName($indexName);
283 283
 
Please login to merge, or discard this patch.
Tests/Functional/FunctionalTestCase.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration();
72 72
 
73 73
         if ($this->disableJsonWrappedResponse) {
74
-            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) {
74
+            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function($ext) {
75 75
                 return $ext !== 'Resources/Core/Functional/Extensions/json_response';
76 76
             });
77 77
         }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $jsonDocuments = json_decode(file_get_contents($path), true);
153 153
 
154 154
         $updateQuery = $solr->service->createUpdate();
155
-        $documents = array_map(function ($jsonDoc) use ($updateQuery) {
155
+        $documents = array_map(function($jsonDoc) use ($updateQuery) {
156 156
             $document = $updateQuery->createDocument();
157 157
             foreach ($jsonDoc as $key => $value) {
158 158
                 $document->setField($key, $value);
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,8 @@  discard block
 block discarded – undo
71 71
         $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration();
72 72
 
73 73
         if ($this->disableJsonWrappedResponse) {
74
-            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) {
74
+            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext)
75
+            {
75 76
                 return $ext !== 'Resources/Core/Functional/Extensions/json_response';
76 77
             });
77 78
         }
@@ -152,7 +153,8 @@  discard block
 block discarded – undo
152 153
         $jsonDocuments = json_decode(file_get_contents($path), true);
153 154
 
154 155
         $updateQuery = $solr->service->createUpdate();
155
-        $documents = array_map(function ($jsonDoc) use ($updateQuery) {
156
+        $documents = array_map(function ($jsonDoc) use ($updateQuery)
157
+        {
156 158
             $document = $updateQuery->createDocument();
157 159
             foreach ($jsonDoc as $key => $value) {
158 160
                 $document->setField($key, $value);
Please login to merge, or discard this patch.
Classes/Format/AudioVideoMD.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,6 +48,6 @@
 block discarded – undo
48 48
             $metadata['video_duration'] = [$videoDuration];
49 49
         }
50 50
 
51
-        $metadata['duration'] = $metadata['video_duration'] ?: $metadata['audio_duration'] ?: [];
51
+        $metadata['duration'] = $metadata['video_duration'] ? : $metadata['audio_duration'] ? : [];
52 52
     }
53 53
 }
Please login to merge, or discard this patch.
Classes/Common/Helper.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
             return '';
401 401
         }
402 402
 
403
-        $makeCacheKey = function ($pid, $uid) {
403
+        $makeCacheKey = function($pid, $uid) {
404 404
             return $pid . '.' . $uid;
405 405
         };
406 406
 
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
925 925
             self::log('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.', LOG_SEVERITY_WARNING);
926 926
             return false;
927 927
         }
928
-        $content  = $response->getBody()->getContents();
928
+        $content = $response->getBody()->getContents();
929 929
 
930 930
         return $content;
931 931
     }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -400,7 +400,8 @@
 block discarded – undo
400 400
             return '';
401 401
         }
402 402
 
403
-        $makeCacheKey = function ($pid, $uid) {
403
+        $makeCacheKey = function ($pid, $uid)
404
+        {
404 405
             return $pid . '.' . $uid;
405 406
         };
406 407
 
Please login to merge, or discard this patch.
Classes/Controller/TableOfContentsController.php 1 patch
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -344,7 +344,8 @@  discard block
 block discarded – undo
344 344
      *
345 345
      * @return bool true if found, false otherwise
346 346
      */
347
-    private function isFound($entry) {
347
+    private function isFound($entry)
348
+    {
348 349
         if (!empty($this->requestData['title'] && !empty($this->requestData['types']) && !empty($this->requestData['author']))) {
349 350
             return $this->isTitleFound($entry) && $this->isTypeFound($entry) && $this->isAuthorFound($entry);
350 351
         } else if (!empty($this->requestData['title']) && !empty($this->requestData['author'])) {
@@ -372,7 +373,8 @@  discard block
 block discarded – undo
372 373
      *
373 374
      * @return bool true if found, false otherwise
374 375
      */
375
-    private function isAuthorFound($entry) {
376
+    private function isAuthorFound($entry)
377
+    {
376 378
         $value = strtolower($entry['author']);
377 379
         $author = strtolower($this->requestData['author']);
378 380
         return str_contains($value, $author);
@@ -385,7 +387,8 @@  discard block
 block discarded – undo
385 387
      *
386 388
      * @return bool true if found, false otherwise
387 389
      */
388
-    private function isTitleFound($entry) {
390
+    private function isTitleFound($entry)
391
+    {
389 392
         $value = strtolower($entry['label']);
390 393
         $title = strtolower($this->requestData['title']);
391 394
         return str_contains($value, $title);
@@ -398,7 +401,8 @@  discard block
 block discarded – undo
398 401
      *
399 402
      * @return bool true if found, false otherwise
400 403
      */
401
-    private function isTypeFound($entry) {
404
+    private function isTypeFound($entry)
405
+    {
402 406
         return str_contains($entry['identifier'], $this->requestData['types']);
403 407
     }
404 408
 
@@ -409,7 +413,8 @@  discard block
 block discarded – undo
409 413
      *
410 414
      * @return array of object types
411 415
      */
412
-    private function getTypes($entry) {
416
+    private function getTypes($entry)
417
+    {
413 418
         $types = [];
414 419
         $index = 0;
415 420
 
@@ -433,7 +438,8 @@  discard block
 block discarded – undo
433 438
      *
434 439
      * @return string type name without number
435 440
      */
436
-    private function getType($entry) {
441
+    private function getType($entry)
442
+    {
437 443
         $type = $entry['identifier'];
438 444
         if (!empty($type)) {
439 445
             return strtok($type, ',');
Please login to merge, or discard this patch.