Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — 2.x (#531)
by Sebastian
04:10
created
hooks/class.tx_dlf_em.php 1 patch
Braces   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -17,7 +17,8 @@  discard block
 block discarded – undo
17 17
  * @subpackage	tx_dlf
18 18
  * @access	public
19 19
  */
20
-class tx_dlf_em {
20
+class tx_dlf_em
21
+{
21 22
 
22 23
     /**
23 24
      * This holds the current configuration
@@ -45,7 +46,8 @@  discard block
 block discarded – undo
45 46
      *
46 47
      * @return	string		Message informing the user of success or failure
47 48
      */
48
-    public function checkSolrConnection(&$params, &$pObj) {
49
+    public function checkSolrConnection(&$params, &$pObj)
50
+    {
49 51
 
50 52
         $solrInfo = tx_dlf_solr::getSolrConnectionInfo();
51 53
 
@@ -120,7 +122,8 @@  discard block
 block discarded – undo
120 122
      *
121 123
      * @return	integer		UID of user or 0 if something is wrong
122 124
      */
123
-    protected function checkCliUser($checkOnly, $groupUid) {
125
+    protected function checkCliUser($checkOnly, $groupUid)
126
+    {
124 127
 
125 128
         // Set default return value.
126 129
         $usrUid = 0;
@@ -292,7 +295,8 @@  discard block
 block discarded – undo
292 295
      *
293 296
      * @return	integer		UID of usergroup or 0 if something is wrong
294 297
      */
295
-    protected function checkCliGroup($checkOnly, $settings = array ()) {
298
+    protected function checkCliGroup($checkOnly, $settings = array ())
299
+    {
296 300
 
297 301
         // Set default return value.
298 302
         $grpUid = 0;
@@ -507,7 +511,8 @@  discard block
 block discarded – undo
507 511
      *
508 512
      * @return	string		Message informing the user of success or failure
509 513
      */
510
-    public function checkCliUserGroup(&$params, &$pObj) {
514
+    public function checkCliUserGroup(&$params, &$pObj)
515
+    {
511 516
 
512 517
         // Check if usergroup "_cli_dlf" exists and is configured properly.
513 518
         $groupUid = $this->checkCliGroup(empty($this->conf['makeCliUserGroup']));
@@ -560,7 +565,8 @@  discard block
 block discarded – undo
560 565
      *
561 566
      * @return	string		Message informing the user of success or failure
562 567
      */
563
-    public function checkMetadataFormats(&$params, &$pObj) {
568
+    public function checkMetadataFormats(&$params, &$pObj)
569
+    {
564 570
 
565 571
         $nsDefined = array (
566 572
             'MODS' => FALSE,
@@ -661,7 +667,8 @@  discard block
 block discarded – undo
661 667
      *
662 668
      * @return	void
663 669
      */
664
-    public function __construct() {
670
+    public function __construct()
671
+    {
665 672
 
666 673
         // Load localization file.
667 674
         $GLOBALS['LANG']->includeLLFile('EXT:dlf/locallang.xml');
Please login to merge, or discard this patch.
hooks/class.tx_dlf_tcemain.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -17,7 +17,8 @@  discard block
 block discarded – undo
17 17
  * @subpackage	tx_dlf
18 18
  * @access	public
19 19
  */
20
-class tx_dlf_tcemain {
20
+class tx_dlf_tcemain
21
+{
21 22
 
22 23
     /**
23 24
      * Field post-processing hook for the process_datamap() method.
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
32 33
      *
33 34
      * @return	void
34 35
      */
35
-    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray, $pObj) {
36
+    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray, $pObj)
37
+    {
36 38
 
37 39
         if ($status == 'new') {
38 40
 
@@ -292,7 +294,8 @@  discard block
 block discarded – undo
292 294
      *
293 295
      * @return	void
294 296
      */
295
-    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray, $pObj) {
297
+    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray, $pObj)
298
+    {
296 299
 
297 300
         if ($status == 'update') {
298 301
 
@@ -377,7 +380,8 @@  discard block
 block discarded – undo
377 380
      *
378 381
      * @return	void
379 382
      */
380
-    public function processCmdmap_postProcess($command, $table, $id, $value, $pObj) {
383
+    public function processCmdmap_postProcess($command, $table, $id, $value, $pObj)
384
+    {
381 385
 
382 386
         if (in_array($command, array ('move', 'delete', 'undelete')) && $table == 'tx_dlf_documents') {
383 387
 
Please login to merge, or discard this patch.
hooks/class.tx_dlf_doctype.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,7 +18,8 @@  discard block
 block discarded – undo
18 18
  * @subpackage	tx_dlf
19 19
  * @access	public
20 20
  */
21
-class tx_dlf_doctype {
21
+class tx_dlf_doctype
22
+{
22 23
 
23 24
     /**
24 25
      * This holds the current document
@@ -60,7 +61,8 @@  discard block
 block discarded – undo
60 61
      *
61 62
      * @return	string		The type of the current document
62 63
      */
63
-    public function getDocType() {
64
+    public function getDocType()
65
+    {
64 66
 
65 67
         // Load current document.
66 68
         $this->loadDocument();
@@ -156,7 +158,8 @@  discard block
 block discarded – undo
156 158
      *
157 159
      * @return	void
158 160
      */
159
-    protected function loadDocument() {
161
+    protected function loadDocument()
162
+    {
160 163
 
161 164
         // Check for required variable.
162 165
         if (!empty($this->piVars['id'])) {
@@ -223,7 +226,8 @@  discard block
 block discarded – undo
223 226
      *
224 227
      * @return	void
225 228
      */
226
-    public function __construct() {
229
+    public function __construct()
230
+    {
227 231
 
228 232
         // Load current plugin parameters.
229 233
         $this->piVars = \TYPO3\CMS\Core\Utility\GeneralUtility::_GPmerged($this->prefixId);
Please login to merge, or discard this patch.
ext_localconf.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,8 @@
 block discarded – undo
105 105
      *
106 106
      * @return	boolean		TRUE if document type matches, FALSE if not
107 107
      */
108
-    function user_dlf_docTypeCheck($type) {
108
+    function user_dlf_docTypeCheck($type)
109
+    {
109 110
 
110 111
         $hook = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_dlf_doctype');
111 112
 
Please login to merge, or discard this patch.
cli/class.tx_dlf_cli.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,8 @@  discard block
 block discarded – undo
23 23
  * @subpackage	tx_dlf
24 24
  * @access	public
25 25
  */
26
-class tx_dlf_cli extends \TYPO3\CMS\Core\Controller\CommandLineController {
26
+class tx_dlf_cli extends \TYPO3\CMS\Core\Controller\CommandLineController
27
+{
27 28
 
28 29
     /**
29 30
      * This is the return code.
@@ -40,7 +41,8 @@  discard block
 block discarded – undo
40 41
      *
41 42
      * @return	void
42 43
      */
43
-    public function main() {
44
+    public function main()
45
+    {
44 46
 
45 47
         switch ((string) $this->cli_args['_DEFAULT'][1]) {
46 48
 
@@ -210,7 +212,8 @@  discard block
 block discarded – undo
210 212
 
211 213
     }
212 214
 
213
-    public function __construct() {
215
+    public function __construct()
216
+    {
214 217
 
215 218
         // Set basic information about the script.
216 219
         $this->cli_help = array (
Please login to merge, or discard this patch.
class.ext_update.php 1 patch
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -17,7 +17,8 @@  discard block
 block discarded – undo
17 17
  * @subpackage	tx_dlf
18 18
  * @access	public
19 19
  */
20
-class ext_update {
20
+class ext_update
21
+{
21 22
 
22 23
     /**
23 24
      * This holds the output ready to return
@@ -34,7 +35,8 @@  discard block
 block discarded – undo
34 35
      *
35 36
      * @return	boolean		Should the update option be shown?
36 37
      */
37
-    public function access() {
38
+    public function access()
39
+    {
38 40
 
39 41
         if (count($this->getMetadataConfig())) {
40 42
 
@@ -61,7 +63,8 @@  discard block
 block discarded – undo
61 63
      *
62 64
      * @return	array		Array of UIDs of outdated records
63 65
      */
64
-    protected function getMetadataConfig() {
66
+    protected function getMetadataConfig()
67
+    {
65 68
 
66 69
         $uids = array ();
67 70
 
@@ -105,7 +108,8 @@  discard block
 block discarded – undo
105 108
      *
106 109
      * @return	string		The content that is displayed on the website
107 110
      */
108
-    public function main() {
111
+    public function main()
112
+    {
109 113
 
110 114
         // Load localization file.
111 115
         $GLOBALS['LANG']->includeLLFile('EXT:dlf/locallang.xml');
@@ -138,7 +142,8 @@  discard block
 block discarded – undo
138 142
      *
139 143
      * @return	boolean		true if old index related columns exist
140 144
      */
141
-    protected function oldIndexRelatedTableNames() {
145
+    protected function oldIndexRelatedTableNames()
146
+    {
142 147
 
143 148
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
144 149
             'column_name',
@@ -172,7 +177,8 @@  discard block
 block discarded – undo
172 177
      *
173 178
      * @return	void
174 179
      */
175
-    protected function renameIndexRelatedColumns() {
180
+    protected function renameIndexRelatedColumns()
181
+    {
176 182
 
177 183
         $sqlQuery = "UPDATE tx_dlf_metadata SET `index_tokenized` = `tokenized`
178 184
 											, `index_stored` = `stored`
@@ -216,7 +222,8 @@  discard block
 block discarded – undo
216 222
      *
217 223
      * @return	void
218 224
      */
219
-    protected function updateMetadataConfig() {
225
+    protected function updateMetadataConfig()
226
+    {
220 227
 
221 228
         $metadataUids = $this->getMetadataConfig();
222 229
 
@@ -297,7 +304,8 @@  discard block
 block discarded – undo
297 304
      *
298 305
      * @return	boolean
299 306
      */
300
-    protected function solariumSolrUpdateRequired() {
307
+    protected function solariumSolrUpdateRequired()
308
+    {
301 309
 
302 310
         // Get all Solr cores that were not deleted.
303 311
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
@@ -333,7 +341,8 @@  discard block
 block discarded – undo
333 341
      *
334 342
      * @return	void
335 343
      */
336
-    protected function doSolariumSolrUpdate() {
344
+    protected function doSolariumSolrUpdate()
345
+    {
337 346
 
338 347
         // Get all Solr cores that were not deleted.
339 348
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
Please login to merge, or discard this patch.