Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#852)
by Beatrycze
09:11
created
Build/Documentation/dbdocs/RstSection.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function ($entry)
50
+        {
50 51
             return !empty($entry);
51 52
         }));
52 53
 
Please login to merge, or discard this patch.
Classes/Common/Indexer.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -531,7 +531,8 @@  discard block
 block discarded – undo
531 531
      *
532 532
      * @return \Solarium\Core\Query\DocumentInterface
533 533
      */
534
-    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') {
534
+    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '')
535
+    {
535 536
         $solrDoc = $updateQuery->createDocument();
536 537
         // Create unique identifier from document's UID and unit's XML ID.
537 538
         $solrDoc->setField('id', $document->getUid() . $unit['id']);
@@ -555,7 +556,8 @@  discard block
 block discarded – undo
555 556
      *
556 557
      * @return array|string
557 558
      */
558
-    private static function removeAppendsFromAuthor($authors) {
559
+    private static function removeAppendsFromAuthor($authors)
560
+    {
559 561
         if (is_array($authors)) {
560 562
             foreach ($authors as $i => $author) {
561 563
                 $splitName = explode(chr(31), $author);
Please login to merge, or discard this patch.
Build/Documentation/dbdocs/Generator.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,8 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function ($lhs, $rhs)
208
+        {
208 209
             return $lhs->name <=> $rhs->name;
209 210
         });
210 211
 
@@ -231,7 +232,8 @@  discard block
 block discarded – undo
231 232
                 'description' => 'Description',
232 233
             ]];
233 234
 
234
-            $rows = array_map(function ($column) use ($page) {
235
+            $rows = array_map(function ($column) use ($page)
236
+            {
235 237
                 return [
236 238
                     'field' => (
237 239
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Tests/Functional/FunctionalTestCase.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,8 @@  discard block
 block discarded – undo
71 71
         $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration();
72 72
 
73 73
         if ($this->disableJsonWrappedResponse) {
74
-            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) {
74
+            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext)
75
+            {
75 76
                 return $ext !== 'Resources/Core/Functional/Extensions/json_response';
76 77
             });
77 78
         }
@@ -152,7 +153,8 @@  discard block
 block discarded – undo
152 153
         $jsonDocuments = json_decode(file_get_contents($path), true);
153 154
 
154 155
         $updateQuery = $solr->service->createUpdate();
155
-        $documents = array_map(function ($jsonDoc) use ($updateQuery) {
156
+        $documents = array_map(function ($jsonDoc) use ($updateQuery)
157
+        {
156 158
             $document = $updateQuery->createDocument();
157 159
             foreach ($jsonDoc as $key => $value) {
158 160
                 $document->setField($key, $value);
Please login to merge, or discard this patch.
Classes/Common/Helper.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -400,7 +400,8 @@
 block discarded – undo
400 400
             return '';
401 401
         }
402 402
 
403
-        $makeCacheKey = function ($pid, $uid) {
403
+        $makeCacheKey = function ($pid, $uid)
404
+        {
404 405
             return $pid . '.' . $uid;
405 406
         };
406 407
 
Please login to merge, or discard this patch.
Classes/Common/SolrSearchQuery.php 1 patch
Braces   +66 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,9 @@  discard block
 block discarded – undo
20 20
         $this->limit = count($solrSearch);
21 21
     }
22 22
 
23
-    public function getSource() {}
23
+    public function getSource()
24
+    {
25
+}
24 26
 
25 27
     public function execute($returnRawQueryResult = false)
26 28
     {
@@ -35,7 +37,9 @@  discard block
 block discarded – undo
35 37
         return $result;
36 38
     }
37 39
 
38
-    public function setOrderings(array $orderings) {}
40
+    public function setOrderings(array $orderings)
41
+    {
42
+}
39 43
 
40 44
     public function setLimit($limit)
41 45
     {
@@ -49,28 +53,60 @@  discard block
 block discarded – undo
49 53
         return $this;
50 54
     }
51 55
 
52
-    public function matching($constraint) {}
53
-    public function logicalAnd($constraint1) {}
54
-    public function logicalOr($constraint1) {}
55
-    public function logicalNot(ConstraintInterface $constraint) {}
56
-    public function equals($propertyName, $operand, $caseSensitive = true) {}
57
-    public function like($propertyName, $operand) {}
58
-    public function contains($propertyName, $operand) {}
59
-    public function in($propertyName, $operand) {}
60
-    public function lessThan($propertyName, $operand) {}
61
-    public function lessThanOrEqual($propertyName, $operand) {}
62
-    public function greaterThan($propertyName, $operand) {}
63
-    public function greaterThanOrEqual($propertyName, $operand) {}
64
-    public function getType() {}
65
-    public function setQuerySettings(QuerySettingsInterface $querySettings) {}
66
-    public function getQuerySettings() {}
56
+    public function matching($constraint)
57
+    {
58
+}
59
+    public function logicalAnd($constraint1)
60
+    {
61
+}
62
+    public function logicalOr($constraint1)
63
+    {
64
+}
65
+    public function logicalNot(ConstraintInterface $constraint)
66
+    {
67
+}
68
+    public function equals($propertyName, $operand, $caseSensitive = true)
69
+    {
70
+}
71
+    public function like($propertyName, $operand)
72
+    {
73
+}
74
+    public function contains($propertyName, $operand)
75
+    {
76
+}
77
+    public function in($propertyName, $operand)
78
+    {
79
+}
80
+    public function lessThan($propertyName, $operand)
81
+    {
82
+}
83
+    public function lessThanOrEqual($propertyName, $operand)
84
+    {
85
+}
86
+    public function greaterThan($propertyName, $operand)
87
+    {
88
+}
89
+    public function greaterThanOrEqual($propertyName, $operand)
90
+    {
91
+}
92
+    public function getType()
93
+    {
94
+}
95
+    public function setQuerySettings(QuerySettingsInterface $querySettings)
96
+    {
97
+}
98
+    public function getQuerySettings()
99
+    {
100
+}
67 101
 
68 102
     public function count()
69 103
     {
70 104
         // TODO?
71 105
     }
72 106
 
73
-    public function getOrderings() {}
107
+    public function getOrderings()
108
+    {
109
+}
74 110
 
75 111
     public function getLimit()
76 112
     {
@@ -82,8 +118,16 @@  discard block
 block discarded – undo
82 118
         return $this->offset;
83 119
     }
84 120
 
85
-    public function getConstraint() {}
86
-    public function isEmpty($propertyName) {}
87
-    public function setSource(SourceInterface $source) {}
88
-    public function getStatement() {}
121
+    public function getConstraint()
122
+    {
123
+}
124
+    public function isEmpty($propertyName)
125
+    {
126
+}
127
+    public function setSource(SourceInterface $source)
128
+    {
129
+}
130
+    public function getStatement()
131
+    {
132
+}
89 133
 }
Please login to merge, or discard this patch.
Classes/Hooks/ItemsProcFunc.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,8 @@
 block discarded – undo
58 58
      *
59 59
      * @return void
60 60
      */
61
-    public function getTyposcriptConfigFromPluginSiteRoot($params) {
61
+    public function getTyposcriptConfigFromPluginSiteRoot($params)
62
+    {
62 63
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
63 64
         $pid = $params['flexParentDatabaseRow']['pid'];
64 65
         $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid);
Please login to merge, or discard this patch.
Classes/Common/MetsDocument.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -412,7 +412,8 @@  discard block
 block discarded – undo
412 412
         return $details;
413 413
     }
414 414
 
415
-    private function getLogicalStructureFor3D($details) {
415
+    private function getLogicalStructureFor3D($details)
416
+    {
416 417
         // add description and identifier for 3D objects
417 418
         if ($details['type'] == 'collection' || $details['type'] == 'object') {
418 419
             $metadata = $this->getMetadata($details['id']);
@@ -710,7 +711,8 @@  discard block
 block discarded – undo
710 711
             }
711 712
         }
712 713
 
713
-        return array_filter($allMdIds, function ($element) {
714
+        return array_filter($allMdIds, function ($element)
715
+        {
714 716
             return !empty($element);
715 717
         });
716 718
     }
Please login to merge, or discard this patch.
Classes/Controller/TableOfContentsController.php 1 patch
Braces   +25 added lines, -13 removed lines patch added patch discarded remove patch
@@ -386,7 +386,8 @@  discard block
 block discarded – undo
386 386
      *
387 387
      * @return bool true if found, false otherwise
388 388
      */
389
-    private function isFound($entry) {
389
+    private function isFound($entry)
390
+    {
390 391
         if (!empty($this->requestData['title'] && !empty($this->requestData['type']) && !empty($this->requestData['author']))) {
391 392
             return $this->isTitleFound($entry) && $this->isTypeFound($entry) && $this->isAuthorFound($entry);
392 393
         } else if (!empty($this->requestData['title']) && !empty($this->requestData['author'])) {
@@ -403,7 +404,7 @@  discard block
 block discarded – undo
403 404
             return $this->isLicenceFound($entry);
404 405
         } else if (!empty($this->requestData['type'])) {
405 406
             return $this->isTypeFound($entry);
406
-        }  else if (!empty($this->requestData['type'])) {
407
+        } else if (!empty($this->requestData['type'])) {
407 408
             return $this->isSoftwareFound($entry);
408 409
         } else {
409 410
             // no parameters so entry is matching
@@ -418,7 +419,8 @@  discard block
 block discarded – undo
418 419
      *
419 420
      * @return bool true if found, false otherwise
420 421
      */
421
-    private function isAuthorFound($entry) {
422
+    private function isAuthorFound($entry)
423
+    {
422 424
         $value = strtolower($entry['author']);
423 425
         $author = strtolower($this->requestData['author']);
424 426
         return str_contains($value, $author);
@@ -431,7 +433,8 @@  discard block
 block discarded – undo
431 433
      *
432 434
      * @return bool true if found, false otherwise
433 435
      */
434
-    private function isTitleFound($entry) {
436
+    private function isTitleFound($entry)
437
+    {
435 438
         $value = strtolower($entry['label']);
436 439
         $title = strtolower($this->requestData['title']);
437 440
         return str_contains($value, $title);
@@ -444,7 +447,8 @@  discard block
 block discarded – undo
444 447
      *
445 448
      * @return bool true if found, false otherwise
446 449
      */
447
-    private function isTypeFound($entry) {
450
+    private function isTypeFound($entry)
451
+    {
448 452
         return str_contains($entry['identifier'], $this->requestData['types']);
449 453
     }
450 454
 
@@ -455,7 +459,8 @@  discard block
 block discarded – undo
455 459
      *
456 460
      * @return void
457 461
      */
458
-    private function addAuthorToAutocomplete($author) {
462
+    private function addAuthorToAutocomplete($author)
463
+    {
459 464
         if ($author != NULL && !(in_array($author, $this->authors))) {
460 465
             // additional check if actually not more than 1 author is included
461 466
             if (strpos($author, ',') !== false) {
@@ -476,8 +481,10 @@  discard block
 block discarded – undo
476 481
      *
477 482
      * @return void
478 483
      */
479
-    private function sortAuthors() {
480
-        usort($this->authors, function($firstAuthor, $secondAuthor) {
484
+    private function sortAuthors()
485
+    {
486
+        usort($this->authors, function($firstAuthor, $secondAuthor)
487
+        {
481 488
             $firstAuthor = substr(strrchr($firstAuthor, ' '), 1);
482 489
             $secondAuthor = substr(strrchr($secondAuthor, ' '), 1);
483 490
             return strcmp($firstAuthor, $secondAuthor);
@@ -491,7 +498,8 @@  discard block
 block discarded – undo
491 498
      *
492 499
      * @return void
493 500
      */
494
-    private function addTitleToAutocomplete($title) {
501
+    private function addTitleToAutocomplete($title)
502
+    {
495 503
         if (!(in_array($title, $this->titles)) && $title != NULL) {
496 504
             $this->titles[] = $title;
497 505
         }
@@ -504,7 +512,8 @@  discard block
 block discarded – undo
504 512
      *
505 513
      * @return array of object types
506 514
      */
507
-    private function getTypes($entry) {
515
+    private function getTypes($entry)
516
+    {
508 517
         $types = [];
509 518
         $index = 0;
510 519
 
@@ -528,7 +537,8 @@  discard block
 block discarded – undo
528 537
      *
529 538
      * @return string type name without number
530 539
      */
531
-    private function getType($entry) {
540
+    private function getType($entry)
541
+    {
532 542
         $type = $entry['identifier'];
533 543
         if (!empty($type)) {
534 544
             $temp = strtok($type, ',');
@@ -544,7 +554,8 @@  discard block
 block discarded – undo
544 554
      *
545 555
      * @return array of object softwares
546 556
      */
547
-    private function getSoftwares($entry) {
557
+    private function getSoftwares($entry)
558
+    {
548 559
         $softwares = [];
549 560
         $index = 0;
550 561
 
@@ -568,7 +579,8 @@  discard block
 block discarded – undo
568 579
      *
569 580
      * @return string software name split by commas
570 581
      */
571
-    private function getSoftware($entry) {
582
+    private function getSoftware($entry)
583
+    {
572 584
         $software = $entry['software'];
573 585
         if (!empty($software)) {
574 586
             return strtok($software, ',');;
Please login to merge, or discard this patch.