kitodo / kitodo-presentation

Configuration/TCA/tx_dlf_documents.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -268,10 +268,10 @@
                 'readOnly' => 1,
                 'fieldControl' => [
                     'elementBrowser' => [
-                        'disabled' => true
+                        'disabled' => TRUE
                     ]
                 ],
-                'hideDeleteIcon' => true
+                'hideDeleteIcon' => TRUE
             ],
         ],
         'volume' => [

ext_localconf.php

Spacing +5 added lines, -5 removed lines

@@ -14,19 +14,19 @@
 }
 // Define constants.
 if (!defined('DEVLOG_SEVERITY_OK')) {
-    define ('DEVLOG_SEVERITY_OK', -1);
+    define('DEVLOG_SEVERITY_OK', -1);
 }
 if (!defined('DEVLOG_SEVERITY_INFO')) {
-    define ('DEVLOG_SEVERITY_INFO', 0);
+    define('DEVLOG_SEVERITY_INFO', 0);
 }
 if (!defined('DEVLOG_SEVERITY_NOTICE')) {
-    define ('DEVLOG_SEVERITY_NOTICE', 1);
+    define('DEVLOG_SEVERITY_NOTICE', 1);
 }
 if (!defined('DEVLOG_SEVERITY_WARNING')) {
-    define ('DEVLOG_SEVERITY_WARNING', 2);
+    define('DEVLOG_SEVERITY_WARNING', 2);
 }
 if (!defined('DEVLOG_SEVERITY_ERROR')) {
-    define ('DEVLOG_SEVERITY_ERROR', 3);
+    define('DEVLOG_SEVERITY_ERROR', 3);
 }
 // Register plugins.
 \Kitodo\Dlf\Hooks\ExtensionManagementUtility::addPItoST43($_EXTKEY, \Kitodo\Dlf\Plugin\AudioPlayer::class, '_audioplayer', 'list_type', TRUE);

Classes/Command/ReindexCommand.php

Braces +3 added lines, -6 removed lines

@@ -27,13 +27,11 @@ 
 /**
  * Reindex a collection into database and solr.
  */
-class ReindexCommand extends Command
-{
+class ReindexCommand extends Command {
     /**
      * Configure the command by defining the name, options and arguments
      */
-    public function configure()
-    {
+    public function configure() {
         $this
             ->setDescription('Reindex a collection into database and solr.')
             ->setHelp('')
@@ -75,8 +73,7 @@ 
      * @param InputInterface $input
      * @param OutputInterface $output
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
-    {
+    protected function execute(InputInterface $input, OutputInterface $output) {
         // Make sure the _cli_ user is loaded
         Bootstrap::getInstance()->initializeBackendAuthentication();
 

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -39,7 +39,7 @@ 
             ->setHelp('')
             ->addOption(
                 'dry-run',
-                null,
+                NULL,
                 InputOption::VALUE_NONE,
                 'If this option is set, the files will not actually be processed but the location URI is shown.'
             )
@@ -80,7 +80,7 @@ 
         // Make sure the _cli_ user is loaded
         Bootstrap::getInstance()->initializeBackendAuthentication();
 
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != FALSE ? TRUE : FALSE;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());
@@ -125,7 +125,7 @@ 
             $documents = $this->getAllDocuments($startingPoint);
         } else {
             // coll may be a single integer, a list of integer
-            if (empty(array_filter(GeneralUtility::intExplode(',', $input->getOption('coll'), true)))) {
+            if (empty(array_filter(GeneralUtility::intExplode(',', $input->getOption('coll'), TRUE)))) {
                 $io->error('ERROR: "' . $input->getOption('coll') . '" is not a valid list of collection UIDs for --coll|-c.');
                 exit(1);
             }
@@ -230,7 +230,7 @@ 
                   $queryBuilder->expr()->in(
                       'tx_dlf_collections_join.uid',
                       $queryBuilder->createNamedParameter(
-                          GeneralUtility::intExplode(',', $collIds, true),
+                          GeneralUtility::intExplode(',', $collIds, TRUE),
                           Connection::PARAM_INT_ARRAY
                       )
                   ),

Indentation +21 added lines, -21 removed lines

@@ -226,23 +226,23 @@ 
                 )
             )
             -> where(
-              $queryBuilder->expr()->andX(
-                  $queryBuilder->expr()->in(
-                      'tx_dlf_collections_join.uid',
-                      $queryBuilder->createNamedParameter(
-                          GeneralUtility::intExplode(',', $collIds, true),
-                          Connection::PARAM_INT_ARRAY
-                      )
-                  ),
-                  $queryBuilder->expr()->eq(
-                      'tx_dlf_collections_join.pid',
-                      $queryBuilder->createNamedParameter($pageId, Connection::PARAM_INT)
-                  ),
-                  $queryBuilder->expr()->eq(
-                      'tx_dlf_relations_joins.ident',
-                      $queryBuilder->createNamedParameter('docs_colls')
-                  )
-              )
+                $queryBuilder->expr()->andX(
+                    $queryBuilder->expr()->in(
+                        'tx_dlf_collections_join.uid',
+                        $queryBuilder->createNamedParameter(
+                            GeneralUtility::intExplode(',', $collIds, true),
+                            Connection::PARAM_INT_ARRAY
+                        )
+                    ),
+                    $queryBuilder->expr()->eq(
+                        'tx_dlf_collections_join.pid',
+                        $queryBuilder->createNamedParameter($pageId, Connection::PARAM_INT)
+                    ),
+                    $queryBuilder->expr()->eq(
+                        'tx_dlf_relations_joins.ident',
+                        $queryBuilder->createNamedParameter('docs_colls')
+                    )
+                )
             )
             ->groupBy('tx_dlf_documents.uid')
             ->orderBy('tx_dlf_documents.uid', 'ASC')
@@ -274,10 +274,10 @@ 
             ->select('uid')
             ->from('tx_dlf_documents')
             -> where(
-              $queryBuilder->expr()->eq(
-                  'tx_dlf_documents.pid',
-                  $queryBuilder->createNamedParameter($pageId, Connection::PARAM_INT)
-              )
+                $queryBuilder->expr()->eq(
+                    'tx_dlf_documents.pid',
+                    $queryBuilder->createNamedParameter($pageId, Connection::PARAM_INT)
+                )
             )
             ->orderBy('tx_dlf_documents.uid', 'ASC')
             ->execute();

Spacing +12 added lines, -12 removed lines

@@ -87,17 +87,17 @@ 
 
         $startingPoint = 0;
         if (MathUtility::canBeInterpretedAsInteger($input->getOption('pid'))) {
-            $startingPoint = MathUtility::forceIntegerInRange((int)$input->getOption('pid'), 0);
+            $startingPoint = MathUtility::forceIntegerInRange((int) $input->getOption('pid'), 0);
         }
         if ($startingPoint == 0) {
-            $io->error('ERROR: No valid PID (' . $startingPoint . ') given.');
+            $io->error('ERROR: No valid PID ('.$startingPoint.') given.');
             exit(1);
         }
 
         if ($input->getOption('solr')) {
             $allSolrCores = $this->getSolrCores($startingPoint);
             if (MathUtility::canBeInterpretedAsInteger($input->getOption('solr'))) {
-                $solrCoreUid = MathUtility::forceIntegerInRange((int)$input->getOption('solr'), 0);
+                $solrCoreUid = MathUtility::forceIntegerInRange((int) $input->getOption('solr'), 0);
             } else {
                 $solrCoreName = $input->getOption('solr');
                 $solrCoreUid = $allSolrCores[$solrCoreName];
@@ -105,13 +105,13 @@ 
             // Abort if solrCoreUid is empty or not in the array of allowed solr cores.
             if (empty($solrCoreUid) || !in_array($solrCoreUid, $allSolrCores)) {
                 foreach ($allSolrCores as $index_name => $uid) {
-                    $output_solrCores .= ' ' . $uid . ' : ' . $index_name ."\n";
+                    $output_solrCores .= ' '.$uid.' : '.$index_name."\n";
                 }
                 if (empty($output_solrCores)) {
-                    $io->error('ERROR: No valid solr core ("'. $input->getOption('solr') . '") given. ' . "No valid cores found on PID " . $startingPoint .".\n" . $output_solrCores);
+                    $io->error('ERROR: No valid solr core ("'.$input->getOption('solr').'") given. '."No valid cores found on PID ".$startingPoint.".\n".$output_solrCores);
                     exit(1);
                 } else {
-                    $io->error('ERROR: No valid solr core ("'. $input->getOption('solr') . '") given. ' . "Valid cores are (<uid>:<index_name>):\n" . $output_solrCores);
+                    $io->error('ERROR: No valid solr core ("'.$input->getOption('solr').'") given. '."Valid cores are (<uid>:<index_name>):\n".$output_solrCores);
                     exit(1);
                 }
             }
@@ -126,7 +126,7 @@ 
         } else {
             // coll may be a single integer, a list of integer
             if (empty(array_filter(GeneralUtility::intExplode(',', $input->getOption('coll'), true)))) {
-                $io->error('ERROR: "' . $input->getOption('coll') . '" is not a valid list of collection UIDs for --coll|-c.');
+                $io->error('ERROR: "'.$input->getOption('coll').'" is not a valid list of collection UIDs for --coll|-c.');
                 exit(1);
             }
             $documents = $this->getDocumentsToProceed($input->getOption('coll'), $startingPoint);
@@ -136,10 +136,10 @@ 
             $doc = Document::getInstance($document, $startingPoint, TRUE);
             if ($doc->ready) {
                 if ($dryRun) {
-                    $io->writeln('DRY RUN: Would index ' . $id . '/' . count($documents) . ' ' . $doc->uid . ' ' . $doc->location . ' on UID ' . $startingPoint . ' and solr core ' . $solrCoreUid .'.');
+                    $io->writeln('DRY RUN: Would index '.$id.'/'.count($documents).' '.$doc->uid.' '.$doc->location.' on UID '.$startingPoint.' and solr core '.$solrCoreUid.'.');
                 } else {
                     if ($io->isVerbose()) {
-                        $io->writeln(date('Y-m-d H:i:s') . ' ' . $id . '/' . count($documents) . ' ' . $doc->uid . ' ' . $doc->location . ' on UID ' . $startingPoint . ' and solr core ' . $solrCoreUid .'.');
+                        $io->writeln(date('Y-m-d H:i:s').' '.$id.'/'.count($documents).' '.$doc->uid.' '.$doc->location.' on UID '.$startingPoint.' and solr core '.$solrCoreUid.'.');
                     }
                     // ...and save it to the database...
                     if (!$doc->save($startingPoint, $solrCoreUid)) {
@@ -169,7 +169,7 @@ 
             ->getQueryBuilderForTable('tx_dlf_solrcores');
 
         $solrCores = [];
-        $pageId = (int)$pageId;
+        $pageId = (int) $pageId;
         $result = $queryBuilder
             ->select('uid', 'index_name')
             ->from('tx_dlf_solrcores')
@@ -203,7 +203,7 @@ 
             ->getQueryBuilderForTable('tx_dlf_documents');
 
         $documents = [];
-        $pageId = (int)$pageId;
+        $pageId = (int) $pageId;
         $result = $queryBuilder
             ->select('tx_dlf_documents.uid')
             ->from('tx_dlf_documents')
@@ -269,7 +269,7 @@ 
             ->getQueryBuilderForTable('tx_dlf_documents');
 
         $documents = [];
-        $pageId = (int)$pageId;
+        $pageId = (int) $pageId;
         $result = $queryBuilder
             ->select('uid')
             ->from('tx_dlf_documents')

Classes/Command/IndexCommand.php

Braces +3 added lines, -6 removed lines

@@ -26,13 +26,11 @@ 
 /**
  * Index single document into database and solr.
  */
-class IndexCommand extends Command
-{
+class IndexCommand extends Command {
     /**
      * Configure the command by defining the name, options and arguments
      */
-    public function configure()
-    {
+    public function configure() {
         $this
             ->setDescription('Index single document into database and solr.')
             ->setHelp('')
@@ -68,8 +66,7 @@ 
      * @param InputInterface $input
      * @param OutputInterface $output
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
-    {
+    protected function execute(InputInterface $input, OutputInterface $output) {
         // Make sure the _cli_ user is loaded
         Bootstrap::getInstance()->initializeBackendAuthentication();
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
             ->setHelp('')
             ->addOption(
                 'dry-run',
-                null,
+                NULL,
                 InputOption::VALUE_NONE,
                 'If this option is set, the files will not actually be processed but the location URI is shown.'
             )
@@ -73,7 +73,7 @@ 
         // Make sure the _cli_ user is loaded
         Bootstrap::getInstance()->initializeBackendAuthentication();
 
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != FALSE ? TRUE : FALSE;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());

Spacing +10 added lines, -10 removed lines

@@ -80,17 +80,17 @@ 
 
         $startingPoint = 0;
         if (MathUtility::canBeInterpretedAsInteger($input->getOption('pid'))) {
-            $startingPoint = MathUtility::forceIntegerInRange((int)$input->getOption('pid'), 0);
+            $startingPoint = MathUtility::forceIntegerInRange((int) $input->getOption('pid'), 0);
         }
         if ($startingPoint == 0) {
-            $io->error('ERROR: No valid PID (' . $startingPoint . ') given.');
+            $io->error('ERROR: No valid PID ('.$startingPoint.') given.');
             exit(1);
         }
 
         if ($input->getOption('solr')) {
             $allSolrCores = $this->getSolrCores($startingPoint);
             if (MathUtility::canBeInterpretedAsInteger($input->getOption('solr'))) {
-                $solrCoreUid = MathUtility::forceIntegerInRange((int)$input->getOption('solr'), 0);
+                $solrCoreUid = MathUtility::forceIntegerInRange((int) $input->getOption('solr'), 0);
             } else {
                 $solrCoreName = $input->getOption('solr');
                 $solrCoreUid = $allSolrCores[$solrCoreName];
@@ -98,13 +98,13 @@ 
             // Abort if solrCoreUid is empty or not in the array of allowed solr cores.
             if (empty($solrCoreUid) || !in_array($solrCoreUid, $allSolrCores)) {
                 foreach ($allSolrCores as $index_name => $uid) {
-                    $output_solrCores .= ' ' . $uid . ' : ' . $index_name ."\n";
+                    $output_solrCores .= ' '.$uid.' : '.$index_name."\n";
                 }
                 if (empty($output_solrCores)) {
-                    $io->error('ERROR: No valid solr core ("'. $input->getOption('solr') . '") given. ' . "No valid cores found on PID " . $startingPoint .".\n" . $output_solrCores);
+                    $io->error('ERROR: No valid solr core ("'.$input->getOption('solr').'") given. '."No valid cores found on PID ".$startingPoint.".\n".$output_solrCores);
                     exit(1);
                 } else {
-                    $io->error('ERROR: No valid solr core ("'. $input->getOption('solr') . '") given. ' . "Valid cores are (<uid>:<index_name>):\n" . $output_solrCores);
+                    $io->error('ERROR: No valid solr core ("'.$input->getOption('solr').'") given. '."Valid cores are (<uid>:<index_name>):\n".$output_solrCores);
                     exit(1);
                 }
             }
@@ -115,7 +115,7 @@ 
 
         if (!MathUtility::canBeInterpretedAsInteger($input->getOption('doc'))
             && !GeneralUtility::isValidUrl($input->getOption('doc'))) {
-            $io->error('ERROR: "' . $input->getOption('doc') . '" is not a valid document UID or URL for --doc|-d.');
+            $io->error('ERROR: "'.$input->getOption('doc').'" is not a valid document UID or URL for --doc|-d.');
             exit(1);
         }
 
@@ -123,10 +123,10 @@ 
         $doc = Document::getInstance($input->getOption('doc'), $startingPoint, TRUE);
         if ($doc->ready) {
             if ($dryRun) {
-                $io->section('DRY RUN: Would index ' . $doc->uid . ' '. $doc->location . ' on UID ' . $startingPoint . ' and solr core ' . $solrCoreUid .'.');
+                $io->section('DRY RUN: Would index '.$doc->uid.' '.$doc->location.' on UID '.$startingPoint.' and solr core '.$solrCoreUid.'.');
             } else {
                 if ($io->isVerbose()) {
-                    $io->section('Will index ' . $doc->uid . ' ' . $doc->location . ' on UID ' . $startingPoint . ' and solr core ' . $solrCoreUid .'.');
+                    $io->section('Will index '.$doc->uid.' '.$doc->location.' on UID '.$startingPoint.' and solr core '.$solrCoreUid.'.');
                 }
                 // ...and save it to the database...
                 if (!$doc->save($startingPoint, $solrCoreUid)) {
@@ -157,7 +157,7 @@ 
             ->getQueryBuilderForTable('tx_dlf_solrcores');
 
         $solrCores = [];
-        $pageId = (int)$pageId;
+        $pageId = (int) $pageId;
         $result = $queryBuilder
             ->select('uid', 'index_name')
             ->from('tx_dlf_solrcores')

Classes/Common/AbstractPlugin.php

Spacing +2 added lines, -2 removed lines

@@ -72,9 +72,9 @@
             $this->template = $this->templateService->getSubpart($this->cObj->fileResource($this->conf['templateFile']), $part);
         } else {
             if (empty($directory)) {
-                $templateLocation = 'EXT:'.$this->extKey.'/Resources/Private/Templates/' . Helper::getUnqualifiedClassName(get_class($this)) . '.tmpl';
+                $templateLocation = 'EXT:'.$this->extKey.'/Resources/Private/Templates/'.Helper::getUnqualifiedClassName(get_class($this)).'.tmpl';
             } else {
-                $templateLocation = 'EXT:'.$this->extKey.'/Resources/Private/Templates/'. $directory . '/' . Helper::getUnqualifiedClassName(get_class($this)) . '.tmpl';
+                $templateLocation = 'EXT:'.$this->extKey.'/Resources/Private/Templates/'.$directory.'/'.Helper::getUnqualifiedClassName(get_class($this)).'.tmpl';
             }
 
             // Load default template file.

Classes/Plugin/Search.php

Spacing +1 added lines, -1 removed lines

@@ -558,7 +558,7 @@
         $results = $solr->service->select($selectQuery);
         $facet = $results->getFacetSet();
 
-        $facetCollectionArray = array();
+        $facetCollectionArray = array ();
 
         // replace everything expect numbers and comma
         $facetCollections = preg_replace('/[^0-9,]/', '', $this->conf['facetCollections']);

Classes/Plugin/OaiPmh.php

Spacing +1 added lines, -1 removed lines

@@ -741,7 +741,7 @@
             )
             ->from('tx_dlf_collections')
             ->where(
-                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array(-1, 0)),
+                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array (-1, 0)),
                 $queryBuilder->expr()->eq('tx_dlf_collections.pid', intval($this->conf['pages'])),
                 $queryBuilder->expr()->neq('tx_dlf_collections.oai_name', ''),
                 $where,

Classes/Module/NewTenant.php

Spacing +1 added lines, -1 removed lines

@@ -268,7 +268,7 @@
                 )
                 ->from('tx_dlf_solrcores')
                 ->where(
-                    $queryBuilder->expr()->in('tx_dlf_solrcores.pid', array(intval($this->id), 0)),
+                    $queryBuilder->expr()->in('tx_dlf_solrcores.pid', array (intval($this->id), 0)),
                     Helper::whereExpression('tx_dlf_solrcores')
                 )
                 ->execute();

Classes/Common/Document.php

Spacing +3 added lines, -3 removed lines

@@ -482,7 +482,7 @@ 
                     /* @var $xml \SimpleXMLElement */
                     $xml->registerXPathNamespace('mets', 'http://www.loc.gov/METS/');
                     $xpathResult = $xml->xpath('//mets:mets');
-                    $documentFormat = ($xpathResult !== false && count($xpathResult)>0) ? 'METS' : null;
+                    $documentFormat = ($xpathResult !== false && count($xpathResult) > 0) ? 'METS' : null;
                 } else {
                     // Try to load file as IIIF resource instead.
                     $contentAsJsonArray = json_decode($content, true);
@@ -749,7 +749,7 @@ 
                 return $depth;
             } elseif (array_key_exists('children', $element)) {
                 $foundInChildren = $this->getTreeDepth($element['children'], $depth + 1, $logId);
-                if ($foundInChildren!==false) {
+                if ($foundInChildren !== false) {
                     return $foundInChildren;
                 }
             }
@@ -986,7 +986,7 @@ 
             ->from('tx_dlf_collections')
             ->where(
                 $queryBuilder->expr()->eq('tx_dlf_collections.pid', intval($pid)),
-                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array(-1, 0)),
+                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array (-1, 0)),
                 Helper::whereExpression('tx_dlf_collections')
             )
             ->execute();

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -415,9 +415,9 @@ 
             }
         }
         // Create new instance depending on format (METS or IIIF) ...
-        $documentFormat = null;
-        $xml = null;
-        $iiif = null;
+        $documentFormat = NULL;
+        $xml = NULL;
+        $iiif = NULL;
         // Try to get document format from database
         if (MathUtility::canBeInterpretedAsInteger($uid)) {
             /** @var QueryBuilder $queryBuilder */
@@ -480,15 +480,15 @@ 
                 libxml_disable_entity_loader($previousValueOfEntityLoader);
                 // Reset libxml's error logging.
                 libxml_use_internal_errors($libxmlErrors);
-                if ($xml !== false) {
+                if ($xml !== FALSE) {
                     /* @var $xml \SimpleXMLElement */
                     $xml->registerXPathNamespace('mets', 'http://www.loc.gov/METS/');
                     $xpathResult = $xml->xpath('//mets:mets');
-                    $documentFormat = ($xpathResult !== false && count($xpathResult)>0) ? 'METS' : null;
+                    $documentFormat = ($xpathResult !== FALSE && count($xpathResult)>0) ? 'METS' : NULL;
                 } else {
                     // Try to load file as IIIF resource instead.
-                    $contentAsJsonArray = json_decode($content, true);
-                    if ($contentAsJsonArray !== null) {
+                    $contentAsJsonArray = json_decode($content, TRUE);
+                    if ($contentAsJsonArray !== NULL) {
                         // Load plugin configuration.
                         $conf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'][self::$extKey]);
                         IiifHelper::setUrlReader(IiifUrlReader::getInstance());
@@ -752,12 +752,12 @@ 
                 return $depth;
             } elseif (array_key_exists('children', $element)) {
                 $foundInChildren = $this->getTreeDepth($element['children'], $depth + 1, $logId);
-                if ($foundInChildren!==false) {
+                if ($foundInChildren!==FALSE) {
                     return $foundInChildren;
                 }
             }
         }
-        return false;
+        return FALSE;
     }
 
     /**