CollectionRepositoryTest::canFindCollectionsBySettings() - Code Metrics - Inspection of "[MAINTENANCE] Added additional repository function..." - kitodo/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#895)

unknown

created 2023-02-06 16:55 UTC

canFindCollectionsBySettings() A

↳ Parent: CollectionRepositoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	71
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	50
nc	1
nop	0
dl	0
loc	71
rs	9.0909
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Kitodo\Dlf\Tests\Functional\Repository;

use TYPO3\CMS\Extbase\Persistence\Generic\QueryResult;
use Kitodo\Dlf\Domain\Repository\CollectionRepository;
use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;

class CollectionRepositoryTest extends FunctionalTestCase
{
    /**
     * @var CollectionRepository
     */
    protected $collectionRepository;

    public function setUp(): void
    {
        parent::setUp();

        $this->collectionRepository = $this->initializeRepository(
            CollectionRepository::class,
            20000
        );

        $this->importDataSet(__DIR__ . '/../../Fixtures/Repository/collections.xml');
        /** @scrutinizer ignore-deprecated */ $this->importDataSet(__DIR__ . '/../../Fixtures/Repository/collections.xml');
    }

    /**
     *
     * @group find
     */
    public function canFindAllByUids(): void
    {
        $collections = $this->collectionRepository->findAllByUids([1101, 1102]);
        $collections = $this->collectionRepository->findAllByUids(/** @scrutinizer ignore-type */ [1101, 1102]);
        $this->assertNotNull($collections);
        $this->assertInstanceOf(QueryResult::class, $collections);

        $collectionsByLabel = [];
        foreach ($collections as $collection) {
            $collectionsByLabel[$collection->getLabel()] = $collection;
        }

        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
    }

    /**
     * @test
     * @group find
     */
    public function canGetCollectionForMetadata(): void
    {
        $collections = $this->collectionRepository->getCollectionForMetadata("20000");
        $this->assertNotNull($collections);
        $this->assertInstanceOf(QueryResult::class, $collections);

        $collectionsByLabel = [];
        foreach ($collections as $collection) {
            $collectionsByLabel[$collection->getLabel()] = $collection;
        }

        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);
        $this->assertArrayHasKey('Bildende Kunst', $collectionsByLabel);
    }

    /**
     * @param $settings
     * @return array
     */
    protected function findCollectionsBySettings($settings): array
    {
        $collections = $this->collectionRepository->findCollectionsBySettings($settings);
        $this->assertNotNull($collections);
        $this->assertInstanceOf(QueryResult::class, $collections);

        $collectionsByLabel = [];
        foreach ($collections as $collection) {
            $collectionsByLabel[$collection->getLabel()] = $collection;
        }

        return $collectionsByLabel;
    }

    /**
     * @test
     * @group find
     */
    public function canFindCollectionsBySettings(): void
    {
        $collectionsByLabel = $this->findCollectionsBySettings(['collections' => '1101, 1102']);
        $this->assertEquals(2, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Musik', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings([
            'index_name' => ['Geschichte', 'collection-with-single-document'],
            'show_userdefined' => true
        ]);
        $this->assertEquals(2, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => true]);
        $this->assertEquals(4, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);
        $this->assertArrayHasKey('Bildende Kunst', $collectionsByLabel);
        $this->assertEquals(
            'Bildende Kunst, Collection with single document, Geschichte, Musik',
            implode(', ', array_keys($collectionsByLabel))
        );

        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => false]);
        $this->assertEquals(2, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => true]);
        $this->assertEquals(2, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings(
            [
                'hideEmptyOaiNames' => true,
                'show_userdefined' => true
            ]
        );
        $this->assertEquals(3, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings(
            [
                'hideEmptyOaiNames' => false,
                'show_userdefined' => true
            ]
        );
        $this->assertEquals(4, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Musik', $collectionsByLabel);
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);
        $this->assertArrayHasKey('Bildende Kunst', $collectionsByLabel);

        $collectionsByLabel = $this->findCollectionsBySettings(
            [
                'collections' => '1101, 1102, 1103, 1104',
                'show_userdefined' => true,
                'hideEmptyOaiNames' => false,
                'index_name' => ['Geschichte', 'collection-with-single-document']
            ]
        );

        $this->assertEquals(2, sizeof($collectionsByLabel));
        $this->assertArrayHasKey('Collection with single document', $collectionsByLabel);
        $this->assertArrayHasKey('Geschichte', $collectionsByLabel);
    }

    /**
     * @test
     * @group find
     */
    public function canGetIndexNameForSolr(): void
    {
        $indexName = $this->collectionRepository->getIndexNameForSolr(
            ['show_userdefined' => true, 'storagePid' => '20000'], 'history'
        );
        $result = $indexName->fetchAllAssociative();
        $this->assertEquals(1, $indexName->rowCount());
        $this->assertEquals('Geschichte', $result[0]['index_name']);
        $this->assertEquals('*:*', $result[0]['index_query']);
        $this->assertEquals('1103', $result[0]['uid']);

        $indexName = $this->collectionRepository->getIndexNameForSolr(
            ['show_userdefined' => false, 'storagePid' => '20000'], 'history'
        );
        $this->assertEquals(0, $indexName->rowCount());

        $indexName = $this->collectionRepository->getIndexNameForSolr(
            ['show_userdefined' => false, 'storagePid' => '20000'], 'collection-with-single-document'
        );
        $this->assertEquals(1, $indexName->rowCount());
        $this->assertEquals('collection-with-single-document', $indexName->fetchOne());
    }
}


Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — master (#895)

canFindCollectionsBySettings() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

kitodo / kitodo-presentation

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — master (#895)

canFindCollectionsBySettings() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like