kitodo /
kitodo-presentation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Total Complexity | 72 |
| Total Lines | 286 |
| Duplicated Lines | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Complex classes like MetadataController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MetadataController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 24 | class MetadataController extends AbstractController |
||
| 25 | { |
||
| 26 | public $prefixId = 'tx_dlf'; |
||
| 27 | |||
| 28 | protected $metadataRepository; |
||
| 29 | |||
| 30 | protected $collectionRepository; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @param CollectionRepository $collectionRepository |
||
| 34 | */ |
||
| 35 | public function injectCollectionRepository(CollectionRepository $collectionRepository) |
||
| 38 | } |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @param MetadataRepository $metadataRepository |
||
| 42 | */ |
||
| 43 | public function injectMetadataRepository(MetadataRepository $metadataRepository) |
||
| 44 | { |
||
| 45 | $this->metadataRepository = $metadataRepository; |
||
| 46 | } |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @return string|void |
||
| 50 | */ |
||
| 51 | public function mainAction() |
||
| 146 | } |
||
| 147 | |||
| 148 | /** |
||
| 149 | * Prepares the metadata array for output |
||
| 150 | * |
||
| 151 | * @access protected |
||
| 152 | * |
||
| 153 | * @param array $metadataArray: The metadata array |
||
| 154 | * @param bool $useOriginalIiifManifestMetadata: Output IIIF metadata as simple key/value pairs? |
||
| 155 | * |
||
| 156 | * @return string The metadata array ready for output |
||
| 157 | */ |
||
| 158 | protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false) |
||
| 159 | { |
||
| 160 | if ($useOriginalIiifManifestMetadata) { |
||
| 161 | $iiifData = []; |
||
| 162 | foreach ($metadataArray as $metadata) { |
||
| 163 | foreach ($metadata as $key => $group) { |
||
| 164 | if ($key == '_id') { |
||
| 165 | continue; |
||
| 166 | } |
||
| 167 | if (!is_array($group)) { |
||
| 168 | if ( |
||
| 169 | IRI::isAbsoluteIri($group) |
||
| 170 | && (($scheme = (new IRI($group))->getScheme()) == 'http' || $scheme == 'https') |
||
| 171 | ) { |
||
| 172 | // Build link |
||
| 173 | $iiifData[$key] = [ |
||
| 174 | 'label' => $key, |
||
| 175 | 'value' => $group, |
||
| 176 | 'buildUrl' => true |
||
| 177 | ]; |
||
| 178 | } else { |
||
| 179 | // Data output |
||
| 180 | $iiifData[$key] = [ |
||
| 181 | 'label' => $key, |
||
| 182 | 'value' => $group, |
||
| 183 | 'buildUrl' => false |
||
| 184 | ]; |
||
| 185 | } |
||
| 186 | } else { |
||
| 187 | foreach ($group as $label => $value) { |
||
| 188 | if ($label == '_id') { |
||
| 189 | continue; |
||
| 190 | } |
||
| 191 | if (is_array($value)) { |
||
| 192 | $value = implode($this->settings['separator'], $value); |
||
| 193 | } |
||
| 194 | if (IRI::isAbsoluteIri($value) && (($scheme = (new IRI($value))->getScheme()) == 'http' || $scheme == 'https')) { |
||
| 195 | $nolabel = $value == $label; |
||
| 196 | $iiifData[$key]['data'][] = [ |
||
| 197 | 'label' => $nolabel ? '' : htmlspecialchars($label), |
||
| 198 | 'value' => $value, |
||
| 199 | 'buildUrl' => true |
||
| 200 | ]; |
||
| 201 | } else { |
||
| 202 | $iiifData[$key]['data'][] = [ |
||
| 203 | 'label' => htmlspecialchars($label), |
||
| 204 | 'value' => $value, |
||
| 205 | 'buildUrl' => false |
||
| 206 | ]; |
||
| 207 | } |
||
| 208 | } |
||
| 209 | } |
||
| 210 | $this->view->assign('useIiif', true); |
||
| 211 | $this->view->assign('iiifData', $iiifData); |
||
| 212 | } |
||
| 213 | } |
||
| 214 | } else { |
||
| 215 | $context = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Context\Context::class); |
||
| 216 | $currentLanguageUid = $context->getPropertyFromAspect('language', 'id'); |
||
| 217 | |||
| 218 | $metadataResult = $this->metadataRepository->getMetadata($this->settings['pages'], $currentLanguageUid); |
||
| 219 | |||
| 220 | // Get collections to check if they are hidden |
||
| 221 | $collections = $this->collectionRepository->getCollectionForMetadata($this->settings['pages']); |
||
| 222 | |||
| 223 | $collList = []; |
||
| 224 | /** @var Collection $collection */ |
||
| 225 | foreach ($collections as $collection) { |
||
| 226 | $collList[] = $collection->getIndexName(); |
||
| 227 | } |
||
| 228 | |||
| 229 | $buildUrl = []; |
||
| 230 | $i = 0; |
||
| 231 | foreach ($metadataArray as $metadataSection) { |
||
| 232 | foreach ($metadataSection as $metadataName => $metadataValue) { |
||
| 233 | if ($metadataName == 'title') { |
||
| 234 | // Get title of parent document if needed. |
||
| 235 | if (empty($metadataValue) && $this->settings['getTitle'] && $this->doc->parentId) { |
||
| 236 | $superiorTitle = Document::getTitle($this->doc->parentId, true); |
||
| 237 | if (!empty($superiorTitle)) { |
||
| 238 | $metadataArray[$i][$metadataName] = ['[' . $superiorTitle . ']']; |
||
| 239 | } |
||
| 240 | } |
||
| 241 | if (!empty($metadataValue)) { |
||
| 242 | $metadataArray[$i][$metadataName][0] = htmlspecialchars($metadataArray[$i][$metadataName][0]); |
||
| 243 | // Link title to pageview. |
||
| 244 | if ($this->settings['linkTitle'] && $metadataSection['_id']) { |
||
| 245 | $details = $this->doc->getLogicalStructure($metadataSection['_id']); |
||
| 246 | $buildUrl[$i][$metadataName]['buildUrl'] = [ |
||
| 247 | 'id' => $this->doc->uid, |
||
| 248 | 'page' => (!empty($details['points']) ? intval($details['points']) : 1), |
||
| 249 | 'targetPid' => (!empty($this->settings['targetPid']) ? $this->settings['targetPid'] : 0) |
||
| 250 | ]; |
||
| 251 | } |
||
| 252 | } |
||
| 253 | } elseif ($metadataName == 'owner' && !empty($metadataValue)) { |
||
| 254 | // Translate name of holding library. |
||
| 255 | $metadataArray[$i][$metadataName][0] = htmlspecialchars(Helper::translate($metadataArray[$i][$metadataName][0], 'tx_dlf_libraries', $this->settings['pages'])); |
||
| 256 | } elseif ($metadataName == 'type' && !empty($metadataValue)) { |
||
| 257 | // Translate document type. |
||
| 258 | $metadataArray[$i][$metadataName][0] = htmlspecialchars(Helper::translate($metadataArray[$i][$metadataName][0], 'tx_dlf_structures', $this->settings['pages'])); |
||
| 259 | } elseif ($metadataName == 'collection' && !empty($metadataValue)) { |
||
| 260 | // Check if collections isn't hidden. |
||
| 261 | $j = 0; |
||
| 262 | foreach ($metadataValue as $metadataEntry) { |
||
| 263 | if (in_array($metadataEntry, $collList)) { |
||
| 264 | // Translate collection. |
||
| 265 | $metadataArray[$i][$metadataName][$j] = htmlspecialchars(Helper::translate($metadataArray[$i][$metadataName][$j], 'tx_dlf_collections', $this->settings['pages'])); |
||
| 266 | } else { |
||
| 267 | $metadataArray[$i][$metadataName][$j] = ''; |
||
| 268 | } |
||
| 269 | $j++; |
||
| 270 | } |
||
| 271 | } elseif ($metadataName == 'language' && !empty($metadataValue)) { |
||
| 272 | // Translate ISO 639 language code. |
||
| 273 | $metadataArray[$i][$metadataName][0] = htmlspecialchars(Helper::getLanguageName($metadataArray[$i][$metadataName][0])); |
||
| 274 | } elseif (!empty($metadataValue)) { |
||
| 275 | // Sanitize value for output. |
||
| 276 | $metadataArray[$i][$metadataName][0] = htmlspecialchars($metadataArray[$i][$metadataName][0]); |
||
| 277 | } |
||
| 278 | } |
||
| 279 | $i++; |
||
| 280 | } |
||
| 281 | |||
| 282 | $this->view->assign('buildUrl', $buildUrl); |
||
| 283 | $this->view->assign('documentMetadataSections', $metadataArray); |
||
| 284 | $this->view->assign('configMetadata', $metadataResult); |
||
| 285 | $this->view->assign('separator', $this->settings['separator']); |
||
| 286 | |||
| 287 | } |
||
| 288 | } |
||
| 289 | |||
| 290 | // TODO: Needs to be placed in an abstract class (like before in AbstractPlugin) |
||
| 291 | /** |
||
| 292 | * Parses a string into a Typoscript array |
||
| 293 | * |
||
| 294 | * @access protected |
||
| 295 | * |
||
| 296 | * @param string $string: The string to parse |
||
| 297 | * |
||
| 298 | * @return array The resulting typoscript array |
||
| 299 | */ |
||
| 300 | protected function parseTS($string = '') |
||
| 301 | { |
||
| 302 | $parser = GeneralUtility::makeInstance(\TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser::class); |
||
| 303 | $parser->parse($string); |
||
| 304 | return $parser->setup; |
||
| 305 | } |
||
| 306 | |||
| 307 | protected function pi_getLL($label) |
||
| 310 | } |
||
| 311 | |||
| 312 | } |
||
| 313 |
Loading history...
