IsArrayViewHelper::renderStatic() - Code Metrics - Inspection of "Two-level metadata: Model and appearance" - kitodo/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#835)

unknown

created 2022-07-21 11:57 UTC

IsArrayViewHelper::renderStatic() A

↳ Parent: IsArrayViewHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
c	2
b	0
f	0
nc	2
nop	3
dl	0
loc	11
rs	10

<?php

/**
 * (c) Kitodo. Key to digital objects e.V. <[email protected]>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Kitodo\Dlf\ViewHelpers;
use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;

/**
 * Checks if the given subject is an array.
 */
class IsArrayViewHelper extends AbstractViewHelper
{
    public function initializeArguments()
    {
        parent::initializeArguments();
        $this->registerArgument('subject', 'string', 'The subject');
    }

    /**
     * @return bool
     */
    public static function renderStatic(
        array $arguments,
        \Closure $renderChildrenClosure,
        RenderingContextInterface $renderingContext
    ) {
        $subject = $arguments['subject'];
        if (null === $subject) {
            $subject = $renderChildrenClosure();
        }

        return \is_array($subject);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — master (#835)

IsArrayViewHelper::renderStatic() A

Complexity

Size

Duplication

Importance

1			<?php
2
3			/**
4			* (c) Kitodo. Key to digital objects e.V. <[email protected]>
5			*
6			* This file is part of the Kitodo and TYPO3 projects.
7			*
8			* @license GNU General Public License version 3 or later.
9			* For the full copyright and license information, please read the
10			* LICENSE.txt file that was distributed with this source code.
11			*/
12
13			namespace Kitodo\Dlf\ViewHelpers;
14			use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
15			use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
16
17			/**
18			* Checks if the given subject is an array.
19			*/
20			class IsArrayViewHelper extends AbstractViewHelper
21			{
22			public function initializeArguments()
23			{
24			parent::initializeArguments();
25			$this->registerArgument('subject', 'string', 'The subject');
26			}
27
28			/**
29			* @return bool
30			*/
31			public static function renderStatic(
32			array $arguments,
33			\Closure $renderChildrenClosure,
34			RenderingContextInterface $renderingContext
35			) {
36			$subject = $arguments['subject'];
37			if (null === $subject) {
38			$subject = $renderChildrenClosure();
39			}
40
41			return \is_array($subject);
			0 ignored issues – show Bug Best Practice introduced 2022-07-20 09:07 UTC by Report Bug Copy Issue Report The expression `return is_array($subject)` returns the type `boolean` which is incompatible with the return type mandated by `TYPO3Fluid\Fluid\Core\Vi...terface::renderStatic()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
42			}
43			}
44

kitodo / kitodo-presentation

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — master (#835)

IsArrayViewHelper::renderStatic() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like