Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Push — master ( 182690...aedf9a )
by Sebastian
03:49
created
Classes/Plugin/ListView.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
             if ((!empty($this->piVars['order']) && $this->piVars['order'] != $listMetadata['options']['order'])
448 448
                 || (isset($this->piVars['asc']) && $this->piVars['asc'] != $listMetadata['options']['order.asc'])) {
449 449
                 // Update list's metadata.
450
-                $listMetadata['options']['params']['sort'] = [$this->piVars['order']."_sorting" => (boolean) $this->piVars['asc']?'asc':'desc'];
450
+                $listMetadata['options']['params']['sort'] = [$this->piVars['order']."_sorting" => (boolean) $this->piVars['asc'] ? 'asc' : 'desc'];
451 451
                 $listMetadata['options']['order'] = $this->piVars['order'];
452 452
                 $listMetadata['options']['order.asc'] = (boolean) $this->piVars['asc'];
453 453
                 // Reset pointer.
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
                     return $content;
466 466
                 }
467 467
                 // Set search parameters.
468
-                $solr->cPid =  $listMetadata['options']['pid'];
468
+                $solr->cPid = $listMetadata['options']['pid'];
469 469
                 $solr->params = $listMetadata['options']['params'];
470 470
                 // Perform search.
471 471
                 $this->list = $solr->search();
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
             $markerArray['###LISTTHUMBNAIL###'] = '';
506 506
         }
507 507
         if ($currentEntry) {
508
-            $currentEntry =  ($this->piVars['pointer'] * $this->conf['limit']) + 1;
508
+            $currentEntry = ($this->piVars['pointer'] * $this->conf['limit']) + 1;
509 509
             $lastEntry = ($this->piVars['pointer'] * $this->conf['limit']) + $this->conf['limit'];
510 510
             $markerArray['###COUNT###'] = htmlspecialchars(sprintf($this->pi_getLL('count'), $currentEntry, $lastEntry < $this->list->metadata['options']['numberOfToplevelHits'] ? $lastEntry : $this->list->metadata['options']['numberOfToplevelHits'], $this->list->metadata['options']['numberOfToplevelHits']));
511 511
         } else {
Please login to merge, or discard this patch.
Classes/Common/Helper.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -580,18 +580,18 @@
 block discarded – undo
580 580
         return $original;
581 581
     }
582 582
 
583
-     /**
584
-     * Process a data and/or command map with TYPO3 core engine as admin.
585
-     *
586
-     * @access public
587
-     *
588
-     * @param array $data: Data map
589
-     * @param array $cmd: Command map
590
-     * @param boolean $reverseOrder: Should the data map be reversed?
591
-     * @param boolean $cmdFirst: Should the command map be processed first?
592
-     *
593
-     * @return array Array of substituted "NEW..." identifiers and their actual UIDs.
594
-     */
583
+        /**
584
+         * Process a data and/or command map with TYPO3 core engine as admin.
585
+         *
586
+         * @access public
587
+         *
588
+         * @param array $data: Data map
589
+         * @param array $cmd: Command map
590
+         * @param boolean $reverseOrder: Should the data map be reversed?
591
+         * @param boolean $cmdFirst: Should the command map be processed first?
592
+         *
593
+         * @return array Array of substituted "NEW..." identifiers and their actual UIDs.
594
+         */
595 595
     public static function processDBasAdmin(array $data = [], array $cmd = [], $reverseOrder = FALSE, $cmdFirst = FALSE) {
596 596
         if (TYPO3_MODE === 'BE'
597 597
             && $GLOBALS['BE_USER']->isAdmin()) {
Please login to merge, or discard this patch.
class.ext_update.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -422,7 +422,7 @@
 block discarded – undo
422 422
                 $GLOBALS['LANG']->getLL('update.documentSetFormatForOldEntriesOkay', TRUE),
423 423
                 $GLOBALS['LANG']->getLL('update.documentSetFormatForOldEntries', TRUE),
424 424
                 \TYPO3\CMS\Core\Messaging\FlashMessage::OK
425
-               );
425
+                );
426 426
         } else {
427 427
             Helper::addMessage(
428 428
                 $GLOBALS['LANG']->getLL('update.documentSetFormatForOldEntriesNotOkay', TRUE),
Please login to merge, or discard this patch.
Classes/Common/MetsDocument.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,7 @@
 block discarded – undo
131 131
         $fileMimeType = $this->getFileMimeType($id);
132 132
         $fileLocation = $this->getFileLocation($id);
133 133
         if ($fileMimeType == "application/vnd.kitodo.iiif") {
134
-            $fileLocation = strrpos($fileLocation, "info.json") == strlen($fileLocation) - 9 ? $fileLocation :
135
-            strrpos($fileLocation, "/") == strlen($fileLocation) ? $fileLocation."info.json" : $fileLocation."/info.json";
134
+            $fileLocation = strrpos($fileLocation, "info.json") == strlen($fileLocation) - 9 ? $fileLocation : strrpos($fileLocation, "/") == strlen($fileLocation) ? $fileLocation."info.json" : $fileLocation."/info.json";
136 135
             $conf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'][self::$extKey]);
137 136
             IiifHelper::setUrlReader(IiifUrlReader::getInstance());
138 137
             IiifHelper::setMaxThumbnailHeight($conf['iiifThumbnailHeight']);
Please login to merge, or discard this patch.
Classes/Plugin/Tools/AnnotationTool.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
         // Load template file.
66 66
         $this->getTemplate();
67 67
         $annotationContainers = $this->doc->physicalStructureInfo[$this->doc->physicalStructure[$this->piVars['page']]]['annotationContainers'];
68
-        if ($annotationContainers != null && sizeof($annotationContainers)>0) {
68
+        if ($annotationContainers != null && sizeof($annotationContainers) > 0) {
69 69
             $markerArray['###ANNOTATION_SELECT###'] = '<a class="select switchoff" id="tx-dlf-tools-annotations" title="" data-dic="annotations-on:'
70 70
                 .$this->pi_getLL('annotations-on', '', TRUE).';annotations-off:'
71 71
                     .$this->pi_getLL('annotations-off', '', TRUE).'">&nbsp;</a>';
Please login to merge, or discard this patch.
ext_localconf.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,19 +14,19 @@  discard block
 block discarded – undo
14 14
 }
15 15
 // Define constants.
16 16
 if (!defined('DEVLOG_SEVERITY_OK')) {
17
-    define ('DEVLOG_SEVERITY_OK', -1);
17
+    define('DEVLOG_SEVERITY_OK', -1);
18 18
 }
19 19
 if (!defined('DEVLOG_SEVERITY_INFO')) {
20
-    define ('DEVLOG_SEVERITY_INFO', 0);
20
+    define('DEVLOG_SEVERITY_INFO', 0);
21 21
 }
22 22
 if (!defined('DEVLOG_SEVERITY_NOTICE')) {
23
-    define ('DEVLOG_SEVERITY_NOTICE', 1);
23
+    define('DEVLOG_SEVERITY_NOTICE', 1);
24 24
 }
25 25
 if (!defined('DEVLOG_SEVERITY_WARNING')) {
26
-    define ('DEVLOG_SEVERITY_WARNING', 2);
26
+    define('DEVLOG_SEVERITY_WARNING', 2);
27 27
 }
28 28
 if (!defined('DEVLOG_SEVERITY_ERROR')) {
29
-    define ('DEVLOG_SEVERITY_ERROR', 3);
29
+    define('DEVLOG_SEVERITY_ERROR', 3);
30 30
 }
31 31
 // Register plugins.
32 32
 \Kitodo\Dlf\Hooks\ExtensionManagementUtility::addPItoST43($_EXTKEY, \Kitodo\Dlf\Plugin\AudioPlayer::class, '_audioplayer', 'list_type', TRUE);
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['dlf/Classes/Common/MetsDocument.php']['hookClass'][] = \Kitodo\Dlf\Hooks\KitodoProductionHacks::class;
63 63
 // Register command line scripts.
64 64
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['GLOBAL']['cliKeys'][$_EXTKEY] = [
65
-    function () {
65
+    function() {
66 66
         $SOBE = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\Kitodo\Dlf\Cli\CommandLineIndexer::class);
67 67
         $SOBE->main();
68 68
     },
Please login to merge, or discard this patch.
Classes/Plugin/Metadata.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
                 $iiifwrap['value.']['required'] = 1;
166 166
                 $iiifwrap['value.']['wrap'] = '<dd>|</dd>';
167 167
             }
168
-            $iiifLink=[];
168
+            $iiifLink = [];
169 169
             $iiifLink['key.']['wrap'] = '<dt>|</dt>';
170 170
             $iiifLink['value.']['required'] = 1;
171 171
             $iiifLink['value.']['setContentToCurrent'] = 1;
Please login to merge, or discard this patch.
Classes/Common/Document.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
                     /* @var $xml \SimpleXMLElement */
449 449
                     $xml->registerXPathNamespace('mets', 'http://www.loc.gov/METS/');
450 450
                     $xpathResult = $xml->xpath('//mets:mets');
451
-                    $documentFormat = ($xpathResult !== false && count($xpathResult)>0) ? 'METS' : null;
451
+                    $documentFormat = ($xpathResult !== false && count($xpathResult) > 0) ? 'METS' : null;
452 452
                 } else {
453 453
                     // Try to load file as IIIF resource instead.
454 454
                     $contentAsJsonArray = json_decode($content, true);
@@ -682,7 +682,7 @@  discard block
 block discarded – undo
682 682
                 return $depth;
683 683
             } elseif (array_key_exists('children', $element)) {
684 684
                 $foundInChildren = $this->getTreeDepth($element['children'], $depth + 1, $logId);
685
-                if ($foundInChildren!==false) {
685
+                if ($foundInChildren !== false) {
686 686
                     return $foundInChildren;
687 687
                 }
688 688
             }
Please login to merge, or discard this patch.
Classes/Plugin/PageView.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
      * @var array
58 58
      * @access protected
59 59
      */
60
-    protected $annotationContainers = array();
60
+    protected $annotationContainers = array ();
61 61
 
62 62
     /**
63 63
      * Adds Viewer javascript
@@ -250,8 +250,8 @@  discard block
 block discarded – undo
250 250
             if ($iiif instanceof ManifestInterface) {
251 251
                 $canvas = $iiif->getContainedResourceById($canvasId);
252 252
                 /* @var $canvas \Ubl\Iiif\Presentation\Common\Model\Resources\CanvasInterface */
253
-                if ($canvas!=null && !empty($canvas->getPossibleTextAnnotationContainers(Motivation::PAINTING))) {
254
-                    $annotationContainers = array();
253
+                if ($canvas != null && !empty($canvas->getPossibleTextAnnotationContainers(Motivation::PAINTING))) {
254
+                    $annotationContainers = array ();
255 255
                     /*
256 256
                      *  TODO Analyzing the annotations on the server side requires loading the annotation lists / pages
257 257
                      *  just to determine wether they contain text annotations for painting. This will take time and lead to a bad user experience.
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 }
286 286
             }
287 287
         }
288
-        return array();
288
+        return array ();
289 289
     }
290 290
 
291 291
     /**
Please login to merge, or discard this patch.