kitodo / kitodo-presentation

Classes/Controller/View3DController.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
             $settingsParts = explode("/", $model);
             $fileName = end($settingsParts);
-            $path = substr($model, 0,  strrpos($model, $fileName));
+            $path = substr($model, 0, strrpos($model, $fileName));
             $modelSettings = $path . "metadata/" . $fileName . "_viewer";
 
             if (!empty($modelConverted)) {

Classes/Controller/NavigationController.php

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
      * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm
      * @return void
      */
-    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) {
+    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL)
+    {
         if ($pageSelectForm) {
             $uriBuilder = $this->getControllerContext()->getUriBuilder();
             $uri = $uriBuilder->reset()

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
      * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm
      * @return void
      */
-    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) {
+    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) {
         if ($pageSelectForm) {
             $uriBuilder = $this->getControllerContext()->getUriBuilder();
             $uri = $uriBuilder->reset()

Classes/Controller/ListViewController.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
         // extract collection(s) from collection parameter
         $collection = null;
         if ($this->searchParams['collection']) {
-            foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) {
+            foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) {
                 $collection[] = $this->collectionRepository->findByUid($collectionEntry);
             }
         }

Classes/Format/Mods.php

Braces +20 added lines, -10 removed lines

@@ -71,7 +71,8 @@ 
      *
      * @return void
      */
-    private function getAuthors() {
+    private function getAuthors()
+    {
         $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]');
 
         // Get "author" and "author_sorting" again if that was too sophisticated.
@@ -93,7 +94,8 @@ 
         }
     }
 
-    private function getAuthorFromOrcidApi($orcidId, $authors, $i) {
+    private function getAuthorFromOrcidApi($orcidId, $authors, $i)
+    {
         $profile = new OrcidProfile($orcidId);
         $name = $profile->getFullName();
         if (!empty($name)) {
@@ -107,7 +109,8 @@ 
         }
     }
 
-    private function getAuthorFromXml($authors, $i) {
+    private function getAuthorFromXml($authors, $i)
+    {
         $this->getAuthorFromXmlDisplayForm($authors, $i);
 
         $nameParts = $authors[$i]->xpath('./mods:namePart');
@@ -150,7 +153,8 @@ 
         }
     }
 
-    private function getAuthorFromXmlDisplayForm($authors, $i) {
+    private function getAuthorFromXmlDisplayForm($authors, $i)
+    {
         $displayForm = $authors[$i]->xpath('./mods:displayForm');
         if ($displayForm) {
             $this->metadata['author'][$i] = (string) $displayForm[0];
@@ -164,7 +168,8 @@ 
      *
      * @return void
      */
-    private function getHolders() {
+    private function getHolders()
+    {
         $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]');
 
         if (!empty($holders)) {
@@ -181,7 +186,8 @@ 
         }
     }
 
-    private function getHolderFromViafApi($viafId, $holders, $i) {
+    private function getHolderFromViafApi($viafId, $holders, $i)
+    {
         $profile = new ViafProfile($viafId);
         $name = $profile->getFullName();
         if (!empty($name)) {
@@ -195,7 +201,8 @@ 
         }
     }
 
-    private function getHolderFromXml($holders, $i) {
+    private function getHolderFromXml($holders, $i)
+    {
         $this->getHolderFromXmlDisplayForm($holders, $i);
         // Append "valueURI" to name using Unicode unit separator.
         if (isset($holders[$i]['valueURI'])) {
@@ -203,7 +210,8 @@ 
         }
     }
 
-    private function getHolderFromXmlDisplayForm($holders, $i) {
+    private function getHolderFromXmlDisplayForm($holders, $i)
+    {
         // Check if there is a display form.
         $displayForm = $holders[$i]->xpath('./mods:displayForm');
         if ($displayForm) {
@@ -218,7 +226,8 @@ 
      *
      * @return void
      */
-    private function getPlaces() {
+    private function getPlaces()
+    {
         $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm');
         // Get "place" and "place_sorting" again if that was to sophisticated.
         if (empty($places)) {
@@ -242,7 +251,8 @@ 
      *
      * @return void
      */
-    private function getYears() {
+    private function getYears()
+    {
         // Get "year_sorting".
         if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) {
             foreach ($years_sorting as $year_sorting) {

Classes/Controller/SearchController.php

Spacing +9 added lines, -9 removed lines

@@ -108,13 +108,13 @@ 
         }
 
         // sanitize date search input
-        if(empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
+        if (empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
             $this->searchParams['dateFrom'] = '*';
         }
-        if(empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
+        if (empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
             $this->searchParams['dateTo'] = 'NOW';
         }
-        if($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
+        if ($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
             $tmpDate = $this->searchParams['dateFrom'];
             $this->searchParams['dateFrom'] = $this->searchParams['dateTo'];
             $this->searchParams['dateTo'] = $tmpDate;
@@ -259,7 +259,7 @@ 
         // extract collections from collection parameter
         $collection = null;
         if ($this->searchParams['collection']) {
-            foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) {
+            foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) {
                 $collection[] = $this->collectionRepository->findByUid($collectionEntry);
             }
             
@@ -269,8 +269,8 @@ 
             $virtualCollectionsQueryString = '';
             foreach ($collection as $collectionEntry) {
                 // check for virtual collections query string
-                if($collectionEntry->getIndexSearch()) {
-                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
+                if ($collectionEntry->getIndexSearch()) {
+                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR (' . $collectionEntry->getIndexSearch() . ')';
                 }
                 else {
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
@@ -278,8 +278,8 @@ 
             }
             
             // distinguish between simple collection browsing and actual searching within the collection(s)
-            if(!empty($collectionsQueryString)) {
-                if(empty($searchParams['query'])) {
+            if (!empty($collectionsQueryString)) {
+                if (empty($searchParams['query'])) {
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . ') AND toplevel:true AND partof:0)';
                 } else {
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . '))';
@@ -287,7 +287,7 @@ 
             }
 
             // virtual collections might query documents that are neither toplevel:true nor partof:0 and need to be searched separatly
-            if(!empty($virtualCollectionsQueryString)) {
+            if (!empty($virtualCollectionsQueryString)) {
                 $virtualCollectionsQueryString = '(' . $virtualCollectionsQueryString . ')';
             }
 

Braces +3 added lines, -3 removed lines

@@ -271,8 +271,7 @@ 
                 // check for virtual collections query string
                 if($collectionEntry->getIndexSearch()) {
                     $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
-                }
-                else {
+                } else {
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
                 }
             }
@@ -459,7 +458,8 @@ 
      *
      * @return string
      */
-    private function translateValue($field, $value) {
+    private function translateValue($field, $value)
+    {
         switch ($field) {
             case 'owner_faceting':
                 // Translate name of holding library.

Classes/Common/SolrSearch.php

Spacing +10 added lines, -10 removed lines

@@ -212,7 +212,7 @@ 
         // Add filter query for date search
         if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
             // combine dateFrom and dateTo into range search
-            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
+            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
         }
 
         // Add filter query for faceting.
@@ -243,16 +243,16 @@ 
             $virtualCollectionsQueryString = '';
             foreach ($this->collection as $collectionEntry) {
                 // check for virtual collections query string
-                if($collectionEntry->getIndexSearch()) {
-                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
+                if ($collectionEntry->getIndexSearch()) {
+                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR (' . $collectionEntry->getIndexSearch() . ')';
                 } else {
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
                 }
             }
             
             // distinguish between simple collection browsing and actual searching within the collection(s)
-            if(!empty($collectionsQueryString)) {
-                if(empty($query)) {
+            if (!empty($collectionsQueryString)) {
+                if (empty($query)) {
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . ') AND toplevel:true AND partof:0)';
                 } else {
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . '))';
@@ -260,7 +260,7 @@ 
             }
 
             // virtual collections might query documents that are neither toplevel:true nor partof:0 and need to be searched separatly
-            if(!empty($virtualCollectionsQueryString)) {
+            if (!empty($virtualCollectionsQueryString)) {
                 $virtualCollectionsQueryString = '(' . $virtualCollectionsQueryString . ')';
             }
 
@@ -337,8 +337,8 @@ 
                 }
                 if ($documents[$doc['uid']]) {
                     // translate language code if applicable
-                    if($doc['metadata']['language']) {
-                        foreach($doc['metadata']['language'] as $indexName => $language) {
+                    if ($doc['metadata']['language']) {
+                        foreach ($doc['metadata']['language'] as $indexName => $language) {
                             $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
                         }
                     }
@@ -438,8 +438,8 @@ 
 
         foreach ($result['documents'] as $doc) {
             // translate language code if applicable
-            if($doc['metadata']['language']) {
-                foreach($doc['metadata']['language'] as $indexName => $language) {
+            if ($doc['metadata']['language']) {
+                foreach ($doc['metadata']['language'] as $indexName => $language) {
                     $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
                 }
             }

Classes/Api/Viaf/Client.php

Braces +2 added lines, -1 removed lines

@@ -77,7 +77,8 @@
      *
      * @return void
      */
-    public function setEndpoint($endpoint) {
+    public function setEndpoint($endpoint)
+    {
         $this->endpoint = $endpoint;
     }
 

Classes/Api/Orcid/Client.php

Braces +2 added lines, -1 removed lines

@@ -77,7 +77,8 @@
      *
      * @return void
      */
-    public function setEndpoint($endpoint) {
+    public function setEndpoint($endpoint)
+    {
         $this->endpoint = $endpoint;
     }
 

Classes/Controller/CalendarController.php

Spacing +5 added lines, -5 removed lines

@@ -127,7 +127,7 @@ 
                 foreach ($year['children'] as $month) {
                     foreach ($month['children'] as $day) {
                         foreach ($day['children'] as $issue) {
-                            $title = $issue['label'] ?: $issue['orderlabel'];
+                            $title = $issue['label'] ? : $issue['orderlabel'];
                             if (strtotime($title) !== false) {
                                 $title = strftime('%x', strtotime($title));
                             }
@@ -218,8 +218,8 @@ 
         $this->view->assign('calendarData', $calendarData);
         $this->view->assign('documentId', $this->document->getUid());
         $this->view->assign('yearLinkTitle', $yearLinkTitle);
-        $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']);
-        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']);
+        $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']);
+        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']);
     }
 
     /**
@@ -255,7 +255,7 @@ 
 
                 if (empty($yearLabel)) {
                     // if neither order nor orderlabel is set, use the id...
-                    $yearLabel = (string)$id;
+                    $yearLabel = (string) $id;
                 }
 
                 $years[] = [
@@ -294,7 +294,7 @@ 
                     if (is_int($key)) {
                         $yearFilled[] = $yearArray[$key];
                     } else {
-                        $yearFilled[] = ['title' => $min+$i, 'documentId' => ''];
+                        $yearFilled[] = ['title' => $min + $i, 'documentId' => ''];
                     }
                 }
                 $yearArray = $yearFilled;