Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — 2.x (#526)
by Sebastian
05:03
created
plugins/pageview/class.tx_dlf_pageview.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
      * @var	array
28 28
      * @access protected
29 29
      */
30
-    protected $controls = array ();
30
+    protected $controls = array();
31 31
 
32 32
     /**
33 33
      * Holds the current images' URLs and MIME types
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
      * @var	array
36 36
      * @access protected
37 37
      */
38
-    protected $images = array ();
38
+    protected $images = array();
39 39
 
40 40
     /**
41 41
      * Holds the current fulltexts' URLs
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * @var	array
44 44
      * @access protected
45 45
      */
46
-    protected $fulltexts = array ();
46
+    protected $fulltexts = array();
47 47
 
48 48
     /**
49 49
      * Adds Viewer javascript
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     protected function addViewerJS() {
56 56
 
57
-        $output = array ();
57
+        $output = array();
58 58
         $tmp = $this->getFulltext($this->piVars['page']);
59 59
         $bTeiXml = false;
60 60
         if (isset($tmp['mimetype']) && $tmp['mimetype'] == 'application/tei+xml') {
@@ -62,36 +62,36 @@  discard block
 block discarded – undo
62 62
         }
63 63
 
64 64
         // Add OpenLayers library.
65
-        $output[] = '<link type="text/css" rel="stylesheet" href="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'lib/OpenLayers/ol3.css">';
65
+        $output[] = '<link type="text/css" rel="stylesheet" href="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'lib/OpenLayers/ol3.css">';
66 66
 
67
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'lib/OpenLayers/glif.min.js"></script>';
67
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'lib/OpenLayers/glif.min.js"></script>';
68 68
 
69
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'lib/OpenLayers/ol3-dlf.js"></script>';
69
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'lib/OpenLayers/ol3-dlf.js"></script>';
70 70
 
71 71
         // Add viewer library.
72
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_utils.js"></script>';
72
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_utils.js"></script>';
73 73
 
74
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_ol3.js"></script>';
74
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_ol3.js"></script>';
75 75
 
76
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_ol3_styles.js"></script>';
76
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_ol3_styles.js"></script>';
77 77
 
78
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_ol3_source.js"></script>';
78
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_ol3_source.js"></script>';
79 79
 
80 80
         if ($bTeiXml) {
81
-            $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_teiparser.js"></script>';
81
+            $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_teiparser.js"></script>';
82 82
         } else {
83
-            $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_altoparser.js"></script>';
83
+            $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_altoparser.js"></script>';
84 84
         }
85 85
 
86
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_pageview_imagemanipulation_control.js"></script>';
86
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_pageview_imagemanipulation_control.js"></script>';
87 87
 
88 88
         if ($bTeiXml) {
89
-            $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_pageview_teifulltext_control.js"></script>';
89
+            $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_pageview_teifulltext_control.js"></script>';
90 90
         } else {
91
-            $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_pageview_fulltext_control.js"></script>';
91
+            $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_pageview_fulltext_control.js"></script>';
92 92
         }
93 93
 
94
-        $output[] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/pageview/tx_dlf_pageview.js"></script>';
94
+        $output[] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/pageview/tx_dlf_pageview.js"></script>';
95 95
 
96 96
         // Add viewer configuration.
97 97
         $output[] = '
@@ -99,12 +99,12 @@  discard block
 block discarded – undo
99 99
 			window.onload = function() {
100 100
 				if (dlfUtils.exists(dlfViewer)) {
101 101
 					tx_dlf_viewer = new dlfViewer({
102
-						controls: ["'.implode('", "', $this->controls).'"],
103
-						div: "'.$this->conf['elementId'].'",
104
-						images: '.json_encode($this->images).',
105
-						fulltexts: '.json_encode($this->fulltexts).',
106
-                        teifulltext: '.(($bTeiXml) ? 'true' : 'false').',
107
-						useInternalProxy: '.($this->conf['useInternalProxy'] ? 1 : 0).'
102
+						controls: ["'.implode('", "', $this->controls) . '"],
103
+						div: "'.$this->conf['elementId'] . '",
104
+						images: '.json_encode($this->images) . ',
105
+						fulltexts: '.json_encode($this->fulltexts) . ',
106
+                        teifulltext: '.(($bTeiXml) ? 'true' : 'false') . ',
107
+						useInternalProxy: '.($this->conf['useInternalProxy'] ? 1 : 0) . '
108 108
 					})
109 109
 				}
110 110
 			}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
      */
124 124
     protected function addInteraction() {
125 125
 
126
-        $markerArray = array ();
126
+        $markerArray = array();
127 127
 
128 128
         if ($this->piVars['id']) {
129 129
 
@@ -135,9 +135,9 @@  discard block
 block discarded – undo
135 135
 
136 136
             if ($this->conf['crop']) {
137 137
 
138
-                $markerArray['###EDITBUTTON###'] = '<a href="javascript: tx_dlf_viewer.activateSelection();">'.$this->pi_getLL('editMode', '', TRUE).'</a>';
138
+                $markerArray['###EDITBUTTON###'] = '<a href="javascript: tx_dlf_viewer.activateSelection();">' . $this->pi_getLL('editMode', '', TRUE) . '</a>';
139 139
 
140
-                $markerArray['###EDITREMOVE###'] = '<a href="javascript: tx_dlf_viewer.resetCropSelection();">'.$this->pi_getLL('editRemove', '', TRUE).'</a>';
140
+                $markerArray['###EDITREMOVE###'] = '<a href="javascript: tx_dlf_viewer.resetCropSelection();">' . $this->pi_getLL('editRemove', '', TRUE) . '</a>';
141 141
 
142 142
             } else {
143 143
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
             if ($this->conf['magnifier']) {
151 151
 
152
-                $markerArray['###MAGNIFIER###'] = '<a href="javascript: tx_dlf_viewer.activateMagnifier();">'.$this->pi_getLL('magnifier', '', TRUE).'</a>';
152
+                $markerArray['###MAGNIFIER###'] = '<a href="javascript: tx_dlf_viewer.activateMagnifier();">' . $this->pi_getLL('magnifier', '', TRUE) . '</a>';
153 153
 
154 154
             } else {
155 155
 
@@ -171,14 +171,14 @@  discard block
 block discarded – undo
171 171
      */
172 172
     protected function addBasketForm() {
173 173
 
174
-        $markerArray = array ();
174
+        $markerArray = array();
175 175
 
176 176
         // Add basket button
177 177
         if ($this->conf['basketButton'] && $this->conf['targetBasket'] && $this->piVars['id']) {
178 178
 
179 179
             $label = $this->pi_getLL('addBasket', '', TRUE);
180 180
 
181
-            $params = array (
181
+            $params = array(
182 182
                 'id' => $this->piVars['id'],
183 183
                 'addToBasket' => TRUE
184 184
             );
@@ -189,17 +189,17 @@  discard block
 block discarded – undo
189 189
 
190 190
             }
191 191
 
192
-            $basketConf = array (
192
+            $basketConf = array(
193 193
                 'parameter' => $this->conf['targetBasket'],
194 194
                 'additionalParams' => \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId, $params, '', TRUE, FALSE),
195 195
                 'title' => $label
196 196
             );
197 197
 
198
-            $output = '<form id="addToBasketForm" action="'.$this->cObj->typoLink_URL($basketConf).'" method="post">';
198
+            $output = '<form id="addToBasketForm" action="' . $this->cObj->typoLink_URL($basketConf) . '" method="post">';
199 199
 
200
-            $output .= '<input type="hidden" name="tx_dlf[startpage]" id="startpage" value="'.htmlspecialchars($this->piVars['page']).'">';
200
+            $output .= '<input type="hidden" name="tx_dlf[startpage]" id="startpage" value="' . htmlspecialchars($this->piVars['page']) . '">';
201 201
 
202
-            $output .= '<input type="hidden" name="tx_dlf[endpage]" id="endpage" value="'.htmlspecialchars($this->piVars['page']).'">';
202
+            $output .= '<input type="hidden" name="tx_dlf[endpage]" id="endpage" value="' . htmlspecialchars($this->piVars['page']) . '">';
203 203
 
204 204
             $output .= '<input type="hidden" name="tx_dlf[startX]" id="startX">';
205 205
 
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 
212 212
             $output .= '<input type="hidden" name="tx_dlf[rotation]" id="rotation">';
213 213
 
214
-            $output .= '<button id="submitBasketForm" onclick="this.form.submit()">'.$label.'</button>';
214
+            $output .= '<button id="submitBasketForm" onclick="this.form.submit()">' . $label . '</button>';
215 215
 
216 216
             $output .= '</form>';
217 217
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
      */
249 249
     protected function getImage($page) {
250 250
 
251
-        $image = array ();
251
+        $image = array();
252 252
 
253 253
         // Get @USE value of METS fileGrp.
254 254
         $fileGrps = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['fileGrps']);
@@ -262,9 +262,9 @@  discard block
 block discarded – undo
262 262
 
263 263
                 if ($this->conf['useInternalProxy']) {
264 264
                     // Configure @action URL for form.
265
-                    $linkConf = array (
265
+                    $linkConf = array(
266 266
                         'parameter' => $GLOBALS['TSFE']->id,
267
-                        'additionalParams' => '&eID=tx_dlf_geturl_eid&url='.urlencode($image['url']),
267
+                        'additionalParams' => '&eID=tx_dlf_geturl_eid&url=' . urlencode($image['url']),
268 268
                     );
269 269
 
270 270
                     $image['url'] = $this->cObj->typoLink_URL($linkConf);
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 
279 279
                 if (TYPO3_DLOG) {
280 280
 
281
-                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_pageview->getImage('.$page.')] File not found in fileGrp "'.$fileGrp.'"', $this->extKey, SYSLOG_SEVERITY_WARNING);
281
+                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_pageview->getImage(' . $page . ')] File not found in fileGrp "' . $fileGrp . '"', $this->extKey, SYSLOG_SEVERITY_WARNING);
282 282
 
283 283
                 }
284 284
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
      */
302 302
     protected function getFulltext($page) {
303 303
 
304
-        $fulltext = array ();
304
+        $fulltext = array();
305 305
 
306 306
         // Get fulltext link.
307 307
         if (!empty($this->doc->physicalStructureInfo[$this->doc->physicalStructure[$page]]['files'][$this->conf['fileGrpFulltext']])) {
@@ -309,9 +309,9 @@  discard block
 block discarded – undo
309 309
             $fulltext['url'] = $this->doc->getFileLocation($this->doc->physicalStructureInfo[$this->doc->physicalStructure[$page]]['files'][$this->conf['fileGrpFulltext']]);
310 310
 
311 311
             // Configure @action URL for form.
312
-            $linkConf = array (
312
+            $linkConf = array(
313 313
                 'parameter' => $GLOBALS['TSFE']->id,
314
-                'additionalParams' => '&eID=tx_dlf_geturl_eid&url='.urlencode($fulltext['url']),
314
+                'additionalParams' => '&eID=tx_dlf_geturl_eid&url=' . urlencode($fulltext['url']),
315 315
             );
316 316
 
317 317
             $fulltext['url'] = $this->cObj->typoLink_URL($linkConf);
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 
323 323
             if (TYPO3_DLOG) {
324 324
 
325
-                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_pageview->getFulltext('.$page.')] File not found in fileGrp "'.$this->conf['fileGrpFulltext'].'"', $this->extKey, SYSLOG_SEVERITY_WARNING);
325
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_pageview->getFulltext(' . $page . ')] File not found in fileGrp "' . $this->conf['fileGrpFulltext'] . '"', $this->extKey, SYSLOG_SEVERITY_WARNING);
326 326
 
327 327
             }
328 328
 
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
         $this->controls = explode(',', $this->conf['features']);
407 407
 
408 408
         // Fill in the template markers.
409
-        $markerArray = array (
409
+        $markerArray = array(
410 410
             '###VIEWER_JS###' => $this->addViewerJS()
411 411
         );
412 412
 
Please login to merge, or discard this patch.