We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -71,7 +71,8 @@ discard block |
||
| 71 | 71 | * |
| 72 | 72 | * @return void |
| 73 | 73 | */ |
| 74 | - private function getAuthors() { |
|
| 74 | + private function getAuthors() |
|
| 75 | + { |
|
| 75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
| 76 | 77 | |
| 77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
| 93 | 94 | } |
| 94 | 95 | } |
| 95 | 96 | |
| 96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
| 97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
| 98 | + { |
|
| 97 | 99 | $profile = new OrcidProfile($orcidId); |
| 98 | 100 | $name = $profile->getFullName(); |
| 99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
| 107 | 109 | } |
| 108 | 110 | } |
| 109 | 111 | |
| 110 | - private function getAuthorFromXml($authors, $i) { |
|
| 112 | + private function getAuthorFromXml($authors, $i) |
|
| 113 | + { |
|
| 111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
| 112 | 115 | |
| 113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
| 150 | 153 | } |
| 151 | 154 | } |
| 152 | 155 | |
| 153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
| 156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
| 157 | + { |
|
| 154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
| 155 | 159 | if ($displayForm) { |
| 156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
| 164 | 168 | * |
| 165 | 169 | * @return void |
| 166 | 170 | */ |
| 167 | - private function getHolders() { |
|
| 171 | + private function getHolders() |
|
| 172 | + { |
|
| 168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
| 169 | 174 | |
| 170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
| 181 | 186 | } |
| 182 | 187 | } |
| 183 | 188 | |
| 184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
| 189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
| 190 | + { |
|
| 185 | 191 | $profile = new ViafProfile($viafId); |
| 186 | 192 | $name = $profile->getFullName(); |
| 187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
| 195 | 201 | } |
| 196 | 202 | } |
| 197 | 203 | |
| 198 | - private function getHolderFromXml($holders, $i) { |
|
| 204 | + private function getHolderFromXml($holders, $i) |
|
| 205 | + { |
|
| 199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
| 200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
| 201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
| 203 | 210 | } |
| 204 | 211 | } |
| 205 | 212 | |
| 206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
| 213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
| 214 | + { |
|
| 207 | 215 | // Check if there is a display form. |
| 208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
| 209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
| 218 | 226 | * |
| 219 | 227 | * @return void |
| 220 | 228 | */ |
| 221 | - private function getPlaces() { |
|
| 229 | + private function getPlaces() |
|
| 230 | + { |
|
| 222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
| 223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
| 224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
| 242 | 251 | * |
| 243 | 252 | * @return void |
| 244 | 253 | */ |
| 245 | - private function getYears() { |
|
| 254 | + private function getYears() |
|
| 255 | + { |
|
| 246 | 256 | // Get "year_sorting". |
| 247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
| 248 | 258 | foreach ($years_sorting as $year_sorting) { |
@@ -77,7 +77,8 @@ |
||
| 77 | 77 | * |
| 78 | 78 | * @return void |
| 79 | 79 | */ |
| 80 | - public function setEndpoint($endpoint) { |
|
| 80 | + public function setEndpoint($endpoint) |
|
| 81 | + { |
|
| 81 | 82 | $this->endpoint = $endpoint; |
| 82 | 83 | } |
| 83 | 84 | |
@@ -77,7 +77,8 @@ |
||
| 77 | 77 | * |
| 78 | 78 | * @return void |
| 79 | 79 | */ |
| 80 | - public function setEndpoint($endpoint) { |
|
| 80 | + public function setEndpoint($endpoint) |
|
| 81 | + { |
|
| 81 | 82 | $this->endpoint = $endpoint; |
| 82 | 83 | } |
| 83 | 84 | |
@@ -74,7 +74,7 @@ discard block |
||
| 74 | 74 | // extract collection(s) from collection parameter |
| 75 | 75 | $collection = null; |
| 76 | 76 | if ($this->searchParams['collection']) { |
| 77 | - foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
| 77 | + foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
| 78 | 78 | $collection[] = $this->collectionRepository->findByUid($collectionEntry); |
| 79 | 79 | } |
| 80 | 80 | } |
@@ -106,7 +106,7 @@ discard block |
||
| 106 | 106 | $simplePagination = new SimplePagination($solrPaginator); |
| 107 | 107 | |
| 108 | 108 | $pagination = $this->buildSimplePagination($simplePagination, $solrPaginator); |
| 109 | - $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $solrPaginator ]); |
|
| 109 | + $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $solrPaginator]); |
|
| 110 | 110 | } |
| 111 | 111 | |
| 112 | 112 | $this->view->assign('viewData', $this->viewData); |
@@ -205,7 +205,8 @@ |
||
| 205 | 205 | * |
| 206 | 206 | * @return void |
| 207 | 207 | */ |
| 208 | - private function addDcData(&$metadata, $key, $value) { |
|
| 208 | + private function addDcData(&$metadata, $key, $value) |
|
| 209 | + { |
|
| 209 | 210 | if (!empty($value)) { |
| 210 | 211 | $metadata[] = [$key => $value]; |
| 211 | 212 | } |
@@ -278,7 +278,7 @@ |
||
| 278 | 278 | |
| 279 | 279 | if ($this->solrCoreRepository->findOneByPid($this->pid) === null) { |
| 280 | 280 | $newRecord = GeneralUtility::makeInstance(SolrCore::class); |
| 281 | - $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')'); |
|
| 281 | + $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')'); |
|
| 282 | 282 | $indexName = Solr::createCore(''); |
| 283 | 283 | if (!empty($indexName)) { |
| 284 | 284 | $newRecord->setIndexName($indexName); |
@@ -345,7 +345,8 @@ |
||
| 345 | 345 | * |
| 346 | 346 | * @return void |
| 347 | 347 | */ |
| 348 | - private function setDefault($setting, $value) { |
|
| 348 | + private function setDefault($setting, $value) |
|
| 349 | + { |
|
| 349 | 350 | if (!isset($this->settings[$setting])) { |
| 350 | 351 | $this->settings[$setting] = $value; |
| 351 | 352 | } |
@@ -337,7 +337,7 @@ discard block |
||
| 337 | 337 | $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']); |
| 338 | 338 | $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']); |
| 339 | 339 | // verify date formatting |
| 340 | - if(strtotime($metadata['date'][0])) { |
|
| 340 | + if (strtotime($metadata['date'][0])) { |
|
| 341 | 341 | // do not alter dates YYYY or YYYY-MM or YYYY-MM-DD |
| 342 | 342 | if ( |
| 343 | 343 | preg_match("/^[\d]{4}$/", $metadata['date'][0]) |
@@ -346,7 +346,7 @@ discard block |
||
| 346 | 346 | ) { |
| 347 | 347 | $solrDoc->setField('date', $metadata['date'][0]); |
| 348 | 348 | // change date YYYYMMDD to YYYY-MM-DD |
| 349 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
| 349 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
| 350 | 350 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
| 351 | 351 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
| 352 | 352 | } elseif (preg_match("/^[0-9]{4}-[0-9]{2}-[0-9]{2}T.*$/", $metadata['date'][0])) { |
@@ -483,7 +483,7 @@ discard block |
||
| 483 | 483 | !empty($data) |
| 484 | 484 | && substr($index_name, -8) == '_sorting' |
| 485 | 485 | ) { |
| 486 | - $solrDoc->setField($index_name , $doc->metadataArray[$doc->toplevelId][$index_name]); |
|
| 486 | + $solrDoc->setField($index_name, $doc->metadataArray[$doc->toplevelId][$index_name]); |
|
| 487 | 487 | } |
| 488 | 488 | } |
| 489 | 489 | } |
@@ -346,7 +346,7 @@ discard block |
||
| 346 | 346 | ) { |
| 347 | 347 | $solrDoc->setField('date', $metadata['date'][0]); |
| 348 | 348 | // change date YYYYMMDD to YYYY-MM-DD |
| 349 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
| 349 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
| 350 | 350 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
| 351 | 351 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
| 352 | 352 | } elseif (preg_match("/^[0-9]{4}-[0-9]{2}-[0-9]{2}T.*$/", $metadata['date'][0])) { |
@@ -555,7 +555,8 @@ discard block |
||
| 555 | 555 | * |
| 556 | 556 | * @return \Solarium\Core\Query\DocumentInterface |
| 557 | 557 | */ |
| 558 | - private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') { |
|
| 558 | + private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') |
|
| 559 | + { |
|
| 559 | 560 | $solrDoc = $updateQuery->createDocument(); |
| 560 | 561 | // Create unique identifier from document's UID and unit's XML ID. |
| 561 | 562 | $solrDoc->setField('id', $document->getUid() . $unit['id']); |
@@ -579,7 +580,8 @@ discard block |
||
| 579 | 580 | * |
| 580 | 581 | * @return array|string |
| 581 | 582 | */ |
| 582 | - private static function removeAppendsFromAuthor($authors) { |
|
| 583 | + private static function removeAppendsFromAuthor($authors) |
|
| 584 | + { |
|
| 583 | 585 | if (is_array($authors)) { |
| 584 | 586 | foreach ($authors as $i => $author) { |
| 585 | 587 | $splitName = explode(chr(31), $author); |
@@ -102,7 +102,7 @@ |
||
| 102 | 102 | $listRequestData = GeneralUtility::_GPmerged('tx_dlf_listview'); |
| 103 | 103 | |
| 104 | 104 | if (isset($listRequestData['searchParameter']) && is_array($listRequestData['searchParameter'])) { |
| 105 | - $this->searchParams = array_merge($this->searchParams ?: [], $listRequestData['searchParameter']); |
|
| 105 | + $this->searchParams = array_merge($this->searchParams ? : [], $listRequestData['searchParameter']); |
|
| 106 | 106 | $listViewSearch = true; |
| 107 | 107 | $GLOBALS['TSFE']->fe_user->setKey('ses', 'search', $this->searchParams); |
| 108 | 108 | } |
@@ -358,7 +358,8 @@ discard block |
||
| 358 | 358 | * |
| 359 | 359 | * @return string The collection query string |
| 360 | 360 | */ |
| 361 | - private function addCollectionsQuery($query) { |
|
| 361 | + private function addCollectionsQuery($query) |
|
| 362 | + { |
|
| 362 | 363 | // if collections are given, we prepare the collections query string |
| 363 | 364 | // extract collections from collection parameter |
| 364 | 365 | $collections = null; |
@@ -453,7 +454,8 @@ discard block |
||
| 453 | 454 | * |
| 454 | 455 | * @return array menu array |
| 455 | 456 | */ |
| 456 | - private function processResults($facet, $facetCollectionArray, $search) { |
|
| 457 | + private function processResults($facet, $facetCollectionArray, $search) |
|
| 458 | + { |
|
| 457 | 459 | $menuArray = []; |
| 458 | 460 | |
| 459 | 461 | if ($facet) { |