BaseCommand::getSolrCores() - Code Metrics - Inspection of "[BUGFIX] Fix saving to database for documents with..." - kitodo/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 83566b...c23467 )

unknown
created 2024-05-03 14:08 UTC
BaseCommand::getSolrCores() A

↳ Parent: BaseCommand
Complexity

Conditions	2
Paths	2
Size

Total Lines	22
Code Lines	14
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	2
eloc	14
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	22
rs	9.7998
<?php

/**
 * (c) Kitodo. Key to digital objects e.V. <[email protected]>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Kitodo\Dlf\Command;

use Kitodo\Dlf\Common\AbstractDocument;
use Kitodo\Dlf\Common\Helper;
use Kitodo\Dlf\Common\Indexer;
use Kitodo\Dlf\Domain\Repository\CollectionRepository;
use Kitodo\Dlf\Domain\Repository\DocumentRepository;
use Kitodo\Dlf\Domain\Repository\LibraryRepository;
use Kitodo\Dlf\Domain\Repository\StructureRepository;
use Kitodo\Dlf\Domain\Model\Collection;
use Kitodo\Dlf\Domain\Model\Document;
use Kitodo\Dlf\Domain\Model\Library;
use Symfony\Component\Console\Command\Command;
use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\MathUtility;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Database\Connection;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface;
use TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager;

/**
 * Base class for CLI Command classes.
 *
 * @package TYPO3
 * @subpackage dlf
 *
 * @access public
 */
class BaseCommand extends Command
{
    /**
     * @access protected
     * @var CollectionRepository
     */
    protected CollectionRepository $collectionRepository;

    /**
     * @access protected
     * @var DocumentRepository
     */
    protected DocumentRepository $documentRepository;

    /**
     * @access protected
     * @var LibraryRepository
     */
    protected LibraryRepository $libraryRepository;

    /**
     * @access protected
     * @var StructureRepository
     */
    protected StructureRepository $structureRepository;

    /**
     * @access protected
     * @var int
     */
    protected int $storagePid;

    /**
     * @access protected
     * @var Library|null
     */
    protected ?Library $owner;

    /**
     * @access protected
     * @var array
     */
    protected array $extConf;

    /**
     * @var ConfigurationManager
     */
    protected ConfigurationManager $configurationManager;

    public function __construct(
        CollectionRepository $collectionRepository,
        DocumentRepository $documentRepository,
        LibraryRepository $libraryRepository,
        StructureRepository $structureRepository,
        ConfigurationManager $configurationManager
    ) {
        parent::__construct();

        $this->collectionRepository = $collectionRepository;
        $this->documentRepository = $documentRepository;
        $this->libraryRepository = $libraryRepository;
        $this->structureRepository = $structureRepository;
        $this->configurationManager = $configurationManager;
    }

    /**
     * Initialize the extbase repository based on the given storagePid.
     *
     * TYPO3 10+: Find a better solution e.g. based on Symfony Dependency Injection.
     *
     * @access protected
     *
     * @param int $storagePid The storage pid
     *
     * @return bool
     */
    protected function initializeRepositories(int $storagePid): bool
    {
        if (MathUtility::canBeInterpretedAsInteger($storagePid)) {
            $frameworkConfiguration = $this->configurationManager->getConfiguration(ConfigurationManagerInterface::CONFIGURATION_TYPE_FRAMEWORK);

            $frameworkConfiguration['persistence']['storagePid'] = MathUtility::forceIntegerInRange((int) $storagePid, 0);
            $this->configurationManager->setConfiguration($frameworkConfiguration);

            // Get extension configuration.
            $this->extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('dlf');
        } else {
            return false;
        }
        $this->storagePid = MathUtility::forceIntegerInRange((int) $storagePid, 0);

        return true;
    }

    /**
     * Return matching uid of Solr core depending on the input value.
     *
     * @access protected
     *
     * @param array $solrCores array of the valid Solr cores
     * @param string|bool|null $inputSolrId possible uid or name of Solr core
     *
     * @return int matching uid of Solr core
     */
    protected function getSolrCoreUid(array $solrCores, $inputSolrId): int
    {
        if (MathUtility::canBeInterpretedAsInteger($inputSolrId)) {
            $solrCoreUid = MathUtility::forceIntegerInRange((int) $inputSolrId, 0);
        } else {
            $solrCoreUid = $solrCores[$inputSolrId];
        }
        return $solrCoreUid;
    }

    /**
     * Fetches all Solr cores on given page.
     *
     * @access protected
     *
     * @param int $pageId The UID of the Solr core or 0 to disable indexing
     *
     * @return array Array of valid Solr cores
     */
    protected function getSolrCores(int $pageId): array
    {
        $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
            ->getQueryBuilderForTable('tx_dlf_solrcores');

        $solrCores = [];
        $result = $queryBuilder
            ->select('uid', 'index_name')
            ->from('tx_dlf_solrcores')
            ->where(
                $queryBuilder->expr()->eq(
                    'pid',
                    $queryBuilder->createNamedParameter((int) $pageId, Connection::PARAM_INT)
                )
            )
            ->execute();

        while ($record = $result->fetchAssociative()) {
            $solrCores[$record['index_name']] = $record['uid'];
        }

        return $solrCores;
    }

    /**
     * Update or insert document to database
     *
     * @access protected
     *
     * @param Document $document The document instance
     *
     * @return bool true on success, false otherwise
     */
    protected function saveToDatabase(Document $document): bool
    {
        $doc = $document->getCurrentDocument();
        if ($doc === null) {
            return false;
        }
        $persistenceManager = GeneralUtility::makeInstance(PersistenceManager::class);
        $doc->cPid = $this->storagePid;

        $metadata = $doc->getToplevelMetadata($this->storagePid);

        // set title data
        $document->setTitle($metadata['title'][0] ? : '');
        $document->setTitleSorting($metadata['title_sorting'][0] ? : '');
        $document->setPlace(implode('; ', $metadata['place']));
        $document->setYear(implode('; ', $metadata['year']));

        // Remove appended "valueURI" from authors' names for storing in database.
        foreach ($metadata['author'] as $i => $author) {
            $splitName = explode(chr(31), $author);
            $metadata['author'][$i] = $splitName[0];
        }
        $document->setAuthor($this->getAuthors($metadata['author']));
        $document->setThumbnail($doc->thumbnail ? : '');
        $document->setMetsLabel($metadata['mets_label'][0] ? : '');
        $document->setMetsOrderlabel($metadata['mets_orderlabel'][0] ? : '');

        $structure = $this->structureRepository->findOneByIndexName($metadata['type'][0]);
        $structure = $this->structureRepository->findOneByIndexName($metadata['type'][0]);
        $document->setStructure($structure);

        if (is_array($metadata['collection'])) {
            $this->addCollections($document, $metadata['collection'], $persistenceManager);
        }

        // set identifiers
        $document->setProdId($metadata['prod_id'][0] ? : '');
        $document->setOpacId($metadata['opac_id'][0] ? : '');
        $document->setUnionId($metadata['union_id'][0] ? : '');

        $document->setRecordId($metadata['record_id'][0] ? : ''); // (?) $doc->recordId
        $document->setUrn($metadata['urn'][0] ? : '');
        $document->setPurl($metadata['purl'][0] ? : '');
        $document->setDocumentFormat($metadata['document_format'][0] ? : '');

        // set access
        $document->setLicense($metadata['license'][0] ? : '');
        $document->setTerms($metadata['terms'][0] ? : '');
        $document->setRestrictions($metadata['restrictions'][0] ? : '');
        $document->setOutOfPrint($metadata['out_of_print'][0] ? : '');
        $document->setRightsInfo($metadata['rights_info'][0] ? : '');
        $document->setStatus(0);

        $this->setOwner($metadata['owner'][0]);
        $document->setOwner($this->owner);

        // set volume data
        $document->setVolume($metadata['volume'][0] ? : '');
        $document->setVolumeSorting($metadata['volume_sorting'][0] ? : $metadata['mets_order'][0] ? : '');

        // Get UID of parent document.
        if ($document->getDocumentFormat() === 'METS') {
            $document->setPartof($this->getParentDocumentUidForSaving($document));
        }

        if ($document->getUid() === null) {
            // new document
            $this->documentRepository->add($document);
        } else {
            // update of existing document
            $this->documentRepository->update($document);
        }

        $persistenceManager->persistAll();

        return true;
    }

    /**
     * Get the ID of the parent document if the current document has one.
     * Currently only applies to METS documents.
     *
     * @access protected
     *
     * @param Document $document for which parent UID should be taken
     *
     * @return int The parent document's id.
     */
    protected function getParentDocumentUidForSaving(Document $document): int
    {
        $doc = $document->getCurrentDocument();

        if ($doc !== null && !empty($doc->parentHref)) {

            // find document object by record_id of parent
            $parent = AbstractDocument::getInstance($doc->parentHref, ['storagePid' => $this->storagePid]);

            if ($parent->recordId) {
                $parentDocument = $this->documentRepository->findOneByRecordId($parent->recordId);
                $parentDocument = $this->documentRepository->findOneByRecordId($parent->recordId);

                if ($parentDocument === null) {
                    // create new Document object
                    $parentDocument = GeneralUtility::makeInstance(Document::class);
                }

                $parentDocument->setOwner($this->owner);
                                 setOwner($this->owner);
                $parentDocument->setCurrentDocument($parent);
                                 setCurrentDocument($parent);
                $parentDocument->setLocation($doc->parentHref);
                                 setLocation($doc->parentHref);
                $parentDocument->setSolrcore($document->getSolrcore());
                                 setSolrcore($document->getSolrcore());

                $success = $this->saveToDatabase($parentDocument);

                if ($success === true) {
                    // add to index
                    Indexer::add($parentDocument, $this->documentRepository);
                    return $parentDocument->getUid();
                    return $parentDocument->/** @scrutinizer ignore-call */ getUid();
                }
            }
        }

        return 0;
    }

    /**
     * Add collections.
     *
     * @access private
     * 
     * @param Document &$document
     * @param array $collections
     * @param PersistenceManager $persistenceManager
     *
     * @return void
     */
    private function addCollections(Document &$document, array $collections, PersistenceManager $persistenceManager): void
    {
        foreach ($collections as $collection) {
            $documentCollection = $this->collectionRepository->findOneByIndexName($collection);
            $documentCollection = $this->collectionRepository->findOneByIndexName($collection);
            if (!$documentCollection) {
                // create new Collection object
                $documentCollection = GeneralUtility::makeInstance(Collection::class);
                $documentCollection->setIndexName($collection);
                $documentCollection->setLabel($collection);
                $documentCollection->setOaiName((!empty($this->extConf['publishNewCollections']) ? Helper::getCleanString($collection) : ''));
                $documentCollection->setIndexSearch('');
                $documentCollection->setDescription('');
                // add to CollectionRepository
                $this->collectionRepository->add($documentCollection);
                // persist collection to prevent duplicates
                $persistenceManager->persistAll();
            }
            // add to document
            $document->addCollection($documentCollection);
        }
    }

    /**
     * Get authors considering that database field can't accept
     * more than 255 characters.
     *
     * @access private
     * 
     * @param array $metadataAuthor
     *
     * @return string
     */
    private function getAuthors(array $metadataAuthor): string
    {
        $authors = '';
        $delimiter = '; ';
        $ellipsis = 'et al.';

        $count = count($metadataAuthor);

        for ($i = 0; $i < $count; $i++) {
            // Build the next part to add
            $nextPart = ($i === 0 ? '' : $delimiter) . $metadataAuthor[$i];
            // Check if adding this part and ellipsis in future would exceed the character limit
            if (strlen($authors . $nextPart . $delimiter . $ellipsis) > 255) {
                // Add ellipsis and stop adding more authors
                $authors .= $delimiter . $ellipsis;
                break;
            }
            // Add the part to the main string
            $authors .= $nextPart;
        }

        return $authors;
    }

    /**
     * If owner is not set set but found by metadata, take it or take default library, if nothing found in database then create new owner.
     *
     * @access private
     *
     * @param ?string $owner
     *
     * @return void
     */
    private function setOwner($owner): void
    {
        if (empty($this->owner)) {
            // owner is not set set but found by metadata --> take it or take default library
            $owner = $owner ? : 'default';
            $this->owner = $this->libraryRepository->findOneByIndexName($owner);
            $this->owner = $this->libraryRepository->findOneByIndexName($owner);
            if (empty($this->owner)) {
                // create library
                $this->owner = GeneralUtility::makeInstance(Library::class);
                $this->owner->setLabel($owner);
                              setLabel($owner);
                $this->owner->setIndexName($owner);
                $this->libraryRepository->add($this->owner);
            }
        }
    }
}

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Push — master ( 83566b...c23467 )

BaseCommand::getSolrCores() A

Complexity

Size

Duplication

Importance

kitodo / kitodo-presentation

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Push — master ( 83566b...c23467 )

BaseCommand::getSolrCores() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
