Kitodo\Dlf\Plugin\Tools\ImageDownloadTool::main()

Complexity

Conditions	9
Paths	17

Size

Total Lines	35
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function main($content, $conf) {
        $this->init($conf);
        // Merge configuration with conf array of toolbox.
        $this->conf = \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($this->cObj->data['conf'], $this->conf);

It seems like $this->conf can also be of type null; however, parameter $overrule of TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule() does only seem to accept array, maybe add an additional type check?

Are you sure the assignment to $this->conf is correct as TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($this->cObj->data['conf'], $this->conf) targeting TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule() seems to always return null.

        // Load current document.
        $this->loadDocument();
        if ($this->doc === NULL
            || $this->doc->numPages < 1

The property $numPages is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            || empty($this->conf['fileGrpsImageDownload'])) {
            // Quit without doing anything if required variables are not set.
            return $content;
        } else {
            if (!empty($this->piVars['logicalPage'])) {
                $this->piVars['page'] = $this->doc->getPhysicalPage($this->piVars['logicalPage']);
                // The logical page parameter should not appear again
                unset($this->piVars['logicalPage']);
            }
            // Set default values if not set.
            // $this->piVars['page'] may be integer or string (physical structure @ID)
            if ((int) $this->piVars['page'] > 0
                || empty($this->piVars['page'])) {
                $this->piVars['page'] = \TYPO3\CMS\Core\Utility\MathUtility::forceIntegerInRange((int) $this->piVars['page'], 1, $this->doc->numPages, 1);
            } else {
                $this->piVars['page'] = array_search($this->piVars['page'], $this->doc->physicalStructure);

The property $physicalStructure is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            }
            $this->piVars['double'] = \TYPO3\CMS\Core\Utility\MathUtility::forceIntegerInRange($this->piVars['double'], 0, 1, 0);
        }
        // Load template file.
        $this->getTemplate();
        // Get left or single page download.
        $markerArray['###IMAGE_LEFT###'] = $this->piVars['double'] == 1 ? $this->getImage($this->piVars['page'], $this->pi_getLL('leftPage', '')) : $this->getImage($this->piVars['page'], $this->pi_getLL('singlePage', ''));

$markerArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $markerArray = array(); before regardless.

        // Get right page download.
        $markerArray['###IMAGE_RIGHT###'] = $this->piVars['double'] == 1 ? $this->getImage($this->piVars['page'] + 1, $this->pi_getLL('rightPage', '')) : '';
        $content .= $this->cObj->substituteMarkerArray($this->template, $markerArray);

The function TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::substituteMarkerArray() has been deprecated: since TYPO3 v8, will be removed in TYPO3 v9, please use the MarkerBasedTemplateService instead.

        return $this->pi_wrapInBaseClass($content);
    }