kitloong / laravel-migrations-generator

src/KitLoong/MigrationsGenerator/Generators/Modifier/DefaultModifier.php

<?php
/**
 * Created by PhpStorm.
 * User: liow.kitloong
 * Date: 2020/03/31
 */

namespace KitLoong\MigrationsGenerator\Generators\Modifier;

use Doctrine\DBAL\Schema\Column;
use KitLoong\MigrationsGenerator\Generators\BooleanField;
use KitLoong\MigrationsGenerator\Generators\DatetimeField;
use KitLoong\MigrationsGenerator\Generators\Decorator;
use KitLoong\MigrationsGenerator\MigrationMethod\ColumnModifier;
use KitLoong\MigrationsGenerator\Types\DBALTypes;

class DefaultModifier
{
    private $booleanField;
    private $datetimeField;
    private $decorator;

    public function __construct(BooleanField $booleanField, DatetimeField $datetimeField, Decorator $decorator)
    {
        $this->booleanField = $booleanField;
        $this->datetimeField = $datetimeField;
        $this->decorator = $decorator;
    }

    /**
     * @param  string  $dbalType
     * @param  Column  $column
     * @return string
     */
    public function generate(string $dbalType, Column $column): string
    {
        switch ($dbalType) {
            case DBALTypes::SMALLINT:
            case DBALTypes::INTEGER:
            case DBALTypes::BIGINT:
            case DBALTypes::MEDIUMINT:
            case DBALTypes::TINYINT:
            case DBALTypes::DECIMAL:
            case DBALTypes::FLOAT:
            case DBALTypes::DOUBLE:
                $default = $column->getDefault();
                break;
            case DBALTypes::BOOLEAN:
                $default = $this->booleanField->makeDefault($column);
                break;
            case DBALTypes::DATETIME_MUTABLE:
            case DBALTypes::TIMESTAMP:
                return $this->datetimeField->makeDefault($column);
            default:
                $default = $this->decorator->columnDefaultToString($column->getDefault());

It seems like $column->getDefault() can also be of type null; however, parameter $args of KitLoong\MigrationsGenerator\Generators\Decorator::columnDefaultToString() does only seem to accept string, maybe add an additional type check?

        }

        return $this->decorator->decorate(ColumnModifier::DEFAULT, [$default]);
    }
}