StringField::makeField() - Code Metrics - Inspection of "Fixed failed tests" - kitloong/laravel-migrations-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/collation ( 3fa00f )

by Kit Loong

created 2020-12-31 08:59 UTC

StringField::makeField() B

↳ Parent: StringField

Complexity

Conditions	8
Paths	10

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	8
eloc	13
c	2
b	0
f	0
nc	10
nop	3
dl	0
loc	22
rs	8.4444

<?php
/**
 * Created by PhpStorm.
 * User: liow.kitloong
 * Date: 2020/03/29
 */

namespace KitLoong\MigrationsGenerator\Generators;

use Doctrine\DBAL\Schema\Column;
use Illuminate\Database\Schema\Builder;
use KitLoong\MigrationsGenerator\Generators\Modifier\CollationModifier;
use KitLoong\MigrationsGenerator\MigrationMethod\ColumnName;
use KitLoong\MigrationsGenerator\MigrationMethod\ColumnType;

class StringField
{
    private $collationModifier;

    public function __construct(CollationModifier $collationModifier)
    {
        $this->collationModifier = $collationModifier;
    }

    public function makeField(string $tableName, array $field, Column $column): array
    {
        if ($field['field'] === ColumnName::REMEMBER_TOKEN && $column->getLength() === 100 && !$column->getFixed()) {
            $field['type'] = ColumnType::REMEMBER_TOKEN;
            $field['field'] = null;
            $field['args'] = [];
        } else {
            if ($column->getFixed()) {
                $field['type'] = ColumnType::CHAR;
            }

            if ($column->getLength() && $column->getLength() !== Builder::$defaultStringLength) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                $field['args'][] = $column->getLength();
            }
        }

        $collation = $this->collationModifier->generate($tableName, $column);
        if ($collation !== '') {
            $field['decorators'][] = $collation;
        }

        return $field;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: liow.kitloong
5			* Date: 2020/03/29
6			*/
7
8			namespace KitLoong\MigrationsGenerator\Generators;
9
10			use Doctrine\DBAL\Schema\Column;
11			use Illuminate\Database\Schema\Builder;
12			use KitLoong\MigrationsGenerator\Generators\Modifier\CollationModifier;
13			use KitLoong\MigrationsGenerator\MigrationMethod\ColumnName;
14			use KitLoong\MigrationsGenerator\MigrationMethod\ColumnType;
15
16			class StringField
17			{
18			private $collationModifier;
19
20			public function __construct(CollationModifier $collationModifier)
21			{
22			$this->collationModifier = $collationModifier;
23			}
24
25			public function makeField(string $tableName, array $field, Column $column): array
26			{
27			if ($field['field'] === ColumnName::REMEMBER_TOKEN && $column->getLength() === 100 && !$column->getFixed()) {
28			$field['type'] = ColumnType::REMEMBER_TOKEN;
29			$field['field'] = null;
30			$field['args'] = [];
31			} else {
32			if ($column->getFixed()) {
33			$field['type'] = ColumnType::CHAR;
34			}
35
36			if ($column->getLength() && $column->getLength() !== Builder::$defaultStringLength) {
			0 ignored issues – show Bug Best Practice introduced 2020-04-08 15:12 UTC by Report Bug Copy Issue Report The expression `$column->getLength()` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
37			$field['args'][] = $column->getLength();
38			}
39			}
40
41			$collation = $this->collationModifier->generate($tableName, $column);
42			if ($collation !== '') {
43			$field['decorators'][] = $collation;
44			}
45
46			return $field;
47			}
48			}
49

kitloong / laravel-migrations-generator

Push — feature/collation ( 3fa00f )

StringField::makeField() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like