Issues in Plugin.php (master) - Issues in master - kint-php/kint - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1165)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Renderer/Rich/Plugin.php (23 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

abstract class Kint_Renderer_Rich_Plugin

{
    protected $renderer;

    public function __construct(Kint_Renderer_Rich $r)

    {
        $this->renderer = $r;
    }

    /**
     * Renders a locked header.
     *
     * This is a placeholder until Kint 3 when it can be renamed to
     * renderLockedHeader after the deprecated static method is removed
     */
    public function renderHeaderLocked(Kint_Object $o, $content)

    {
        $header = '<dt class="kint-parent kint-locked">';

        if (Kint_Renderer_Rich::$access_paths && $o->depth > 0 && $ap = $o->getAccessPath()) {

            $header .= '<span class="kint-access-path-trigger" title="Show access path">&rlarr;</span>';
        }

        $header .= '<span class="kint-popup-trigger" title="Open in new window">&rarr;</span><nav></nav>';

        if (($s = $o->getModifiers()) !== null) {

            $header .= '<var>'.$s.'</var> ';
        }

        if (($s = $o->getName()) !== null) {

            $header .= '<dfn>'.$this->renderer->escape($s).'</dfn> ';

            if ($s = $o->getOperator()) {
                $header .= $this->renderer->escape($s, 'ASCII').' ';
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        if (($s = $o->getType()) !== null) {
            $s = $this->renderer->escape($s);

            if ($o->reference) {
                $s = '&amp;'.$s;
            }

            $header .= '<var>'.$s.'</var> ';
        }

        if (($s = $o->getSize()) !== null) {

            $header .= '('.$this->renderer->escape($s).') ';
        }

        $header .= $content;

        if (!empty($ap)) {
            $header .= '<div class="access-path">'.$this->renderer->escape($ap).'</div>';
        }

        return $header.'</dt>';
    }

    public static function renderLockedHeader(Kint_Object $o, $content)

    {
        static $show_dep = true;

        if ($show_dep) {

            trigger_error('Kint_Renderer_Rich_Plugin::renderLockedHeader() is deprecated and will be removed in Kint 3.0. Use renderHeaderLocked instead.', KINT_PHP53 ? E_USER_DEPRECATED : E_USER_NOTICE);
            $show_dep = false;

        }

        $header = '<dt class="kint-parent kint-locked">';

        if (Kint_Renderer_Rich::$access_paths && $o->depth > 0 && $ap = $o->getAccessPath()) {

            $header .= '<span class="kint-access-path-trigger" title="Show access path">&rlarr;</span>';
        }

        $header .= '<span class="kint-popup-trigger" title="Open in new window">&rarr;</span><nav></nav>';

        if (($s = $o->getModifiers()) !== null) {

            $header .= '<var>'.$s.'</var> ';
        }

        if (($s = $o->getName()) !== null) {

            $header .= '<dfn>'.Kint_Object_Blob::escape($s).'</dfn> ';

            if ($s = $o->getOperator()) {
                $header .= Kint_Object_Blob::escape($s, 'ASCII').' ';
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        if (($s = $o->getType()) !== null) {

            $s = Kint_Object_Blob::escape($s);

            if ($o->reference) {
                $s = '&amp;'.$s;
            }

            $header .= '<var>'.$s.'</var> ';
        }

        if (($s = $o->getSize()) !== null) {

            $header .= '('.Kint_Object_Blob::escape($s).') ';
        }

        $header .= $content;

        if (!empty($ap)) {
            $header .= '<div class="access-path">'.Kint_Object_Blob::escape($ap).'</div>';
        }

        return $header.'</dt>';
    }

    abstract public function render($o);

}


1		<?php
2
3		abstract class Kint_Renderer_Rich_Plugin
		0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `Kint_Renderer_Rich_Plugin` does not seem to conform to the naming convention (`^[A-Z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `Kint_Renderer_Rich_Plugin` does not seem to conform to the naming convention (`^Abstract\|Factory$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
4		{
5		protected $renderer;
6
7		public function __construct(Kint_Renderer_Rich $r)
		0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $r. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
8		{
9		$this->renderer = $r;
10		}
11
12		/**
13		* Renders a locked header.
14		*
15		* This is a placeholder until Kint 3 when it can be renamed to
16		* renderLockedHeader after the deprecated static method is removed
17		*/
18		public function renderHeaderLocked(Kint_Object $o, $content)
		0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $o. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
19		{
20		$header = '<dt class="kint-parent kint-locked">';
21
22	View Code Duplication	if (Kint_Renderer_Rich::$access_paths && $o->depth > 0 && $ap = $o->getAccessPath()) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $ap. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
23		$header .= '<span class="kint-access-path-trigger" title="Show access path">&rlarr;</span>';
24		}
25
26		$header .= '<span class="kint-popup-trigger" title="Open in new window">→</span><nav></nav>';
27
28		if (($s = $o->getModifiers()) !== null) {
		0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $s. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
29		$header .= '<var>'.$s.'</var> ';
30		}
31
32	View Code Duplication	if (($s = $o->getName()) !== null) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		$header .= '<dfn>'.$this->renderer->escape($s).'</dfn> ';
34
35		if ($s = $o->getOperator()) {
36		$header .= $this->renderer->escape($s, 'ASCII').' ';
		0 ignored issues – show Documentation introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ASCII'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		}
38		}
39
40		if (($s = $o->getType()) !== null) {
41		$s = $this->renderer->escape($s);
42
43		if ($o->reference) {
44		$s = '&'.$s;
45		}
46
47		$header .= '<var>'.$s.'</var> ';
48		}
49
50	View Code Duplication	if (($s = $o->getSize()) !== null) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		$header .= '('.$this->renderer->escape($s).') ';
52		}
53
54		$header .= $content;
55
56		if (!empty($ap)) {
57		$header .= '<div class="access-path">'.$this->renderer->escape($ap).'</div>';
58		}
59
60		return $header.'</dt>';
61		}
62
63		public static function renderLockedHeader(Kint_Object $o, $content)
		0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $o. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
64		{
65		static $show_dep = true;
66
67	View Code Duplication	if ($show_dep) {
		0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$show_dep` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		trigger_error('Kint_Renderer_Rich_Plugin::renderLockedHeader() is deprecated and will be removed in Kint 3.0. Use renderHeaderLocked instead.', KINT_PHP53 ? E_USER_DEPRECATED : E_USER_NOTICE);
69		$show_dep = false;
		0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$show_dep` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
70		}
71
72		$header = '<dt class="kint-parent kint-locked">';
73
74	View Code Duplication	if (Kint_Renderer_Rich::$access_paths && $o->depth > 0 && $ap = $o->getAccessPath()) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $ap. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
75		$header .= '<span class="kint-access-path-trigger" title="Show access path">&rlarr;</span>';
76		}
77
78		$header .= '<span class="kint-popup-trigger" title="Open in new window">→</span><nav></nav>';
79
80		if (($s = $o->getModifiers()) !== null) {
		0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $s. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
81		$header .= '<var>'.$s.'</var> ';
82		}
83
84	View Code Duplication	if (($s = $o->getName()) !== null) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		$header .= '<dfn>'.Kint_Object_Blob::escape($s).'</dfn> ';
86
87		if ($s = $o->getOperator()) {
88		$header .= Kint_Object_Blob::escape($s, 'ASCII').' ';
		0 ignored issues – show Documentation introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ASCII'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89		}
90		}
91
92	View Code Duplication	if (($s = $o->getType()) !== null) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		$s = Kint_Object_Blob::escape($s);
94
95		if ($o->reference) {
96		$s = '&'.$s;
97		}
98
99		$header .= '<var>'.$s.'</var> ';
100		}
101
102	View Code Duplication	if (($s = $o->getSize()) !== null) {
		0 ignored issues – show Duplication introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		$header .= '('.Kint_Object_Blob::escape($s).') ';
104		}
105
106		$header .= $content;
107
108		if (!empty($ap)) {
109		$header .= '<div class="access-path">'.Kint_Object_Blob::escape($ap).'</div>';
110		}
111
112		return $header.'</dt>';
113		}
114
115		abstract public function render($o);
		0 ignored issues – show Documentation introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history... Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $o. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
116		}
117

kint-php / kint

Issues (1165)

Security Analysis no request data

src/Renderer/Rich/Plugin.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like