kint-php / kint

src/Parser/ClassStatics.php

<?php

class Kint_Parser_ClassStatics extends Kint_Parser_Plugin

Kint_Parser_ClassStatics does not seem to conform to the naming convention (^[A-Z][a-zA-Z0-9]*$).

{
    private static $cache = array();

    public function getTypes()
    {
        return array('object');
    }

    public function getTriggers()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return Kint_Parser::TRIGGER_SUCCESS;
    }

    public function parse(&$var, Kint_Object &$o, $trigger)

Avoid variables with short names like $o. Configured minimum length is 3.

    {
        $class = get_class($var);
        $reflection = new ReflectionClass($class);

        // Constants
        // TODO: PHP 7.1 allows private consts but reflection doesn't have a way to check them yet
        if (!isset(self::$cache[$class])) {
            $consts = array();

            foreach ($reflection->getConstants() as $name => $val) {
                $const = Kint_Object::blank($name);
                $const->const = true;
                $const->depth = $o->depth + 1;
                $const->owner_class = $class;
                if (KINT_PHP53) {

This code seems to be duplicated across your project.

                    $const->access_path = '\\'.$class.'::'.$const->name;
                } else {
                    $const->access_path = $class.'::'.$const->name;
                }
                $const->operator = Kint_Object::OPERATOR_STATIC;
                $const = $this->parser->parse($val, $const);

                $consts[] = $const;
            }

            self::$cache[$class] = $consts;
        }

        $statics = new Kint_Object_Representation('Static class properties', 'statics');
        $statics->contents = self::$cache[$class];

        // Statics

        if (!KINT_PHP53) {
            $static_map = $reflection->getStaticProperties();

$static_map does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        foreach ($reflection->getProperties(ReflectionProperty::IS_STATIC) as $static) {
            $prop = new Kint_Object();
            $prop->name = '$'.$static->getName();
            $prop->depth = $o->depth + 1;
            $prop->static = true;
            $prop->operator = Kint_Object::OPERATOR_STATIC;

            if (KINT_PHP53) {
                $prop->owner_class = $static->getDeclaringClass()->name;
            } else {
                // getDeclaringClass() is broke in old PHP versions, but getProperties() will only
                // return accessible properties and we can access them through the parent class so
                // we can just put the parent class here. It's not an accurate portrayal of where
                // the static comes from, but it shows a working access path so it's good enough
                $prop->owner_class = $class;
            }

            $prop->access = Kint_Object::ACCESS_PUBLIC;
            if ($static->isProtected()) {

This code seems to be duplicated across your project.

                $prop->access = Kint_Object::ACCESS_PROTECTED;
            } elseif ($static->isPrivate()) {
                $prop->access = Kint_Object::ACCESS_PRIVATE;
            }

            if ($this->parser->childHasPath($o, $prop)) {

$o of type object<Kint_Object> is not a sub-type of object<Kint_Object_Instance>. It seems like you assume a child class of the class Kint_Object to be always present.

                if (KINT_PHP53) {

This code seems to be duplicated across your project.

                    $prop->access_path = '\\'.$prop->owner_class.'::'.$prop->name;
                } else {
                    $prop->access_path = $prop->owner_class.'::'.$prop->name;
                }
            }

            if (KINT_PHP53) {
                $static->setAccessible(true);
                $val = $static->getValue();
            } else {
                switch ($prop->access) {
                    case Kint_Object::ACCESS_PUBLIC:
                        $val = $static_map[$static->getName()];

$static_map does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The variable $static_map does not seem to be defined for all execution paths leading up to this point.

                        break;
                    case Kint_Object::ACCESS_PROTECTED:
                        $val = $static_map["\0*\0".$static->getName()];

$static_map does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        break;
                    case Kint_Object::ACCESS_PRIVATE:
                        $val = $static_map["\0".$class."\0".$static->getName()];

$static_map does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        break;
                }
            }

            $statics->contents[] = $this->parser->parse($val, $prop);
        }

        if (empty($statics->contents)) {
            return;
        }

        usort($statics->contents, array('Kint_Parser_ClassStatics', 'sort'));

        $o->addRepresentation($statics);
    }

    private static function sort(Kint_Object $a, Kint_Object $b)

Avoid variables with short names like $a. Configured minimum length is 3.

Avoid variables with short names like $b. Configured minimum length is 3.

    {
        $sort = ((int) $a->const) - ((int) $b->const);
        if ($sort) {
            return $sort;
        }

        $sort = Kint_Object::sortByAccess($a, $b);
        if ($sort) {
            return $sort;
        }

        return Kint_Object_Instance::sortByHierarchy($a->owner_class, $b->owner_class);
    }
}