Kint_Parser_Blacklist

Complexity

Total Complexity

10

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getTypes()	0	4	1
A	getTriggers()	0	4	1
B	parse()	0	18	6
B	blacklist()	8	25	2

<?php

class Kint_Parser_Blacklist extends Kint_Parser_Plugin

Kint_Parser_Blacklist does not seem to conform to the naming convention (^[A-Z][a-zA-Z0-9]*$).

The property $shallow_blacklist is not named in camelCase.

{
    /**
     * List of classes and interfaces to blacklist.
     *
     * @var array
     */
    public static $blacklist = array();

    /**
     * List of classes and interfaces to blacklist except when dumped directly.
     *
     * @var array
     */
    public static $shallow_blacklist = array();

$shallow_blacklist does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    public function getTypes()
    {
        return array('object');
    }

    public function getTriggers()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return Kint_Parser::TRIGGER_BEGIN;
    }

    public function parse(&$var, Kint_Object &$o, $trigger)

Avoid variables with short names like $o. Configured minimum length is 3.

    {
        foreach (self::$blacklist as $class) {
            if ($var instanceof $class) {
                return $this->blacklist($var, $o);
            }
        }

        if ($o->depth <= 0) {
            return;
        }

        foreach (self::$shallow_blacklist as $class) {
            if ($var instanceof $class) {
                return $this->blacklist($var, $o);
            }
        }
    }

    protected function blacklist(&$var, &$o)

Avoid variables with short names like $o. Configured minimum length is 3.

    {
        if (function_exists('spl_object_hash')) {

This code seems to be duplicated across your project.

            $hash = spl_object_hash($var);
        } else {
            ob_start();
            var_dump($var);

var_dump($var); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

            preg_match('/#(\d+)/', ob_get_clean(), $match);
            $hash = $match[1];
        }

        $object = $o->transplant(new Kint_Object_Instance());
        $object->classname = get_class($var);
        $object->hash = $hash;
        $object->clearRepresentations();
        $object->value = null;
        $object->size = null;
        $object->hints[] = 'blacklist';

        $o = $object;

        $this->parser->haltParse();

        return;
    }
}