Kint_Object_Representation_Source

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	getSource()	0	11	3

<?php

class Kint_Object_Representation_Source extends Kint_Object_Representation

Kint_Object_Representation_Source does not seem to conform to the naming convention (^[A-Z][a-zA-Z0-9]*$).

{
    public $name = 'source';
    public $label = 'Source';
    public $hints = array('source');
    public $source = array();
    public $filename = null;
    public $line = 0;

    public function __construct($filename, $line, $padding = 7)
    {
        $this->filename = $filename;
        $this->line = $line;

        $start_line = max($line - $padding, 1);

$start_line does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $length = $line + $padding + 1 - $start_line;

$start_line does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->source = self::getSource($filename, $start_line, $length);

$start_line does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like self::getSource($filename, $start_line, $length) can also be of type false. However, the property $source is declared as type array. Maybe add an additional type check?

        if ($this->source !== false) {
            $this->contents = implode("\n", $this->source);

It seems like implode(' ', $this->source) of type string is incompatible with the declared type array of property $contents.

        }
    }

    /**
     * Gets section of source code.
     *
     * @param string   $filename   Full path to file
     * @param int      $start_line The first line to display (1 based)
     * @param int|null $length     Amount of lines to show
     *
     * @return bool|array

Consider making the return type a bit more specific; maybe use false|array.

     */
    public static function getSource($filename, $start_line = 1, $length = null)

$start_line does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The parameter $start_line is not named in camelCase.

    {
        if (!$filename or !is_readable($filename)) {
            return false;
        }
        $source = preg_split("/\r\n|\n|\r/", file_get_contents($filename));
        $source = array_combine(range(1, count($source)), $source);
        $source = array_slice($source, $start_line - 1, $length, true);

$start_line does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        return $source;
    }
}