DataMutator::setIndexed() - Code Metrics - Inspection of "feat: add sub-path support to mutator and retrieve..." - kingsquare/communibase-databag - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#12)

by Misha

created 2020-10-25 22:44 UTC

DataMutator::setIndexed() B

↳ Parent: DataMutator

Complexity

Conditions	10
Paths	54

Size

Total Lines	35
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	20
c	1
b	0
f	0
nc	54
nop	4
dl	0
loc	35
rs	7.6666

How to fix Complexity

<?php

declare(strict_types=1);

namespace Communibase\DataBag;

final class DataMutator
{
    /**
     * @var array<string,array>
     */
    private $data;

    /**
     * @param mixed $value
     */
    public function setByPath(array &$data, string $path, $value): void
    {
        $this->data = &$data;

        [$entityType, $path] = explode('.', $path, 2);

        // Direct property
        if (strpos($path, '.') === false) {
            $data[$entityType][$path] = $value;
            return;
        }

        [$path, $index] = explode('.', $path, 2);

        // Sub-path
        if (!is_numeric($index) && strpos($index, '.') === false && !$this->isAssocativeArray($value)) {
            $this->data[$entityType][$path][$index] = $value;
            return;
        }

        $this->setIndexed($entityType, $path, $index, $value);
    }

    /**
     * @param mixed $value
     */
    private function setIndexed(string $entityType, string $path, string $index, $value): void
    {
        $field = null;
        if (strpos($index, '.') > 0) {
            [$index, $field] = explode('.', $index, 2);
        }

        $targetIndex = $index;
        if (!is_numeric($targetIndex)) {
            if (\is_array($value)) {
                $value['type'] = $targetIndex;
            }
            $targetIndex = null;
            if (isset($this->data[$entityType][$path])) {
                foreach ((array)$this->data[$entityType][$path] as $nodeIndex => $node) {
                    if (isset($node['type']) && $node['type'] === $index) {
                        $targetIndex = $nodeIndex;
                        break;
                    }
                }
            }
        }

        // No index found, new entry
        if ($targetIndex === null) {
            $this->addNewEntry($entityType, $path, $field, $index, $value);
            return;
        }

        // Use found index
        if ($field === null) {
            $this->data[$entityType][$path][$targetIndex] = $value;
            return;
        }
        $this->data[$entityType][$path][$targetIndex][$field] = $value;
    }

    /**
     * @param mixed $value
     */
    private function addNewEntry(string $entityType, string $path, ?string $field, string $target, $value): void
    {
        if ($field === null) {
            $this->data[$entityType][$path][] = $value;
            return;
        }
        $value = [
            $field => $value
        ];
        if (!is_numeric($target)) {
            $value['type'] = $target;
        }
        $this->data[$entityType][$path][] = $value;
    }

    /**
     * @param mixed $value
     */
    private function isAssocativeArray($value): bool
    {
        return \is_array($value) && (array_keys($value) !== range(0, \count($value) - 1));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Communibase\DataBag;
6
7			final class DataMutator
8			{
9			/**
10			* @var array<string,array>
11			*/
12			private $data;
13
14			/**
15			* @param mixed $value
16			*/
17			public function setByPath(array &$data, string $path, $value): void
18			{
19			$this->data = &$data;
20
21			[$entityType, $path] = explode('.', $path, 2);
22
23			// Direct property
24			if (strpos($path, '.') === false) {
25			$data[$entityType][$path] = $value;
26			return;
27			}
28
29			[$path, $index] = explode('.', $path, 2);
30
31			// Sub-path
32			if (!is_numeric($index) && strpos($index, '.') === false && !$this->isAssocativeArray($value)) {
33			$this->data[$entityType][$path][$index] = $value;
34			return;
35			}
36
37			$this->setIndexed($entityType, $path, $index, $value);
38			}
39
40			/**
41			* @param mixed $value
42			*/
43			private function setIndexed(string $entityType, string $path, string $index, $value): void
44			{
45			$field = null;
46			if (strpos($index, '.') > 0) {
47			[$index, $field] = explode('.', $index, 2);
48			}
49
50			$targetIndex = $index;
51			if (!is_numeric($targetIndex)) {
52			if (\is_array($value)) {
53			$value['type'] = $targetIndex;
54			}
55			$targetIndex = null;
56			if (isset($this->data[$entityType][$path])) {
57			foreach ((array)$this->data[$entityType][$path] as $nodeIndex => $node) {
58			if (isset($node['type']) && $node['type'] === $index) {
59			$targetIndex = $nodeIndex;
60			break;
61			}
62			}
63			}
64			}
65
66			// No index found, new entry
67			if ($targetIndex === null) {
68			$this->addNewEntry($entityType, $path, $field, $index, $value);
69			return;
70			}
71
72			// Use found index
73			if ($field === null) {
74			$this->data[$entityType][$path][$targetIndex] = $value;
75			return;
76			}
77			$this->data[$entityType][$path][$targetIndex][$field] = $value;
78			}
79
80			/**
81			* @param mixed $value
82			*/
83			private function addNewEntry(string $entityType, string $path, ?string $field, string $target, $value): void
84			{
85			if ($field === null) {
86			$this->data[$entityType][$path][] = $value;
87			return;
88			}
89			$value = [
90			$field => $value
91			];
92			if (!is_numeric($target)) {
93			$value['type'] = $target;
94			}
95			$this->data[$entityType][$path][] = $value;
96			}
97
98			/**
99			* @param mixed $value
100			*/
101			private function isAssocativeArray($value): bool
102			{
103			return \is_array($value) && (array_keys($value) !== range(0, \count($value) - 1));
104			}
105			}
106

kingsquare / communibase-databag

Pull Request — master (#12)

DataMutator::setIndexed() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like