Complex classes like Connector often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Connector, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class Connector implements ConnectorInterface |
||
| 23 | { |
||
| 24 | /** |
||
| 25 | * The official service URI; can be overridden via the constructor |
||
| 26 | * |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | const SERVICE_PRODUCTION_URL = 'https://api.communibase.nl/0.1/'; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * The API key which is to be used for the api. |
||
| 33 | * Is required to be set via the constructor. |
||
| 34 | * |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | private $apiKey; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * The url which is to be used for this connector. Defaults to the production url. |
||
| 41 | * Can be set via the constructor. |
||
| 42 | * |
||
| 43 | * @var string |
||
| 44 | */ |
||
| 45 | private $serviceUrl; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var array of extra headers to send with each request |
||
| 49 | */ |
||
| 50 | private $extraHeaders = []; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var QueryLogger |
||
| 54 | */ |
||
| 55 | private $logger; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var ClientInterface |
||
| 59 | */ |
||
| 60 | private $client; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Create a new Communibase Connector instance based on the given api-key and possible serviceUrl |
||
| 64 | * |
||
| 65 | * @param string $apiKey The API key for Communibase |
||
| 66 | * @param string $serviceUrl The Communibase API endpoint; defaults to self::SERVICE_PRODUCTION_URL |
||
| 67 | * @param ClientInterface $client An optional GuzzleHttp Client (or Interface for mocking) |
||
| 68 | */ |
||
| 69 | public function __construct( |
||
| 70 | $apiKey, |
||
| 71 | $serviceUrl = self::SERVICE_PRODUCTION_URL, |
||
| 72 | ClientInterface $client = null |
||
| 73 | ) { |
||
| 74 | $this->apiKey = $apiKey; |
||
| 75 | $this->serviceUrl = $serviceUrl; |
||
| 76 | $this->client = $client; |
||
| 77 | } |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Returns an array that has all the fields according to the definition in Communibase. |
||
| 81 | * |
||
| 82 | * @param string $entityType |
||
| 83 | * |
||
| 84 | * @return array |
||
| 85 | * |
||
| 86 | * @throws Exception |
||
| 87 | */ |
||
| 88 | public function getTemplate($entityType) |
||
| 89 | { |
||
| 90 | $params = [ |
||
| 91 | 'fields' => 'attributes.title', |
||
| 92 | 'limit' => 1, |
||
| 93 | ]; |
||
| 94 | $definition = $this->search('EntityType', ['title' => $entityType], $params); |
||
| 95 | |||
| 96 | return array_fill_keys(array_merge(['_id'], array_column($definition[0]['attributes'], 'title')), null); |
||
| 97 | } |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Get a single Entity by its id |
||
| 101 | * |
||
| 102 | * @param string $entityType |
||
| 103 | * @param string $id |
||
| 104 | * @param array $params (optional) |
||
| 105 | * @param string|null $version |
||
| 106 | * |
||
| 107 | * @return array entity |
||
| 108 | * |
||
| 109 | * @throws Exception |
||
| 110 | */ |
||
| 111 | public function getById($entityType, $id, array $params = [], $version = null) |
||
| 112 | { |
||
| 113 | if (empty($id)) { |
||
| 114 | throw new Exception('Id is empty'); |
||
| 115 | } |
||
| 116 | |||
| 117 | if (!static::isIdValid($id)) { |
||
| 118 | throw new Exception('Id is invalid, please use a correctly formatted id'); |
||
| 119 | } |
||
| 120 | |||
| 121 | return ($version === null) |
||
| 122 | ? $this->doGet($entityType . '.json/crud/' . $id, $params) |
||
| 123 | : $this->doGet($entityType . '.json/history/' . $id . '/' . $version, $params); |
||
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Get a single Entity by a ref-string |
||
| 128 | * |
||
| 129 | * @todo if the ref is a parent.parent.parent the code would need further improvement. |
||
| 130 | * |
||
| 131 | * @param array $ref |
||
| 132 | * @param array $parentEntity (optional) |
||
| 133 | * |
||
| 134 | * @return array the referred Entity data |
||
| 135 | * |
||
| 136 | * @throws Exception |
||
| 137 | */ |
||
| 138 | public function getByRef(array $ref, array $parentEntity = []) |
||
| 139 | { |
||
| 140 | $document = $parentEntity; |
||
| 141 | if (strpos($ref['rootDocumentEntityType'], 'parent') === false) { |
||
| 142 | if (empty($document['_id']) || $document['_id'] !== $ref['rootDocumentId']) { |
||
| 143 | $document = $this->getById($ref['rootDocumentEntityType'], $ref['rootDocumentId']); |
||
| 144 | } |
||
| 145 | |||
| 146 | if (count($document) === 0) { |
||
| 147 | throw new Exception('Invalid document reference (document cannot be found by Id)'); |
||
| 148 | } |
||
| 149 | } |
||
| 150 | |||
| 151 | $container = $document; |
||
| 152 | foreach ($ref['path'] as $pathInDocument) { |
||
| 153 | if (!array_key_exists($pathInDocument['field'], $container)) { |
||
| 154 | throw new Exception('Could not find the path in document'); |
||
| 155 | } |
||
| 156 | $container = $container[$pathInDocument['field']]; |
||
| 157 | if (empty($pathInDocument['objectId'])) { |
||
| 158 | continue; |
||
| 159 | } |
||
| 160 | |||
| 161 | if (!is_array($container)) { |
||
| 162 | throw new Exception('Invalid value for path in document'); |
||
| 163 | } |
||
| 164 | $result = array_filter($container, function ($item) use ($pathInDocument) { |
||
| 165 | return $item['_id'] === $pathInDocument['objectId']; |
||
| 166 | }); |
||
| 167 | if (count($result) === 0) { |
||
| 168 | throw new Exception('Empty result of reference'); |
||
| 169 | } |
||
| 170 | $container = reset($result); |
||
| 171 | } |
||
| 172 | return $container; |
||
| 173 | } |
||
| 174 | |||
| 175 | /** |
||
| 176 | * Get an array of entities by their ids |
||
| 177 | * |
||
| 178 | * @param string $entityType |
||
| 179 | * @param array $ids |
||
| 180 | * @param array $params (optional) |
||
| 181 | * |
||
| 182 | * @return array entities |
||
| 183 | * |
||
| 184 | * @throws Exception |
||
| 185 | */ |
||
| 186 | public function getByIds($entityType, array $ids, array $params = []) |
||
| 187 | { |
||
| 188 | $validIds = array_values(array_unique(array_filter($ids, [__CLASS__, 'isIdValid']))); |
||
| 189 | |||
| 190 | if (count($validIds) === 0) { |
||
| 191 | return []; |
||
| 192 | } |
||
| 193 | |||
| 194 | $doSortByIds = empty($params['sort']); |
||
| 195 | $results = $this->search($entityType, ['_id' => ['$in' => $validIds]], $params); |
||
| 196 | if (!$doSortByIds) { |
||
| 197 | return $results; |
||
| 198 | } |
||
| 199 | |||
| 200 | $flipped = array_flip($validIds); |
||
| 201 | foreach ($results as $result) { |
||
| 202 | $flipped[$result['_id']] = $result; |
||
| 203 | } |
||
| 204 | return array_filter(array_values($flipped), function ($result) { |
||
| 205 | return is_array($result) && count($result) > 0; |
||
| 206 | }); |
||
| 207 | |||
| 208 | } |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Get all entities of a certain type |
||
| 212 | * |
||
| 213 | * @param string $entityType |
||
| 214 | * @param array $params (optional) |
||
| 215 | * |
||
| 216 | * @return array|null |
||
| 217 | * |
||
| 218 | * @throws Exception |
||
| 219 | */ |
||
| 220 | public function getAll($entityType, array $params = []) |
||
| 221 | { |
||
| 222 | return $this->doGet($entityType . '.json/crud/', $params); |
||
| 223 | } |
||
| 224 | |||
| 225 | /** |
||
| 226 | * Get result entityIds of a certain search |
||
| 227 | * |
||
| 228 | * @param string $entityType |
||
| 229 | * @param array $selector (optional) |
||
| 230 | * @param array $params (optional) |
||
| 231 | * |
||
| 232 | * @return array |
||
| 233 | * |
||
| 234 | * @throws Exception |
||
| 235 | */ |
||
| 236 | public function getIds($entityType, array $selector = [], array $params = []) |
||
| 237 | { |
||
| 238 | $params['fields'] = '_id'; |
||
| 239 | |||
| 240 | return array_column($this->search($entityType, $selector, $params), '_id'); |
||
| 241 | } |
||
| 242 | |||
| 243 | /** |
||
| 244 | * Get the id of an entity based on a search |
||
| 245 | * |
||
| 246 | * @param string $entityType i.e. Person |
||
| 247 | * @param array $selector (optional) i.e. ['firstName' => 'Henk'] |
||
| 248 | * |
||
| 249 | * @return array resultData |
||
| 250 | * |
||
| 251 | * @throws Exception |
||
| 252 | */ |
||
| 253 | public function getId($entityType, array $selector = []) |
||
| 254 | { |
||
| 255 | $params = ['limit' => 1]; |
||
| 256 | $ids = (array)$this->getIds($entityType, $selector, $params); |
||
| 257 | |||
| 258 | return array_shift($ids); |
||
| 259 | } |
||
| 260 | |||
| 261 | /** |
||
| 262 | * Call the aggregate endpoint with a given set of pipeline definitions: |
||
| 263 | * E.g. [ |
||
| 264 | * { "$match": { "_id": {"$ObjectId": "52f8fb85fae15e6d0806e7c7"} } }, |
||
| 265 | * { "$unwind": "$participants" }, |
||
| 266 | * { "$group": { "_id": "$_id", "participantCount": { "$sum": 1 } } } |
||
| 267 | * ] |
||
| 268 | * |
||
| 269 | * @see http://docs.mongodb.org/manual/core/aggregation-pipeline/ |
||
| 270 | * |
||
| 271 | * @param $entityType |
||
| 272 | * @param array $pipeline |
||
| 273 | * @return array |
||
| 274 | * |
||
| 275 | * @throws Exception |
||
| 276 | */ |
||
| 277 | public function aggregate($entityType, array $pipeline) |
||
| 278 | { |
||
| 279 | return $this->doPost($entityType . '.json/aggregate', [], $pipeline); |
||
| 280 | } |
||
| 281 | |||
| 282 | /** |
||
| 283 | * Returns an array of the history for the entity with the following format: |
||
| 284 | * |
||
| 285 | * <code> |
||
| 286 | * [ |
||
| 287 | * [ |
||
| 288 | * 'updatedBy' => '', // name of the user |
||
| 289 | * 'updatedAt' => '', // a string according to the DateTime::ISO8601 format |
||
| 290 | * '_id' => '', // the ID of the entity which can ge fetched separately |
||
| 291 | * ], |
||
| 292 | * ... |
||
| 293 | * ] |
||
| 294 | * </code> |
||
| 295 | * |
||
| 296 | * @param string $entityType |
||
| 297 | * @param string $id |
||
| 298 | * |
||
| 299 | * @return array |
||
| 300 | * |
||
| 301 | * @throws Exception |
||
| 302 | */ |
||
| 303 | public function getHistory($entityType, $id) |
||
| 304 | { |
||
| 305 | return $this->doGet($entityType . '.json/history/' . $id); |
||
| 306 | } |
||
| 307 | |||
| 308 | /** |
||
| 309 | * Search for the given entity by optional passed selector/params |
||
| 310 | * |
||
| 311 | * @param string $entityType |
||
| 312 | * @param array $querySelector |
||
| 313 | * @param array $params (optional) |
||
| 314 | * |
||
| 315 | * @return array |
||
| 316 | * |
||
| 317 | * @throws Exception |
||
| 318 | */ |
||
| 319 | public function search($entityType, array $querySelector, array $params = []) |
||
| 320 | { |
||
| 321 | return $this->doPost($entityType . '.json/search', $params, $querySelector); |
||
| 322 | } |
||
| 323 | |||
| 324 | /** |
||
| 325 | * This will save an entity in Communibase. When a _id-field is found, this entity will be updated |
||
| 326 | * |
||
| 327 | * NOTE: When updating, depending on the Entity, you may need to include all fields. |
||
| 328 | * |
||
| 329 | * @param string $entityType |
||
| 330 | * @param array $properties - the to-be-saved entity data |
||
| 331 | * |
||
| 332 | * @return array resultData |
||
| 333 | * |
||
| 334 | * @throws Exception |
||
| 335 | */ |
||
| 336 | public function update($entityType, array $properties) |
||
| 337 | { |
||
| 338 | if (empty($properties['_id'])) { |
||
| 339 | return $this->doPost($entityType . '.json/crud/', [], $properties); |
||
| 340 | } |
||
| 341 | return $this->doPut($entityType . '.json/crud/' . $properties['_id'], [], $properties); |
||
| 342 | } |
||
| 343 | |||
| 344 | /** |
||
| 345 | * Finalize an invoice by adding an invoiceNumber to it. |
||
| 346 | * Besides, invoice items will receive a 'generalLedgerAccountNumber'. |
||
| 347 | * This number will be unique and sequential within the 'daybook' of the invoice. |
||
| 348 | * |
||
| 349 | * NOTE: this is Invoice specific |
||
| 350 | * |
||
| 351 | * @param string $entityType |
||
| 352 | * @param string $id |
||
| 353 | * |
||
| 354 | * @return array |
||
| 355 | * |
||
| 356 | * @throws Exception |
||
| 357 | */ |
||
| 358 | public function finalize($entityType, $id) |
||
| 366 | |||
| 367 | /** |
||
| 368 | * Delete something from Communibase |
||
| 369 | * |
||
| 370 | * @param string $entityType |
||
| 371 | * @param string $id |
||
| 372 | * |
||
| 373 | * @return array resultData |
||
| 374 | * |
||
| 375 | * @throws Exception |
||
| 376 | */ |
||
| 377 | public function destroy($entityType, $id) |
||
| 381 | |||
| 382 | /** |
||
| 383 | * Get the binary contents of a file by its ID |
||
| 384 | * |
||
| 385 | * NOTE: for meta-data like filesize and mimetype, one can use the getById()-method. |
||
| 386 | * |
||
| 387 | * @param string $id id string for the file-entity |
||
| 388 | * |
||
| 389 | * @return StreamInterface Binary contents of the file. |
||
| 390 | * Since the stream can be made a string this works like a charm! |
||
| 391 | * |
||
| 392 | * @throws Exception |
||
| 393 | */ |
||
| 394 | public function getBinary($id) |
||
| 402 | |||
| 403 | /** |
||
| 404 | * Uploads the contents of the resource (this could be a file handle) to Communibase |
||
| 405 | * |
||
| 406 | * @param StreamInterface $resource |
||
| 407 | * @param string $name |
||
| 408 | * @param string $destinationPath |
||
| 409 | * @param string $id |
||
| 410 | * |
||
| 411 | * @return array|mixed |
||
| 412 | * |
||
| 413 | * @throws \RuntimeException | Exception |
||
| 414 | */ |
||
| 415 | public function updateBinary(StreamInterface $resource, $name, $destinationPath, $id = '') |
||
| 450 | |||
| 451 | /** |
||
| 452 | * Perform the actual GET |
||
| 453 | * |
||
| 454 | * @param string $path |
||
| 455 | * @param array $params |
||
| 456 | * @param array $data |
||
| 457 | * |
||
| 458 | * @return array |
||
| 459 | * |
||
| 460 | * @throws Exception |
||
| 461 | */ |
||
| 462 | protected function doGet($path, array $params = null, array $data = null) |
||
| 466 | |||
| 467 | /** |
||
| 468 | * Perform the actual POST |
||
| 469 | * |
||
| 470 | * @param string $path |
||
| 471 | * @param array $params |
||
| 472 | * @param array $data |
||
| 473 | * |
||
| 474 | * @return array |
||
| 475 | * |
||
| 476 | * @throws Exception |
||
| 477 | */ |
||
| 478 | protected function doPost($path, array $params = null, array $data = null) |
||
| 482 | |||
| 483 | /** |
||
| 484 | * Perform the actual PUT |
||
| 485 | * |
||
| 486 | * @param string $path |
||
| 487 | * @param array $params |
||
| 488 | * @param array $data |
||
| 489 | * |
||
| 490 | * @return array |
||
| 491 | * |
||
| 492 | * @throws Exception |
||
| 493 | */ |
||
| 494 | protected function doPut($path, array $params = null, array $data = null) |
||
| 498 | |||
| 499 | /** |
||
| 500 | * Perform the actual DELETE |
||
| 501 | * |
||
| 502 | * @param string $path |
||
| 503 | * @param array $params |
||
| 504 | * @param array $data |
||
| 505 | * |
||
| 506 | * @return array |
||
| 507 | * |
||
| 508 | * @throws Exception |
||
| 509 | */ |
||
| 510 | protected function doDelete($path, array $params = null, array $data = null) |
||
| 514 | |||
| 515 | /** |
||
| 516 | * Process the request |
||
| 517 | * |
||
| 518 | * @param string $method |
||
| 519 | * @param string $path |
||
| 520 | * @param array $params |
||
| 521 | * @param array $data |
||
| 522 | * |
||
| 523 | * @return array i.e. [success => true|false, [errors => ['message' => 'this is broken', ..]]] |
||
| 524 | * |
||
| 525 | * @throws Exception |
||
| 526 | */ |
||
| 527 | protected function getResult($method, $path, array $params = null, array $data = null) |
||
| 528 | { |
||
| 529 | if ($params === null) { |
||
| 530 | $params = []; |
||
| 531 | } |
||
| 532 | $options = [ |
||
| 533 | 'query' => $this->preParseParams($params), |
||
| 534 | ]; |
||
| 535 | if (is_array($data) && count($data) > 0) { |
||
| 536 | $options['json'] = $data; |
||
| 537 | } |
||
| 538 | |||
| 539 | $response = $this->call($method, [$path, $options]); |
||
| 540 | |||
| 541 | $responseData = $this->parseResult($response->getBody(), $response->getStatusCode()); |
||
| 542 | |||
| 543 | if ($response->getStatusCode() !== 200) { |
||
| 544 | throw new Exception( |
||
| 545 | $responseData['message'], |
||
| 546 | $responseData['code'], |
||
| 547 | null, |
||
| 548 | (($_ =& $responseData['errors']) ?: []) |
||
| 549 | ); |
||
| 550 | } |
||
| 551 | |||
| 552 | return $responseData; |
||
| 553 | } |
||
| 554 | |||
| 555 | /** |
||
| 556 | * @param array $params |
||
| 557 | * |
||
| 558 | * @return mixed |
||
| 559 | */ |
||
| 560 | private function preParseParams(array $params) |
||
| 586 | |||
| 587 | /** |
||
| 588 | * Parse the Communibase result and if necessary throw an exception |
||
| 589 | * |
||
| 590 | * @param string $response |
||
| 591 | * @param int $httpCode |
||
| 592 | * |
||
| 593 | * @return array |
||
| 594 | * |
||
| 595 | * @throws Exception |
||
| 596 | */ |
||
| 597 | private function parseResult($response, $httpCode) |
||
| 607 | |||
| 608 | /** |
||
| 609 | * Error message based on the most recent JSON error. |
||
| 610 | * |
||
| 611 | * @see http://nl1.php.net/manual/en/function.json-last-error.php |
||
| 612 | * |
||
| 613 | * @return string |
||
| 614 | */ |
||
| 615 | private function getLastJsonError() |
||
| 628 | |||
| 629 | /** |
||
| 630 | * Verify the given $id is a valid Communibase string according to format |
||
| 631 | * |
||
| 632 | * @param string $id |
||
| 633 | * |
||
| 634 | * @return bool |
||
| 635 | */ |
||
| 636 | public static function isIdValid($id) |
||
| 648 | |||
| 649 | /** |
||
| 650 | * Generate a Communibase compatible ID, that consists of: |
||
| 651 | * |
||
| 652 | * a 4-byte timestamp, |
||
| 653 | * a 3-byte machine identifier, |
||
| 654 | * a 2-byte process id, and |
||
| 655 | * a 3-byte counter, starting with a random value. |
||
| 656 | * |
||
| 657 | * @return string |
||
| 658 | */ |
||
| 659 | public static function generateId() |
||
| 676 | |||
| 677 | /** |
||
| 678 | * Add extra headers to be added to each request |
||
| 679 | * |
||
| 680 | * @see http://php.net/manual/en/function.header.php |
||
| 681 | * |
||
| 682 | * @param array $extraHeaders |
||
| 683 | */ |
||
| 684 | public function addExtraHeaders(array $extraHeaders) |
||
| 688 | |||
| 689 | /** |
||
| 690 | * @param QueryLogger $logger |
||
| 691 | */ |
||
| 692 | public function setQueryLogger(QueryLogger $logger) |
||
| 696 | |||
| 697 | /** |
||
| 698 | * @return QueryLogger |
||
| 699 | */ |
||
| 700 | public function getQueryLogger() |
||
| 704 | |||
| 705 | /** |
||
| 706 | * @return ClientInterface |
||
| 707 | * |
||
| 708 | * @throws Exception |
||
| 709 | */ |
||
| 710 | protected function getClient() |
||
| 731 | |||
| 732 | /** |
||
| 733 | * Perform the actual call to Communibase |
||
| 734 | * |
||
| 735 | * @param string $method |
||
| 736 | * @param array $arguments |
||
| 737 | * |
||
| 738 | * @return \Psr\Http\Message\ResponseInterface |
||
| 739 | * |
||
| 740 | * @throws Exception |
||
| 741 | */ |
||
| 742 | private function call($method, array $arguments) |
||
| 788 | } |
||
| 789 |