Groundskeeper\Tokens\Elements\Dfn

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	44 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	removeInvalidChildren()	0	10	3
A	removeInvalidSelf()	11	11	2

<?php

namespace Groundskeeper\Tokens\Elements;

use Groundskeeper\Tokens\ElementTypes\FlowContent;
use Groundskeeper\Tokens\ElementTypes\InlineElement;
use Groundskeeper\Tokens\ElementTypes\OpenElement;
use Groundskeeper\Tokens\ElementTypes\PhrasingContent;
use Groundskeeper\Tokens\NonParticipating;
use Groundskeeper\Tokens\Token;
use Psr\Log\LoggerInterface;

/**
 * "dfn" element
 *
 * https://html.spec.whatwg.org/multipage/semantics.html#the-dfn-element
 */
class Dfn extends OpenElement implements FlowContent, PhrasingContent, InlineElement
{
    protected function removeInvalidChildren(LoggerInterface $logger)
    {
        // There must be no dfn element descendants.
        foreach ($this->children as $child) {
            if ($child instanceof Dfn) {
                $logger->debug('Removing ' . $child . '. Element "dfn" cannot contain "dfn" elements.');
                $this->removeChild($child);
            }
        }
    }

    protected function removeInvalidSelf(LoggerInterface $logger)

This method seems to be duplicated in your project.

    {
        $dfn = new self($this->configuration);

The call to Dfn::__construct() misses a required argument $name.

        if ($this->hasAncestor($dfn)) {
            $logger->debug('Removing ' . $child . '. Element "dfn" cannot contain "dfn" elements.');

The variable $child does not exist. Did you forget to declare it?

            return true;
        }

        return false;
    }
}