Completed
Push — master ( 64950e...559766 )
by Kevin
03:41
created

AbstractToken::getLine()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 1

Importance

Changes 1
Bugs 0 Features 1
Metric Value
c 1
b 0
f 1
dl 0
loc 4
ccs 2
cts 2
cp 1
rs 10
cc 1
eloc 2
nc 1
nop 0
crap 1
1
<?php
2
3
namespace Groundskeeper\Tokens;
4
5
use Groundskeeper\Configuration;
6
use Psr\Log\LoggerInterface;
7
8
/**
9
 * A base class for all tokens.
10
 */
11
abstract class AbstractToken implements Token
12
{
13
    /** @var Configuration */
14
    protected $configuration;
15
16
    /** @var int */
17
    private $depth;
18
19
    /** @var int */
20
    private $line;
21
22
    /** @var null|Token */
23
    private $parent;
24
25
    /** @var int */
26
    private $position;
27
28
    /**
29
     * Constructor
30
     */
31 146
    public function __construct(Configuration $configuration, $line, $position)
32
    {
33 146
        $this->configuration = $configuration;
34 146
        $this->depth = 0;
35 146
        $this->line = $line;
36 146
        $this->parent = null;
37 146
        $this->position = $position;
38 146
    }
39
40
    /**
41
     * Required by the Token interface.
42
     */
43 101
    public function getDepth()
44
    {
45 101
        return $this->depth;
46
    }
47
48
    /**
49
     * Getter for 'line'.
50
     */
51 71
    public function getLine()
52
    {
53 71
        return $this->line;
54
    }
55
56
    /**
57
     * Required by the Token interface.
58
     */
59 60
    public function getParent()
60
    {
61 60
        return $this->parent;
62
    }
63
64
    /**
65
     * Chainable setter for 'parent'.
66
     */
67 100
    public function setParent(Token $parent = null)
68
    {
69 100
        $this->depth = 0;
70 100
        if ($parent instanceof Token) {
71 100
            $this->depth = $parent->getDepth() + 1;
72 100
        }
73
74 100
        $this->parent = $parent;
75
76 100
        return $this;
77
    }
78
79 14
    public function hasAncestor(Element $element)
80
    {
81 14
        if ($this->parent === null) {
82 12
            return false;
83
        }
84
85 13
        if ($this->parent->getType() == Token::ELEMENT &&
86 13
            $this->parent->getName() == $element->getName()) {
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface Groundskeeper\Tokens\Token as the method getName() does only exist in the following implementations of said interface: Groundskeeper\Tokens\Element, Groundskeeper\Tokens\ElementTypes\ClosedElement, Groundskeeper\Tokens\ElementTypes\OpenElement, Groundskeeper\Tokens\Elements\A, Groundskeeper\Tokens\Elements\Abbr, Groundskeeper\Tokens\Elements\Address, Groundskeeper\Tokens\Elements\Area, Groundskeeper\Tokens\Elements\Article, Groundskeeper\Tokens\Elements\Aside, Groundskeeper\Tokens\Elements\Audio, Groundskeeper\Tokens\Elements\B, Groundskeeper\Tokens\Elements\Base, Groundskeeper\Tokens\Elements\Bdi, Groundskeeper\Tokens\Elements\Bdo, Groundskeeper\Tokens\Elements\Blockquote, Groundskeeper\Tokens\Elements\Body, Groundskeeper\Tokens\Elements\Br, Groundskeeper\Tokens\Elements\Button, Groundskeeper\Tokens\Elements\Canvas, Groundskeeper\Tokens\Elements\Caption, Groundskeeper\Tokens\Elements\Cite, Groundskeeper\Tokens\Elements\Code, Groundskeeper\Tokens\Elements\Col, Groundskeeper\Tokens\Elements\Colgroup, Groundskeeper\Tokens\Elements\Data, Groundskeeper\Tokens\Elements\Datalist, Groundskeeper\Tokens\Elements\Dd, Groundskeeper\Tokens\Elements\Del, Groundskeeper\Tokens\Elements\Details, Groundskeeper\Tokens\Elements\Dfn, Groundskeeper\Tokens\Elements\Dialog, Groundskeeper\Tokens\Elements\Div, Groundskeeper\Tokens\Elements\Dl, Groundskeeper\Tokens\Elements\Dt, Groundskeeper\Tokens\Elements\Em, Groundskeeper\Tokens\Elements\Embed, Groundskeeper\Tokens\Elements\Fieldset, Groundskeeper\Tokens\Elements\Figcaption, Groundskeeper\Tokens\Elements\Figure, Groundskeeper\Tokens\Elements\Footer, Groundskeeper\Tokens\Elements\Form, Groundskeeper\Tokens\Elements\H1, Groundskeeper\Tokens\Elements\H2, Groundskeeper\Tokens\Elements\H3, Groundskeeper\Tokens\Elements\H4, Groundskeeper\Tokens\Elements\H5, Groundskeeper\Tokens\Elements\H6, Groundskeeper\Tokens\Elements\Head, Groundskeeper\Tokens\Elements\Header, Groundskeeper\Tokens\Elements\Hgroup, Groundskeeper\Tokens\Elements\Hr, Groundskeeper\Tokens\Elements\Html, Groundskeeper\Tokens\Elements\I, Groundskeeper\Tokens\Elements\Iframe, Groundskeeper\Tokens\Elements\Img, Groundskeeper\Tokens\Elements\Input, Groundskeeper\Tokens\Elements\Ins, Groundskeeper\Tokens\Elements\Kbd, Groundskeeper\Tokens\Elements\Label, Groundskeeper\Tokens\Elements\Legend, Groundskeeper\Tokens\Elements\Li, Groundskeeper\Tokens\Elements\Link, Groundskeeper\Tokens\Elements\Main, Groundskeeper\Tokens\Elements\Map, Groundskeeper\Tokens\Elements\Mark, Groundskeeper\Tokens\Elements\Menu, Groundskeeper\Tokens\Elements\Menuitem, Groundskeeper\Tokens\Elements\Meta, Groundskeeper\Tokens\Elements\Meter, Groundskeeper\Tokens\Elements\Nav, Groundskeeper\Tokens\Elements\Noscript, Groundskeeper\Tokens\Elements\Object, Groundskeeper\Tokens\Elements\Ol, Groundskeeper\Tokens\Elements\Optgroup, Groundskeeper\Tokens\Elements\Option, Groundskeeper\Tokens\Elements\Output, Groundskeeper\Tokens\Elements\P, Groundskeeper\Tokens\Elements\Param, Groundskeeper\Tokens\Elements\Picture, Groundskeeper\Tokens\Elements\Pre, Groundskeeper\Tokens\Elements\Progress, Groundskeeper\Tokens\Elements\Q, Groundskeeper\Tokens\Elements\Rp, Groundskeeper\Tokens\Elements\Rt, Groundskeeper\Tokens\Elements\Ruby, Groundskeeper\Tokens\Elements\S, Groundskeeper\Tokens\Elements\Samp, Groundskeeper\Tokens\Elements\Script, Groundskeeper\Tokens\Elements\Section, Groundskeeper\Tokens\Elements\Select, Groundskeeper\Tokens\Elements\Slot, Groundskeeper\Tokens\Elements\Small, Groundskeeper\Tokens\Elements\Source, Groundskeeper\Tokens\Elements\Span, Groundskeeper\Tokens\Elements\Strong, Groundskeeper\Tokens\Elements\Style, Groundskeeper\Tokens\Elements\Sub, Groundskeeper\Tokens\Elements\Summary, Groundskeeper\Tokens\Elements\Sup, Groundskeeper\Tokens\Elements\Table, Groundskeeper\Tokens\Elements\Tbody, Groundskeeper\Tokens\Elements\Td, Groundskeeper\Tokens\Elements\Template, Groundskeeper\Tokens\Elements\Textarea, Groundskeeper\Tokens\Elements\Tfoot, Groundskeeper\Tokens\Elements\Th, Groundskeeper\Tokens\Elements\Thead, Groundskeeper\Tokens\Elements\Time, Groundskeeper\Tokens\Elements\Title, Groundskeeper\Tokens\Elements\Tr, Groundskeeper\Tokens\Elements\Track, Groundskeeper\Tokens\Elements\U, Groundskeeper\Tokens\Elements\Ul, Groundskeeper\Tokens\Elements\VarElement, Groundskeeper\Tokens\Elements\Video, Groundskeeper\Tokens\Elements\Wbr.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
87 7
            return true;
88
        }
89
90 11
        return $this->parent->hasAncestor($element);
91
    }
92
93
    /**
94
     * Getter for 'position'.
95
     */
96 71
    public function getPosition()
97
    {
98 71
        return $this->position;
99
    }
100
101 109
    public static function cleanChildTokens(Configuration $configuration, array &$children, LoggerInterface $logger)
102
    {
103 109
        if ($configuration->get('clean-strategy') == Configuration::CLEAN_STRATEGY_NONE) {
104 96
            return true;
105
        }
106
107 108
        foreach ($children as $key => $child) {
108 104
            if ($child instanceof Cleanable) {
109 98
                $isClean = $child->clean($logger);
110 98
                if (!$isClean && $configuration->get('clean-strategy') !== Configuration::CLEAN_STRATEGY_LENIENT) {
111 23
                    unset($children[$key]);
112 23
                }
113 98
            }
114 108
        }
115
116 108
        return true;
117
    }
118
119
    abstract public function getType();
120
121 12
    public function __toString()
122
    {
123 12
        return ucfirst($this->getType()) . ' (line: ' . $this->line .
124 12
            '; position: ' . $this->position . ')';
125
    }
126
}
127