1 | <?php |
||
11 | abstract class AbstractToken implements Token |
||
12 | { |
||
13 | /** @var Configuration */ |
||
14 | protected $configuration; |
||
15 | |||
16 | /** @var int */ |
||
17 | private $depth; |
||
18 | |||
19 | /** @var null|Token */ |
||
20 | private $parent; |
||
21 | |||
22 | /** @var string */ |
||
23 | private $type; |
||
24 | |||
25 | /** |
||
26 | * Constructor |
||
27 | */ |
||
28 | 84 | public function __construct($type, Configuration $configuration) |
|
29 | { |
||
30 | 1 | if ($type !== Token::CDATA |
|
31 | 84 | && $type !== Token::COMMENT |
|
32 | 84 | && $type !== Token::DOCTYPE |
|
33 | 84 | && $type !== Token::ELEMENT |
|
34 | 84 | && $type !== Token::TEXT) { |
|
35 | 1 | throw new \InvalidArgumentException('Invalid type: ' . $type); |
|
36 | } |
||
37 | |||
38 | 83 | $this->configuration = $configuration; |
|
39 | 83 | $this->depth = 0; |
|
40 | 83 | $this->parent = null; |
|
41 | 83 | $this->type = $type; |
|
42 | 83 | } |
|
43 | |||
44 | /** |
||
45 | * Required by the Token interface. |
||
46 | */ |
||
47 | 59 | public function getDepth() |
|
51 | |||
52 | /** |
||
53 | * Required by the Token interface. |
||
54 | */ |
||
55 | 34 | public function getParent() |
|
59 | |||
60 | /** |
||
61 | * Chainable setter for 'parent'. |
||
62 | */ |
||
63 | 58 | public function setParent(Token $parent = null) |
|
74 | |||
75 | 3 | public function hasAncestor(Element $element) |
|
76 | { |
||
77 | 3 | if ($this->parent === null) { |
|
78 | 1 | return false; |
|
79 | } |
||
80 | |||
81 | 3 | if ($this->parent->getType() == Token::ELEMENT && |
|
82 | 3 | $this->parent->getName() == $element->getName()) { |
|
|
|||
83 | 2 | return true; |
|
84 | } |
||
85 | |||
86 | 1 | return $this->parent->hasAncestor($element); |
|
87 | } |
||
88 | |||
89 | /** |
||
90 | * Required by the Token interface. |
||
91 | */ |
||
92 | 46 | public function getType() |
|
96 | |||
97 | 64 | public static function cleanChildTokens(Configuration $configuration, array &$children, LoggerInterface $logger) |
|
115 | |||
116 | 5 | public function __toString() |
|
120 | } |
||
121 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: