Completed
Push — master ( 0490e0...5154b1 )
by Kevin
03:30
created

Hgroup   A

Complexity

Total Complexity 13

Size/Duplication

Total Lines 41
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 100%

Importance

Changes 4
Bugs 1 Features 2
Metric Value
wmc 13
c 4
b 1
f 2
lcom 1
cbo 2
dl 0
loc 41
ccs 24
cts 24
cp 1
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
C removeInvalidChildren() 0 24 10
A removeInvalidSelf() 0 13 3
1
<?php
2
3
namespace Groundskeeper\Tokens\Elements;
4
5
use Groundskeeper\Tokens\ElementTypes\FlowContent;
6
use Groundskeeper\Tokens\ElementTypes\HeadingContent;
7
use Groundskeeper\Tokens\ElementTypes\OpenElement;
8
use Groundskeeper\Tokens\NonParticipating;
9
use Psr\Log\LoggerInterface;
10
11
/**
12
 * "hgroup" element
13
 *
14
 * https://html.spec.whatwg.org/multipage/semantics.html#the-hgroup-element
15
 */
16
class Hgroup extends OpenElement implements FlowContent, HeadingContent
17
{
18 2
    protected function removeInvalidChildren(LoggerInterface $logger)
19
    {
20
        // One or more "h1", "h2", "h3", "h4", "h5", "h6", and
0 ignored issues
show
Unused Code Comprehensibility introduced by
54% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
21
        // "template" elements required.
22 2
        $headingContentElementCount = 0;
0 ignored issues
show
Unused Code introduced by
$headingContentElementCount is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
23 2
        foreach ($this->children as $child) {
24 2
            if ($child instanceof NonParticipating) {
25 1
                continue;
26
            }
27
28 2
            if (!$child instanceof H1 &&
29 2
                !$child instanceof H2 &&
30 2
                !$child instanceof H3 &&
31 2
                !$child instanceof H4 &&
32 2
                !$child instanceof H5 &&
33 2
                !$child instanceof H6 &&
34 2
                !$child instanceof Tempate) {
0 ignored issues
show
Bug introduced by
The class Groundskeeper\Tokens\Elements\Tempate does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
35 1
                $logger->debug('Removing ' .  $child . '. Only "h1"-"h6" and "template" elements allowed as child of "hgroup" element.');
36 1
                $this->removeChild($child);
37
38 1
                continue;
39
            }
40 2
        }
41 2
    }
42
43 3
    protected function removeInvalidSelf(LoggerInterface $logger)
44
    {
45 3
        foreach ($this->children as $child) {
46 3
            if ($child instanceof HeadingContent) {
47 2
                return false;
48
            }
49 3
        }
50
51
        // Handle no child HeadingContent.
52 1
        $logger->debug('Removing ' . $this . '. Must contain at least one of the following elements: "h1", "h2", "h3", "h4", "h5", "h6", or "template".');
53
54 1
        return true;
55
    }
56
}
57