Body - Code Metrics - Inspection of "Added Null Object pattern for logger. Added tests..." - kevintweber/Groundskeeper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a17ead...35004c )

by Kevin

created 2016-05-04 01:42 UTC

Body A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

17.24%

Importance

Changes	3
Bugs	0	Features	3

Metric	Value
wmc	5
c	3
b	0
f	3
lcom	0
cbo	3
dl	7
loc	42
ccs	5
cts	29
cp	0.1724
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getAllowedAttributes()	0	25	1
A	doClean()	7	13	4

How to fix Duplicated Code

<?php

namespace Groundskeeper\Tokens\Elements;

use Groundskeeper\Tokens\Element;
use Groundskeeper\Tokens\ElementTypes\OpenElement;
use Groundskeeper\Tokens\ElementTypes\SectioningRoot;
use Groundskeeper\Tokens\Token;
use Psr\Log\LoggerInterface;

class Body extends OpenElement implements SectioningRoot
{
    protected function getAllowedAttributes()
    {
        $bodyAllowedAttributes = array(
            '/^onafterprint$/i' => Element::ATTR_JS,
            '/^onbeforeprint$/i' => Element::ATTR_JS,
            '/^onbeforeunload$/i' => Element::ATTR_JS,
            '/^onhashchange$/i' => Element::ATTR_JS,
            '/^onlanguagechange$/i' => Element::ATTR_JS,
            '/^onmessage$/i' => Element::ATTR_JS,
            '/^onoffline$/i' => Element::ATTR_JS,
            '/^ononline$/i' => Element::ATTR_JS,
            '/^onpagehide$/i' => Element::ATTR_JS,
            '/^onpageshow$/i' => Element::ATTR_JS,
            '/^onpopstate$/i' => Element::ATTR_JS,
            '/^onrejectionhandled$/i' => Element::ATTR_JS,
            '/^onstorage$/i' => Element::ATTR_JS,
            '/^onunhandledrejection$/i' => Element::ATTR_JS,
            '/^onunload$/i' => Element::ATTR_JS
        );

        return array_merge(
            $bodyAllowedAttributes,
            parent::getAllowedAttributes()
        );
    }

    protected function doClean(LoggerInterface $logger)
    {
        // "body" element must be a child of "html" element.
        if ($this->getParent() !== null &&

            $this->getParent()->getType() === Token::ELEMENT &&
            $this->getParent()->getName() != 'html') {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $logger->debug('Element "body" must be a child of "html" element.');

            return false;
        }

        return true;
    }
}


1			<?php
2
3			namespace Groundskeeper\Tokens\Elements;
4
5			use Groundskeeper\Tokens\Element;
6			use Groundskeeper\Tokens\ElementTypes\OpenElement;
7			use Groundskeeper\Tokens\ElementTypes\SectioningRoot;
8			use Groundskeeper\Tokens\Token;
9			use Psr\Log\LoggerInterface;
10
11			class Body extends OpenElement implements SectioningRoot
12			{
13			protected function getAllowedAttributes()
14			{
15			$bodyAllowedAttributes = array(
16			'/^onafterprint$/i' => Element::ATTR_JS,
17			'/^onbeforeprint$/i' => Element::ATTR_JS,
18			'/^onbeforeunload$/i' => Element::ATTR_JS,
19			'/^onhashchange$/i' => Element::ATTR_JS,
20			'/^onlanguagechange$/i' => Element::ATTR_JS,
21			'/^onmessage$/i' => Element::ATTR_JS,
22			'/^onoffline$/i' => Element::ATTR_JS,
23			'/^ononline$/i' => Element::ATTR_JS,
24			'/^onpagehide$/i' => Element::ATTR_JS,
25			'/^onpageshow$/i' => Element::ATTR_JS,
26			'/^onpopstate$/i' => Element::ATTR_JS,
27			'/^onrejectionhandled$/i' => Element::ATTR_JS,
28			'/^onstorage$/i' => Element::ATTR_JS,
29			'/^onunhandledrejection$/i' => Element::ATTR_JS,
30			'/^onunload$/i' => Element::ATTR_JS
31			);
32
33			return array_merge(
34			$bodyAllowedAttributes,
35			parent::getAllowedAttributes()
36			);
37			}
38	16
39			protected function doClean(LoggerInterface $logger)
40			{
41	16		// "body" element must be a child of "html" element.
42	16	View Code Duplication	if ($this->getParent() !== null &&
			0 ignored issues – show Duplication introduced 2016-05-04 01:44 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43	16		$this->getParent()->getType() === Token::ELEMENT &&
44			$this->getParent()->getName() != 'html') {
			0 ignored issues – show Bug introduced 2016-05-02 01:49 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Groundskeeper\Tokens\Token` as the method `getName()` does only exist in the following implementations of said interface: `Groundskeeper\Tokens\Element`, `Groundskeeper\Tokens\ElementTypes\ClosedElement`, `Groundskeeper\Tokens\ElementTypes\OpenElement`, `Groundskeeper\Tokens\Elements\Article`, `Groundskeeper\Tokens\Elements\Aside`, `Groundskeeper\Tokens\Elements\Base`, `Groundskeeper\Tokens\Elements\Body`, `Groundskeeper\Tokens\Elements\Br`, `Groundskeeper\Tokens\Elements\Footer`, `Groundskeeper\Tokens\Elements\H1`, `Groundskeeper\Tokens\Elements\H2`, `Groundskeeper\Tokens\Elements\H3`, `Groundskeeper\Tokens\Elements\H4`, `Groundskeeper\Tokens\Elements\H5`, `Groundskeeper\Tokens\Elements\H6`, `Groundskeeper\Tokens\Elements\Head`, `Groundskeeper\Tokens\Elements\Header`, `Groundskeeper\Tokens\Elements\Hgroup`, `Groundskeeper\Tokens\Elements\Hr`, `Groundskeeper\Tokens\Elements\Html`, `Groundskeeper\Tokens\Elements\Link`, `Groundskeeper\Tokens\Elements\Main`, `Groundskeeper\Tokens\Elements\Meta`, `Groundskeeper\Tokens\Elements\Nav`, `Groundskeeper\Tokens\Elements\Noscript`, `Groundskeeper\Tokens\Elements\Script`, `Groundskeeper\Tokens\Elements\Section`, `Groundskeeper\Tokens\Elements\Style`, `Groundskeeper\Tokens\Elements\Template`, `Groundskeeper\Tokens\Elements\Title`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45			$logger->debug('Element "body" must be a child of "html" element.');
46
47			return false;
48			}
49
50			return true;
51	16		}
52			}
53

kevintweber / Groundskeeper

Push — master ( a17ead...35004c )

Body A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like