kevintweber /
Groundskeeper
| Conditions | 5 |
| Paths | 3 |
| Total Lines | 17 |
| Code Lines | 11 |
| Lines | 17 |
| Ratio | 100 % |
| Tests | 0 |
| CRAP Score | 30 |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
| 1 | <?php |
||
| 14 | protected function doClean(LoggerInterface $logger = null) |
||
| 15 | { |
||
| 16 | $footer = new Footer($this->configuration, 'footer'); |
||
| 17 | $header = new Header($this->configuration, 'header'); |
||
| 18 | $main = new Main($this->configuration, 'main'); |
||
| 19 | if ($this->hasAncestor($footer) || |
||
| 20 | $this->hasAncestor($header) || |
||
| 21 | $this->hasAncestor($main)) { |
||
| 22 | if ($logger !== null) { |
||
| 23 | $logger->debug('Removing ' . $this . '. Element "header" should not be a descendant of "footer", "header", or "main" elements.'); |
||
| 24 | } |
||
| 25 | |||
| 26 | return false; |
||
| 27 | } |
||
| 28 | |||
| 29 | return true; |
||
| 30 | } |
||
| 31 | } |
||
| 32 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.