AbstractToken::getIsValid() - Code Metrics - Inspection of "Improve the readme." - kevintweber/Groundskeeper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b66e97...9d450b )

by Kevin

created 2016-04-23 16:45 UTC

AbstractToken::getIsValid() A

↳ Parent: AbstractToken

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Groundskeeper\Tokens;

use Groundskeeper\Configuration;

abstract class AbstractToken implements Token
{
    /** @var int */
    private $depth;

    /** @var int */
    protected $isValid;

    /** @var null|Token */
    private $parent;

    /** @var string */
    private $type;

    /**
     * Constructor
     */
    public function __construct($type, Token $parent = null)
    {
        if (!$this->isValidType($type)) {
            throw new \InvalidArgumentException('Invalid type: ' . $type);
        }

        $this->isValid = false;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->setParent($parent);
        $this->type = $type;
    }

    public function getDepth()
    {
        return $this->depth;
    }

    /**
     * Getter for 'isValid'.
     */
    public function getIsValid()
    {
        return $this->isValid;
    }

    /**
     * Getter for 'parent'.
     */
    public function getParent()
    {
        return $this->parent;
    }

    /**
     * Chainable setter for 'parent'.
     */
    public function setParent(Token $parent = null)
    {
        $this->depth = 0;
        if ($parent instanceof Token) {
            $this->depth = $parent->getDepth() + 1;
        }

        $this->parent = $parent;

        return $this;
    }

    public function getType()
    {
        return $this->type;
    }

    public function validate(Configuration $configuration)
    {
        $this->isValid = $configuration->isAllowedType($this->type);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    protected function isValidType($type)
    {
        return $type === Token::CDATA
            || $type === Token::COMMENT
            || $type === Token::DOCTYPE
            || $type === Token::ELEMENT
            || $type === Token::TEXT;
    }
}


1		<?php
2
3		namespace Groundskeeper\Tokens;
4
5		use Groundskeeper\Configuration;
6
7		abstract class AbstractToken implements Token
8		{
9		/** @var int */
10		private $depth;
11
12		/** @var int */
13		protected $isValid;
14
15		/** @var null\|Token */
16		private $parent;
17
18		/** @var string */
19		private $type;
20
21		/**
22		* Constructor
23		*/
24	11	public function __construct($type, Token $parent = null)
25		{
26	11	if (!$this->isValidType($type)) {
27		throw new \InvalidArgumentException('Invalid type: ' . $type);
28		}
29
30	11	$this->isValid = false;
		0 ignored issues – show Documentation Bug introduced 2016-04-23 16:47 UTC by Report Bug Copy Issue Report The property `$isValid` was declared of type `integer`, but `false` is of type `false`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
31	11	$this->setParent($parent);
32	11	$this->type = $type;
33	11	}
34
35		public function getDepth()
36		{
37		return $this->depth;
38		}
39
40		/**
41		* Getter for 'isValid'.
42		*/
43		public function getIsValid()
44		{
45		return $this->isValid;
46		}
47
48		/**
49		* Getter for 'parent'.
50		*/
51	2	public function getParent()
52		{
53	2	return $this->parent;
54		}
55
56		/**
57		* Chainable setter for 'parent'.
58		*/
59	11	public function setParent(Token $parent = null)
60		{
61	11	$this->depth = 0;
62	11	if ($parent instanceof Token) {
63		$this->depth = $parent->getDepth() + 1;
64		}
65
66	11	$this->parent = $parent;
67
68	11	return $this;
69		}
70
71		public function getType()
72		{
73		return $this->type;
74		}
75
76	10	public function validate(Configuration $configuration)
77		{
78	10	$this->isValid = $configuration->isAllowedType($this->type);
		0 ignored issues – show Documentation Bug introduced 2016-04-23 16:47 UTC by Report Bug Copy Issue Report The property `$isValid` was declared of type `integer`, but `$configuration->isAllowedType($this->type)` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
79	10	}
80
81	11	protected function isValidType($type)
82		{
83		return $type === Token::CDATA
84	11	\|\| $type === Token::COMMENT
85	9	\|\| $type === Token::DOCTYPE
86	7	\|\| $type === Token::ELEMENT
87	11	\|\| $type === Token::TEXT;
88		}
89		}
90

kevintweber / Groundskeeper

Push — master ( b66e97...9d450b )

AbstractToken::getIsValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like