Groundskeeper\Tokens\AbstractToken

Complexity

Total Complexity

14

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

70%

Importance

Changes	2
Bugs	0	Features	2

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	getDepth()	0	4	1
A	getIsValid()	0	4	1
A	getParent()	0	4	1
A	setParent()	0	11	2
A	getType()	0	4	1
A	validate()	0	4	1
B	isValidType()	0	8	5

<?php

namespace Groundskeeper\Tokens;

use Groundskeeper\Configuration;

abstract class AbstractToken implements Token
{
    /** @var int */
    private $depth;

    /** @var int */
    protected $isValid;

    /** @var null|Token */
    private $parent;

    /** @var string */
    private $type;

    /**
     * Constructor
     */
    public function __construct($type, Token $parent = null)
    {
        if (!$this->isValidType($type)) {
            throw new \InvalidArgumentException('Invalid type: ' . $type);
        }

        $this->isValid = false;

The property $isValid was declared of type integer, but false is of type false. Maybe add a type cast?

        $this->setParent($parent);
        $this->type = $type;
    }

    public function getDepth()
    {
        return $this->depth;
    }

    /**
     * Getter for 'isValid'.
     */
    public function getIsValid()
    {
        return $this->isValid;
    }

    /**
     * Getter for 'parent'.
     */
    public function getParent()
    {
        return $this->parent;
    }

    /**
     * Chainable setter for 'parent'.
     */
    public function setParent(Token $parent = null)
    {
        $this->depth = 0;
        if ($parent instanceof Token) {
            $this->depth = $parent->getDepth() + 1;
        }

        $this->parent = $parent;

        return $this;
    }

    public function getType()
    {
        return $this->type;
    }

    public function validate(Configuration $configuration)
    {
        $this->isValid = $configuration->isAllowedType($this->type);

The property $isValid was declared of type integer, but $configuration->isAllowedType($this->type) is of type boolean. Maybe add a type cast?

    }

    protected function isValidType($type)
    {
        return $type === Token::CDATA
            || $type === Token::COMMENT
            || $type === Token::DOCTYPE
            || $type === Token::ELEMENT
            || $type === Token::TEXT;
    }
}