Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class Dt extends OpenElement |
||
16 | { |
||
17 | 3 | View Code Duplication | protected function removeInvalidChildren(LoggerInterface $logger) |
|
|||
18 | { |
||
19 | // No "header", "footer", sectioning content, or heading content descendants. |
||
20 | 3 | foreach ($this->children as $child) { |
|
21 | 3 | if ($child instanceof Header || |
|
22 | 3 | $child instanceof Footer || |
|
23 | 3 | $child instanceof SectioningContent || |
|
24 | 3 | $child instanceof HeadingContent) { |
|
25 | 1 | $logger->debug('Removing ' . $child . '. No "header", "footer", and sectioning content, or heading content elements allowed as children of "dt" element.'); |
|
26 | 3 | $this->removeChild($child); |
|
27 | } |
||
28 | } |
||
29 | 3 | } |
|
30 | |||
31 | 4 | protected function removeInvalidSelf(LoggerInterface $logger) : bool |
|
44 | } |
||
45 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.