Issues in OrderService.php (master) - Issues in master - kevin92dev/MailChimpEcommerceBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Services/OrderService.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of the MailChimpEcommerceBundle package.
 *
 * Copyright (c) 2017 kevin92dev.es
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * Feel free to edit as you please, and have fun.
 *
 * @author Kevin Murillo <[email protected]>
 */

namespace Kevin92dev\MailChimpEcommerceBundle\Services;

use Kevin92dev\MailChimpEcommerceBundle\Entities\Address;
use Kevin92dev\MailChimpEcommerceBundle\Entities\Customer;
use Kevin92dev\MailChimpEcommerceBundle\Entities\Order;
use Kevin92dev\MailChimpEcommerceBundle\Entities\OrderLine;
use Kevin92dev\MailChimpEcommerceBundle\Exceptions\OrderNotFoundException;
use Kevin92dev\MailChimpEcommerceBundle\RequestTypes;

/**
 * OrderService
 *
 * @author Kevin Murillo <[email protected]>
 */
class OrderService
{
    /**
     * @var MailChimp
     */
    private $mailChimp;

    /**
     * @var array
     */
    private $body;

    /**
     * Initializes OrderService
     *
     * @param MailChimp $mailChimp
     */
    public function __construct(MailChimp $mailChimp)
    {
        $this->mailChimp = $mailChimp;
    }

    /**
     * Create a new order in MailChimp
     *
     * @var Order $order
     * @throws \Exception
     */
    public function create(Order $order)

    {
        $method = RequestTypes::$POST;
        $resource = '/orders';

        $this->generateBody($order);
        $this->addCustomer($order);
        $this->addAddress($order->getCustomer(), $order->getShippingAddress(), 'shipping_address');
        $this->addAddress($order->getCustomer(), $order->getBillingAddress(), 'billing_address');
        $this->addOrderLines($order);

        try {
            $this->mailChimp->doRequest($method, $this->body, $resource);
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * Edit an order in MailChimp
     *
     * @var Order $order
     * @throws \Exception
     */
    public function edit(Order $order)

    {
        $method = RequestTypes::$PATCH;
        $resource = '/orders/'.$order->getId();

        $this->generateBody($order, false);
        $this->addCustomer($order);
        $this->addAddress($order->getCustomer(), $order->getShippingAddress(), 'shipping_address');
        $this->addAddress($order->getCustomer(), $order->getBillingAddress(), 'billing_address');
        $this->addOrderLines($order);

        try {
            $this->mailChimp->doRequest($method, $this->body, $resource);
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * Read orders from MailChimp
     *
     * @param Order $order
     * @param int $count
     * @param int $offset
     *
     * @return string
     * @throws OrderNotFoundException|\Exception
     */
    public function read(Order $order = null, $count = 50, $offset = 0)
    {
        $method = RequestTypes::$GET;

        if ($order instanceof Order) {
            $resource = '/orders/'.$order->getId();
        } else {
            $resource = '/orders';
        }

        $resource .= '?count='.$count.'&offset='.$offset;

        $data = [];

        try {
            $request = $this->mailChimp->doRequest($method, $data, $resource);
        } catch (OrderNotFoundException $e) {
            throw $e;
        } catch (\Exception $e) {
            throw $e;
        }

        return $request->getBody()->getContents();
    }

    /**
     * Delete order from MailChimp
     *
     * @var Order $order
     */
    public function delete(Order $order)
    {
        $method = RequestTypes::$DELETE;
        $resource = '/orders/'.$order->getId();

        $this->mailChimp->doRequest($method, null, $resource);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Generate body array
     *
     * @param  Order $order
     * @param  bool  $addId
     */
    public function generateBody(Order $order, $addId = true)
    {
        $this->body = [
            'landing_site' => strval($order->getLandingSite()),
            'financial_status' => strval($order->getFinancialStatus()),
            'fulfillment_status' => strval($order->getFulfillmentStatus()),
            'currency_code' => strval($order->getCurrencyCode()),
            'order_total' => floatval($order->getOrderTotal()),
            'tax_total' => floatval($order->getTaxTotal()),
            'shipping_total' => floatval($order->getShippingTotal()),
            'tracking_code' => strval($order->getTrackingCode()),
            'processed_at_foreign' => strval($order->getProcessedAtForeign()),
            'cancelled_at_foreign' => strval($order->getCancelledAtForeign()),
            'updated_at_foreign' => strval($order->getUpdatedAtForeign()),
        ];

        if ($addId === true) {
            $this->body['id'] = strval($order->getId());
        }

        if (!is_null($order->getCampaignId())) {
            $this->body['campaign_id'] = strval($order->getCampaignId());
        }
    }

    /**
     * Add customer to array
     *
     * @param Order $order
     */
    public function addCustomer(Order $order)
    {
        $customer = $order->getCustomer();

        $this->body['customer'] = [
            'id' => strval($customer->getId()),
            'email_address' => strval($customer->getEmail()),
            'opt_in_status' => boolval($customer->isOptInStatus()),
            'company' => strval($customer->getCompany()),
            'first_name' => strval($customer->getFirstname()),
            'last_name' => strval($customer->getLastname()),
            'orders_count' => intval($customer->getOrdersCount()),
            'total_spent' => floatval($customer->getTotalSpent()),
        ];

        $this->addCustomerAddress($customer);
    }

    /**
     * Add address to a array
     *
     * @param Customer $customer
     * @param Address  $address
     * @param string   $type
     */
    public function addAddress(Customer $customer, Address $address, $type)

    {
        $this->body[$type] = [
            'name' => $type.' address for '.$customer->getEmail(),
            'address1' => strval($address->getAddress1()),
            'address2' => strval($address->getAddress2()),
            'city' => strval($address->getCity()),
            'province' => strval($address->getProvince()),
            'province_code' => strval($address->getProvinceCode()),
            'postal_code' => strval($address->getPostalCode()),
            'country' => strval($address->getCountry()),
            'country_code' => strval($address->getCountryCode()),
        ];
    }

    /**
     * Add address to a customer
     *
     * @param Customer $customer
     */
    public function addCustomerAddress(Customer $customer)

    {
        $address = $customer->getAddress();

        $this->body['customer']['address'] = [
            'address1' => strval($address->getAddress1()),
            'address2' => strval($address->getAddress2()),
            'city' => strval($address->getCity()),
            'province' => strval($address->getProvince()),
            'province_code' => strval($address->getProvinceCode()),
            'postal_code' => strval($address->getPostalCode()),
            'country' => strval($address->getCountry()),
            'country_code' => strval($address->getCountryCode()),
        ];
    }

    /**
     * Add order lines to array
     *
     * @param Order $order
     */
    public function addOrderLines(Order $order)
    {
        /**
         * @var OrderLine $orderLine
         */
        foreach ($order->getOrderLines() as $orderLine) {
            $this->body['lines'][] = [
                'id' => strval($orderLine->getId()),
                'product_id' => strval($orderLine->getProduct()->getId()),
                'product_variant_id' => strval($orderLine->getProductVariant()->getId()),
                'quantity' => intval($orderLine->getQuantity()),
                'price' => floatval($orderLine->getPrice()),
            ];
        }
    }
}


1		<?php
2		/*
3		* This file is part of the MailChimpEcommerceBundle package.
4		*
5		* Copyright (c) 2017 kevin92dev.es
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* Feel free to edit as you please, and have fun.
11		*
12		* @author Kevin Murillo <[email protected]>
13		*/
14
15		namespace Kevin92dev\MailChimpEcommerceBundle\Services;
16
17		use Kevin92dev\MailChimpEcommerceBundle\Entities\Address;
18		use Kevin92dev\MailChimpEcommerceBundle\Entities\Customer;
19		use Kevin92dev\MailChimpEcommerceBundle\Entities\Order;
20		use Kevin92dev\MailChimpEcommerceBundle\Entities\OrderLine;
21		use Kevin92dev\MailChimpEcommerceBundle\Exceptions\OrderNotFoundException;
22		use Kevin92dev\MailChimpEcommerceBundle\RequestTypes;
23
24		/**
25		* OrderService
26		*
27		* @author Kevin Murillo <[email protected]>
28		*/
29		class OrderService
30		{
31		/**
32		* @var MailChimp
33		*/
34		private $mailChimp;
35
36		/**
37		* @var array
38		*/
39		private $body;
40
41		/**
42		* Initializes OrderService
43		*
44		* @param MailChimp $mailChimp
45		*/
46		public function __construct(MailChimp $mailChimp)
47		{
48		$this->mailChimp = $mailChimp;
49		}
50
51		/**
52		* Create a new order in MailChimp
53		*
54		* @var Order $order
55		* @throws \Exception
56		*/
57	View Code Duplication	public function create(Order $order)
		0 ignored issues – show Duplication introduced 2017-02-13 08:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$method = RequestTypes::$POST;
60		$resource = '/orders';
61
62		$this->generateBody($order);
63		$this->addCustomer($order);
64		$this->addAddress($order->getCustomer(), $order->getShippingAddress(), 'shipping_address');
65		$this->addAddress($order->getCustomer(), $order->getBillingAddress(), 'billing_address');
66		$this->addOrderLines($order);
67
68		try {
69		$this->mailChimp->doRequest($method, $this->body, $resource);
70		} catch (\Exception $e) {
71		throw $e;
72		}
73		}
74
75		/**
76		* Edit an order in MailChimp
77		*
78		* @var Order $order
79		* @throws \Exception
80		*/
81	View Code Duplication	public function edit(Order $order)
		0 ignored issues – show Duplication introduced 2017-02-13 08:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$method = RequestTypes::$PATCH;
84		$resource = '/orders/'.$order->getId();
85
86		$this->generateBody($order, false);
87		$this->addCustomer($order);
88		$this->addAddress($order->getCustomer(), $order->getShippingAddress(), 'shipping_address');
89		$this->addAddress($order->getCustomer(), $order->getBillingAddress(), 'billing_address');
90		$this->addOrderLines($order);
91
92		try {
93		$this->mailChimp->doRequest($method, $this->body, $resource);
94		} catch (\Exception $e) {
95		throw $e;
96		}
97		}
98
99		/**
100		* Read orders from MailChimp
101		*
102		* @param Order $order
103		* @param int $count
104		* @param int $offset
105		*
106		* @return string
107		* @throws OrderNotFoundException\|\Exception
108		*/
109		public function read(Order $order = null, $count = 50, $offset = 0)
110		{
111		$method = RequestTypes::$GET;
112
113		if ($order instanceof Order) {
114		$resource = '/orders/'.$order->getId();
115		} else {
116		$resource = '/orders';
117		}
118
119		$resource .= '?count='.$count.'&offset='.$offset;
120
121		$data = [];
122
123		try {
124		$request = $this->mailChimp->doRequest($method, $data, $resource);
125		} catch (OrderNotFoundException $e) {
126		throw $e;
127		} catch (\Exception $e) {
128		throw $e;
129		}
130
131		return $request->getBody()->getContents();
132		}
133
134		/**
135		* Delete order from MailChimp
136		*
137		* @var Order $order
138		*/
139		public function delete(Order $order)
140		{
141		$method = RequestTypes::$DELETE;
142		$resource = '/orders/'.$order->getId();
143
144		$this->mailChimp->doRequest($method, null, $resource);
		0 ignored issues – show Documentation introduced 2017-02-13 08:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
145		}
146
147		/**
148		* Generate body array
149		*
150		* @param Order $order
151		* @param bool $addId
152		*/
153		public function generateBody(Order $order, $addId = true)
154		{
155		$this->body = [
156		'landing_site' => strval($order->getLandingSite()),
157		'financial_status' => strval($order->getFinancialStatus()),
158		'fulfillment_status' => strval($order->getFulfillmentStatus()),
159		'currency_code' => strval($order->getCurrencyCode()),
160		'order_total' => floatval($order->getOrderTotal()),
161		'tax_total' => floatval($order->getTaxTotal()),
162		'shipping_total' => floatval($order->getShippingTotal()),
163		'tracking_code' => strval($order->getTrackingCode()),
164		'processed_at_foreign' => strval($order->getProcessedAtForeign()),
165		'cancelled_at_foreign' => strval($order->getCancelledAtForeign()),
166		'updated_at_foreign' => strval($order->getUpdatedAtForeign()),
167		];
168
169		if ($addId === true) {
170		$this->body['id'] = strval($order->getId());
171		}
172
173		if (!is_null($order->getCampaignId())) {
174		$this->body['campaign_id'] = strval($order->getCampaignId());
175		}
176		}
177
178		/**
179		* Add customer to array
180		*
181		* @param Order $order
182		*/
183		public function addCustomer(Order $order)
184		{
185		$customer = $order->getCustomer();
186
187		$this->body['customer'] = [
188		'id' => strval($customer->getId()),
189		'email_address' => strval($customer->getEmail()),
190		'opt_in_status' => boolval($customer->isOptInStatus()),
191		'company' => strval($customer->getCompany()),
192		'first_name' => strval($customer->getFirstname()),
193		'last_name' => strval($customer->getLastname()),
194		'orders_count' => intval($customer->getOrdersCount()),
195		'total_spent' => floatval($customer->getTotalSpent()),
196		];
197
198		$this->addCustomerAddress($customer);
199		}
200
201		/**
202		* Add address to a array
203		*
204		* @param Customer $customer
205		* @param Address $address
206		* @param string $type
207		*/
208	View Code Duplication	public function addAddress(Customer $customer, Address $address, $type)
		0 ignored issues – show Duplication introduced 2017-02-13 08:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
209		{
210		$this->body[$type] = [
211		'name' => $type.' address for '.$customer->getEmail(),
212		'address1' => strval($address->getAddress1()),
213		'address2' => strval($address->getAddress2()),
214		'city' => strval($address->getCity()),
215		'province' => strval($address->getProvince()),
216		'province_code' => strval($address->getProvinceCode()),
217		'postal_code' => strval($address->getPostalCode()),
218		'country' => strval($address->getCountry()),
219		'country_code' => strval($address->getCountryCode()),
220		];
221		}
222
223		/**
224		* Add address to a customer
225		*
226		* @param Customer $customer
227		*/
228	View Code Duplication	public function addCustomerAddress(Customer $customer)
		0 ignored issues – show Duplication introduced 2017-02-13 08:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
229		{
230		$address = $customer->getAddress();
231
232		$this->body['customer']['address'] = [
233		'address1' => strval($address->getAddress1()),
234		'address2' => strval($address->getAddress2()),
235		'city' => strval($address->getCity()),
236		'province' => strval($address->getProvince()),
237		'province_code' => strval($address->getProvinceCode()),
238		'postal_code' => strval($address->getPostalCode()),
239		'country' => strval($address->getCountry()),
240		'country_code' => strval($address->getCountryCode()),
241		];
242		}
243
244		/**
245		* Add order lines to array
246		*
247		* @param Order $order
248		*/
249		public function addOrderLines(Order $order)
250		{
251		/**
252		* @var OrderLine $orderLine
253		*/
254		foreach ($order->getOrderLines() as $orderLine) {
255		$this->body['lines'][] = [
256		'id' => strval($orderLine->getId()),
257		'product_id' => strval($orderLine->getProduct()->getId()),
258		'product_variant_id' => strval($orderLine->getProductVariant()->getId()),
259		'quantity' => intval($orderLine->getQuantity()),
260		'price' => floatval($orderLine->getPrice()),
261		];
262		}
263		}
264		}
265

kevin92dev / MailChimpEcommerceBundle

Issues (15)

Security Analysis no request data

Services/OrderService.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like