Issues in PersistentMenu.php (master) - Issues in master - ker0x/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Model/ProfileSettings/PersistentMenu.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Kerox\Messenger\Model\ProfileSettings;

use Kerox\Messenger\Helper\ValidatorTrait;
use Kerox\Messenger\Model\Common\Button\AbstractButton;

class PersistentMenu implements ProfileSettingsInterface, \JsonSerializable
{
    use ValidatorTrait;

    /**
     * @var string
     */
    protected $locale;

    /**
     * @var bool
     */
    protected $composerInputDisabled = false;

    /**
     * @var \Kerox\Messenger\Model\Common\Button\AbstractButton[]
     */
    protected $buttons = [];

    /**
     * PersistentMenu constructor.
     *
     * @throws \Kerox\Messenger\Exception\MessengerException
     */
    public function __construct(string $locale = self::DEFAULT_LOCALE)
    {
        if ($locale !== self::DEFAULT_LOCALE) {
            $this->isValidLocale($locale);
        }

        $this->locale = $locale;
    }

    /**
     * @throws \Kerox\Messenger\Exception\MessengerException
     *
     * @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
     */
    public static function create(string $locale = self::DEFAULT_LOCALE): self
    {
        return new self($locale);
    }

    /**
     * @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
     */
    public function setComposerInputDisabled(bool $composerInputDisabled): self
    {
        $this->composerInputDisabled = $composerInputDisabled;

        return $this;
    }

    /**
     * @param \Kerox\Messenger\Model\Common\Button\AbstractButton[] $buttons
     *
     * @throws \Kerox\Messenger\Exception\MessengerException
     *
     * @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
     */
    public function addButtons(array $buttons): self

    {
        $this->isValidArray($buttons, 5);
        $this->isValidButtons($buttons, $this->getAllowedButtonsType());

        $this->buttons = $buttons;

        return $this;
    }

    protected function getAllowedButtonsType(): array
    {
        return [
            AbstractButton::TYPE_WEB_URL,
            AbstractButton::TYPE_POSTBACK,
            AbstractButton::TYPE_NESTED,

        ];
    }

    public function toArray(): array
    {
        $array = [
            'locale' => $this->locale,
            'composer_input_disabled' => $this->composerInputDisabled,
            'call_to_actions' => $this->buttons,
        ];

        return array_filter($array);
    }

    public function jsonSerialize(): array
    {
        return $this->toArray();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Kerox\Messenger\Model\ProfileSettings;
6
7			use Kerox\Messenger\Helper\ValidatorTrait;
8			use Kerox\Messenger\Model\Common\Button\AbstractButton;
9
10			class PersistentMenu implements ProfileSettingsInterface, \JsonSerializable
11			{
12			use ValidatorTrait;
13
14			/**
15			* @var string
16			*/
17			protected $locale;
18
19			/**
20			* @var bool
21			*/
22			protected $composerInputDisabled = false;
23
24			/**
25			* @var \Kerox\Messenger\Model\Common\Button\AbstractButton[]
26			*/
27			protected $buttons = [];
28
29			/**
30			* PersistentMenu constructor.
31			*
32			* @throws \Kerox\Messenger\Exception\MessengerException
33			*/
34	3		public function __construct(string $locale = self::DEFAULT_LOCALE)
35			{
36	3		if ($locale !== self::DEFAULT_LOCALE) {
37	1		$this->isValidLocale($locale);
38			}
39
40	3		$this->locale = $locale;
41	3		}
42
43			/**
44			* @throws \Kerox\Messenger\Exception\MessengerException
45			*
46			* @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
47			*/
48	3		public static function create(string $locale = self::DEFAULT_LOCALE): self
49			{
50	3		return new self($locale);
51			}
52
53			/**
54			* @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
55			*/
56	3		public function setComposerInputDisabled(bool $composerInputDisabled): self
57			{
58	3		$this->composerInputDisabled = $composerInputDisabled;
59
60	3		return $this;
61			}
62
63			/**
64			* @param \Kerox\Messenger\Model\Common\Button\AbstractButton[] $buttons
65			*
66			* @throws \Kerox\Messenger\Exception\MessengerException
67			*
68			* @return \Kerox\Messenger\Model\ProfileSettings\PersistentMenu
69			*/
70	3	View Code Duplication	public function addButtons(array $buttons): self
			0 ignored issues – show Duplication introduced 2020-02-18 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71			{
72	3		$this->isValidArray($buttons, 5);
73	3		$this->isValidButtons($buttons, $this->getAllowedButtonsType());
74
75	1		$this->buttons = $buttons;
76
77	1		return $this;
78			}
79
80	3		protected function getAllowedButtonsType(): array
81			{
82			return [
83	3		AbstractButton::TYPE_WEB_URL,
84			AbstractButton::TYPE_POSTBACK,
85			AbstractButton::TYPE_NESTED,
			0 ignored issues – show Deprecated Code introduced 2020-02-18 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `Kerox\Messenger\Model\Co...ractButton::TYPE_NESTED` has been deprecated with message: Since version 3.3.1 and will be removed in version 4.0.0. This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history...
86			];
87			}
88
89	1		public function toArray(): array
90			{
91			$array = [
92	1		'locale' => $this->locale,
93	1		'composer_input_disabled' => $this->composerInputDisabled,
94	1		'call_to_actions' => $this->buttons,
95			];
96
97	1		return array_filter($array);
98			}
99
100	1		public function jsonSerialize(): array
101			{
102	1		return $this->toArray();
103			}
104			}
105

ker0x / messenger

Issues (56)

Security Analysis not enabled

src/Model/ProfileSettings/PersistentMenu.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like