DeliveryEvent::getName() - Code Metrics - Inspection of "add method getName to event, update tests" - ker0x/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Romain

created 2016-11-30 08:41 UTC

DeliveryEvent::getName() A

↳ Parent: DeliveryEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
namespace Kerox\Messenger\Event;

use Kerox\Messenger\Model\Callback\Delivery;

class DeliveryEvent extends AbstractEvent
{

    const NAME = 'delivery';

    /**
     * @var \Kerox\Messenger\Model\Callback\Delivery
     */
    protected $delivery;

    /**
     * DeliveryEvent constructor.
     *
     * @param string $senderId
     * @param string $recipientId
     * @param \Kerox\Messenger\Model\Callback\Delivery $delivery
     */
    public function __construct(string $senderId, string $recipientId, Delivery $delivery)
    {
        parent::__construct($senderId, $recipientId);

        $this->delivery = $delivery;
    }

    /**
     * @return \Kerox\Messenger\Model\Callback\Delivery
     */
    public function getDelivery(): Delivery
    {
        return $this->delivery;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return self::NAME;
    }
}


1		<?php
2		namespace Kerox\Messenger\Event;
3
4		use Kerox\Messenger\Model\Callback\Delivery;
5
6		class DeliveryEvent extends AbstractEvent
7		{
8
9		const NAME = 'delivery';
10
11		/**
12		* @var \Kerox\Messenger\Model\Callback\Delivery
13		*/
14		protected $delivery;
15
16		/**
17		* DeliveryEvent constructor.
18		*
19		* @param string $senderId
20		* @param string $recipientId
21		* @param \Kerox\Messenger\Model\Callback\Delivery $delivery
22		*/
23	2	public function __construct(string $senderId, string $recipientId, Delivery $delivery)
24		{
25	2	parent::__construct($senderId, $recipientId);
26
27	2	$this->delivery = $delivery;
28	2	}
29
30		/**
31		* @return \Kerox\Messenger\Model\Callback\Delivery
32		*/
33	1	public function getDelivery(): Delivery
34		{
35	1	return $this->delivery;
36		}
37
38		/**
39		* @return string
40		*/
41	1	public function getName(): string
42		{
43	1	return self::NAME;
44		}
45		}
46

ker0x / messenger

Pull Request — master (#10)

DeliveryEvent::getName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like