AirlineItinerary::__construct() - Code Metrics - Inspection of "move folder Message inside Model, add support for..." - ker0x/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (8166a6)

by Romain

created 2016-11-21 16:46 UTC

AirlineItinerary::__construct() A

↳ Parent: AirlineItinerary

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	16
nc	1
nop	8

How to fix Many Parameters

<?php
namespace Kerox\Messenger\Model\Message\Attachment\Template;

use Kerox\Messenger\Model\Message\Attachment\Template;

class AirlineItinerary extends AbstractAirline
{

    /**
     * @var string
     */
    protected $introMessage;

    /**
     * @var string
     */
    protected $pnrNumber;

    /**
     * @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerInfo[]
     */
    protected $passengerInfo;

    /**
     * @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\ExtendedFlightInfo[]
     */
    protected $flightInfo;

    /**
     * @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerSegmentInfo[]
     */
    protected $passengerSegmentInfo;

    /**
     * @var array
     */
    protected $priceInfo = [];

    /**
     * @var null|float
     */
    protected $basePrice;

    /**
     * @var null|float
     */
    protected $tax;

    /**
     * @var float
     */
    protected $totalPrice;

    /**
     * @var string
     */
    protected $currency;

    /**
     * AirlineItinerary constructor.
     *
     * @param string $introMessage
     * @param string $locale
     * @param string $pnrNumber
     * @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerInfo[] $passengerInfo
     * @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\ExtendedFlightInfo[] $flightInfo
     * @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerSegmentInfo[] $passengerSegmentInfo
     * @param float $totalPrice
     * @param string $currency
     */
    public function __construct(string $introMessage,
                                string $locale,
                                string $pnrNumber,
                                array $passengerInfo,
                                array $flightInfo,
                                array $passengerSegmentInfo,
                                float $totalPrice,
                                string $currency
    ) {
        parent::__construct($locale);

        $this->introMessage = $introMessage;
        $this->pnrNumber = $pnrNumber;
        $this->passengerInfo = $passengerInfo;
        $this->flightInfo = $flightInfo;
        $this->passengerSegmentInfo = $passengerSegmentInfo;
        $this->totalPrice = (string)$totalPrice;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->currency = $currency;
    }

    /**
     * @param string $title
     * @param float $amount
     * @param string $currency
     * @return \Kerox\Messenger\Model\Message\Attachment\Template\AirlineItinerary
     * @internal param array|null $priceInfo
     */
    public function addPriceInfo(string $title, float $amount, string $currency = null): AirlineItinerary
    {
        if ($currency !== null) {
            $this->isValidCurrency($currency);
        }

        $priceInfo = [
            'title' => $title,
            'amount' => $amount,
            'currency' => $currency,
        ];

        $this->isValidArray($this->priceInfo, 4);
        $this->priceInfo[] = array_filter($priceInfo);

        return $this;
    }

    /**
     * @param float $basePrice
     * @return AirlineItinerary
     */
    public function setBasePrice(float $basePrice): AirlineItinerary
    {
        $this->basePrice = (string)$basePrice;


        return $this;
    }

    /**
     * @param float $tax
     * @return AirlineItinerary
     */
    public function setTax(float $tax): AirlineItinerary
    {
        $this->tax = (string)$tax;


        return $this;
    }

    /**
     * @return array
     */
    public function jsonSerialize(): array
    {
        $payload = [
            'template_type' => Template::TYPE_AIRLINE_ITINERARY,
            'intro_message' => $this->introMessage,
            'locale' => $this->locale,
            'theme_color' => $this->themeColor,
            'pnr_number' => $this->pnrNumber,
            'passenger_info' => $this->passengerInfo,
            'flight_info' => $this->flightInfo,
            'passenger_segment_info' => $this->passengerSegmentInfo,
            'price_info' => $this->priceInfo,
            'base_price' => $this->basePrice,
            'tax' => $this->tax,
            'total_price' => $this->totalPrice,
            'currency' => $this->currency,
        ];

        $json = parent::jsonSerialize();
        $json += [
            'payload' => array_filter($payload),
        ];

        return $json;
    }
}


1			<?php
2			namespace Kerox\Messenger\Model\Message\Attachment\Template;
3
4			use Kerox\Messenger\Model\Message\Attachment\Template;
5
6			class AirlineItinerary extends AbstractAirline
7			{
8
9			/**
10			* @var string
11			*/
12			protected $introMessage;
13
14			/**
15			* @var string
16			*/
17			protected $pnrNumber;
18
19			/**
20			* @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerInfo[]
21			*/
22			protected $passengerInfo;
23
24			/**
25			* @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\ExtendedFlightInfo[]
26			*/
27			protected $flightInfo;
28
29			/**
30			* @var \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerSegmentInfo[]
31			*/
32			protected $passengerSegmentInfo;
33
34			/**
35			* @var array
36			*/
37			protected $priceInfo = [];
38
39			/**
40			* @var null\|float
41			*/
42			protected $basePrice;
43
44			/**
45			* @var null\|float
46			*/
47			protected $tax;
48
49			/**
50			* @var float
51			*/
52			protected $totalPrice;
53
54			/**
55			* @var string
56			*/
57			protected $currency;
58
59			/**
60			* AirlineItinerary constructor.
61			*
62			* @param string $introMessage
63			* @param string $locale
64			* @param string $pnrNumber
65			* @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerInfo[] $passengerInfo
66			* @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\ExtendedFlightInfo[] $flightInfo
67			* @param \Kerox\Messenger\Model\Message\Attachment\Template\Airline\PassengerSegmentInfo[] $passengerSegmentInfo
68			* @param float $totalPrice
69			* @param string $currency
70			*/
71			public function __construct(string $introMessage,
72			string $locale,
73			string $pnrNumber,
74			array $passengerInfo,
75			array $flightInfo,
76			array $passengerSegmentInfo,
77			float $totalPrice,
78			string $currency
79			) {
80			parent::__construct($locale);
81
82			$this->introMessage = $introMessage;
83			$this->pnrNumber = $pnrNumber;
84			$this->passengerInfo = $passengerInfo;
85			$this->flightInfo = $flightInfo;
86			$this->passengerSegmentInfo = $passengerSegmentInfo;
87			$this->totalPrice = (string)$totalPrice;
			0 ignored issues – show Documentation Bug introduced 2016-11-20 16:34 UTC by Report Bug Copy Issue Report The property `$totalPrice` was declared of type `double`, but `(string) $totalPrice` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
88			$this->currency = $currency;
89			}
90
91			/**
92			* @param string $title
93			* @param float $amount
94			* @param string $currency
95			* @return \Kerox\Messenger\Model\Message\Attachment\Template\AirlineItinerary
96			* @internal param array\|null $priceInfo
97			*/
98			public function addPriceInfo(string $title, float $amount, string $currency = null): AirlineItinerary
99			{
100			if ($currency !== null) {
101			$this->isValidCurrency($currency);
102			}
103
104			$priceInfo = [
105			'title' => $title,
106			'amount' => $amount,
107			'currency' => $currency,
108			];
109
110			$this->isValidArray($this->priceInfo, 4);
111			$this->priceInfo[] = array_filter($priceInfo);
112
113			return $this;
114			}
115
116			/**
117			* @param float $basePrice
118			* @return AirlineItinerary
119			*/
120			public function setBasePrice(float $basePrice): AirlineItinerary
121			{
122			$this->basePrice = (string)$basePrice;
			0 ignored issues – show Documentation Bug introduced 2016-11-20 16:34 UTC by Report Bug Copy Issue Report It seems like `(string) $basePrice` of type `string` is incompatible with the declared type `null\|double` of property `$basePrice`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
123
124			return $this;
125			}
126
127			/**
128			* @param float $tax
129			* @return AirlineItinerary
130			*/
131			public function setTax(float $tax): AirlineItinerary
132			{
133			$this->tax = (string)$tax;
			0 ignored issues – show Documentation Bug introduced 2016-11-20 16:34 UTC by Report Bug Copy Issue Report It seems like `(string) $tax` of type `string` is incompatible with the declared type `null\|double` of property `$tax`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
134
135			return $this;
136			}
137
138			/**
139			* @return array
140			*/
141			public function jsonSerialize(): array
142			{
143			$payload = [
144			'template_type' => Template::TYPE_AIRLINE_ITINERARY,
145			'intro_message' => $this->introMessage,
146			'locale' => $this->locale,
147			'theme_color' => $this->themeColor,
148			'pnr_number' => $this->pnrNumber,
149			'passenger_info' => $this->passengerInfo,
150			'flight_info' => $this->flightInfo,
151			'passenger_segment_info' => $this->passengerSegmentInfo,
152			'price_info' => $this->priceInfo,
153			'base_price' => $this->basePrice,
154			'tax' => $this->tax,
155			'total_price' => $this->totalPrice,
156			'currency' => $this->currency,
157			];
158
159			$json = parent::jsonSerialize();
160			$json += [
161			'payload' => array_filter($payload),
162			];
163
164			return $json;
165			}
166			}
167

ker0x / messenger

Branch — develop (8166a6)

AirlineItinerary::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like