PersonaResponse::getPersona() - Code Metrics - Inspection of "Merge pull request #121 from misantron/issue-118" - ker0x/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 151cc0...3583a4 )

by Romain

created 2018-10-02 23:24 UTC

PersonaResponse::getPersona() A

↳ Parent: PersonaResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace Kerox\Messenger\Response;

use Kerox\Messenger\Model\Persona;

class PersonaResponse extends AbstractResponse
{
    /**
     * @var Persona
     */
    protected $persona;

    /**
     * @var bool
     */
    protected $success;

    /**
     * @param array $response
     */
    protected function parseResponse(array $response): void
    {
        $this->persona = new Persona($response);
        $this->success = $response['success'] ?? null;
    }

    public function getPersona(): Persona
    {
        return $this->persona;
    }

    /**
     * @return string|null
     */
    public function getId(): ?string
    {
        return $this->persona->getId();
    }

    /**
     * @return bool
     */
    public function isSuccess(): bool
    {
        return $this->success === true;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Kerox\Messenger\Response;
6
7		use Kerox\Messenger\Model\Persona;
8
9		class PersonaResponse extends AbstractResponse
10		{
11		/**
12		* @var Persona
13		*/
14		protected $persona;
15
16		/**
17		* @var bool
18		*/
19		protected $success;
20
21		/**
22		* @param array $response
23		*/
24	3	protected function parseResponse(array $response): void
25		{
26	3	$this->persona = new Persona($response);
27	3	$this->success = $response['success'] ?? null;
28	3	}
29
30	1	public function getPersona(): Persona
31		{
32	1	return $this->persona;
33		}
34
35		/**
36		* @return string\|null
37		*/
38	1	public function getId(): ?string
39		{
40	1	return $this->persona->getId();
41		}
42
43		/**
44		* @return bool
45		*/
46	1	public function isSuccess(): bool
47		{
48	1	return $this->success === true;
49		}
50		}
51

ker0x / messenger

Push — master ( 151cc0...3583a4 )

PersonaResponse::getPersona() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like