@@ -38,12 +38,12 @@ |
||
38 | 38 | $real_path = realpath($path); |
39 | 39 | if ($real_path === FALSE) |
40 | 40 | { |
41 | - throw new RuntimeException($path . ' does not exist?'); |
|
41 | + throw new RuntimeException($path.' does not exist?'); |
|
42 | 42 | } |
43 | 43 | if (is_dir($real_path)) |
44 | 44 | { |
45 | 45 | // Must use DIRECTORY_SEPARATOR for Windows |
46 | - $real_path = $real_path . DIRECTORY_SEPARATOR; |
|
46 | + $real_path = $real_path.DIRECTORY_SEPARATOR; |
|
47 | 47 | } |
48 | 48 | $new_paths[] = $excluded ? '-'.$real_path : $real_path; |
49 | 49 | } |
@@ -35,7 +35,7 @@ discard block |
||
35 | 35 | { |
36 | 36 | if ($this->db === null) |
37 | 37 | { |
38 | - $CI =& get_instance(); |
|
38 | + $CI = & get_instance(); |
|
39 | 39 | $CI->load->database(); |
40 | 40 | $this->db = $CI->db; |
41 | 41 | } |
@@ -54,7 +54,7 @@ discard block |
||
54 | 54 | */ |
55 | 55 | protected function tearDown() |
56 | 56 | { |
57 | - if (! empty($this->insertCache)) |
|
57 | + if ( ! empty($this->insertCache)) |
|
58 | 58 | { |
59 | 59 | foreach ($this->insertCache as $row) |
60 | 60 | { |
@@ -17,7 +17,7 @@ discard block |
||
17 | 17 | |
18 | 18 | public function __construct() |
19 | 19 | { |
20 | - $this->CI =& get_instance(); |
|
20 | + $this->CI = & get_instance(); |
|
21 | 21 | $this->CI->load->database(); |
22 | 22 | $this->CI->load->dbforge(); |
23 | 23 | $this->db = $this->CI->db; |
@@ -33,10 +33,10 @@ discard block |
||
33 | 33 | { |
34 | 34 | if ($this->seedPath === null) |
35 | 35 | { |
36 | - $this->seedPath = APPPATH . 'database/seeds/'; |
|
36 | + $this->seedPath = APPPATH.'database/seeds/'; |
|
37 | 37 | } |
38 | 38 | |
39 | - $file = $this->seedPath . $seeder . '.php'; |
|
39 | + $file = $this->seedPath.$seeder.'.php'; |
|
40 | 40 | require_once $file; |
41 | 41 | |
42 | 42 | $obj = new $seeder; |
@@ -67,8 +67,7 @@ discard block |
||
67 | 67 | if ($filename === '' OR $data === '') |
68 | 68 | { |
69 | 69 | return; |
70 | - } |
|
71 | - elseif ($data === NULL) |
|
70 | + } elseif ($data === NULL) |
|
72 | 71 | { |
73 | 72 | if ( ! @is_file($filename) OR ($filesize = @filesize($filename)) === FALSE) |
74 | 73 | { |
@@ -78,8 +77,7 @@ discard block |
||
78 | 77 | $filepath = $filename; |
79 | 78 | $filename = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename)); |
80 | 79 | $filename = end($filename); |
81 | - } |
|
82 | - else |
|
80 | + } else |
|
83 | 81 | { |
84 | 82 | $filesize = strlen($data); |
85 | 83 | } |
@@ -158,8 +156,7 @@ discard block |
||
158 | 156 | if (ENVIRONMENT !== 'testing') |
159 | 157 | { |
160 | 158 | exit($data); |
161 | - } |
|
162 | - else |
|
159 | + } else |
|
163 | 160 | { |
164 | 161 | echo($data); |
165 | 162 | throw new CIPHPUnitTestExitException('exit() from force_download()'); |
@@ -176,8 +173,7 @@ discard block |
||
176 | 173 | if (ENVIRONMENT !== 'testing') |
177 | 174 | { |
178 | 175 | exit; |
179 | - } |
|
180 | - else |
|
176 | + } else |
|
181 | 177 | { |
182 | 178 | throw new CIPHPUnitTestExitException('exit() from force_download()'); |
183 | 179 | } |
@@ -101,7 +101,7 @@ discard block |
||
101 | 101 | } |
102 | 102 | |
103 | 103 | // Load the mime types |
104 | - $mimes =& get_mimes(); |
|
104 | + $mimes = & get_mimes(); |
|
105 | 105 | |
106 | 106 | // Only change the default MIME if we can find one |
107 | 107 | if (isset($mimes[$extension])) |
@@ -146,7 +146,7 @@ discard block |
||
146 | 146 | |
147 | 147 | if (ENVIRONMENT === 'testing') |
148 | 148 | { |
149 | - $CI =& get_instance(); |
|
149 | + $CI = & get_instance(); |
|
150 | 150 | $CI->output->set_header('Content-Type: '.$mime); |
151 | 151 | $CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"'); |
152 | 152 | $CI->output->set_header('Expires: 0'); |
@@ -49,7 +49,7 @@ discard block |
||
49 | 49 | return $this->$name; |
50 | 50 | } |
51 | 51 | |
52 | - throw new LogicException('No such property: ' . $name); |
|
52 | + throw new LogicException('No such property: '.$name); |
|
53 | 53 | } |
54 | 54 | |
55 | 55 | public static function setUpBeforeClass() |
@@ -72,7 +72,7 @@ discard block |
||
72 | 72 | { |
73 | 73 | reset_instance(); |
74 | 74 | CIPHPUnitTest::createCodeIgniterInstance(); |
75 | - $this->CI =& get_instance(); |
|
75 | + $this->CI = & get_instance(); |
|
76 | 76 | } |
77 | 77 | |
78 | 78 | /** |
@@ -85,7 +85,7 @@ discard block |
||
85 | 85 | { |
86 | 86 | reset_instance(); |
87 | 87 | $controller = new $classname; |
88 | - $this->CI =& get_instance(); |
|
88 | + $this->CI = & get_instance(); |
|
89 | 89 | return $controller; |
90 | 90 | } |
91 | 91 | |
@@ -266,7 +266,7 @@ discard block |
||
266 | 266 | $this->assertSame( |
267 | 267 | $code, |
268 | 268 | $actual, |
269 | - 'Status code is not ' . $code . ' but ' . $actual . '.' |
|
269 | + 'Status code is not '.$code.' but '.$actual.'.' |
|
270 | 270 | ); |
271 | 271 | } |
272 | 272 | |
@@ -278,7 +278,7 @@ discard block |
||
278 | 278 | */ |
279 | 279 | public function assertResponseHeader($name, $value) |
280 | 280 | { |
281 | - $CI =& get_instance(); |
|
281 | + $CI = & get_instance(); |
|
282 | 282 | $actual = $CI->output->get_header($name); |
283 | 283 | |
284 | 284 | if ($actual === null) |
@@ -302,7 +302,7 @@ discard block |
||
302 | 302 | */ |
303 | 303 | public function assertResponseCookie($name, $value, $allow_duplicate = false) |
304 | 304 | { |
305 | - $CI =& get_instance(); |
|
305 | + $CI = & get_instance(); |
|
306 | 306 | $cookies = isset($CI->output->_cookies[$name]) |
307 | 307 | ? $CI->output->_cookies[$name] : null; |
308 | 308 | |
@@ -360,23 +360,23 @@ discard block |
||
360 | 360 | $this->fail('redirect() is not called.'); |
361 | 361 | } |
362 | 362 | |
363 | - if (! function_exists('site_url')) |
|
363 | + if ( ! function_exists('site_url')) |
|
364 | 364 | { |
365 | - $CI =& get_instance(); |
|
365 | + $CI = & get_instance(); |
|
366 | 366 | $CI->load->helper('url'); |
367 | 367 | } |
368 | 368 | |
369 | - if (! preg_match('#^(\w+:)?//#i', $uri)) |
|
369 | + if ( ! preg_match('#^(\w+:)?//#i', $uri)) |
|
370 | 370 | { |
371 | 371 | $uri = site_url($uri); |
372 | 372 | } |
373 | 373 | $absolute_url = $uri; |
374 | - $expected = 'Redirect to ' . $absolute_url; |
|
374 | + $expected = 'Redirect to '.$absolute_url; |
|
375 | 375 | |
376 | 376 | $this->assertSame( |
377 | 377 | $expected, |
378 | 378 | $status['redirect'], |
379 | - 'URL to redirect is not ' . $expected . ' but ' . $status['redirect'] . '.' |
|
379 | + 'URL to redirect is not '.$expected.' but '.$status['redirect'].'.' |
|
380 | 380 | ); |
381 | 381 | |
382 | 382 | if ($code !== null) |
@@ -384,7 +384,7 @@ discard block |
||
384 | 384 | $this->assertSame( |
385 | 385 | $code, |
386 | 386 | $status['code'], |
387 | - 'Status code is not ' . $code . ' but ' . $status['code'] . '.' |
|
387 | + 'Status code is not '.$code.' but '.$status['code'].'.' |
|
388 | 388 | ); |
389 | 389 | } |
390 | 390 | } |
@@ -42,9 +42,9 @@ discard block |
||
42 | 42 | } |
43 | 43 | |
44 | 44 | // Handle single file |
45 | - $file =& $files[$field]; |
|
45 | + $file = & $files[$field]; |
|
46 | 46 | |
47 | - if (! file_exists($file['tmp_name'])) |
|
47 | + if ( ! file_exists($file['tmp_name'])) |
|
48 | 48 | { |
49 | 49 | $file['error'] = UPLOAD_ERR_NO_FILE; |
50 | 50 | $file['type'] = ''; |
@@ -110,7 +110,7 @@ discard block |
||
110 | 110 | // Set $_GET if URI string has query string |
111 | 111 | parse_str($query_string, $_GET); |
112 | 112 | // Remove query string from URI string |
113 | - $argv = substr($argv, 0, -strlen($query_string)-1); |
|
113 | + $argv = substr($argv, 0, -strlen($query_string) - 1); |
|
114 | 114 | } |
115 | 115 | } |
116 | 116 | |
@@ -143,12 +143,12 @@ discard block |
||
143 | 143 | if ($_GET !== []) |
144 | 144 | { |
145 | 145 | $_SERVER['REQUEST_URI'] = |
146 | - '/' . $path . '?' |
|
146 | + '/'.$path.'?' |
|
147 | 147 | . http_build_query($_GET); |
148 | 148 | } |
149 | 149 | else |
150 | 150 | { |
151 | - $_SERVER['REQUEST_URI'] = '/' . $path; |
|
151 | + $_SERVER['REQUEST_URI'] = '/'.$path; |
|
152 | 152 | } |
153 | 153 | } |
154 | 154 | |
@@ -165,7 +165,7 @@ discard block |
||
165 | 165 | |
166 | 166 | if ($query_string === false) |
167 | 167 | { |
168 | - throw new LogicException('Bad URI string: ' . $uri); |
|
168 | + throw new LogicException('Bad URI string: '.$uri); |
|
169 | 169 | } |
170 | 170 | |
171 | 171 | return $query_string; |
@@ -190,7 +190,7 @@ discard block |
||
190 | 190 | } |
191 | 191 | else |
192 | 192 | { |
193 | - $key = 'HTTP_' . $normalized_name; |
|
193 | + $key = 'HTTP_'.$normalized_name; |
|
194 | 194 | } |
195 | 195 | |
196 | 196 | $_SERVER[$key] = $value; |
@@ -76,8 +76,7 @@ discard block |
||
76 | 76 | if (is_numeric($value)) |
77 | 77 | { |
78 | 78 | return $value; |
79 | - } |
|
80 | - else |
|
79 | + } else |
|
81 | 80 | { |
82 | 81 | $value_length = strlen($value); |
83 | 82 | $number = substr($value, 0, $value_length - 1); |
@@ -133,8 +132,7 @@ discard block |
||
133 | 132 | if (is_string($argv)) |
134 | 133 | { |
135 | 134 | $path = $argv; |
136 | - } |
|
137 | - elseif (is_array($argv)) |
|
135 | + } elseif (is_array($argv)) |
|
138 | 136 | { |
139 | 137 | // Generate URI path from array of controller, method, arg, ... |
140 | 138 | $path = implode('/', $argv); |
@@ -145,8 +143,7 @@ discard block |
||
145 | 143 | $_SERVER['REQUEST_URI'] = |
146 | 144 | '/' . $path . '?' |
147 | 145 | . http_build_query($_GET); |
148 | - } |
|
149 | - else |
|
146 | + } else |
|
150 | 147 | { |
151 | 148 | $_SERVER['REQUEST_URI'] = '/' . $path; |
152 | 149 | } |
@@ -187,8 +184,7 @@ discard block |
||
187 | 184 | ) |
188 | 185 | { |
189 | 186 | $key = $normalized_name; |
190 | - } |
|
191 | - else |
|
187 | + } else |
|
192 | 188 | { |
193 | 189 | $key = 'HTTP_' . $normalized_name; |
194 | 190 | } |
@@ -293,8 +293,8 @@ discard block |
||
293 | 293 | { |
294 | 294 | empty($config) OR $this->initialize($config, FALSE); |
295 | 295 | |
296 | - $this->_mimes =& get_mimes(); |
|
297 | - $this->_CI =& get_instance(); |
|
296 | + $this->_mimes = & get_mimes(); |
|
297 | + $this->_CI = & get_instance(); |
|
298 | 298 | |
299 | 299 | log_message('info', 'Upload Class Initialized'); |
300 | 300 | } |
@@ -480,7 +480,7 @@ discard block |
||
480 | 480 | else |
481 | 481 | { |
482 | 482 | // An extension was provided, let's have it! |
483 | - $this->file_ext = $this->get_extension($this->_file_name_override); |
|
483 | + $this->file_ext = $this->get_extension($this->_file_name_override); |
|
484 | 484 | } |
485 | 485 | |
486 | 486 | if ( ! $this->is_allowed_filetype(TRUE)) |
@@ -493,7 +493,7 @@ discard block |
||
493 | 493 | // Convert the file size to kilobytes |
494 | 494 | if ($this->file_size > 0) |
495 | 495 | { |
496 | - $this->file_size = round($this->file_size/1024, 2); |
|
496 | + $this->file_size = round($this->file_size / 1024, 2); |
|
497 | 497 | } |
498 | 498 | |
499 | 499 | // Is the file size within the allowed maximum? |
@@ -818,10 +818,10 @@ discard block |
||
818 | 818 | { |
819 | 819 | $types = array(1 => 'gif', 2 => 'jpeg', 3 => 'png'); |
820 | 820 | |
821 | - $this->image_width = $D[0]; |
|
822 | - $this->image_height = $D[1]; |
|
823 | - $this->image_type = isset($types[$D[2]]) ? $types[$D[2]] : 'unknown'; |
|
824 | - $this->image_size_str = $D[3]; // string containing height and width |
|
821 | + $this->image_width = $D[0]; |
|
822 | + $this->image_height = $D[1]; |
|
823 | + $this->image_type = isset($types[$D[2]]) ? $types[$D[2]] : 'unknown'; |
|
824 | + $this->image_size_str = $D[3]; // string containing height and width |
|
825 | 825 | } |
826 | 826 | } |
827 | 827 | |
@@ -869,7 +869,7 @@ discard block |
||
869 | 869 | $this->file_type = 'image/jpeg'; |
870 | 870 | } |
871 | 871 | |
872 | - $img_mimes = array('image/gif', 'image/jpeg', 'image/png'); |
|
872 | + $img_mimes = array('image/gif', 'image/jpeg', 'image/png'); |
|
873 | 873 | |
874 | 874 | return in_array($this->file_type, $img_mimes, TRUE); |
875 | 875 | } |
@@ -1011,7 +1011,7 @@ discard block |
||
1011 | 1011 | return FALSE; |
1012 | 1012 | } |
1013 | 1013 | |
1014 | - $this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/', $this->upload_path); |
|
1014 | + $this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/', $this->upload_path); |
|
1015 | 1015 | return TRUE; |
1016 | 1016 | } |
1017 | 1017 | |
@@ -1055,9 +1055,9 @@ discard block |
||
1055 | 1055 | $ext = ''; |
1056 | 1056 | if (strpos($filename, '.') !== FALSE) |
1057 | 1057 | { |
1058 | - $parts = explode('.', $filename); |
|
1059 | - $ext = '.'.array_pop($parts); |
|
1060 | - $filename = implode('.', $parts); |
|
1058 | + $parts = explode('.', $filename); |
|
1059 | + $ext = '.'.array_pop($parts); |
|
1060 | + $filename = implode('.', $parts); |
|
1061 | 1061 | } |
1062 | 1062 | |
1063 | 1063 | return substr($filename, 0, ($length - strlen($ext))).$ext; |
@@ -327,19 +327,16 @@ discard block |
||
327 | 327 | if ($reflection->hasMethod('set_'.$key)) |
328 | 328 | { |
329 | 329 | $this->{'set_'.$key}($config[$key]); |
330 | - } |
|
331 | - else |
|
330 | + } else |
|
332 | 331 | { |
333 | 332 | $this->$key = $config[$key]; |
334 | 333 | } |
335 | - } |
|
336 | - else |
|
334 | + } else |
|
337 | 335 | { |
338 | 336 | $this->$key = $defaults[$key]; |
339 | 337 | } |
340 | 338 | } |
341 | - } |
|
342 | - else |
|
339 | + } else |
|
343 | 340 | { |
344 | 341 | foreach ($config as $key => &$value) |
345 | 342 | { |
@@ -348,8 +345,7 @@ discard block |
||
348 | 345 | if ($reflection->hasMethod('set_'.$key)) |
349 | 346 | { |
350 | 347 | $this->{'set_'.$key}($value); |
351 | - } |
|
352 | - else |
|
348 | + } else |
|
353 | 349 | { |
354 | 350 | $this->$key = $value; |
355 | 351 | } |
@@ -409,9 +405,11 @@ discard block |
||
409 | 405 | } |
410 | 406 | |
411 | 407 | // Was the file able to be uploaded? If not, determine the reason why. |
412 | - if ( ! file_exists($_file['tmp_name'])) // modified by ci-phpunit-test |
|
408 | + if ( ! file_exists($_file['tmp_name'])) { |
|
409 | + // modified by ci-phpunit-test |
|
413 | 410 | { |
414 | 411 | $error = isset($_file['error']) ? $_file['error'] : 4; |
412 | + } |
|
415 | 413 | |
416 | 414 | switch ($error) |
417 | 415 | { |
@@ -476,8 +474,7 @@ discard block |
||
476 | 474 | if (strpos($this->_file_name_override, '.') === FALSE) |
477 | 475 | { |
478 | 476 | $this->file_name .= $this->file_ext; |
479 | - } |
|
480 | - else |
|
477 | + } else |
|
481 | 478 | { |
482 | 479 | // An extension was provided, let's have it! |
483 | 480 | $this->file_ext = $this->get_extension($this->_file_name_override); |
@@ -677,8 +674,7 @@ discard block |
||
677 | 674 | { |
678 | 675 | $this->set_error('upload_bad_filename', 'debug'); |
679 | 676 | return FALSE; |
680 | - } |
|
681 | - else |
|
677 | + } else |
|
682 | 678 | { |
683 | 679 | return $new_filename; |
684 | 680 | } |
@@ -863,8 +859,7 @@ discard block |
||
863 | 859 | if (in_array($this->file_type, $png_mimes)) |
864 | 860 | { |
865 | 861 | $this->file_type = 'image/png'; |
866 | - } |
|
867 | - elseif (in_array($this->file_type, $jpeg_mimes)) |
|
862 | + } elseif (in_array($this->file_type, $jpeg_mimes)) |
|
868 | 863 | { |
869 | 864 | $this->file_type = 'image/jpeg'; |
870 | 865 | } |
@@ -1116,9 +1111,12 @@ discard block |
||
1116 | 1111 | |
1117 | 1112 | if (function_exists('getimagesize') && @getimagesize($file) !== FALSE) |
1118 | 1113 | { |
1119 | - if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary |
|
1114 | + if (($file = @fopen($file, 'rb')) === FALSE) { |
|
1115 | + // "b" to force binary |
|
1120 | 1116 | { |
1121 | - return FALSE; // Couldn't open the file, return FALSE |
|
1117 | + return FALSE; |
|
1118 | + } |
|
1119 | + // Couldn't open the file, return FALSE |
|
1122 | 1120 | } |
1123 | 1121 | |
1124 | 1122 | $opening_bytes = fread($file, 256); |
@@ -1220,9 +1218,11 @@ discard block |
||
1220 | 1218 | |
1221 | 1219 | // Fileinfo extension - most reliable method |
1222 | 1220 | $finfo = @finfo_open(FILEINFO_MIME); |
1223 | - if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system |
|
1221 | + if (is_resource($finfo)) { |
|
1222 | + // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system |
|
1224 | 1223 | { |
1225 | 1224 | $mime = @finfo_file($finfo, $file['tmp_name']); |
1225 | + } |
|
1226 | 1226 | finfo_close($finfo); |
1227 | 1227 | |
1228 | 1228 | /* According to the comments section of the PHP manual page, |
@@ -1306,10 +1306,12 @@ discard block |
||
1306 | 1306 | if (function_exists('mime_content_type')) |
1307 | 1307 | { |
1308 | 1308 | $this->file_type = @mime_content_type($file['tmp_name']); |
1309 | - if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string |
|
1309 | + if (strlen($this->file_type) > 0) { |
|
1310 | + // It's possible that mime_content_type() returns FALSE or an empty string |
|
1310 | 1311 | { |
1311 | 1312 | return; |
1312 | 1313 | } |
1314 | + } |
|
1313 | 1315 | } |
1314 | 1316 | |
1315 | 1317 | $this->file_type = $file['type']; |