Installer::update() - Code Metrics - Inspection of "Allow setting a custom test path." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#362)

by Kenji

created 2021-02-24 06:33 UTC

Installer::update() A

↳ Parent: Installer

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer
{
    private $silent = false;
    private $app_dir = 'application';  // -a DIRECTORY
    private $pub_dir = 'public';       // -p DIRECTORY
    private $test_dir = null;          // -t DIRECTORY
    private $from_composer = false;

    public function __construct($argv)
    {
        $this->parse_args($argv);
    }

    private function parse_args($argv)
    {
        $argc = count($argv);

        if ($argc === 1) {
            return;
        }

        for ($i = 1; $i <= $argc; $i++) {
            if (! isset($argv[$i])) {
                break;
            }

            switch ($argv[$i]) {
                // php install.php -s
                case '-s':
                    $this->silent = true;
                    break;

                // php install.php -a application
                case '-a':

                    if (is_dir($argv[$i+1])) {
                        $this->app_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such application directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;

                // php install.php -p public
                case '-p':

                    if (is_dir($argv[$i+1])) {
                        $this->pub_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such public directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;
                // php install.php -t application/tests
                case '-t':

                    if (is_dir($argv[$i+1])) {
                        $this->test_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such test directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;

                case '--from-composer':
                    $this->from_composer = true;
                    $i++;
                    break;

                default:
                    throw new Exception('Unknown argument: '.$argv[$i]);
            }
        }
        if (is_null($this->test_dir)) {
            $test_dir = $this->app_dir.'/tests';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }

    public function install()
    {
        $this->recursiveCopy(
            dirname(dirname(__FILE__)).'/application/tests',
            $this->test_dir
        );
        $this->fixPath();
        if ($this->from_composer) {
            $this->recursiveUnlink($this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test');
        }
    }

    /**
     * Fix paths in Bootstrap.php
     *
     * @FIXME Too ad hoc. Must rewrite, because can't handle complex paths.
     */
    private function fixPath()
    {
        $file = $this->test_dir.'/Bootstrap.php';
        $contents = file_get_contents($file);

        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }

        if (! file_exists('index.php')) {
            if (file_exists($this->pub_dir.'/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
                    $contents
                );
            } elseif (file_exists($this->app_dir.'/public/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($this->app_dir !== 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$this->app_dir}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }

        file_put_contents($file, $contents);
    }

    public function update()
    {
        $target_dir = $this->test_dir.'/_ci_phpunit_test';
        $this->recursiveUnlink($target_dir);
        $this->recursiveCopy(
            dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst.'/'.$iterator->getSubPathName());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            } else {
                $success = copy($file, $dst.'/'.$iterator->getSubPathName());
                if ($success) {
                    if (! $this->silent) {
                        echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private function recursiveUnlink($dir)

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }

        rmdir($dir);
    }
}


1		<?php
2		/**
3		* Part of ci-phpunit-test
4		*
5		* @author Kenji Suzuki <https://github.com/kenjis>
6		* @license MIT License
7		* @copyright 2015 Kenji Suzuki
8		* @link https://github.com/kenjis/ci-phpunit-test
9		*/
10
11		class Installer
12		{
13		private $silent = false;
14		private $app_dir = 'application'; // -a DIRECTORY
15		private $pub_dir = 'public'; // -p DIRECTORY
16		private $test_dir = null; // -t DIRECTORY
17		private $from_composer = false;
18
19		public function __construct($argv)
20		{
21		$this->parse_args($argv);
22		}
23
24		private function parse_args($argv)
25		{
26		$argc = count($argv);
27
28		if ($argc === 1) {
29		return;
30		}
31
32		for ($i = 1; $i <= $argc; $i++) {
33		if (! isset($argv[$i])) {
34		break;
35		}
36
37		switch ($argv[$i]) {
38		// php install.php -s
39		case '-s':
40		$this->silent = true;
41		break;
42
43		// php install.php -a application
44	View Code Duplication	case '-a':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		if (is_dir($argv[$i+1])) {
46		$this->app_dir = $argv[$i+1];
47		} else {
48		throw new Exception('No such application directory: '.$argv[$i+1]);
49		}
50		$i++;
51		break;
52
53		// php install.php -p public
54	View Code Duplication	case '-p':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		if (is_dir($argv[$i+1])) {
56		$this->pub_dir = $argv[$i+1];
57		} else {
58		throw new Exception('No such public directory: '.$argv[$i+1]);
59		}
60		$i++;
61		break;
62		// php install.php -t application/tests
63	View Code Duplication	case '-t':
		0 ignored issues – show Duplication introduced 2019-07-01 17:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		if (is_dir($argv[$i+1])) {
65		$this->test_dir = $argv[$i+1];
66		} else {
67		throw new Exception('No such test directory: '.$argv[$i+1]);
68		}
69		$i++;
70		break;
71
72		case '--from-composer':
73		$this->from_composer = true;
74		$i++;
75		break;
76
77		default:
78		throw new Exception('Unknown argument: '.$argv[$i]);
79		}
80		}
81		if (is_null($this->test_dir)) {
82		$test_dir = $this->app_dir.'/tests';
		0 ignored issues – show Unused Code introduced 2019-07-01 17:29 UTC by Report Bug Copy Issue Report `$test_dir` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
83		}
84		}
85
86		public function install()
87		{
88		$this->recursiveCopy(
89		dirname(dirname(__FILE__)).'/application/tests',
90		$this->test_dir
91		);
92		$this->fixPath();
93		if ($this->from_composer) {
94		$this->recursiveUnlink($this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test');
95		}
96		}
97
98		/**
99		* Fix paths in Bootstrap.php
100		*
101		* @FIXME Too ad hoc. Must rewrite, because can't handle complex paths.
102		*/
103		private function fixPath()
104		{
105		$file = $this->test_dir.'/Bootstrap.php';
106		$contents = file_get_contents($file);
107
108		if (! file_exists('system')) {
109		if (file_exists('vendor/codeigniter/framework/system')) {
110		$contents = str_replace(
111		'$system_path = \'../../system\';',
112		'$system_path = \'../../vendor/codeigniter/framework/system\';',
113		$contents
114		);
115		} else {
116		throw new Exception('Can\'t find "system" folder.');
117		}
118		}
119
120		if (! file_exists('index.php')) {
121		if (file_exists($this->pub_dir.'/index.php')) {
122		// CodeIgniter 3.0.6 and after
123		$contents = str_replace(
124		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
125		"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
126		$contents
127		);
128		// CodeIgniter 3.0.5 and before
129		$contents = str_replace(
130		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
131		"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
132		$contents
133		);
134		} elseif (file_exists($this->app_dir.'/public/index.php')) {
135		// CodeIgniter 3.0.6 and after
136		$contents = str_replace(
137		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
138		"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
139		$contents
140		);
141		// CodeIgniter 3.0.5 and before
142		$contents = str_replace(
143		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
144		"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
145		$contents
146		);
147		if ($this->app_dir !== 'application') {
148		$contents = str_replace(
149		"\$application_folder = '../../application';",
150		"\$application_folder = '../../{$this->app_dir}';",
151		$contents
152		);
153		}
154		} else {
155		throw new Exception('Can\'t find "index.php".');
156		}
157		}
158
159		file_put_contents($file, $contents);
160		}
161
162		public function update()
163		{
164		$target_dir = $this->test_dir.'/_ci_phpunit_test';
165		$this->recursiveUnlink($target_dir);
166		$this->recursiveCopy(
167		dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
168		$target_dir
169		);
170		}
171
172		/**
173		* Recursive Copy
174		*
175		* @param string $src
176		* @param string $dst
177		*/
178		private function recursiveCopy($src, $dst)
179		{
180		@mkdir($dst, 0755);
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
181
182		$iterator = new \RecursiveIteratorIterator(
183		new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
184		\RecursiveIteratorIterator::SELF_FIRST
185		);
186
187		foreach ($iterator as $file) {
188		if ($file->isDir()) {
189		@mkdir($dst.'/'.$iterator->getSubPathName());
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
190		} else {
191		$success = copy($file, $dst.'/'.$iterator->getSubPathName());
192		if ($success) {
193		if (! $this->silent) {
194		echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
195		}
196		}
197		}
198		}
199		}
200
201		/**
202		* Recursive Unlink
203		*
204		* @param string $dir
205		*/
206	View Code Duplication	private function recursiveUnlink($dir)
		0 ignored issues – show Duplication introduced 2017-08-21 08:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
207		{
208		$iterator = new \RecursiveIteratorIterator(
209		new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
210		\RecursiveIteratorIterator::CHILD_FIRST
211		);
212
213		foreach ($iterator as $file) {
214		if ($file->isDir()) {
215		rmdir($file);
216		} else {
217		unlink($file);
218		}
219		}
220
221		rmdir($dir);
222		}
223		}
224

kenjis / ci-phpunit-test

Pull Request — master (#362)

Installer::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like