Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class Installer |
||
|
|
|||
| 12 | { |
||
| 13 | const TEST_FOLDER = 'application/tests'; |
||
| 14 | |||
| 15 | public static function install() |
||
| 16 | { |
||
| 17 | self::recursiveCopy( |
||
| 18 | 'vendor/kenjis/ci-phpunit-test/application/tests', |
||
| 19 | static::TEST_FOLDER |
||
| 20 | ); |
||
| 21 | self::fixPath(); |
||
| 22 | } |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Fix paths in Bootstrap.php |
||
| 26 | */ |
||
| 27 | private static function fixPath() |
||
| 28 | { |
||
| 29 | $file = static::TEST_FOLDER . '/Bootstrap.php'; |
||
| 30 | $contents = file_get_contents($file); |
||
| 31 | |||
| 32 | View Code Duplication | if (! file_exists('system')) { |
|
| 33 | if (file_exists('vendor/codeigniter/framework/system')) { |
||
| 34 | $contents = str_replace( |
||
| 35 | '$system_path = \'../../system\';', |
||
| 36 | '$system_path = \'../../vendor/codeigniter/framework/system\';', |
||
| 37 | $contents |
||
| 38 | ); |
||
| 39 | } else { |
||
| 40 | throw new Exception('Can\'t find "system" folder.'); |
||
| 41 | } |
||
| 42 | } |
||
| 43 | |||
| 44 | View Code Duplication | if (! file_exists('index.php')) { |
|
| 45 | if (file_exists('public/index.php')) { |
||
| 46 | $contents = str_replace( |
||
| 47 | "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');", |
||
| 48 | "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');", |
||
| 49 | $contents |
||
| 50 | ); |
||
| 51 | } else { |
||
| 52 | throw new Exception('Can\'t find "index.php".'); |
||
| 53 | } |
||
| 54 | } |
||
| 55 | |||
| 56 | file_put_contents($file, $contents); |
||
| 57 | } |
||
| 58 | |||
| 59 | public static function update() |
||
| 60 | { |
||
| 61 | self::recursiveUnlink('application/tests/_ci_phpunit_test'); |
||
| 62 | self::recursiveCopy( |
||
| 63 | 'vendor/kenjis/ci-phpunit-test/application/tests/_ci_phpunit_test', |
||
| 64 | 'application/tests/_ci_phpunit_test' |
||
| 65 | ); |
||
| 66 | } |
||
| 67 | |||
| 68 | /** |
||
| 69 | * Recursive Copy |
||
| 70 | * |
||
| 71 | * @param string $src |
||
| 72 | * @param string $dst |
||
| 73 | */ |
||
| 74 | private static function recursiveCopy($src, $dst) |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Recursive Unlink |
||
| 97 | * |
||
| 98 | * @param string $dir |
||
| 99 | */ |
||
| 100 | View Code Duplication | private static function recursiveUnlink($dir) |
|
| 117 | } |
||
| 118 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.