Inspection of "Fix Monkey Patch" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#364)

by Kenji

created 2021-02-26 11:04 UTC

Status

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -44,8 +44,7 @@  discard block
 block discarded – undo
 				APPPATH.'modules',
 				APPPATH.'hooks',
 			];
-		}
-		else
+		} else
 		{
 			$this->dirs = $dirs;
 		}
@@ -86,8 +85,7 @@  discard block
 block discarded – undo
 		{
 			$dir = __DIR__;
 			$this->loadClassFile($dir, $class);
-		}
-		else
+		} else
 		{
 			$dir = __DIR__ . '/exceptions';
 			$this->loadClassFile($dir, $class);
@@ -152,8 +150,7 @@  discard block
 block discarded – undo
 			{
 				require $filename;
 				return true;
-			}
-			else
+			} else
 			{
 				unset($this->cache[$class]);
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ExitPatcher.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -27,20 +27,17 @@
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($token[0] === T_EXIT)
+			} elseif ($token[0] === T_EXIT)
 			{
 				if ($tokens[$i+1] === ';')
 				{
 					$new_source .= 'exit__()';
-				}
-				else
+				} else
 				{
 					$new_source .= 'exit__';
 				}
 				$patched = true;
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/AbstractPatcher.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -38,8 +38,7 @@
 block discarded – undo
 		{
 			$patched = true;
 			$new_source = static::generateNewSource($source);
-		}
-		else
+		} else
 		{
 			$new_source = $source;
 		}

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher/PatchManager.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -56,12 +56,10 @@  discard block
 block discarded – undo
 			if (isset($info['class_method']))
 			{
 				$called_method = $info['class_method'];
-			}
-			elseif (isset($info['function']))
+			} elseif (isset($info['function']))
 			{
 				$called_method = $info['function'];
-			}
-			else
+			} else
 			{
 				$called_method = 'n/a';
 			}
@@ -88,8 +86,7 @@  discard block
 block discarded – undo
 		)
 		{
 			$patch = self::$patches[$class][$method];
-		}
-		else
+		} else
 		{
 			return __GO_TO_ORIG__;
 		}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/Backtrace.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -47,8 +47,7 @@  discard block
 block discarded – undo
 					? $backtrace[$offset+2]['class']
 					: null;
 			$function = $backtrace[$offset+2]['function'];
-		}
-		else
+		} else
 		{
 			$class = null;
 			$function = null;
@@ -59,8 +58,7 @@  discard block
 block discarded – undo
 			$method = $function;
 			$class_method = $class . '::' . $function;
 			$function = null;
-		}
-		else
+		} else
 		{
 			$method = null;
 			$class_method = null;

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/MonkeyPatchManager.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,8 +70,7 @@
 block discarded – undo
 		if (isset($config['root_dir']))
 		{
 			Cache::setProjectRootDir($config['root_dir']);
-		}
-		else
+		} else
 		{
 			// APPPATH is constant in CodeIgniter
 			Cache::setProjectRootDir(APPPATH . '../');

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/ExitPatcher.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -27,20 +27,17 @@
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($token[0] === T_EXIT)
+			} elseif ($token[0] === T_EXIT)
 			{
 				if ($tokens[$i+1] === ';')
 				{
 					$new_source .= 'exit__()';
-				}
-				else
+				} else
 				{
 					$new_source .= 'exit__';
 				}
 				$patched = true;
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/AbstractPatcher.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -38,8 +38,7 @@
 block discarded – undo
 		{
 			$patched = true;
 			$new_source = static::generateNewSource($source);
-		}
-		else
+		} else
 		{
 			$new_source = $source;
 		}

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/2.x/Patcher/MethodPatcher/PatchManager.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -56,12 +56,10 @@  discard block
 block discarded – undo
 			if (isset($info['class_method']))
 			{
 				$called_method = $info['class_method'];
-			}
-			elseif (isset($info['function']))
+			} elseif (isset($info['function']))
 			{
 				$called_method = $info['function'];
-			}
-			else
+			} else
 			{
 				$called_method = 'n/a';
 			}
@@ -88,8 +86,7 @@  discard block
 block discarded – undo
 		)
 		{
 			$patch = self::$patches[$class][$method];
-		}
-		else
+		} else
 		{
 			return __GO_TO_ORIG__;
 		}

Please login to merge, or discard this patch.

		@@ -27,20 +27,17 @@
		block discarded – undo
27	27	if (is_string($token))
28	28	{
29	29	$new_source .= $token;
30		- }
31		- elseif ($token[0] === T_EXIT)
	30	+ } elseif ($token[0] === T_EXIT)
32	31	{
33	32	if ($tokens[$i+1] === ';')
34	33	{
35	34	$new_source .= 'exit__()';
36		- }
37		- else
	35	+ } else
38	36	{
39	37	$new_source .= 'exit__';
40	38	}
41	39	$patched = true;
42		- }
43		- else
	40	+ } else
44	41	{
45	42	$new_source .= $token[1];
46	43	}

		@@ -70,8 +70,7 @@
		block discarded – undo
70	70	if (isset($config['root_dir']))
71	71	{
72	72	Cache::setProjectRootDir($config['root_dir']);
73		- }
74		- else
	73	+ } else
75	74	{
76	75	// APPPATH is constant in CodeIgniter
77	76	Cache::setProjectRootDir(APPPATH . '../');

		@@ -27,20 +27,17 @@
		block discarded – undo
27	27	if (is_string($token))
28	28	{
29	29	$new_source .= $token;
30		- }
31		- elseif ($token[0] === T_EXIT)
	30	+ } elseif ($token[0] === T_EXIT)
32	31	{
33	32	if ($tokens[$i+1] === ';')
34	33	{
35	34	$new_source .= 'exit__()';
36		- }
37		- else
	35	+ } else
38	36	{
39	37	$new_source .= 'exit__';
40	38	}
41	39	$patched = true;
42		- }
43		- else
	40	+ } else
44	41	{
45	42	$new_source .= $token[1];
46	43	}

		@@ -44,8 +44,7 @@ discard block
		block discarded – undo
44	44	APPPATH.'modules',
45	45	APPPATH.'hooks',
46	46	];
47		- }
48		- else
	47	+ } else
49	48	{
50	49	$this->dirs = $dirs;
51	50	}
		@@ -86,8 +85,7 @@ discard block
		block discarded – undo
86	85	{
87	86	$dir = __DIR__;
88	87	$this->loadClassFile($dir, $class);
89		- }
90		- else
	88	+ } else
91	89	{
92	90	$dir = __DIR__ . '/exceptions';
93	91	$this->loadClassFile($dir, $class);
		@@ -152,8 +150,7 @@ discard block
		block discarded – undo
152	150	{
153	151	require $filename;
154	152	return true;
155		- }
156		- else
	153	+ } else
157	154	{
158	155	unset($this->cache[$class]);
159	156	}

		@@ -38,8 +38,7 @@
		block discarded – undo
38	38	{
39	39	$patched = true;
40	40	$new_source = static::generateNewSource($source);
41		- }
42		- else
	41	+ } else
43	42	{
44	43	$new_source = $source;
45	44	}

		@@ -56,12 +56,10 @@ discard block
		block discarded – undo
56	56	if (isset($info['class_method']))
57	57	{
58	58	$called_method = $info['class_method'];
59		- }
60		- elseif (isset($info['function']))
	59	+ } elseif (isset($info['function']))
61	60	{
62	61	$called_method = $info['function'];
63		- }
64		- else
	62	+ } else
65	63	{
66	64	$called_method = 'n/a';
67	65	}
		@@ -88,8 +86,7 @@ discard block
		block discarded – undo
88	86	)
89	87	{
90	88	$patch = self::$patches[$class][$method];
91		- }
92		- else
	89	+ } else
93	90	{
94	91	return __GO_TO_ORIG__;
95	92	}

		@@ -47,8 +47,7 @@ discard block
		block discarded – undo
47	47	? $backtrace[$offset+2]['class']
48	48	: null;
49	49	$function = $backtrace[$offset+2]['function'];
50		- }
51		- else
	50	+ } else
52	51	{
53	52	$class = null;
54	53	$function = null;
		@@ -59,8 +58,7 @@ discard block
		block discarded – undo
59	58	$method = $function;
60	59	$class_method = $class . '::' . $function;
61	60	$function = null;
62		- }
63		- else
	61	+ } else
64	62	{
65	63	$method = null;
66	64	$class_method = null;

kenjis / ci-phpunit-test

Pull Request — master (#364)

Status

Category

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch