Installer::fixPath() - Code Metrics - Inspection of "Improve install arguments, add custom public dir." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#232)

unknown

created 2018-03-06 15:41 UTC

Installer::fixPath() B

↳ Parent: Installer

Complexity

Conditions	7
Paths	11

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	38
nc	11
nop	2
dl	0
loc	58
rs	7.6045
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer
namespace YourVendor;

class YourClass { }
{
    const TEST_FOLDER = 'tests';

    private $silent = false;

    public function __construct($silent = false)
    {
        $this->silent = $silent;
    }

    public function install($app = 'application', $pub = 'public')
    {
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests',
            $app . '/' . static::TEST_FOLDER
        );
        $this->fixPath($app, $pub);
    }

    /**
     * Fix paths in Bootstrap.php
     */
    private function fixPath($app = 'application', $pub = 'public')
    {
        $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
        $contents = file_get_contents($file);
        
        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }
        
        if (! file_exists('index.php')) {
            if (file_exists($pub . '/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../'. $pub).DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../' . $pub).'/');",
                    $contents
                );
            } elseif (file_exists($app . '/public/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($app != 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$app}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }
        
        file_put_contents($file, $contents);
    }

    public function update($app = 'application')
    {
        $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
        $this->recursiveUnlink($target_dir);
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );
        
        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst . '/' . $iterator->getSubPathName());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            } else {
                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
                if ($success) {
                    if (! $this->silent) {
                        echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private function recursiveUnlink($dir)

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );
        
        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }
        
        rmdir($dir);
    }
}


1		<?php
2		/**
3		* Part of ci-phpunit-test
4		*
5		* @author Kenji Suzuki <https://github.com/kenjis>
6		* @license MIT License
7		* @copyright 2015 Kenji Suzuki
8		* @link https://github.com/kenjis/ci-phpunit-test
9		*/
10
11		class Installer
		0 ignored issues – show Coding Style Compatibility introduced 2017-04-19 04:17 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		const TEST_FOLDER = 'tests';
14
15		private $silent = false;
16
17		public function __construct($silent = false)
18		{
19		$this->silent = $silent;
20		}
21
22		public function install($app = 'application', $pub = 'public')
23		{
24		$this->recursiveCopy(
25		dirname(__FILE__) . '/application/tests',
26		$app . '/' . static::TEST_FOLDER
27		);
28		$this->fixPath($app, $pub);
29		}
30
31		/**
32		* Fix paths in Bootstrap.php
33		*/
34		private function fixPath($app = 'application', $pub = 'public')
35		{
36		$file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
37		$contents = file_get_contents($file);
38
39		if (! file_exists('system')) {
40		if (file_exists('vendor/codeigniter/framework/system')) {
41		$contents = str_replace(
42		'$system_path = \'../../system\';',
43		'$system_path = \'../../vendor/codeigniter/framework/system\';',
44		$contents
45		);
46		} else {
47		throw new Exception('Can\'t find "system" folder.');
48		}
49		}
50
51		if (! file_exists('index.php')) {
52		if (file_exists($pub . '/index.php')) {
53		// CodeIgniter 3.0.6 and after
54		$contents = str_replace(
55		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
56		"define('FCPATH', realpath(dirname(__FILE__).'/../../'. $pub).DIRECTORY_SEPARATOR);",
57		$contents
58		);
59		// CodeIgniter 3.0.5 and before
60		$contents = str_replace(
61		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
62		"define('FCPATH', realpath(dirname(__FILE__).'/../../' . $pub).'/');",
63		$contents
64		);
65		} elseif (file_exists($app . '/public/index.php')) {
66		// CodeIgniter 3.0.6 and after
67		$contents = str_replace(
68		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
69		"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
70		$contents
71		);
72		// CodeIgniter 3.0.5 and before
73		$contents = str_replace(
74		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
75		"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
76		$contents
77		);
78		if ($app != 'application') {
79		$contents = str_replace(
80		"\$application_folder = '../../application';",
81		"\$application_folder = '../../{$app}';",
82		$contents
83		);
84		}
85		} else {
86		throw new Exception('Can\'t find "index.php".');
87		}
88		}
89
90		file_put_contents($file, $contents);
91		}
92
93		public function update($app = 'application')
94		{
95		$target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
96		$this->recursiveUnlink($target_dir);
97		$this->recursiveCopy(
98		dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
99		$target_dir
100		);
101		}
102
103		/**
104		* Recursive Copy
105		*
106		* @param string $src
107		* @param string $dst
108		*/
109		private function recursiveCopy($src, $dst)
110		{
111		@mkdir($dst, 0755);
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
112
113		$iterator = new \RecursiveIteratorIterator(
114		new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
115		\RecursiveIteratorIterator::SELF_FIRST
116		);
117
118		foreach ($iterator as $file) {
119		if ($file->isDir()) {
120		@mkdir($dst . '/' . $iterator->getSubPathName());
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
121		} else {
122		$success = copy($file, $dst . '/' . $iterator->getSubPathName());
123		if ($success) {
124		if (! $this->silent) {
125		echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
126		}
127		}
128		}
129		}
130		}
131
132		/**
133		* Recursive Unlink
134		*
135		* @param string $dir
136		*/
137	View Code Duplication	private function recursiveUnlink($dir)
		0 ignored issues – show Duplication introduced 2017-08-21 08:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
138		{
139		$iterator = new \RecursiveIteratorIterator(
140		new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
141		\RecursiveIteratorIterator::CHILD_FIRST
142		);
143
144		foreach ($iterator as $file) {
145		if ($file->isDir()) {
146		rmdir($file);
147		} else {
148		unlink($file);
149		}
150		}
151
152		rmdir($dir);
153		}
154		}
155

kenjis / ci-phpunit-test

Pull Request — master (#232)

Installer::fixPath() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like