Completed
Pull Request — master (#364)
by Kenji
02:19
created
application/tests/_ci_phpunit_test/replacing/core/old/3.0.6-CodeIgniter.php 1 patch
Braces   +9 added lines, -18 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,16 +419,14 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
@@ -475,8 +468,7 @@  discard block
 block discarded – undo
475 468
 						$RTR->directory = '';
476 469
 					}
477 470
 				}
478
-			}
479
-			else
471
+			} else
480 472
 			{
481 473
 				$e404 = FALSE;
482 474
 			}
@@ -492,8 +484,7 @@  discard block
 block discarded – undo
492 484
 				1 => $class,
493 485
 				2 => $method
494 486
 			);
495
-		}
496
-		else
487
+		} else
497 488
 		{
498 489
 			show_404($RTR->directory.$class.'/'.$method);
499 490
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/libraries/old/3.1.3-Upload.php 1 patch
Braces   +21 added lines, -19 removed lines patch added patch discarded remove patch
@@ -331,19 +331,16 @@  discard block
 block discarded – undo
331 331
 					if ($reflection->hasMethod('set_'.$key))
332 332
 					{
333 333
 						$this->{'set_'.$key}($config[$key]);
334
-					}
335
-					else
334
+					} else
336 335
 					{
337 336
 						$this->$key = $config[$key];
338 337
 					}
339
-				}
340
-				else
338
+				} else
341 339
 				{
342 340
 					$this->$key = $defaults[$key];
343 341
 				}
344 342
 			}
345
-		}
346
-		else
343
+		} else
347 344
 		{
348 345
 			foreach ($config as $key => &$value)
349 346
 			{
@@ -352,8 +349,7 @@  discard block
 block discarded – undo
352 349
 					if ($reflection->hasMethod('set_'.$key))
353 350
 					{
354 351
 						$this->{'set_'.$key}($value);
355
-					}
356
-					else
352
+					} else
357 353
 					{
358 354
 						$this->$key = $value;
359 355
 					}
@@ -415,9 +411,11 @@  discard block
 block discarded – undo
415 411
 		}
416 412
 
417 413
 		// Was the file able to be uploaded? If not, determine the reason why.
418
-		if ( ! file_exists($_file['tmp_name']))	// modified by ci-phpunit-test
414
+		if ( ! file_exists($_file['tmp_name'])) {
415
+			// modified by ci-phpunit-test
419 416
 		{
420 417
 			$error = isset($_file['error']) ? $_file['error'] : 4;
418
+		}
421 419
 
422 420
 			switch ($error)
423 421
 			{
@@ -482,8 +480,7 @@  discard block
 block discarded – undo
482 480
 			if (strpos($this->_file_name_override, '.') === FALSE)
483 481
 			{
484 482
 				$this->file_name .= $this->file_ext;
485
-			}
486
-			else
483
+			} else
487 484
 			{
488 485
 				// An extension was provided, let's have it!
489 486
 				$this->file_ext	= $this->get_extension($this->_file_name_override);
@@ -687,8 +684,7 @@  discard block
 block discarded – undo
687 684
 		{
688 685
 			$this->set_error('upload_bad_filename', 'debug');
689 686
 			return FALSE;
690
-		}
691
-		else
687
+		} else
692 688
 		{
693 689
 			return $new_filename;
694 690
 		}
@@ -883,8 +879,7 @@  discard block
 block discarded – undo
883 879
 		if (in_array($this->file_type, $png_mimes))
884 880
 		{
885 881
 			$this->file_type = 'image/png';
886
-		}
887
-		elseif (in_array($this->file_type, $jpeg_mimes))
882
+		} elseif (in_array($this->file_type, $jpeg_mimes))
888 883
 		{
889 884
 			$this->file_type = 'image/jpeg';
890 885
 		}
@@ -1150,9 +1145,12 @@  discard block
 block discarded – undo
1150 1145
 
1151 1146
 		if (function_exists('getimagesize') && @getimagesize($file) !== FALSE)
1152 1147
 		{
1153
-			if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary
1148
+			if (($file = @fopen($file, 'rb')) === FALSE) {
1149
+				// "b" to force binary
1154 1150
 			{
1155
-				return FALSE; // Couldn't open the file, return FALSE
1151
+				return FALSE;
1152
+			}
1153
+			// Couldn't open the file, return FALSE
1156 1154
 			}
1157 1155
 
1158 1156
 			$opening_bytes = fread($file, 256);
@@ -1271,9 +1269,11 @@  discard block
 block discarded – undo
1271 1269
 		if (function_exists('finfo_file'))
1272 1270
 		{
1273 1271
 			$finfo = @finfo_open(FILEINFO_MIME);
1274
-			if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1272
+			if (is_resource($finfo)) {
1273
+				// It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1275 1274
 			{
1276 1275
 				$mime = @finfo_file($finfo, $file['tmp_name']);
1276
+			}
1277 1277
 				finfo_close($finfo);
1278 1278
 
1279 1279
 				/* According to the comments section of the PHP manual page,
@@ -1358,10 +1358,12 @@  discard block
 block discarded – undo
1358 1358
 		if (function_exists('mime_content_type'))
1359 1359
 		{
1360 1360
 			$this->file_type = @mime_content_type($file['tmp_name']);
1361
-			if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string
1361
+			if (strlen($this->file_type) > 0) {
1362
+				// It's possible that mime_content_type() returns FALSE or an empty string
1362 1363
 			{
1363 1364
 				return;
1364 1365
 			}
1366
+			}
1365 1367
 		}
1366 1368
 
1367 1369
 		$this->file_type = $file['type'];
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.3-CodeIgniter.php 1 patch
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.3-Common.php 1 patch
Braces   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -158,14 +158,16 @@  discard block
 block discarded – undo
158 158
 	if ($status_code < 100)
159 159
 	{
160 160
 		$exit_status = $status_code + 9; // 9 is EXIT__AUTO_MIN
161
-		if ($exit_status > 125) // 125 is EXIT__AUTO_MAX
161
+		if ($exit_status > 125) {
162
+			// 125 is EXIT__AUTO_MAX
162 163
 		{
163
-			$exit_status = 1; // EXIT_ERROR
164
+			$exit_status = 1;
165
+		}
166
+		// EXIT_ERROR
164 167
 		}
165 168
 
166 169
 		$status_code = 500;
167
-	}
168
-	else
170
+	} else
169 171
 	{
170 172
 		$exit_status = 1; // EXIT_ERROR
171 173
 	}
@@ -254,8 +256,7 @@  discard block
 block discarded – undo
254 256
 		if (isset($stati[$code]))
255 257
 		{
256 258
 			$text = $stati[$code];
257
-		}
258
-		else
259
+		} else
259 260
 		{
260 261
 			show_error('No status text available. Please check your status code number or supply your own message text.', 500);
261 262
 		}
@@ -281,8 +282,7 @@  discard block
 block discarded – undo
281 282
 	if (strpos(PHP_SAPI, 'cgi') === 0)
282 283
 	{
283 284
 		header('Status: '.$code.' '.$text, TRUE);
284
-	}
285
-	else
285
+	} else
286 286
 	{
287 287
 		$server_protocol = isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.1';
288 288
 		header($server_protocol.' '.$code.' '.$text, TRUE, $code);
@@ -325,8 +325,7 @@  discard block
 block discarded – undo
325 325
 		if (file_exists($file_path = APPPATH.'config/'.ENVIRONMENT.'/config.php'))
326 326
 		{
327 327
 			require($file_path);
328
-		}
329
-		elseif ( ! $found)
328
+		} elseif ( ! $found)
330 329
 		{
331 330
 			set_status_header(503);
332 331
 			echo 'The configuration file does not exist.';
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.3-Input.php 1 patch
Braces   +17 added lines, -25 removed lines patch added patch discarded remove patch
@@ -200,29 +200,30 @@  discard block
 block discarded – undo
200 200
 		if (isset($array[$index]))
201 201
 		{
202 202
 			$value = $array[$index];
203
-		}
204
-		elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) // Does the index contain array notation
203
+		} elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) {
204
+			// Does the index contain array notation
205 205
 		{
206 206
 			$value = $array;
207
+		}
207 208
 			for ($i = 0; $i < $count; $i++)
208 209
 			{
209 210
 				$key = trim($matches[0][$i], '[]');
210
-				if ($key === '') // Empty notation will return the value as array
211
+				if ($key === '') {
212
+					// Empty notation will return the value as array
211 213
 				{
212 214
 					break;
213 215
 				}
216
+				}
214 217
 
215 218
 				if (isset($value[$key]))
216 219
 				{
217 220
 					$value = $value[$key];
218
-				}
219
-				else
221
+				} else
220 222
 				{
221 223
 					return NULL;
222 224
 				}
223 225
 			}
224
-		}
225
-		else
226
+		} else
226 227
 		{
227 228
 			return NULL;
228 229
 		}
@@ -421,8 +422,7 @@  discard block
 block discarded – undo
421 422
 		if ( ! is_numeric($expire))
422 423
 		{
423 424
 			$expire = time() - 86500;
424
-		}
425
-		else
425
+		} else
426 426
 		{
427 427
 			$expire = ($expire > 0) ? time() + $expire : 0;
428 428
 		}
@@ -483,8 +483,7 @@  discard block
 block discarded – undo
483 483
 					if ( ! $this->valid_ip($spoof))
484 484
 					{
485 485
 						$spoof = NULL;
486
-					}
487
-					else
486
+					} else
488 487
 					{
489 488
 						break;
490 489
 					}
@@ -537,8 +536,7 @@  discard block
 block discarded – undo
537 536
 							}
538 537
 
539 538
 							$sprintf = '%016b%016b%016b%016b%016b%016b%016b%016b';
540
-						}
541
-						else
539
+						} else
542 540
 						{
543 541
 							$ip = explode('.', $this->ip_address);
544 542
 							$sprintf = '%08b%08b%08b%08b';
@@ -558,8 +556,7 @@  discard block
 block discarded – undo
558 556
 						{
559 557
 							$netaddr[$j] = intval($netaddr[$j], 16);
560 558
 						}
561
-					}
562
-					else
559
+					} else
563 560
 					{
564 561
 						$netaddr = explode('.', $netaddr);
565 562
 					}
@@ -646,8 +643,7 @@  discard block
 block discarded – undo
646 643
 		if ($this->_allow_get_array === FALSE)
647 644
 		{
648 645
 			$_GET = array();
649
-		}
650
-		elseif (is_array($_GET))
646
+		} elseif (is_array($_GET))
651 647
 		{
652 648
 			foreach ($_GET as $key => $val)
653 649
 			{
@@ -683,8 +679,7 @@  discard block
 block discarded – undo
683 679
 				if (($cookie_key = $this->_clean_input_keys($key)) !== FALSE)
684 680
 				{
685 681
 					$_COOKIE[$cookie_key] = $this->_clean_input_data($val);
686
-				}
687
-				else
682
+				} else
688 683
 				{
689 684
 					unset($_COOKIE[$key]);
690 685
 				}
@@ -774,8 +769,7 @@  discard block
 block discarded – undo
774 769
 			if ($fatal === TRUE)
775 770
 			{
776 771
 				return FALSE;
777
-			}
778
-			else
772
+			} else
779 773
 			{
780 774
 				set_status_header(503);
781 775
 				echo 'Disallowed Key Characters.';
@@ -814,8 +808,7 @@  discard block
 block discarded – undo
814 808
 		if (function_exists('apache_request_headers'))
815 809
 		{
816 810
 			$this->headers = apache_request_headers();
817
-		}
818
-		else
811
+		} else
819 812
 		{
820 813
 			isset($_SERVER['CONTENT_TYPE']) && $this->headers['Content-Type'] = $_SERVER['CONTENT_TYPE'];
821 814
 
@@ -944,8 +937,7 @@  discard block
 block discarded – undo
944 937
 		{
945 938
 			isset($this->_raw_input_stream) OR $this->_raw_input_stream = file_get_contents('php://input');
946 939
 			return $this->_raw_input_stream;
947
-		}
948
-		elseif ($name === 'ip_address')
940
+		} elseif ($name === 'ip_address')
949 941
 		{
950 942
 			return $this->ip_address;
951 943
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/Common.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -160,8 +160,7 @@  discard block
 block discarded – undo
160 160
 		$exit_status = $status_code + 9; // 9 is EXIT__AUTO_MIN
161 161
 
162 162
 		$status_code = 500;
163
-	}
164
-	else
163
+	} else
165 164
 	{
166 165
 		$exit_status = 1; // EXIT_ERROR
167 166
 	}
@@ -256,8 +255,7 @@  discard block
 block discarded – undo
256 255
 		if (isset($stati[$code]))
257 256
 		{
258 257
 			$text = $stati[$code];
259
-		}
260
-		else
258
+		} else
261 259
 		{
262 260
 			show_error('No status text available. Please check your status code number or supply your own message text.', 500);
263 261
 		}
@@ -327,8 +325,7 @@  discard block
 block discarded – undo
327 325
 		if (file_exists($file_path = APPPATH.'config/'.ENVIRONMENT.'/config.php'))
328 326
 		{
329 327
 			require($file_path);
330
-		}
331
-		elseif ( ! $found)
328
+		} elseif ( ! $found)
332 329
 		{
333 330
 			set_status_header(503);
334 331
 			echo 'The configuration file does not exist.';
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/libraries/old/3.1.4-Upload.php 1 patch
Braces   +21 added lines, -19 removed lines patch added patch discarded remove patch
@@ -331,19 +331,16 @@  discard block
 block discarded – undo
331 331
 					if ($reflection->hasMethod('set_'.$key))
332 332
 					{
333 333
 						$this->{'set_'.$key}($config[$key]);
334
-					}
335
-					else
334
+					} else
336 335
 					{
337 336
 						$this->$key = $config[$key];
338 337
 					}
339
-				}
340
-				else
338
+				} else
341 339
 				{
342 340
 					$this->$key = $defaults[$key];
343 341
 				}
344 342
 			}
345
-		}
346
-		else
343
+		} else
347 344
 		{
348 345
 			foreach ($config as $key => &$value)
349 346
 			{
@@ -352,8 +349,7 @@  discard block
 block discarded – undo
352 349
 					if ($reflection->hasMethod('set_'.$key))
353 350
 					{
354 351
 						$this->{'set_'.$key}($value);
355
-					}
356
-					else
352
+					} else
357 353
 					{
358 354
 						$this->$key = $value;
359 355
 					}
@@ -415,9 +411,11 @@  discard block
 block discarded – undo
415 411
 		}
416 412
 
417 413
 		// Was the file able to be uploaded? If not, determine the reason why.
418
-		if ( ! file_exists($_file['tmp_name']))	// modified by ci-phpunit-test
414
+		if ( ! file_exists($_file['tmp_name'])) {
415
+			// modified by ci-phpunit-test
419 416
 		{
420 417
 			$error = isset($_file['error']) ? $_file['error'] : 4;
418
+		}
421 419
 
422 420
 			switch ($error)
423 421
 			{
@@ -482,8 +480,7 @@  discard block
 block discarded – undo
482 480
 			if (strpos($this->_file_name_override, '.') === FALSE)
483 481
 			{
484 482
 				$this->file_name .= $this->file_ext;
485
-			}
486
-			else
483
+			} else
487 484
 			{
488 485
 				// An extension was provided, let's have it!
489 486
 				$this->file_ext	= $this->get_extension($this->_file_name_override);
@@ -687,8 +684,7 @@  discard block
 block discarded – undo
687 684
 		{
688 685
 			$this->set_error('upload_bad_filename', 'debug');
689 686
 			return FALSE;
690
-		}
691
-		else
687
+		} else
692 688
 		{
693 689
 			return $new_filename;
694 690
 		}
@@ -883,8 +879,7 @@  discard block
 block discarded – undo
883 879
 		if (in_array($this->file_type, $png_mimes))
884 880
 		{
885 881
 			$this->file_type = 'image/png';
886
-		}
887
-		elseif (in_array($this->file_type, $jpeg_mimes))
882
+		} elseif (in_array($this->file_type, $jpeg_mimes))
888 883
 		{
889 884
 			$this->file_type = 'image/jpeg';
890 885
 		}
@@ -1150,9 +1145,12 @@  discard block
 block discarded – undo
1150 1145
 
1151 1146
 		if (function_exists('getimagesize') && @getimagesize($file) !== FALSE)
1152 1147
 		{
1153
-			if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary
1148
+			if (($file = @fopen($file, 'rb')) === FALSE) {
1149
+				// "b" to force binary
1154 1150
 			{
1155
-				return FALSE; // Couldn't open the file, return FALSE
1151
+				return FALSE;
1152
+			}
1153
+			// Couldn't open the file, return FALSE
1156 1154
 			}
1157 1155
 
1158 1156
 			$opening_bytes = fread($file, 256);
@@ -1271,9 +1269,11 @@  discard block
 block discarded – undo
1271 1269
 		if (function_exists('finfo_file'))
1272 1270
 		{
1273 1271
 			$finfo = @finfo_open(FILEINFO_MIME);
1274
-			if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1272
+			if (is_resource($finfo)) {
1273
+				// It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1275 1274
 			{
1276 1275
 				$mime = @finfo_file($finfo, $file['tmp_name']);
1276
+			}
1277 1277
 				finfo_close($finfo);
1278 1278
 
1279 1279
 				/* According to the comments section of the PHP manual page,
@@ -1358,10 +1358,12 @@  discard block
 block discarded – undo
1358 1358
 		if (function_exists('mime_content_type'))
1359 1359
 		{
1360 1360
 			$this->file_type = @mime_content_type($file['tmp_name']);
1361
-			if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string
1361
+			if (strlen($this->file_type) > 0) {
1362
+				// It's possible that mime_content_type() returns FALSE or an empty string
1362 1363
 			{
1363 1364
 				return;
1364 1365
 			}
1366
+			}
1365 1367
 		}
1366 1368
 
1367 1369
 		$this->file_type = $file['type'];
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.4-Common.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -160,8 +160,7 @@  discard block
 block discarded – undo
160 160
 		$exit_status = $status_code + 9; // 9 is EXIT__AUTO_MIN
161 161
 
162 162
 		$status_code = 500;
163
-	}
164
-	else
163
+	} else
165 164
 	{
166 165
 		$exit_status = 1; // EXIT_ERROR
167 166
 	}
@@ -256,8 +255,7 @@  discard block
 block discarded – undo
256 255
 		if (isset($stati[$code]))
257 256
 		{
258 257
 			$text = $stati[$code];
259
-		}
260
-		else
258
+		} else
261 259
 		{
262 260
 			show_error('No status text available. Please check your status code number or supply your own message text.', 500);
263 261
 		}
@@ -327,8 +325,7 @@  discard block
 block discarded – undo
327 325
 		if (file_exists($file_path = APPPATH.'config/'.ENVIRONMENT.'/config.php'))
328 326
 		{
329 327
 			require($file_path);
330
-		}
331
-		elseif ( ! $found)
328
+		} elseif ( ! $found)
332 329
 		{
333 330
 			set_status_header(503);
334 331
 			echo 'The configuration file does not exist.';
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.4-CodeIgniter.php 1 patch
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.