Completed
Pull Request — master (#364)
by Kenji
02:19
created
application/tests/_ci_phpunit_test/replacing/core/old/3.1.6-CodeIgniter.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
  *  Start the timer... tick tock tick tock...
186 186
  * ------------------------------------------------------
187 187
  */
188
-	$BM =& load_class('Benchmark', 'core');
188
+	$BM = & load_class('Benchmark', 'core');
189 189
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
190 190
 	$BM->mark('total_execution_time_start');
191 191
 	$BM->mark('loading_time:_base_classes_start');
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
  *  Instantiate the hooks class
196 196
  * ------------------------------------------------------
197 197
  */
198
-	$EXT =& load_class('Hooks', 'core');
198
+	$EXT = & load_class('Hooks', 'core');
199 199
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
200 200
 
201 201
 /*
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
  * depending on another class that uses it.
216 216
  *
217 217
  */
218
-	$CFG =& load_class('Config', 'core');
218
+	$CFG = & load_class('Config', 'core');
219 219
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
220 220
 
221 221
 	// Do we have any manually set config items in the index.php file?
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
  *  Instantiate the UTF-8 class
295 295
  * ------------------------------------------------------
296 296
  */
297
-	$UNI =& load_class('Utf8', 'core');
297
+	$UNI = & load_class('Utf8', 'core');
298 298
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
299 299
 
300 300
 /*
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
  *  Instantiate the URI class
303 303
  * ------------------------------------------------------
304 304
  */
305
-	$URI =& load_class('URI', 'core');
305
+	$URI = & load_class('URI', 'core');
306 306
 	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
307 307
 
308 308
 /*
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
  *  Instantiate the routing class and set the routing
311 311
  * ------------------------------------------------------
312 312
  */
313
-	$RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
313
+	$RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
314 314
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
315 315
 
316 316
 /*
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
  *  Instantiate the output class
319 319
  * ------------------------------------------------------
320 320
  */
321
-	$OUT =& load_class('Output', 'core');
321
+	$OUT = & load_class('Output', 'core');
322 322
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
323 323
 
324 324
 /*
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
  * Load the security class for xss and csrf support
337 337
  * -----------------------------------------------------
338 338
  */
339
-	$SEC =& load_class('Security', 'core');
339
+	$SEC = & load_class('Security', 'core');
340 340
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
341 341
 
342 342
 /*
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
  *  Load the Input class and sanitize globals
345 345
  * ------------------------------------------------------
346 346
  */
347
-	$IN	=& load_class('Input', 'core');
347
+	$IN = & load_class('Input', 'core');
348 348
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
349 349
 
350 350
 /*
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
  *  Load the Language class
353 353
  * ------------------------------------------------------
354 354
  */
355
-	$LANG =& load_class('Lang', 'core');
355
+	$LANG = & load_class('Lang', 'core');
356 356
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
357 357
 
358 358
 /*
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	 */
376 376
 	function &get_instance()
377 377
 	{
378
-		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
378
+		if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 379
 		{
380 380
 			return CI_Controller::get_instance();
381 381
 		}
Please login to merge, or discard this patch.
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/Output.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @var	array
78 78
 	 */
79
-	public $mimes =	array();
79
+	public $mimes = array();
80 80
 
81 81
 	/**
82 82
 	 * Mime-type for the current page
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 *
112 112
 	 * @var	array
113 113
 	 */
114
-	protected $_profiler_sections =	array();
114
+	protected $_profiler_sections = array();
115 115
 
116 116
 	/**
117 117
 	 * Parse markers flag
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		isset(self::$func_overload) OR self::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
167 167
 
168 168
 		// Get mime types for later
169
-		$this->mimes =& get_mimes();
169
+		$this->mimes = & get_mimes();
170 170
 
171 171
 		log_message('info', 'Output Class Initialized');
172 172
 	}
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 			// Is this extension supported?
265 265
 			if (isset($this->mimes[$extension]))
266 266
 			{
267
-				$mime_type =& $this->mimes[$extension];
267
+				$mime_type = & $this->mimes[$extension];
268 268
 
269 269
 				if (is_array($mime_type))
270 270
 				{
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 		{
335 335
 			if (strncasecmp($header, $headers[$c], $l = self::strlen($header)) === 0)
336 336
 			{
337
-				return trim(self::substr($headers[$c], $l+1));
337
+				return trim(self::substr($headers[$c], $l + 1));
338 338
 			}
339 339
 		}
340 340
 
@@ -437,13 +437,13 @@  discard block
 block discarded – undo
437 437
 		// Note:  We use load_class() because we can't use $CI =& get_instance()
438 438
 		// since this function is sometimes called by the caching mechanism,
439 439
 		// which happens before the CI super object is available.
440
-		$BM =& load_class('Benchmark', 'core');
441
-		$CFG =& load_class('Config', 'core');
440
+		$BM = & load_class('Benchmark', 'core');
441
+		$CFG = & load_class('Config', 'core');
442 442
 
443 443
 		// Grab the super object if we can.
444 444
 		if (class_exists('CI_Controller', FALSE))
445 445
 		{
446
-			$CI =& get_instance();
446
+			$CI = & get_instance();
447 447
 		}
448 448
 
449 449
 		// --------------------------------------------------------------------
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 		// Set the output data
452 452
 		if ($output === '')
453 453
 		{
454
-			$output =& $this->final_output;
454
+			$output = & $this->final_output;
455 455
 		}
456 456
 
457 457
 		// --------------------------------------------------------------------
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 	 */
573 573
 	public function _write_cache($output)
574 574
 	{
575
-		$CI =& get_instance();
575
+		$CI = & get_instance();
576 576
 		$path = $CI->config->item('cache_path');
577 577
 		$cache_path = ($path === '') ? APPPATH.'cache/' : $path;
578 578
 
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
 	 */
752 752
 	public function delete_cache($uri = '')
753 753
 	{
754
-		$CI =& get_instance();
754
+		$CI = & get_instance();
755 755
 		$cache_path = $CI->config->item('cache_path');
756 756
 		if ($cache_path === '')
757 757
 		{
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -511,8 +511,7 @@  discard block
 block discarded – undo
511 511
 				{
512 512
 //					header('Content-Encoding: gzip');
513 513
 //					header('Content-Length: '.self::strlen($output));
514
-				}
515
-				else
514
+				} else
516 515
 				{
517 516
 					// User agent doesn't support gzip compression,
518 517
 					// so we'll have to decompress our cache
@@ -552,8 +551,7 @@  discard block
 block discarded – undo
552 551
 		if (method_exists($CI, '_output'))
553 552
 		{
554 553
 			$CI->_output($output);
555
-		}
556
-		else
554
+		} else
557 555
 		{
558 556
 			echo $output; // Send it to the browser!
559 557
 		}
@@ -591,8 +589,7 @@  discard block
 block discarded – undo
591 589
 			if (is_array($cache_query_string))
592 590
 			{
593 591
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
594
-			}
595
-			else
592
+			} else
596 593
 			{
597 594
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
598 595
 			}
@@ -685,8 +682,7 @@  discard block
 block discarded – undo
685 682
 			if (is_array($cache_query_string))
686 683
 			{
687 684
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
688
-			}
689
-			else
685
+			} else
690 686
 			{
691 687
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
692 688
 			}
@@ -773,8 +769,7 @@  discard block
 block discarded – undo
773 769
 				if (is_array($cache_query_string))
774 770
 				{
775 771
 					$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
776
-				}
777
-				else
772
+				} else
778 773
 				{
779 774
 					$uri .= '?'.$_SERVER['QUERY_STRING'];
780 775
 				}
Please login to merge, or discard this patch.
application/libraries/Seeder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
 	public function __construct()
20 20
 	{
21
-		$this->CI =& get_instance();
21
+		$this->CI = & get_instance();
22 22
 		$this->CI->load->database();
23 23
 		$this->CI->load->dbforge();
24 24
 		$this->db = $this->CI->db;
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	{
35 35
 		if ($this->seedPath === null)
36 36
 		{
37
-			$this->seedPath = APPPATH . 'database/seeds/';
37
+			$this->seedPath = APPPATH.'database/seeds/';
38 38
 		}
39 39
 
40 40
 		$obj = $this->loadSeeder($seeder);
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 */
54 54
 	protected function loadSeeder($seeder)
55 55
 	{
56
-		$file = $this->seedPath . $seeder . '.php';
56
+		$file = $this->seedPath.$seeder.'.php';
57 57
 		require_once $file;
58 58
 
59 59
 		return new $seeder;
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-Common.php 3 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -136,6 +136,11 @@  discard block
 block discarded – undo
136 136
 	return $_is_loaded;
137 137
 }
138 138
 
139
+/**
140
+ * @param boolean $return
141
+ *
142
+ * @return boolean
143
+ */
139 144
 function is_cli($return = null)
140 145
 {
141 146
 	static $_return = TRUE;
@@ -148,6 +153,9 @@  discard block
 block discarded – undo
148 153
 	return $_return;
149 154
 }
150 155
 
156
+/**
157
+ * @param string $message
158
+ */
151 159
 function show_error($message, $status_code = 500, $heading = 'An Error Was Encountered')
152 160
 {
153 161
 	$status_code = abs($status_code);
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 
264 264
 	// Save status code in Output object
265 265
 	// added by ci-phpunit-test
266
-	$CI =& get_instance();
266
+	$CI = & get_instance();
267 267
 	$output = $CI->output;
268 268
 	$output->_status = [
269 269
 		'code'     => $code,
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
 	if (empty($_config))
377 377
 	{
378 378
 		// references cannot be directly assigned to static variables, so we use an array
379
-		$_config[0] =& get_config();
379
+		$_config[0] = & get_config();
380 380
 	}
381 381
 
382 382
 	return isset($_config[0][$item]) ? $_config[0][$item] : NULL;
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -160,8 +160,7 @@  discard block
 block discarded – undo
160 160
 		$exit_status = $status_code + 9; // 9 is EXIT__AUTO_MIN
161 161
 
162 162
 		$status_code = 500;
163
-	}
164
-	else
163
+	} else
165 164
 	{
166 165
 		$exit_status = 1; // EXIT_ERROR
167 166
 	}
@@ -256,8 +255,7 @@  discard block
 block discarded – undo
256 255
 		if (isset($stati[$code]))
257 256
 		{
258 257
 			$text = $stati[$code];
259
-		}
260
-		else
258
+		} else
261 259
 		{
262 260
 			show_error('No status text available. Please check your status code number or supply your own message text.', 500);
263 261
 		}
@@ -327,8 +325,7 @@  discard block
 block discarded – undo
327 325
 		if (file_exists($file_path = APPPATH.'config/'.ENVIRONMENT.'/config.php'))
328 326
 		{
329 327
 			require($file_path);
330
-		}
331
-		elseif ( ! $found)
328
+		} elseif ( ! $found)
332 329
 		{
333 330
 			set_status_header(503);
334 331
 			echo 'The configuration file does not exist.';
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-Input.php 3 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 	/**
238 238
 	 * Fetch an item from the GET array
239 239
 	 *
240
-	 * @param	mixed	$index		Index for item to be fetched from $_GET
240
+	 * @param	string	$index		Index for item to be fetched from $_GET
241 241
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
242 242
 	 * @return	mixed
243 243
 	 *
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 	/**
254 254
 	 * Fetch an item from the POST array
255 255
 	 *
256
-	 * @param	mixed	$index		Index for item to be fetched from $_POST
256
+	 * @param	string	$index		Index for item to be fetched from $_POST
257 257
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
258 258
 	 * @return	mixed
259 259
 	 *
@@ -321,9 +321,9 @@  discard block
 block discarded – undo
321 321
 	/**
322 322
 	 * Fetch an item from the SERVER array
323 323
 	 *
324
-	 * @param	mixed	$index		Index for item to be fetched from $_SERVER
324
+	 * @param	string	$index		Index for item to be fetched from $_SERVER
325 325
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
326
-	 * @return	mixed
326
+	 * @return	string
327 327
 	 *
328 328
 	 * @codeCoverageIgnore
329 329
 	 */
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
934 934
 	 * Allows read access to protected properties
935 935
 	 *
936 936
 	 * @param	string	$name
937
-	 * @return	mixed
937
+	 * @return	string|null
938 938
 	 *
939 939
 	 * @codeCoverageIgnore
940 940
 	 */
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -139,17 +139,17 @@  discard block
 block discarded – undo
139 139
 	 */
140 140
 	public function __construct()
141 141
 	{
142
-		$this->_allow_get_array		= (config_item('allow_get_array') !== FALSE);
143
-		$this->_enable_xss		= (config_item('global_xss_filtering') === TRUE);
144
-		$this->_enable_csrf		= (config_item('csrf_protection') === TRUE);
145
-		$this->_standardize_newlines	= (bool) config_item('standardize_newlines');
142
+		$this->_allow_get_array = (config_item('allow_get_array') !== FALSE);
143
+		$this->_enable_xss = (config_item('global_xss_filtering') === TRUE);
144
+		$this->_enable_csrf = (config_item('csrf_protection') === TRUE);
145
+		$this->_standardize_newlines = (bool) config_item('standardize_newlines');
146 146
 
147
-		$this->security =& load_class('Security', 'core');
147
+		$this->security = & load_class('Security', 'core');
148 148
 
149 149
 		// Do we need the UTF-8 class?
150 150
 		if (UTF8_ENABLED === TRUE)
151 151
 		{
152
-			$this->uni =& load_class('Utf8', 'core');
152
+			$this->uni = & load_class('Utf8', 'core');
153 153
 		}
154 154
 
155 155
 		// Sanitize global arrays
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
 
430 430
 		// Save cookie in Output object
431 431
 		// added by ci-phpunit-test
432
-		$CI =& get_instance();
432
+		$CI = & get_instance();
433 433
 		$output = $CI->output;
434 434
 		$output->_cookies[$prefix.$name][] = [
435 435
 			'value' => $value,
Please login to merge, or discard this patch.
Braces   +17 added lines, -25 removed lines patch added patch discarded remove patch
@@ -200,29 +200,30 @@  discard block
 block discarded – undo
200 200
 		if (isset($array[$index]))
201 201
 		{
202 202
 			$value = $array[$index];
203
-		}
204
-		elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) // Does the index contain array notation
203
+		} elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) {
204
+			// Does the index contain array notation
205 205
 		{
206 206
 			$value = $array;
207
+		}
207 208
 			for ($i = 0; $i < $count; $i++)
208 209
 			{
209 210
 				$key = trim($matches[0][$i], '[]');
210
-				if ($key === '') // Empty notation will return the value as array
211
+				if ($key === '') {
212
+					// Empty notation will return the value as array
211 213
 				{
212 214
 					break;
213 215
 				}
216
+				}
214 217
 
215 218
 				if (isset($value[$key]))
216 219
 				{
217 220
 					$value = $value[$key];
218
-				}
219
-				else
221
+				} else
220 222
 				{
221 223
 					return NULL;
222 224
 				}
223 225
 			}
224
-		}
225
-		else
226
+		} else
226 227
 		{
227 228
 			return NULL;
228 229
 		}
@@ -421,8 +422,7 @@  discard block
 block discarded – undo
421 422
 		if ( ! is_numeric($expire))
422 423
 		{
423 424
 			$expire = time() - 86500;
424
-		}
425
-		else
425
+		} else
426 426
 		{
427 427
 			$expire = ($expire > 0) ? time() + $expire : 0;
428 428
 		}
@@ -483,8 +483,7 @@  discard block
 block discarded – undo
483 483
 					if ( ! $this->valid_ip($spoof))
484 484
 					{
485 485
 						$spoof = NULL;
486
-					}
487
-					else
486
+					} else
488 487
 					{
489 488
 						break;
490 489
 					}
@@ -537,8 +536,7 @@  discard block
 block discarded – undo
537 536
 							}
538 537
 
539 538
 							$sprintf = '%016b%016b%016b%016b%016b%016b%016b%016b';
540
-						}
541
-						else
539
+						} else
542 540
 						{
543 541
 							$ip = explode('.', $this->ip_address);
544 542
 							$sprintf = '%08b%08b%08b%08b';
@@ -558,8 +556,7 @@  discard block
 block discarded – undo
558 556
 						{
559 557
 							$netaddr[$j] = intval($netaddr[$j], 16);
560 558
 						}
561
-					}
562
-					else
559
+					} else
563 560
 					{
564 561
 						$netaddr = explode('.', $netaddr);
565 562
 					}
@@ -646,8 +643,7 @@  discard block
 block discarded – undo
646 643
 		if ($this->_allow_get_array === FALSE)
647 644
 		{
648 645
 			$_GET = array();
649
-		}
650
-		elseif (is_array($_GET))
646
+		} elseif (is_array($_GET))
651 647
 		{
652 648
 			foreach ($_GET as $key => $val)
653 649
 			{
@@ -683,8 +679,7 @@  discard block
 block discarded – undo
683 679
 				if (($cookie_key = $this->_clean_input_keys($key)) !== FALSE)
684 680
 				{
685 681
 					$_COOKIE[$cookie_key] = $this->_clean_input_data($val);
686
-				}
687
-				else
682
+				} else
688 683
 				{
689 684
 					unset($_COOKIE[$key]);
690 685
 				}
@@ -774,8 +769,7 @@  discard block
 block discarded – undo
774 769
 			if ($fatal === TRUE)
775 770
 			{
776 771
 				return FALSE;
777
-			}
778
-			else
772
+			} else
779 773
 			{
780 774
 				set_status_header(503);
781 775
 				echo 'Disallowed Key Characters.';
@@ -814,8 +808,7 @@  discard block
 block discarded – undo
814 808
 		if (function_exists('apache_request_headers'))
815 809
 		{
816 810
 			$this->headers = apache_request_headers();
817
-		}
818
-		else
811
+		} else
819 812
 		{
820 813
 			isset($_SERVER['CONTENT_TYPE']) && $this->headers['Content-Type'] = $_SERVER['CONTENT_TYPE'];
821 814
 
@@ -944,8 +937,7 @@  discard block
 block discarded – undo
944 937
 		{
945 938
 			isset($this->_raw_input_stream) OR $this->_raw_input_stream = file_get_contents('php://input');
946 939
 			return $this->_raw_input_stream;
947
-		}
948
-		elseif ($name === 'ip_address')
940
+		} elseif ($name === 'ip_address')
949 941
 		{
950 942
 			return $this->ip_address;
951 943
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-Loader.php 3 patches
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 	 * @param	mixed	$library	Library name
192 192
 	 * @param	array	$params		Optional parameters to pass to the library class constructor
193 193
 	 * @param	string	$object_name	An optional object name to assign to
194
-	 * @return	object
194
+	 * @return	CI_Loader
195 195
 	 *
196 196
 	 * @codeCoverageIgnore
197 197
 	 */
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 	 * @param	mixed	$model		Model name
238 238
 	 * @param	string	$name		An optional object name to assign to
239 239
 	 * @param	bool	$db_conn	An optional database connection configuration to initialize
240
-	 * @return	object
240
+	 * @return	CI_Loader
241 241
 	 *
242 242
 	 * modified by ci-phpunit-test
243 243
 	 */
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	/**
376 376
 	 * Database Loader
377 377
 	 *
378
-	 * @param	mixed	$params		Database configuration options
378
+	 * @param	string|boolean	$params		Database configuration options
379 379
 	 * @param	bool	$return 	Whether to return the database object
380 380
 	 * @param	bool	$query_builder	Whether to enable Query Builder
381 381
 	 *					(overrides the configuration setting)
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 	 *					An associative array or object containing values
540 540
 	 *					to be set, or a value's name if string
541 541
 	 * @param 	string	$val	Value to set, only used if $vars is a string
542
-	 * @return	object
542
+	 * @return	CI_Loader
543 543
 	 *
544 544
 	 * @codeCoverageIgnore
545 545
 	 */
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
 	 * Helper Loader
614 614
 	 *
615 615
 	 * @param	string|string[]	$helpers	Helper name(s)
616
-	 * @return	object
616
+	 * @return	CI_Loader
617 617
 	 *
618 618
 	 * @codeCoverageIgnore
619 619
 	 */
@@ -692,7 +692,7 @@  discard block
 block discarded – undo
692 692
 	 *
693 693
 	 * @uses	CI_Loader::helper()
694 694
 	 * @param	string|string[]	$helpers	Helper name(s)
695
-	 * @return	object
695
+	 * @return	CI_Loader
696 696
 	 *
697 697
 	 * @codeCoverageIgnore
698 698
 	 */
@@ -710,7 +710,7 @@  discard block
 block discarded – undo
710 710
 	 *
711 711
 	 * @param	string|string[]	$files	List of language file names to load
712 712
 	 * @param	string		Language name
713
-	 * @return	object
713
+	 * @return	CI_Loader
714 714
 	 *
715 715
 	 * @codeCoverageIgnore
716 716
 	 */
@@ -810,7 +810,7 @@  discard block
 block discarded – undo
810 810
 	 *
811 811
 	 * @param	string	$path		Path to add
812 812
 	 * @param 	bool	$view_cascade	(default: TRUE)
813
-	 * @return	object
813
+	 * @return	CI_Loader
814 814
 	 *
815 815
 	 * @codeCoverageIgnore
816 816
 	 */
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
 	 * added path will be removed removed.
859 859
 	 *
860 860
 	 * @param	string	$path	Path to remove
861
-	 * @return	object
861
+	 * @return	CI_Loader
862 862
 	 *
863 863
 	 * @codeCoverageIgnore
864 864
 	 */
Please login to merge, or discard this patch.
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -63,63 +63,63 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @var	array
65 65
 	 */
66
-	protected $_ci_view_paths =	array(VIEWPATH	=> TRUE);
66
+	protected $_ci_view_paths = array(VIEWPATH	=> TRUE);
67 67
 
68 68
 	/**
69 69
 	 * List of paths to load libraries from
70 70
 	 *
71 71
 	 * @var	array
72 72
 	 */
73
-	protected $_ci_library_paths =	array(APPPATH, BASEPATH);
73
+	protected $_ci_library_paths = array(APPPATH, BASEPATH);
74 74
 
75 75
 	/**
76 76
 	 * List of paths to load models from
77 77
 	 *
78 78
 	 * @var	array
79 79
 	 */
80
-	protected $_ci_model_paths =	array(APPPATH);
80
+	protected $_ci_model_paths = array(APPPATH);
81 81
 
82 82
 	/**
83 83
 	 * List of paths to load helpers from
84 84
 	 *
85 85
 	 * @var	array
86 86
 	 */
87
-	protected $_ci_helper_paths =	array(APPPATH, BASEPATH);
87
+	protected $_ci_helper_paths = array(APPPATH, BASEPATH);
88 88
 
89 89
 	/**
90 90
 	 * List of cached variables
91 91
 	 *
92 92
 	 * @var	array
93 93
 	 */
94
-	protected $_ci_cached_vars =	array();
94
+	protected $_ci_cached_vars = array();
95 95
 
96 96
 	/**
97 97
 	 * List of loaded classes
98 98
 	 *
99 99
 	 * @var	array
100 100
 	 */
101
-	protected $_ci_classes =	array();
101
+	protected $_ci_classes = array();
102 102
 
103 103
 	/**
104 104
 	 * List of loaded models
105 105
 	 *
106 106
 	 * @var	array
107 107
 	 */
108
-	protected $_ci_models =	array();
108
+	protected $_ci_models = array();
109 109
 
110 110
 	/**
111 111
 	 * List of loaded helpers
112 112
 	 *
113 113
 	 * @var	array
114 114
 	 */
115
-	protected $_ci_helpers =	array();
115
+	protected $_ci_helpers = array();
116 116
 
117 117
 	/**
118 118
 	 * List of class name mappings
119 119
 	 *
120 120
 	 * @var	array
121 121
 	 */
122
-	protected $_ci_varmap =	array(
122
+	protected $_ci_varmap = array(
123 123
 		'unit_test' => 'unit',
124 124
 		'user_agent' => 'agent'
125 125
 	);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	public function __construct()
139 139
 	{
140 140
 		$this->_ci_ob_level = ob_get_level();
141
-		$this->_ci_classes =& is_loaded();
141
+		$this->_ci_classes = & is_loaded();
142 142
 
143 143
 		log_message('info', 'Loader Class Initialized');
144 144
 	}
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 			return $this;
280 280
 		}
281 281
 
282
-		$CI =& get_instance();
282
+		$CI = & get_instance();
283 283
 		if (isset($CI->$name))
284 284
 		{
285 285
 			throw new RuntimeException('The model name you are loading is the name of a resource that is already being used: '.$name);
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
 	public function database($params = '', $return = FALSE, $query_builder = NULL)
383 383
 	{
384 384
 		// Grab the super object
385
-		$CI =& get_instance();
385
+		$CI = & get_instance();
386 386
 
387 387
 		// Do we even need to load the database class?
388 388
 		if ($return === FALSE && $query_builder === NULL && isset($CI->db) && is_object($CI->db) && ! empty($CI->db->conn_id))
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 		$CI->db = '';
403 403
 
404 404
 		// Load the DB class
405
-		$CI->db =& DB($params, $query_builder);
405
+		$CI->db = & DB($params, $query_builder);
406 406
 		return $this;
407 407
 	}
408 408
 
@@ -419,12 +419,12 @@  discard block
 block discarded – undo
419 419
 	 */
420 420
 	public function dbutil($db = NULL, $return = FALSE)
421 421
 	{
422
-		$CI =& get_instance();
422
+		$CI = & get_instance();
423 423
 
424 424
 		if ( ! is_object($db) OR ! ($db instanceof CI_DB))
425 425
 		{
426 426
 			class_exists('CI_DB', FALSE) OR $this->database();
427
-			$db =& $CI->db;
427
+			$db = & $CI->db;
428 428
 		}
429 429
 
430 430
 		require_once(BASEPATH.'database/DB_utility.php');
@@ -453,11 +453,11 @@  discard block
 block discarded – undo
453 453
 	 */
454 454
 	public function dbforge($db = NULL, $return = FALSE)
455 455
 	{
456
-		$CI =& get_instance();
456
+		$CI = & get_instance();
457 457
 		if ( ! is_object($db) OR ! ($db instanceof CI_DB))
458 458
 		{
459 459
 			class_exists('CI_DB', FALSE) OR $this->database();
460
-			$db =& $CI->db;
460
+			$db = & $CI->db;
461 461
 		}
462 462
 
463 463
 		require_once(BASEPATH.'database/DB_forge.php');
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 		$this->_ci_view_paths = array($path.'views/' => $view_cascade) + $this->_ci_view_paths;
820 820
 
821 821
 		// Add config file path
822
-		$config =& $this->_ci_get_component('config');
822
+		$config = & $this->_ci_get_component('config');
823 823
 		$config->_config_paths[] = $path;
824 824
 
825 825
 		return $this;
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
 	 */
859 859
 	public function remove_package_path($path = '')
860 860
 	{
861
-		$config =& $this->_ci_get_component('config');
861
+		$config = & $this->_ci_get_component('config');
862 862
 
863 863
 		if ($path === '')
864 864
 		{
@@ -961,12 +961,12 @@  discard block
 block discarded – undo
961 961
 
962 962
 		// This allows anything loaded using $this->load (views, files, etc.)
963 963
 		// to become accessible from within the Controller and Model functions.
964
-		$_ci_CI =& get_instance();
964
+		$_ci_CI = & get_instance();
965 965
 		foreach (get_object_vars($_ci_CI) as $_ci_key => $_ci_var)
966 966
 		{
967 967
 			if ( ! isset($this->$_ci_key))
968 968
 			{
969
-				$this->$_ci_key =& $_ci_CI->$_ci_key;
969
+				$this->$_ci_key = & $_ci_CI->$_ci_key;
970 970
 			}
971 971
 		}
972 972
 
@@ -1099,7 +1099,7 @@  discard block
 block discarded – undo
1099 1099
 				isset($this->_ci_varmap[$property]) && $property = $this->_ci_varmap[$property];
1100 1100
 			}
1101 1101
 
1102
-			$CI =& get_instance();
1102
+			$CI = & get_instance();
1103 1103
 			if (isset($CI->$property))
1104 1104
 			{
1105 1105
 //				log_message('debug', $class.' class already loaded. Second attempt ignored.');
@@ -1174,7 +1174,7 @@  discard block
 block discarded – undo
1174 1174
 				isset($this->_ci_varmap[$property]) && $property = $this->_ci_varmap[$property];
1175 1175
 			}
1176 1176
 
1177
-			$CI =& get_instance();
1177
+			$CI = & get_instance();
1178 1178
 			if ( ! isset($CI->$property))
1179 1179
 			{
1180 1180
 				return $this->_ci_init_library($library_name, $prefix, $params, $object_name);
@@ -1322,7 +1322,7 @@  discard block
 block discarded – undo
1322 1322
 		}
1323 1323
 
1324 1324
 		// Don't overwrite existing properties
1325
-		$CI =& get_instance();
1325
+		$CI = & get_instance();
1326 1326
 		if (isset($CI->$object_name))
1327 1327
 		{
1328 1328
 			if ($CI->$object_name instanceof $class_name)
@@ -1473,7 +1473,7 @@  discard block
 block discarded – undo
1473 1473
 	 */
1474 1474
 	protected function &_ci_get_component($component)
1475 1475
 	{
1476
-		$CI =& get_instance();
1476
+		$CI = & get_instance();
1477 1477
 		return $CI->$component;
1478 1478
 	}
1479 1479
 }
Please login to merge, or discard this patch.
Braces   +15 added lines, -30 removed lines patch added patch discarded remove patch
@@ -200,16 +200,14 @@  discard block
 block discarded – undo
200 200
 		if (empty($library))
201 201
 		{
202 202
 			return $this;
203
-		}
204
-		elseif (is_array($library))
203
+		} elseif (is_array($library))
205 204
 		{
206 205
 			foreach ($library as $key => $value)
207 206
 			{
208 207
 				if (is_int($key))
209 208
 				{
210 209
 					$this->library($value, $params);
211
-				}
212
-				else
210
+				} else
213 211
 				{
214 212
 					$this->library($key, $params, $value);
215 213
 				}
@@ -246,8 +244,7 @@  discard block
 block discarded – undo
246 244
 		if (empty($model))
247 245
 		{
248 246
 			return $this;
249
-		}
250
-		elseif (is_array($model))
247
+		} elseif (is_array($model))
251 248
 		{
252 249
 			foreach ($model as $key => $value)
253 250
 			{
@@ -315,8 +312,7 @@  discard block
 block discarded – undo
315 312
 				}
316 313
 
317 314
 				log_message('info', 'CI_Model class loaded');
318
-			}
319
-			elseif ( ! class_exists('CI_Model', FALSE))
315
+			} elseif ( ! class_exists('CI_Model', FALSE))
320 316
 			{
321 317
 				require_once(BASEPATH.'core'.DIRECTORY_SEPARATOR.'Model.php');
322 318
 			}
@@ -477,8 +473,7 @@  discard block
 block discarded – undo
477 473
 				require_once($driver_path);
478 474
 				$class = 'CI_DB_'.$db->dbdriver.'_'.$db->subdriver.'_forge';
479 475
 			}
480
-		}
481
-		else
476
+		} else
482 477
 		{
483 478
 			$class = 'CI_DB_'.$db->dbdriver.'_forge';
484 479
 		}
@@ -765,16 +760,14 @@  discard block
 block discarded – undo
765 760
 				if (is_int($key))
766 761
 				{
767 762
 					$this->driver($value, $params);
768
-				}
769
-				else
763
+				} else
770 764
 				{
771 765
 					$this->driver($key, $params, $value);
772 766
 				}
773 767
 			}
774 768
 
775 769
 			return $this;
776
-		}
777
-		elseif (empty($library))
770
+		} elseif (empty($library))
778 771
 		{
779 772
 			return FALSE;
780 773
 		}
@@ -873,8 +866,7 @@  discard block
 block discarded – undo
873 866
 			array_shift($this->_ci_helper_paths);
874 867
 			array_shift($this->_ci_view_paths);
875 868
 			array_pop($config->_config_paths);
876
-		}
877
-		else
869
+		} else
878 870
 		{
879 871
 			$path = rtrim($path, '/').'/';
880 872
 			foreach (array('_ci_library_paths', '_ci_model_paths', '_ci_helper_paths') as $var)
@@ -938,8 +930,7 @@  discard block
 block discarded – undo
938 930
 		{
939 931
 			$_ci_x = explode('/', $_ci_path);
940 932
 			$_ci_file = end($_ci_x);
941
-		}
942
-		else
933
+		} else
943 934
 		{
944 935
 			$_ci_ext = pathinfo($_ci_view, PATHINFO_EXTENSION);
945 936
 			$_ci_file = ($_ci_ext === '') ? $_ci_view.'.php' : $_ci_view;
@@ -1006,8 +997,7 @@  discard block
 block discarded – undo
1006 997
 		if ( ! is_php('5.4') && ! ini_get('short_open_tag') && config_item('rewrite_short_tags') === TRUE)
1007 998
 		{
1008 999
 			echo eval('?>'.preg_replace('/;*\s*\?>/', '; ?>', str_replace('<?=', '<?php echo ', file_get_contents($_ci_path))));
1009
-		}
1010
-		else
1000
+		} else
1011 1001
 		{
1012 1002
 			include($_ci_path); // include() vs include_once() allows for multiple views with the same name
1013 1003
 		}
@@ -1034,8 +1024,7 @@  discard block
 block discarded – undo
1034 1024
 		if (ob_get_level() > $this->_ci_ob_level + 1)
1035 1025
 		{
1036 1026
 			ob_end_flush();
1037
-		}
1038
-		else
1027
+		} else
1039 1028
 		{
1040 1029
 			$_ci_CI->output->append_output(ob_get_contents());
1041 1030
 			@ob_end_clean();
@@ -1075,8 +1064,7 @@  discard block
 block discarded – undo
1075 1064
 
1076 1065
 			// Get the filename from the path
1077 1066
 			$class = substr($class, $last_slash);
1078
-		}
1079
-		else
1067
+		} else
1080 1068
 		{
1081 1069
 			$subdir = '';
1082 1070
 		}
@@ -1214,8 +1202,7 @@  discard block
 block discarded – undo
1214 1202
 		if (file_exists(CI_PHPUNIT_TESTPATH.'replacing/libraries/'.$file_path.$library_name.'.php'))
1215 1203
 		{
1216 1204
 			include_once(CI_PHPUNIT_TESTPATH.'replacing/libraries/'.$file_path.$library_name.'.php');
1217
-		}
1218
-		else
1205
+		} else
1219 1206
 		{
1220 1207
 			include_once(BASEPATH.'libraries/'.$file_path.$library_name.'.php');
1221 1208
 		}
@@ -1279,8 +1266,7 @@  discard block
 block discarded – undo
1279 1266
 					{
1280 1267
 						include($path.'config/'.strtolower($class).'.php');
1281 1268
 						$found = TRUE;
1282
-					}
1283
-					elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php'))
1269
+					} elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php'))
1284 1270
 					{
1285 1271
 						include($path.'config/'.ucfirst(strtolower($class)).'.php');
1286 1272
 						$found = TRUE;
@@ -1290,8 +1276,7 @@  discard block
 block discarded – undo
1290 1276
 					{
1291 1277
 						include($path.'config/'.ENVIRONMENT.'/'.strtolower($class).'.php');
1292 1278
 						$found = TRUE;
1293
-					}
1294
-					elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php'))
1279
+					} elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php'))
1295 1280
 					{
1296 1281
 						include($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php');
1297 1282
 						$found = TRUE;
Please login to merge, or discard this patch.
tests/_ci_phpunit_test/replacing/helpers/old/3.1.7-url_helper.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 				ob_end_clean();
106 106
 			}
107 107
 
108
-			throw new CIPHPUnitTestRedirectException('Redirect to ' . $uri, $code);
108
+			throw new CIPHPUnitTestRedirectException('Redirect to '.$uri, $code);
109 109
 		}
110 110
 	}
111 111
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -34,16 +34,14 @@  discard block
 block discarded – undo
34 34
 		if ($method === 'auto' && isset($_SERVER['SERVER_SOFTWARE']) && strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS') !== FALSE)
35 35
 		{
36 36
 			$method = 'refresh';
37
-		}
38
-		elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
37
+		} elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
39 38
 		{
40 39
 			if (isset($_SERVER['SERVER_PROTOCOL'], $_SERVER['REQUEST_METHOD']) && $_SERVER['SERVER_PROTOCOL'] === 'HTTP/1.1')
41 40
 			{
42 41
 				$code = ($_SERVER['REQUEST_METHOD'] !== 'GET')
43 42
 					? 303	// reference: http://en.wikipedia.org/wiki/Post/Redirect/Get
44 43
 					: 307;
45
-			}
46
-			else
44
+			} else
47 45
 			{
48 46
 				$code = 302;
49 47
 			}
@@ -68,8 +66,7 @@  discard block
 block discarded – undo
68 66
 		if ( ! TestCase::isTestingEnv())
69 67
 		{
70 68
 			exit;
71
-		}
72
-		else
69
+		} else
73 70
 		{
74 71
 			while (ob_get_level() > 1)
75 72
 			{
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-CodeIgniter.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
  *  Start the timer... tick tock tick tock...
186 186
  * ------------------------------------------------------
187 187
  */
188
-	$BM =& load_class('Benchmark', 'core');
188
+	$BM = & load_class('Benchmark', 'core');
189 189
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
190 190
 	$BM->mark('total_execution_time_start');
191 191
 	$BM->mark('loading_time:_base_classes_start');
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
  *  Instantiate the hooks class
196 196
  * ------------------------------------------------------
197 197
  */
198
-	$EXT =& load_class('Hooks', 'core');
198
+	$EXT = & load_class('Hooks', 'core');
199 199
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
200 200
 
201 201
 /*
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
  * depending on another class that uses it.
216 216
  *
217 217
  */
218
-	$CFG =& load_class('Config', 'core');
218
+	$CFG = & load_class('Config', 'core');
219 219
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
220 220
 
221 221
 	// Do we have any manually set config items in the index.php file?
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
  *  Instantiate the UTF-8 class
295 295
  * ------------------------------------------------------
296 296
  */
297
-	$UNI =& load_class('Utf8', 'core');
297
+	$UNI = & load_class('Utf8', 'core');
298 298
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
299 299
 
300 300
 /*
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
  *  Instantiate the URI class
303 303
  * ------------------------------------------------------
304 304
  */
305
-	$URI =& load_class('URI', 'core');
305
+	$URI = & load_class('URI', 'core');
306 306
 	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
307 307
 
308 308
 /*
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
  *  Instantiate the routing class and set the routing
311 311
  * ------------------------------------------------------
312 312
  */
313
-	$RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
313
+	$RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
314 314
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
315 315
 
316 316
 /*
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
  *  Instantiate the output class
319 319
  * ------------------------------------------------------
320 320
  */
321
-	$OUT =& load_class('Output', 'core');
321
+	$OUT = & load_class('Output', 'core');
322 322
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
323 323
 
324 324
 /*
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
  * Load the security class for xss and csrf support
337 337
  * -----------------------------------------------------
338 338
  */
339
-	$SEC =& load_class('Security', 'core');
339
+	$SEC = & load_class('Security', 'core');
340 340
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
341 341
 
342 342
 /*
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
  *  Load the Input class and sanitize globals
345 345
  * ------------------------------------------------------
346 346
  */
347
-	$IN	=& load_class('Input', 'core');
347
+	$IN = & load_class('Input', 'core');
348 348
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
349 349
 
350 350
 /*
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
  *  Load the Language class
353 353
  * ------------------------------------------------------
354 354
  */
355
-	$LANG =& load_class('Lang', 'core');
355
+	$LANG = & load_class('Lang', 'core');
356 356
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
357 357
 
358 358
 /*
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	 */
376 376
 	function &get_instance()
377 377
 	{
378
-		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
378
+		if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 379
 		{
380 380
 			return CI_Controller::get_instance();
381 381
 		}
Please login to merge, or discard this patch.
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-Output.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @var	array
78 78
 	 */
79
-	public $mimes =	array();
79
+	public $mimes = array();
80 80
 
81 81
 	/**
82 82
 	 * Mime-type for the current page
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 *
112 112
 	 * @var	array
113 113
 	 */
114
-	protected $_profiler_sections =	array();
114
+	protected $_profiler_sections = array();
115 115
 
116 116
 	/**
117 117
 	 * Parse markers flag
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		isset(self::$func_overload) OR self::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
167 167
 
168 168
 		// Get mime types for later
169
-		$this->mimes =& get_mimes();
169
+		$this->mimes = & get_mimes();
170 170
 
171 171
 		log_message('info', 'Output Class Initialized');
172 172
 	}
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 			// Is this extension supported?
265 265
 			if (isset($this->mimes[$extension]))
266 266
 			{
267
-				$mime_type =& $this->mimes[$extension];
267
+				$mime_type = & $this->mimes[$extension];
268 268
 
269 269
 				if (is_array($mime_type))
270 270
 				{
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 		{
335 335
 			if (strncasecmp($header, $headers[$c], $l = self::strlen($header)) === 0)
336 336
 			{
337
-				return trim(self::substr($headers[$c], $l+1));
337
+				return trim(self::substr($headers[$c], $l + 1));
338 338
 			}
339 339
 		}
340 340
 
@@ -437,13 +437,13 @@  discard block
 block discarded – undo
437 437
 		// Note:  We use load_class() because we can't use $CI =& get_instance()
438 438
 		// since this function is sometimes called by the caching mechanism,
439 439
 		// which happens before the CI super object is available.
440
-		$BM =& load_class('Benchmark', 'core');
441
-		$CFG =& load_class('Config', 'core');
440
+		$BM = & load_class('Benchmark', 'core');
441
+		$CFG = & load_class('Config', 'core');
442 442
 
443 443
 		// Grab the super object if we can.
444 444
 		if (class_exists('CI_Controller', FALSE))
445 445
 		{
446
-			$CI =& get_instance();
446
+			$CI = & get_instance();
447 447
 		}
448 448
 
449 449
 		// --------------------------------------------------------------------
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 		// Set the output data
452 452
 		if ($output === '')
453 453
 		{
454
-			$output =& $this->final_output;
454
+			$output = & $this->final_output;
455 455
 		}
456 456
 
457 457
 		// --------------------------------------------------------------------
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 	 */
573 573
 	public function _write_cache($output)
574 574
 	{
575
-		$CI =& get_instance();
575
+		$CI = & get_instance();
576 576
 		$path = $CI->config->item('cache_path');
577 577
 		$cache_path = ($path === '') ? APPPATH.'cache/' : $path;
578 578
 
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
 	 */
752 752
 	public function delete_cache($uri = '')
753 753
 	{
754
-		$CI =& get_instance();
754
+		$CI = & get_instance();
755 755
 		$cache_path = $CI->config->item('cache_path');
756 756
 		if ($cache_path === '')
757 757
 		{
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -511,8 +511,7 @@  discard block
 block discarded – undo
511 511
 				{
512 512
 //					header('Content-Encoding: gzip');
513 513
 //					header('Content-Length: '.self::strlen($output));
514
-				}
515
-				else
514
+				} else
516 515
 				{
517 516
 					// User agent doesn't support gzip compression,
518 517
 					// so we'll have to decompress our cache
@@ -552,8 +551,7 @@  discard block
 block discarded – undo
552 551
 		if (method_exists($CI, '_output'))
553 552
 		{
554 553
 			$CI->_output($output);
555
-		}
556
-		else
554
+		} else
557 555
 		{
558 556
 			echo $output; // Send it to the browser!
559 557
 		}
@@ -591,8 +589,7 @@  discard block
 block discarded – undo
591 589
 			if (is_array($cache_query_string))
592 590
 			{
593 591
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
594
-			}
595
-			else
592
+			} else
596 593
 			{
597 594
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
598 595
 			}
@@ -685,8 +682,7 @@  discard block
 block discarded – undo
685 682
 			if (is_array($cache_query_string))
686 683
 			{
687 684
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
688
-			}
689
-			else
685
+			} else
690 686
 			{
691 687
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
692 688
 			}
@@ -773,8 +769,7 @@  discard block
 block discarded – undo
773 769
 				if (is_array($cache_query_string))
774 770
 				{
775 771
 					$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
776
-				}
777
-				else
772
+				} else
778 773
 				{
779 774
 					$uri .= '?'.$_SERVER['QUERY_STRING'];
780 775
 				}
Please login to merge, or discard this patch.