kenjis / ci-phpunit-test

application/tests/_ci_phpunit_test/CIPHPUnitTestDbTestCase.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 	{
 		if ($this->db === null)
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->load->database();
 			$this->db = $CI->db;
 		}
@@ -54,7 +54,7 @@ 
 	 */
 	protected function tearDown()
 	{
-		if (! empty($this->insertCache))
+		if ( ! empty($this->insertCache))
 		{
 			foreach ($this->insertCache as $row)
 			{

application/libraries/Seeder.php

Spacing +3 added lines, -3 removed lines

@@ -17,7 +17,7 @@ 
 
 	public function __construct()
 	{
-		$this->CI =& get_instance();
+		$this->CI = & get_instance();
 		$this->CI->load->database();
 		$this->CI->load->dbforge();
 		$this->db = $this->CI->db;
@@ -33,10 +33,10 @@ 
 	{
 		if ($this->seedPath === null)
 		{
-			$this->seedPath = APPPATH . 'database/seeds/';
+			$this->seedPath = APPPATH.'database/seeds/';
 		}
 
-		$file = $this->seedPath . $seeder . '.php';
+		$file = $this->seedPath.$seeder.'.php';
 		require_once $file;
 
 		$obj = new $seeder;

application/tests/_ci_phpunit_test/CIPHPUnitTestDouble.php

Braces +1 added lines, -2 removed lines

@@ -48,8 +48,7 @@
 		if ($constructor_params === false)
 		{
 			$mock->disableOriginalConstructor();
-		}
-		elseif (is_array($constructor_params))
+		} elseif (is_array($constructor_params))
 		{
 			$mock->setConstructorArgs($constructor_params);
 		}

Doc Comments +5 added lines, -1 removed lines

@@ -32,7 +32,7 @@ 
 	 *
 	 * @param  string $classname
 	 * @param  array  $params             [method_name => return_value]
-	 * @param  mixed  $constructor_params false: disable construntor, array: construntor params
+	 * @param  boolean  $constructor_params false: disable construntor, array: construntor params
 	 * 
 	 * @return object PHPUnit mock object
 	 */
@@ -72,6 +72,10 @@ 
 		return $mock;
 	}
 
+	/**
+	 * @param string $method
+	 * @param string $with
+	 */
 	protected function _verify($mock, $method, $params = null, $expects, $with)
 	{
 		$invocation = $mock->expects($expects)

application/tests/_ci_phpunit_test/replacing/helpers/download_helper.php

Braces +4 added lines, -8 removed lines

@@ -67,8 +67,7 @@ 
 		if ($filename === '' OR $data === '')
 		{
 			return;
-		}
-		elseif ($data === NULL)
+		} elseif ($data === NULL)
 		{
 			if ( ! @is_file($filename) OR ($filesize = @filesize($filename)) === FALSE)
 			{
@@ -78,8 +77,7 @@ 
 			$filepath = $filename;
 			$filename = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename));
 			$filename = end($filename);
-		}
-		else
+		} else
 		{
 			$filesize = strlen($data);
 		}
@@ -158,8 +156,7 @@ 
 			if (ENVIRONMENT !== 'testing')
 			{
 				exit($data);
-			}
-			else
+			} else
 			{
 				echo($data);
 				throw new CIPHPUnitTestExitException('exit() from force_download()');
@@ -176,8 +173,7 @@ 
 		if (ENVIRONMENT !== 'testing')
 		{
 			exit;
-		}
-		else
+		} else
 		{
 			throw new CIPHPUnitTestExitException('exit() from force_download()');
 		}

Spacing +2 added lines, -2 removed lines

@@ -101,7 +101,7 @@ 
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -146,7 +146,7 @@ 
 
 		if (ENVIRONMENT === 'testing')
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

application/tests/_ci_phpunit_test/CIPHPUnitTestSuperGlobal.php

Spacing +7 added lines, -7 removed lines

@@ -42,9 +42,9 @@ 
 		}
 
 		// Handle single file
-		$file =& $files[$field];
+		$file = & $files[$field];
 
-		if (! file_exists($file['tmp_name']))
+		if ( ! file_exists($file['tmp_name']))
 		{
 			$file['error'] = UPLOAD_ERR_NO_FILE;
 			$file['type'] = '';
@@ -110,7 +110,7 @@ 
 				// Set $_GET if URI string has query string
 				parse_str($query_string, $_GET);
 				// Remove query string from URI string
-				$argv = substr($argv, 0, -strlen($query_string)-1);
+				$argv = substr($argv, 0, -strlen($query_string) - 1);
 			}
 		}
 
@@ -143,12 +143,12 @@ 
 		if ($_GET !== [])
 		{
 			$_SERVER['REQUEST_URI'] =
-				'/' . $path . '?'
+				'/'.$path.'?'
 				. http_build_query($_GET);
 		}
 		else
 		{
-			$_SERVER['REQUEST_URI'] = '/' . $path;
+			$_SERVER['REQUEST_URI'] = '/'.$path;
 		}
 	}
 
@@ -165,7 +165,7 @@ 
 
 		if ($query_string === false)
 		{
-			throw new LogicException('Bad URI string: ' . $uri);
+			throw new LogicException('Bad URI string: '.$uri);
 		}
 
 		return $query_string;
@@ -190,7 +190,7 @@ 
 		}
 		else
 		{
-			$key = 'HTTP_' . $normalized_name;
+			$key = 'HTTP_'.$normalized_name;
 		}
 
 		$_SERVER[$key] = $value;

Braces +4 added lines, -8 removed lines

@@ -76,8 +76,7 @@ 
 		if (is_numeric($value))
 		{
 			return $value;
-		}
-		else
+		} else
 		{
 			$value_length = strlen($value);
 			$number = substr($value, 0, $value_length - 1);
@@ -133,8 +132,7 @@ 
 		if (is_string($argv))
 		{
 			$path = $argv;
-		}
-		elseif (is_array($argv))
+		} elseif (is_array($argv))
 		{
 			// Generate URI path from array of controller, method, arg, ...
 			$path = implode('/', $argv);
@@ -145,8 +143,7 @@ 
 			$_SERVER['REQUEST_URI'] =
 				'/' . $path . '?'
 				. http_build_query($_GET);
-		}
-		else
+		} else
 		{
 			$_SERVER['REQUEST_URI'] = '/' . $path;
 		}
@@ -187,8 +184,7 @@ 
 		)
 		{
 			$key = $normalized_name;
-		}
-		else
+		} else
 		{
 			$key = 'HTTP_' . $normalized_name;
 		}

application/tests/_ci_phpunit_test/replacing/libraries/Upload.php

Spacing +13 added lines, -13 removed lines

@@ -293,8 +293,8 @@ 
 	{
 		empty($config) OR $this->initialize($config, FALSE);
 
-		$this->_mimes =& get_mimes();
-		$this->_CI =& get_instance();
+		$this->_mimes = & get_mimes();
+		$this->_CI = & get_instance();
 
 		log_message('info', 'Upload Class Initialized');
 	}
@@ -480,7 +480,7 @@ 
 			else
 			{
 				// An extension was provided, let's have it!
-				$this->file_ext	= $this->get_extension($this->_file_name_override);
+				$this->file_ext = $this->get_extension($this->_file_name_override);
 			}
 
 			if ( ! $this->is_allowed_filetype(TRUE))
@@ -493,7 +493,7 @@ 
 		// Convert the file size to kilobytes
 		if ($this->file_size > 0)
 		{
-			$this->file_size = round($this->file_size/1024, 2);
+			$this->file_size = round($this->file_size / 1024, 2);
 		}
 
 		// Is the file size within the allowed maximum?
@@ -818,10 +818,10 @@ 
 			{
 				$types = array(1 => 'gif', 2 => 'jpeg', 3 => 'png');
 
-				$this->image_width	= $D[0];
-				$this->image_height	= $D[1];
-				$this->image_type	= isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
-				$this->image_size_str	= $D[3]; // string containing height and width
+				$this->image_width = $D[0];
+				$this->image_height = $D[1];
+				$this->image_type = isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
+				$this->image_size_str = $D[3]; // string containing height and width
 			}
 		}
 
@@ -869,7 +869,7 @@ 
 			$this->file_type = 'image/jpeg';
 		}
 
-		$img_mimes = array('image/gif',	'image/jpeg', 'image/png');
+		$img_mimes = array('image/gif', 'image/jpeg', 'image/png');
 
 		return in_array($this->file_type, $img_mimes, TRUE);
 	}
@@ -1011,7 +1011,7 @@ 
 			return FALSE;
 		}
 
-		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/',  $this->upload_path);
+		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/', $this->upload_path);
 		return TRUE;
 	}
 
@@ -1055,9 +1055,9 @@ 
 		$ext = '';
 		if (strpos($filename, '.') !== FALSE)
 		{
-			$parts		= explode('.', $filename);
-			$ext		= '.'.array_pop($parts);
-			$filename	= implode('.', $parts);
+			$parts = explode('.', $filename);
+			$ext = '.'.array_pop($parts);
+			$filename = implode('.', $parts);
 		}
 
 		return substr($filename, 0, ($length - strlen($ext))).$ext;

Braces +21 added lines, -19 removed lines

@@ -331,19 +331,16 @@ 
 					if ($reflection->hasMethod('set_'.$key))
 					{
 						$this->{'set_'.$key}($config[$key]);
-					}
-					else
+					} else
 					{
 						$this->$key = $config[$key];
 					}
-				}
-				else
+				} else
 				{
 					$this->$key = $defaults[$key];
 				}
 			}
-		}
-		else
+		} else
 		{
 			foreach ($config as $key => &$value)
 			{
@@ -352,8 +349,7 @@ 
 					if ($reflection->hasMethod('set_'.$key))
 					{
 						$this->{'set_'.$key}($value);
-					}
-					else
+					} else
 					{
 						$this->$key = $value;
 					}
@@ -415,9 +411,11 @@ 
 		}
 
 		// Was the file able to be uploaded? If not, determine the reason why.
-		if ( ! file_exists($_file['tmp_name']))	// modified by ci-phpunit-test
+		if ( ! file_exists($_file['tmp_name'])) {
+			// modified by ci-phpunit-test
 		{
 			$error = isset($_file['error']) ? $_file['error'] : 4;
+		}
 
 			switch ($error)
 			{
@@ -482,8 +480,7 @@ 
 			if (strpos($this->_file_name_override, '.') === FALSE)
 			{
 				$this->file_name .= $this->file_ext;
-			}
-			else
+			} else
 			{
 				// An extension was provided, let's have it!
 				$this->file_ext	= $this->get_extension($this->_file_name_override);
@@ -687,8 +684,7 @@ 
 		{
 			$this->set_error('upload_bad_filename', 'debug');
 			return FALSE;
-		}
-		else
+		} else
 		{
 			return $new_filename;
 		}
@@ -883,8 +879,7 @@ 
 		if (in_array($this->file_type, $png_mimes))
 		{
 			$this->file_type = 'image/png';
-		}
-		elseif (in_array($this->file_type, $jpeg_mimes))
+		} elseif (in_array($this->file_type, $jpeg_mimes))
 		{
 			$this->file_type = 'image/jpeg';
 		}
@@ -1150,9 +1145,12 @@ 
 
 		if (function_exists('getimagesize') && @getimagesize($file) !== FALSE)
 		{
-			if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary
+			if (($file = @fopen($file, 'rb')) === FALSE) {
+				// "b" to force binary
 			{
-				return FALSE; // Couldn't open the file, return FALSE
+				return FALSE;
+			}
+			// Couldn't open the file, return FALSE
 			}
 
 			$opening_bytes = fread($file, 256);
@@ -1271,9 +1269,11 @@ 
 		if (function_exists('finfo_file'))
 		{
 			$finfo = @finfo_open(FILEINFO_MIME);
-			if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
+			if (is_resource($finfo)) {
+				// It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
 			{
 				$mime = @finfo_file($finfo, $file['tmp_name']);
+			}
 				finfo_close($finfo);
 
 				/* According to the comments section of the PHP manual page,
@@ -1358,10 +1358,12 @@ 
 		if (function_exists('mime_content_type'))
 		{
 			$this->file_type = @mime_content_type($file['tmp_name']);
-			if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string
+			if (strlen($this->file_type) > 0) {
+				// It's possible that mime_content_type() returns FALSE or an empty string
 			{
 				return;
 			}
+			}
 		}
 
 		$this->file_type = $file['type'];

application/tests/_ci_phpunit_test/patcher/2.x/MonkeyPatchManager.php

Doc Comments +6 added lines

@@ -35,6 +35,9 @@ 
 		'ConstantPatcher',
 	];
 
+	/**
+	 * @param string $message
+	 */
 	public static function log($message)
 	{
 		if (! self::$debug)
@@ -303,6 +306,9 @@ 
 		self::$load_patchers = true;
 	}
 
+	/**
+	 * @param string $source
+	 */
 	protected static function execPatchers($source)
 	{
 		$patched = false;

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 namespace Kenjis\MonkeyPatch;
 
 use LogicException;
-use RuntimeException;
 use PhpParser\ParserFactory;
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 

Braces +1 added lines, -2 removed lines

@@ -70,8 +70,7 @@
 		if (isset($config['root_dir']))
 		{
 			Cache::setProjectRootDir($config['root_dir']);
-		}
-		else
+		} else
 		{
 			// APPPATH is constant in CodeIgniter
 			Cache::setProjectRootDir(APPPATH . '../');

Spacing +17 added lines, -17 removed lines

@@ -37,7 +37,7 @@ 
 
 	public static function log($message)
 	{
-		if (! self::$debug)
+		if ( ! self::$debug)
 		{
 			return;
 		}
@@ -72,7 +72,7 @@ 
 		}
 		if (self::$debug)
 		{
-			self::$log_file = __DIR__ . '/debug.log';
+			self::$log_file = __DIR__.'/debug.log';
 		}
 	}
 
@@ -85,10 +85,10 @@ 
 		else
 		{
 			// APPPATH is constant in CodeIgniter
-			Cache::setProjectRootDir(APPPATH . '../');
+			Cache::setProjectRootDir(APPPATH.'../');
 		}
 
-		if (! isset($config['cache_dir']))
+		if ( ! isset($config['cache_dir']))
 		{
 			throw new LogicException('You have to set "cache_dir"');
 		}
@@ -97,7 +97,7 @@ 
 
 	protected static function setPaths(array $config)
 	{
-		if (! isset($config['include_paths']))
+		if ( ! isset($config['include_paths']))
 		{
 			throw new LogicException('You have to set "include_paths"');
 		}
@@ -158,7 +158,7 @@ 
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpIncludePaths($current);
 		}
@@ -169,7 +169,7 @@ 
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpExcludePaths($current);
 		}
@@ -182,7 +182,7 @@ 
 		// Updated?
 		if ($cached !== self::$patcher_list)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpPatcherList(self::$patcher_list);
 		}
@@ -196,7 +196,7 @@ 
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpFunctionWhitelist($current);
 		}
@@ -258,7 +258,7 @@ 
 	 */
 	public static function patch($path)
 	{
-		if (! is_readable($path))
+		if ( ! is_readable($path))
 		{
 			throw new LogicException("Can't read '$path'");
 		}
@@ -266,17 +266,17 @@ 
 		// Check cache file
 		if ($cache_file = Cache::getValidSrcCachePath($path))
 		{
-			self::log('cache_hit: ' . $path);
+			self::log('cache_hit: '.$path);
 			return fopen($cache_file, 'r');
 		}
 
-		self::log('cache_miss: ' . $path);
+		self::log('cache_miss: '.$path);
 		$source = file_get_contents($path);
 
 		list($new_source, $patched) = self::execPatchers($source);
 
 		// Write to cache file
-		self::log('write_cache: ' . $path);
+		self::log('write_cache: '.$path);
 		Cache::writeSrcCacheFile($path, $new_source);
 
 		$resource = fopen('php://memory', 'rb+');
@@ -292,12 +292,12 @@ 
 			return;
 		}
 
-		require __DIR__ . '/Patcher/AbstractPatcher.php';
-		require __DIR__ . '/Patcher/Backtrace.php';
+		require __DIR__.'/Patcher/AbstractPatcher.php';
+		require __DIR__.'/Patcher/Backtrace.php';
 
 		foreach (self::$patcher_list as $classname)
 		{
-			require __DIR__ . '/Patcher/' . $classname . '.php';
+			require __DIR__.'/Patcher/'.$classname.'.php';
 		}
 
 		self::$load_patchers = true;
@@ -308,7 +308,7 @@ 
 		$patched = false;
 		foreach (self::$patcher_list as $classname)
 		{
-			$classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
+			$classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
 			$patcher = new $classname;
 			list($source, $patched_this) = $patcher->patch($source);
 			$patched = $patched || $patched_this;

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/ConstantPatcher/NodeVisitor.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +8 added lines, -8 removed lines

@@ -24,7 +24,7 @@ 
 
 	public function enterNode(Node $node)
 	{
-		$callback = [$this, 'before' . ucfirst($node->getType())];
+		$callback = [$this, 'before'.ucfirst($node->getType())];
 		if (is_callable($callback)) {
 			call_user_func_array($callback, [$node]);
 		}
@@ -32,9 +32,9 @@ 
 
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ConstFetch))
+		if ( ! ($node instanceof ConstFetch))
 		{
-			$callback = [$this, 'rewrite' . ucfirst($node->getType())];
+			$callback = [$this, 'rewrite'.ucfirst($node->getType())];
 			if (is_callable($callback)) {
 				call_user_func_array($callback, [$node]);
 			}
@@ -47,26 +47,26 @@ 
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
 
-		if (! ConstantPatcher::isBlacklisted((string) $node->name))
+		if ( ! ConstantPatcher::isBlacklisted((string) $node->name))
 		{
 			$replacement = new FullyQualified(array());
 			$replacement->set(
-				'\__ConstProxy__::get(\'' . (string) $node->name . '\')'
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')'
 			);
 
 			$pos = $node->getAttribute('startTokenPos');
 			ConstantPatcher::$replacement[$pos] = 
-				'\__ConstProxy__::get(\'' . (string) $node->name .'\')';
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')';
 
 			$node->name = $replacement;
 		}

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/FunctionPatcher/NodeVisitor.php

Unused Use Statements -4 removed lines

@@ -21,15 +21,11 @@
 
 namespace Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
-use ReflectionFunction;
-use ReflectionException;
-
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +5 added lines, -5 removed lines

@@ -36,17 +36,17 @@ 
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof FuncCall))
+		if ( ! ($node instanceof FuncCall))
 		{
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
@@ -57,12 +57,12 @@ 
 		) {
 			$replacement = new FullyQualified(array());
 			$replacement->set(
-				'\__FuncProxy__::' . (string) $node->name
+				'\__FuncProxy__::'.(string) $node->name
 			);
 
 			$pos = $node->getAttribute('startTokenPos');
 			FunctionPatcher::$replacement[$pos] = 
-				'\__FuncProxy__::' . (string) $node->name;
+				'\__FuncProxy__::'.(string) $node->name;
 
 			$node->name = $replacement;
 		}